From: Marco Elver <elver@google.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Will Deacon <will.deacon@arm.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Peter Collingbourne <pcc@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Branislav Rankov <Branislav.Rankov@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 15/15] kasan: don't run tests when KASAN is not enabled
Date: Fri, 15 Jan 2021 14:13:47 +0100 [thread overview]
Message-ID: <YAGVCxWTBlv4ZITG@elver.google.com> (raw)
In-Reply-To: <da60f1848b42dd04a4977e156715c8d0382a1ecd.1610652890.git.andreyknvl@google.com>
On Thu, Jan 14, 2021 at 08:36PM +0100, Andrey Konovalov wrote:
> Don't run KASAN tests when it's disabled with kasan.mode=off to avoid
> corrupting kernel memory.
>
> Link: https://linux-review.googlesource.com/id/I6447af436a69a94bfc35477f6bf4e2122948355e
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Reviewed-by: Marco Elver <elver@google.com>
> ---
> lib/test_kasan.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index a96376aa7293..6238b56127f8 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -47,6 +47,11 @@ static bool multishot;
> */
> static int kasan_test_init(struct kunit *test)
> {
> + if (!kasan_enabled()) {
> + kunit_err(test, "can't run KASAN tests with KASAN disabled");
> + return -1;
> + }
> +
> multishot = kasan_save_enable_multi_shot();
> hw_set_tagging_report_once(false);
> return 0;
> --
> 2.30.0.284.gd98b1dd5eaa7-goog
>
next prev parent reply other threads:[~2021-01-15 13:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 19:36 [PATCH v3 00/15] kasan: HW_TAGS tests support and fixes Andrey Konovalov
2021-01-14 19:36 ` [PATCH v3 01/15] kasan: prefix global functions with kasan_ Andrey Konovalov
2021-01-14 19:36 ` [PATCH v3 02/15] kasan: clarify HW_TAGS impact on TBI Andrey Konovalov
2021-01-14 19:36 ` [PATCH v3 03/15] kasan: clean up comments in tests Andrey Konovalov
2021-01-15 13:26 ` Alexander Potapenko
2021-01-14 19:36 ` [PATCH v3 04/15] kasan: add macros to simplify checking test constraints Andrey Konovalov
2021-01-14 19:36 ` [PATCH v3 05/15] kasan: add match-all tag tests Andrey Konovalov
2021-01-15 13:33 ` Alexander Potapenko
2021-01-14 19:36 ` [PATCH v3 06/15] kasan, arm64: allow using KUnit tests with HW_TAGS mode Andrey Konovalov
2021-01-14 19:36 ` [PATCH v3 07/15] kasan: rename CONFIG_TEST_KASAN_MODULE Andrey Konovalov
2021-01-14 19:36 ` [PATCH v3 08/15] kasan: add compiler barriers to KUNIT_EXPECT_KASAN_FAIL Andrey Konovalov
2021-01-15 14:11 ` Alexander Potapenko
2021-01-14 19:36 ` [PATCH v3 09/15] kasan: adapt kmalloc_uaf2 test to HW_TAGS mode Andrey Konovalov
2021-01-14 19:36 ` [PATCH v3 10/15] kasan: fix memory corruption in kasan_bitops_tags test Andrey Konovalov
2021-01-14 19:36 ` [PATCH v3 11/15] kasan: move _RET_IP_ to inline wrappers Andrey Konovalov
2021-01-15 13:19 ` Marco Elver
2021-01-15 14:07 ` Alexander Potapenko
2021-01-14 19:36 ` [PATCH v3 12/15] kasan: fix bug detection via ksize for HW_TAGS mode Andrey Konovalov
2021-01-15 13:17 ` Marco Elver
2021-01-15 14:04 ` Alexander Potapenko
2021-01-14 19:36 ` [PATCH v3 13/15] kasan: add proper page allocator tests Andrey Konovalov
2021-01-14 19:36 ` [PATCH v3 14/15] kasan: add a test for kmem_cache_alloc/free_bulk Andrey Konovalov
2021-01-15 13:16 ` Marco Elver
2021-01-15 13:49 ` Alexander Potapenko
2021-01-15 17:24 ` Andrey Konovalov
2021-01-14 19:36 ` [PATCH v3 15/15] kasan: don't run tests when KASAN is not enabled Andrey Konovalov
2021-01-15 13:13 ` Marco Elver [this message]
2021-01-15 13:44 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAGVCxWTBlv4ZITG@elver.google.com \
--to=elver@google.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pcc@google.com \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox