From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73206C433E0 for ; Mon, 25 Jan 2021 09:25:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B997422472 for ; Mon, 25 Jan 2021 09:25:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B997422472 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 35FBC8D0003; Mon, 25 Jan 2021 04:25:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E85D8D0001; Mon, 25 Jan 2021 04:25:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D70B8D0003; Mon, 25 Jan 2021 04:25:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 0424F8D0001 for ; Mon, 25 Jan 2021 04:25:14 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B48808249980 for ; Mon, 25 Jan 2021 09:25:14 +0000 (UTC) X-FDA: 77743763748.16.line48_1b0923f27584 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 7E9A4100E690C for ; Mon, 25 Jan 2021 09:25:14 +0000 (UTC) X-HE-Tag: line48_1b0923f27584 X-Filterd-Recvd-Size: 2398 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 09:25:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 68F692223E; Mon, 25 Jan 2021 09:25:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611566712; bh=mD7lOJznxAY80DHH4l/imiGO1itOVPS2p1dUvHaN6QI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lvTBvSnAYsb3rsPOyx9epkqs1ubThO6ToRQSOzuTrwnyfjSzuHkp4VM4HSgUHItDV xUv9KopGQpf+QgPzoIyFxBP6gayQ81F4tGHNCBBM9ldQbssCjRAF5bDPzhm+BiBw3N NSDXCaNNnpgnaZtgLt4Wpl1LpGGV3PVcwsvovEZw= Date: Mon, 25 Jan 2021 10:25:10 +0100 From: Greg Kroah-Hartman To: Anshuman Khandual Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memory_hotplug: Rename all existing 'memhp' into 'mhp' Message-ID: References: <1611554093-27316-1-git-send-email-anshuman.khandual@arm.com> <3dc093e6-e037-c67c-f2f9-c534fdabdd99@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3dc093e6-e037-c67c-f2f9-c534fdabdd99@arm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 25, 2021 at 02:21:02PM +0530, Anshuman Khandual wrote: > > > On 1/25/21 1:56 PM, Greg Kroah-Hartman wrote: > > On Mon, Jan 25, 2021 at 11:24:53AM +0530, Anshuman Khandual wrote: > >> This renames all 'memhp' instances to 'mhp' except for memhp_default_state > >> for being a kernel command line option. This is just a clean up and should > >> not cause a functional change. > > > > THat says _what_ you are doing, but I have no idea _why_ this is needed > > for anything... > > There is a series [1] which adds some new hotplug functions starting > with mhp_ (after deciding in its favor rather than memhp_). We should > have a common naming scheme either memhp_ based or mhp_ based but not > mixed. As it was proposed [2] to go with mhp_ based names instead, all > the existing memhp_ needed renaming. Hence the this patch. And how was I supposed to know any of this by reading the changelog text? (hint, it needs to go in there...) thanks, greg k-h