From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2CCCC636D6 for ; Fri, 3 Feb 2023 08:00:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65E066B0072; Fri, 3 Feb 2023 03:00:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60E226B0073; Fri, 3 Feb 2023 03:00:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D7A36B0074; Fri, 3 Feb 2023 03:00:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 39DB66B0072 for ; Fri, 3 Feb 2023 03:00:25 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 14865AB8D5 for ; Fri, 3 Feb 2023 08:00:25 +0000 (UTC) X-FDA: 80425233210.10.4627CF9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 1D5EE20013 for ; Fri, 3 Feb 2023 08:00:22 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="zMgPy/kf"; spf=pass (imf13.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675411223; a=rsa-sha256; cv=none; b=TGDxZ5lVE2y+3nk+pXP3AWPM/R3zPOoU3BWqShad6JkZ9NMiC6O2EOUcz3LnPACe/oBeqk D4UEbJ5xUCSkMNWmRZPrMw+sS7GdC+37kMJQrDl6/cQq7YBPhn5rwxEvAfcuJBQW+b+LyM kWqXJoxsHQqyCiVY+lMNMTmZCT8Ahcw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="zMgPy/kf"; spf=pass (imf13.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675411223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sc9OlI5tEly8ctZcYcpP4WMHsOP536WR73647ApfytM=; b=gl/sUy+xezM6x6HXrS+EDQAksWoiRyCrkIQS6zYE1qLAW+P5kDzznoBKaHYTPFr7xWNZo8 oS/heYAQ2oR76G0JrGg9/qTOw3ooHMFKxWglNpamnhOWhrr9fi7rMFDLZfgvHXXL1OH5mg eVZOaN6JC3NSdVgKysz+PT9Ct5O5IL8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C15F61E07; Fri, 3 Feb 2023 08:00:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 350F3C433EF; Fri, 3 Feb 2023 08:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675411221; bh=doIPG1PHyzm6d1DSa5nWk+jTUGsI/pTAYkKovWY+noQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zMgPy/kfGYHzVvcTtpmjprlI/6J7/W5Zdi1LGRDmANAAo6W5/kf3E/zNj08qu+zh5 5+1Fh1IpIQVab84AayR0NE7O6t3qO9BoQG421ZFfFELOUQcrbs2+ascSimzOKxVwKu XqNBTqdKMcXkipXOJX58QSENB0zLIZGK/TxxnxPM= Date: Fri, 3 Feb 2023 09:00:18 +0100 From: Greg KH To: Rishabh Bhatnagar Cc: stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.co Subject: Re: [PATCH stable 4.14 0/1] Fix ext4 xfstests failure Message-ID: References: <20230131043815.14989-1-risbhat@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230131043815.14989-1-risbhat@amazon.com> X-Rspam-User: X-Rspamd-Queue-Id: 1D5EE20013 X-Rspamd-Server: rspam01 X-Stat-Signature: 47f9ix3r38ef6i7emaj5se56do3xji5m X-HE-Tag: 1675411222-304191 X-HE-Meta: U2FsdGVkX1/NfGOrNg5iOpbZn/j3uyNfUimjzOt72nencm6jeU0KLvqwdfIytGk9otEpL9vsyMQcIdVub/xAGyAr07jmFpic9r59W5jxJ2ImW61l9Kqde2RHFLXfCoGGLygPObWv4L7UdUlRC7Ok58p9cWeVw4XRJIhvnLzVMCq+Tw7L9wNXj/LBISIjnMcpl7tokhtyGDL1NyKhYMqOUzJb+xea8XlUDbjJrZspNl7civDNMr78fIhXcVQ931JM2kHM2vM3dXntCNrtmMpvVkACEgcY8fXg2fQNFHyDsijllQYXeJI0awxDpQJsYXyeRFbzDyy/HXJLfKta1C2TdVX7ou5r9aFp8bgisCborsnMMiLzC2hrCWdr66KtSnSaoIkcMEQpMFTLNtrjCKCMPNpTcvLMr0qXpM+PeR5TjKRitBirQAQGvIc08Hp5aqDQML36QNppWJzTOSfcHasyfawdxhAKSgoKVZfb1zeLvuvKARbYfbLB31A6q+tgc2LxC4fgOpw6LV7l8CaUeiq2RK1kgDLe6srOtkpwV206Fm0JpSq7PP69pogTuiqEiYRma5F4mWqxPa948tRnRCuvWoxsVsh+VBRLwUNNRb4z/CNs/16VN5xFfuInJ9om+7c4k8tAYovr4jx24f9AvGjhUkuPs4lUtlGhAi27732I6AOj7nzJ+QnSuI2qG1pIk7ze8SJmZzTd80jhWFSSvSNH1MfiZ+S7rqXpi1/uZNO0Qgv5YYCIbSDiKvA97hVegfkhu6GrCkze79GSGcGEBO9Sg9HuA9h3q8Tt4ERdBvfOVhMBWSr66KiKZTyPlE+SN9avT973AX0jJk+rfPx7Q6LyTj4r+L7HAeBdFOyEmBx751bRyfrAAT3ZNQdfLb+xQCOwHWh0bPhoa7ltXa3UqsngF5r9LynwA3DRYrbeSqbw9ukPD/SzbFc8bR80w5KKocowRPlUskvSXISuBgj5Use SWwIGMda kFLwvFMUBtpxFU+2Ng/thL772M4Klwc+mKo9q5cJjVSpPL359pqxNLuo/fj2YHA8o7m/mOSDfloFSK9UO+5NM8WOkv1ouDhHKEdvEHUycAMYf1qMONC4MDngAgcYVhL0uK8Uu+NOqczg2Bgio1INcYRkwbfKWPzpsdrw5ibXdMn//RSd4hx3lyfKgXVEWxSftwdpn2k1NMfb2NuZpLSvPcRE291MH9AIpatJZX/3BLVL5GFjWre/lNxhZlT+yrrh04QdF4hmaXhKexteYgaZmiFItqqcOH9FBDXqX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 04:38:14AM +0000, Rishabh Bhatnagar wrote: > While running xfstests on 4.14.304 version we see a warning being > generated in one of ext4 tests with the following stack trace. > > WARNING: CPU: 4 PID: 15332 at mm/util.c:414 > kvmalloc_node+0x67/0x70 > ext4_expand_extra_isize_ea+0x2b4/0x870 [ext4] > __ext4_expand_extra_isize+0xcb/0x120 [ext4] > ext4_mark_inode_dirty+0x1a5/0x1d0 [ext4] > ext4_ext_truncate+0x1f/0x90 [ext4] > ext4_truncate+0x363/0x400 [ext4] > ext4_setattr+0x392/0xa00 [ext4] > notify_change+0x300/0x420 > ? ext4_xattr_security_set+0x20/0x20 [ext4] > do_truncate+0x75/0xc0 > ? ext4_release_file+0xa0/0xa0 [ext4] > path_openat+0x737/0x16f0 > do_filp_open+0x9b/0x110 > ? __check_object_size+0xb4/0x190 > ? do_sys_open+0x1bd/0x250 > do_sys_open+0x1bd/0x250 > do_syscall_64+0x67/0x110 > entry_SYSCALL_64_after_hwframe+0x59/0xbe > > It seems rebase to 4.14.304 brings a bunch of ext4 changes. > Commit ext4: allocate extended attribute value in vmalloc area > (73c44f61dab180b5f2dee9f15397aba36a75a882) tries to allocate buffer > using kvmalloc with improper flags that generates this warning. > To fix backport an upstream commit mm: kvmalloc does not > fallback to vmalloc for incompatible gfp flags > (170f26afa0481c72af93aa61b7398b5663451651). This removes the WARN_ON and > fallsback to kmalloc if correct flags are not passed. > > > Michal Hocko (1): > mm: kvmalloc does not fallback to vmalloc for incompatible gfp flags > > mm/util.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > -- > 2.38.1 > Now queued up, thanks. greg k-h