From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E97C636D3 for ; Thu, 2 Feb 2023 19:55:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B394A6B0072; Thu, 2 Feb 2023 14:55:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE9726B0073; Thu, 2 Feb 2023 14:55:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98AE16B0074; Thu, 2 Feb 2023 14:55:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 86C8B6B0072 for ; Thu, 2 Feb 2023 14:55:38 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5FDC84103D for ; Thu, 2 Feb 2023 19:55:38 +0000 (UTC) X-FDA: 80423406756.03.D478A82 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf07.hostedemail.com (Postfix) with ESMTP id 8E21B40009 for ; Thu, 2 Feb 2023 19:55:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=U+SgcU7j; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of aloktiagi@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=aloktiagi@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675367735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XXzyoJpaBaepeQW/gec/uWdRUarHHGnTjkWTqnlvj+Q=; b=UoBp68cmayxz/h0+wCVHs8sq9q22tayPrrkXx3exfg+MBEeWqx0ykOBopyOEpWh1KaHtPm 0ZEn3z7+qLChPw8u91Z3n5bXAuc6ZBEWMYpsAMNPLsCc4CnSYtzZqP5DQZ0YEYtU2Drnfw HLlRXk/NWpLkIQGP7vu8N5bcObRTcus= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=U+SgcU7j; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of aloktiagi@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=aloktiagi@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675367735; a=rsa-sha256; cv=none; b=h+L1F1j8qb22BnqIoTKdew5mvmCiLSkI99cy8Eg2GlYt59LqfB8NbKyUdEqv910LVE0O3O JM3/c+dKA7W3gC0MxtTISIEm2urZw8IlyMwsKrvq8F9w6INhIcLzIfRQ7neWgGkn6CULfV cD6kHeePQgb6MjxjbeMKygyoQ2cW20c= Received: by mail-pl1-f176.google.com with SMTP id m2so3008857plg.4 for ; Thu, 02 Feb 2023 11:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XXzyoJpaBaepeQW/gec/uWdRUarHHGnTjkWTqnlvj+Q=; b=U+SgcU7joLtnGYyjI5whHYRTiIs5Rbl/OnS7TpAgkkzsLoMPRX3S8OlAgf0VdjDAdo SWRVHjRJve0dXNcxXdXQj03m60evskUtHGM83p1puK+x4+MP9VmmJiOrp3IgnOJqdsYW 3FC0YIYvSZtbvt89df2M2vNoRhyLshBI65714yCNwaNgCZgNY2kiydwu7OLHjh0NqKIU Vwtd0Ktg6qOF0J7BEP53DGciDFn7LQC7N+bNw0VMWGlQjOxy4JJCW/xQ0L2o4lg9AgRa 6M5mSYMAwuB8uT+JW3M4qymqeiGlRxtGkfjsHSdpBGPXJh7mxjtD2xjDMl/BTWvlmUrX iIIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XXzyoJpaBaepeQW/gec/uWdRUarHHGnTjkWTqnlvj+Q=; b=GiqyH8F+y5b2M9DgWGiQcGO1aAAxphPOmdfBx86VVGcy7iYrpxnGG0k2D2Gm3Wj8GX AgMqzR1PoIIKPULzOOreZ5TEbysLZqBfgxlX4Q28M84bCLPUpgEMfmpW0m+vJVoU+h4h alU0wJL0Slm/V8XuGO53SRA009wE0hcR13ualLZEKTt+OVY7pvd1ihoWxHTpaIE83721 cwFFFtsLvazHK49qVWCjWRz8V3h8/iYomzO5s7TycgUNLzEPHmJKHtjHJnedZYZPJB4B OgW3Kwgyp31w01zPWf/vQHsx2qKYX2TBofjC3S1EwcTOCDaGEKj/2nCijN0QvFH5r8zo PA7w== X-Gm-Message-State: AO0yUKWPQu0eTKQ1OilD0oQNq6rkKGmFsDCe/idlFct1pHPvd4h+AJKq Ajs1kPyQ/GmcC7H7GIKsNeE= X-Google-Smtp-Source: AK7set/EdT6UKAqV0iniNQUqUFO9TPcZ+oh2aj4hEqE7B/1f4U46BLnD8kb4m048j76SiJEfQLwWSg== X-Received: by 2002:a17:903:1111:b0:196:ea4:c261 with SMTP id n17-20020a170903111100b001960ea4c261mr8709278plh.1.1675367734404; Thu, 02 Feb 2023 11:55:34 -0800 (PST) Received: from ip-172-31-38-16.us-west-2.compute.internal (ec2-52-37-71-140.us-west-2.compute.amazonaws.com. [52.37.71.140]) by smtp.gmail.com with ESMTPSA id n3-20020a170902dc8300b00198c41d0c86sm43922pld.239.2023.02.02.11.55.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 11:55:33 -0800 (PST) Date: Thu, 2 Feb 2023 19:55:32 +0000 From: Alok Tiagi To: Hillf Danton Cc: ebiederm@xmission.com, edumazet@google.com, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] net: add new socket option SO_SETNETNS Message-ID: References: <20230202014810.744-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202014810.744-1-hdanton@sina.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8E21B40009 X-Stat-Signature: 1bidwww6nrixu9ff5es4bjq8pfrgw76p X-HE-Tag: 1675367735-65507 X-HE-Meta: U2FsdGVkX185NtM7o+OEGpSuqSyUyQSHEBbXu2oQwXHE3OSCEzNJXZLU+3hLjeRNNarn+vemY1reck+MlZWpF68rtcyWbhMXGgxLKiqZQhgba8hWJUYo9dW8Fb7IpJc0r01LTIFcyEZlEkQcQoARcnHhFi23WztWO0OzKfqgxHvImKkAhNXb2z98Rum1KDk2ZxbBvnglhjS13onlUIn1B9d+JP8A5r0V2XUpjso+G9Jur6OLGFZl21BMG6Vx8/DMU8mjwDQHnAZwLpAbTBeKS07U50l/1j3wjvjPTpOAuw8N4P8IWvg9ZyOZ/VvgqNzhhSQsQv8gZktSJn0yrAJhk6gKZVRxbyQcKb8oQ66mctTjI+l0zenFxcz1VZfx2if54cuLYtjYQkvLRbkPaUVWcYwaJlttSf1GQIMfW+nmO3s74Y2aM9aLm365nAyYO/6Tlh/xSP8UgnJXORh66hjXADBHwIJdTu0VtnV/SDX8OiABmC4qi4N6XIMSl6Zm0WwRGLTgqY0ECNtIB4Lf3Le6Gvvnh5JOyjo55rf/OcGkx4J7ekSKiYbYyrQPTMezrl8hM9dBIhGd+F9zpNtVLxIjqC8W+XzvLIUeeRMOrtoDOV8mMi01Xnjfl1ESkG9mKB6vrnvr4fZQOSYcHf/u45OgJDtKWFZiiYh3reiE+vZw5DYoUkpbNe0F2myR+4AhyQ/uOebJH0pKa0mTfeKo+6YKpr6754xjzj5e3p6zSMqIR4i9K8z8F6/6GsryugbMOvL9PmCG6IShaybqA5iTp/1uMQ40ZKtxegN1WDfs9gXTdOB9hNXYjdt2T5ObUZO+JVO1MK7/+4RHxJVYsfITypvoSuxUSn3xpIXNN0WDzH87HBX2+a52sO6QWASL7jd0kXUwAoum79EIqqG1ojDfxkaFr4aMEg6mHwNfw3Eix7QcXVvNyB3aFUcnz18M2TR1lIIs3pKdtjZD7zSJKsS4n2o j/Tupx0R eVEvS8anQFelrUt8aGvFgWOKylDSIt3aTJZXdb068+BH4dToRElrCToH9hLXUQCNF3iDuaS4mfzjLXdsLKjX6PbFx+5Hpq7Gf8CpQ7QAItRbNXaFNTG0eLzxtdA6dWPevFG9yZgAYJRVDb09PBqEElXml/iemOacFditQZifi0hyOeNVV94FBLq6AEi+5F0SEN+r0eEzKvSx9ZLirV3jbZ9ol9dIxv1zrjaK2yu8ksgXjJmTzXukqKX8jOHvoTkHSVSnaEUf/6/0e3h0rgmHP/E23Elq4jxrAcpYK6I7aO2B0+heFIY0F5PfvIxZ/a2by840yhzLGr78GRtRpBKQBhEDWBtVcF6GeVcDO0bL2pvQWHn5v7LZhk+TntYJhud6CADz7pux8jpPeJA3co8wDPAbZbqrDwwBTw9U4Uxj/XAk/m/45OhZOXf1IqDuevbo6LlZoqCuu1kHoGBmNrAxJUZMyl+tPZ6fX3WG5h+2OJJS2I84u3yko7Ne0tHpzzHJl2NOvP5SeE0Svj/YSXfVj18Wv8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 02, 2023 at 09:48:10AM +0800, Hillf Danton wrote: > On Wed, 1 Feb 2023 19:22:57 +0000 aloktiagi > > @@ -1535,6 +1535,52 @@ int sk_setsockopt(struct sock *sk, int level, int optname, > > WRITE_ONCE(sk->sk_txrehash, (u8)val); > > break; > > > > + case SO_SETNETNS: > > + { > > + struct net *other_ns, *my_ns; > > + > > + if (sk->sk_family != AF_INET && sk->sk_family != AF_INET6) { > > + ret = -EOPNOTSUPP; > > + break; > > + } > > + > > + if (sk->sk_type != SOCK_STREAM && sk->sk_type != SOCK_DGRAM) { > > + ret = -EOPNOTSUPP; > > + break; > > + } > > + > > + other_ns = get_net_ns_by_fd(val); > > + if (IS_ERR(other_ns)) { > > + ret = PTR_ERR(other_ns); > > + break; > > + } > > + > > + if (!ns_capable(other_ns->user_ns, CAP_NET_ADMIN)) { > > + ret = -EPERM; > > + goto out_err; > > + } > > + > > + /* check that the socket has never been connected or recently disconnected */ > > + if (sk->sk_state != TCP_CLOSE || sk->sk_shutdown & SHUTDOWN_MASK) { > > + ret = -EOPNOTSUPP; > > + goto out_err; > > + } > > + > > + /* check that the socket is not bound to an interface*/ > > + if (sk->sk_bound_dev_if != 0) { > > + ret = -EOPNOTSUPP; > > + goto out_err; > > + } > > + > > + my_ns = sock_net(sk); > > + sock_net_set(sk, other_ns); > > + put_net(my_ns); > > + break; > > cpu 0 cpu 2 > --- --- > ns = sock_net(sk); > my_ns = sock_net(sk); > sock_net_set(sk, other_ns); > put_net(my_ns); > ns is invalid ? That is the reason we want the socket to be in an un-connected state. That should help us avoid this situation. > > > +out_err: > > + put_net(other_ns); > > + break; > > + } > > + > > default: > > ret = -ENOPROTOOPT; > > break;