From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC848C61DA4 for ; Thu, 2 Feb 2023 08:27:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EF8E6B0073; Thu, 2 Feb 2023 03:27:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A08C6B0075; Thu, 2 Feb 2023 03:27:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 067DC6B0078; Thu, 2 Feb 2023 03:27:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E960B6B0073 for ; Thu, 2 Feb 2023 03:27:44 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A2DDF160E7B for ; Thu, 2 Feb 2023 08:27:44 +0000 (UTC) X-FDA: 80421673248.19.5227C6B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf16.hostedemail.com (Postfix) with ESMTP id D96CF180012 for ; Thu, 2 Feb 2023 08:27:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=DGcyKCsk; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675326462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=exe0DtfeQcAlhuYAQJBwVd6y+SRpyDu0VP1XU1cSGK0=; b=qG7U9+JiEWGIzc2zJfdw7liEx3ngYB/i0E82+u/U+AjEoskQBWtL6dezUXHz6OQ6heZHv0 ED0Tuew8U5cvkHtrixHPfhZO5vPy1Y+f6jXY8cz/6mA5KzGmtoaQcrAR32xRs8m/KDEbK6 eq4/I5RQgkN08yzGOLKLNCWQ3kvazhs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=DGcyKCsk; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675326462; a=rsa-sha256; cv=none; b=kYLEyC34Zldzyfp8REb2a2uRxFQNpi96wWI1mod+52cuLcwLCrxwhyZywzZ/AO3nvRVvIj Ys8uibjVEyoMdqHUAtOFdaquiFPcr/XaEGcq/grNZzVby+zJWt+5fpcw+ypHjoWvqfO0tj kHBINQ1dVHtrmPmItmaNKjW1jDxIIro= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 542EB33E4A; Thu, 2 Feb 2023 08:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675326460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=exe0DtfeQcAlhuYAQJBwVd6y+SRpyDu0VP1XU1cSGK0=; b=DGcyKCskLROJaYfTPTapPmF5EHxGu6uUXfqgXYFhdqrgb/9iD14ccSbNigzTJnMCOTleaR 6hBq//gwdIwePPtKTgeVwYAOQzqGE4LbpKPAX+qDcIKzRFsYZhuWiy2i3bRip5V6H0/4L3 8d6HZNPrIguXQnVO5tvB5bm8XVjtpFc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3664E139D0; Thu, 2 Feb 2023 08:27:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hLvwCvxz22P7HwAAMHmgww (envelope-from ); Thu, 02 Feb 2023 08:27:40 +0000 Date: Thu, 2 Feb 2023 09:27:39 +0100 From: Michal Hocko To: "zhaoyang.huang" Cc: Andrew Morton , Johannes Weiner , Peter Zijlstra , Roman Gushchin , Shakeel Butt , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Subject: Re: [PATCH] mm: introduce entrance for root_mem_cgroup's current Message-ID: References: <1675312377-4782-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1675312377-4782-1-git-send-email-zhaoyang.huang@unisoc.com> X-Rspamd-Queue-Id: D96CF180012 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: tdee6cdy81hwy33d7fk6w3eygycekahj X-HE-Tag: 1675326461-244052 X-HE-Meta: U2FsdGVkX18rWjLlLPvOQGxqpvBViVUW8vGLgQMp2IG6aR1MunluWIEsaPQjV7f5U6EwN3wAG3WQ6vMrBTy2ELgaLymZRMgVNdFxVzO7P2eTX4ixByPiVgyN+7GYruBo/7kXCnNAQSZdw1kxyebgrdOUWozze9L4NP4adXt1zg6Y5H2RYVZ2QbSETTDw5NUzeDEZpDVWfDsYU2YtWiBEOU6AE6V4pl3LfrXoXZDtncXdKp/o7xO6n1mY+YeA9bQqbujih1VZO5Yr3l6IqX8IaAIrJLdXWlVCuzgJcss2OZZ26QTHhgwi9CY1g5H+a54lCPKILDt55gZbBmM5rjgn1Zr/I+7yDoIKHTmx6AaBqJ68tGsiQLm+ickdma9iDnqnT06tYIgYgwov4kcBveWe37fTM3JICJVDN7tZCj8I+ZBdJc3r0lOGPilXcmodTCJS2oYCSsK2IcfuQoRSqdT08YfOv5BjOQNQJDpCRMR+wkQippt195lrEdrczIcFzRCdV5JUgKheqpGCx1rrGHZiovZgdU9pVyHJZVMXNV8K6GqiVu3sfUvpjeg5Hb4nQ/lVRNjUe0P0zq+9jRcJIduQLJrwKg01Lx++3+l/0EL9JLtyh2VpcYIRm9ZAnxVQ9pq0dd/m52KI/Nj5+q0utUgWICKj+8lWIQtLhZWIZXX7GeZAOYPZJWv+7aODO8+/y/t8obdtH5cWjKemkRX3tCKBuyOR8lOM3tDE5rePhmCmtw0TdfHEc237R8l+lioEgQoZp1B3mugydfL8OjyEPsMQg9OKZPf+XCM50zzuFx8miYQ3nlYJWsOFU0fv8/LDI9yub5/ILDQZkRHpQsoOQMMGDP1ZX4UwYPMVTn9E1xcb0kDdiw/o4J8+uT2FD2Do2NpaXn3NdRpxTuNaq1+pckAK/VUL/2NlRLFh09jyfAKoqDLyOKxqt9z9OB0PV16CNmwrVxT8enpFNCvmDtcTZ48 MFxCkw/s 82Fen0MeuK4wf04E4RpRY0ooAMQNMvf0OosIgUuuT0WoLw//jKuTiiwJkR9Cf/2gP202pyEPv3u9G+Sk4ujkOFMptK6OadtGBdTMQT70JgWeQCPfBlG4++AV641bdFmi8PXlMX3KIE4IR4qt5X1GBVlpdg7DfzjZTAUWnTjAVKHqSRjAqzOvFD7BvAmYUT4+r2c3rLlSulqQ3klgkNrgSoqwe9svpCHyDG4j4ftkzo4kZmPT0pFTAYUzspCd5XW1OPHypOerBAn7QK7U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 02-02-23 12:32:57, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Introducing memory.root_current for the memory charges on root_mem_cgroup. Charges are not currently accounted for the root memcg universally. See try_charge which is used for all user space and skmem charges. I am not 100% sure about objcg based accounting because there is no explicit check for the root memcg but this might be hidden somewhere as well. That means that the patch as is doesn't really provide and usable value. The root exemption has been removed in the past but that has been reverted due to a regression. See ce00a967377b ("mm: memcontrol: revert use of root_mem_cgroup res_counter") for more. > Signed-off-by: Zhaoyang Huang > --- > mm/memcontrol.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index ab457f0..158d4232 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -6681,6 +6681,11 @@ static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, > > static struct cftype memory_files[] = { > { > + .name = "root_current", > + .flags = CFTYPE_ONLY_ON_ROOT, > + .read_u64 = memory_current_read, > + }, > + { > .name = "current", > .flags = CFTYPE_NOT_ON_ROOT, > .read_u64 = memory_current_read, > -- > 1.9.1 -- Michal Hocko SUSE Labs