From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B49F0C636D4 for ; Wed, 1 Feb 2023 21:59:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12EA46B0078; Wed, 1 Feb 2023 16:59:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DF146B007B; Wed, 1 Feb 2023 16:59:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0FE26B007D; Wed, 1 Feb 2023 16:59:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DED286B0078 for ; Wed, 1 Feb 2023 16:59:24 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AAB4D1404E0 for ; Wed, 1 Feb 2023 21:59:24 +0000 (UTC) X-FDA: 80420089848.07.040AFA8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 8067B1A0024 for ; Wed, 1 Feb 2023 21:59:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NOMH0XkW; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675288762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O64JjRaBy3/jsGPy67DtsVGvqUtSyfjAvr2cPt5vctc=; b=jFhFlgl7bVhAnJgvXIxLngpLrwmrY21CRBtGASLvm+IFABxSnXGwgzDdEmltbQmiyXT02v /cksy/Q1CSXKCYKPzTOpTOtp38CPc9SlqAFKijKFzVXlF5tl/1fFbiK8tkQGKGa51ZIsVe hGtSXDsAEZ5jOqWfx5LpSpHQYjrE5RU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NOMH0XkW; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675288762; a=rsa-sha256; cv=none; b=2lRtkyfQoo6qWlhG5gbXCCWnFpC4EoQe9/Aw4ghyZwbWnW31wu6ak1n7aJ+WcP2u+h6Y/Y IqTduvu8A8E93hwIswT8LVFKF3iyBY0V9VVEovoH8DRph8XfE3myZmSzSxy4QR1rsDVUF1 dwf72vdoeP8d/bT/m0OjSnoJ0vR2vm4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=O64JjRaBy3/jsGPy67DtsVGvqUtSyfjAvr2cPt5vctc=; b=NOMH0XkWg0YK6BfV88GMud2jN2 aMblBUPvCeaK/DFrGI0MtnzQRSy95YCIWAhfJE3Oi9bViN8qXD2gtmZNXH2km2HBfb2euN0NT6ZsL 91fusn2dP7kqx0H7FdX8qeyravkkn5rjeDhcm+P0NxQ/IlqUVSDlfo9PU0wNVDw2GTI6FFpkY/aIB Z22htHa5JXkS+EOWfMdQcxsrp6u+u15FxjhkWa/YQIfkNCd2s8qQlOLSnKzmzol4LQq2hCTK78Kbz DkINNJg6LKVrvGAACcaKqswT9Wgod8X5l6LhV/n/hCx42R16fSuR9+37AvX5GuoeHMR8r+/pyT0x6 sihVTj/Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNL8O-00Cp3g-PD; Wed, 01 Feb 2023 21:59:16 +0000 Date: Wed, 1 Feb 2023 21:59:16 +0000 From: Matthew Wilcox To: Yin Fengwei Cc: david@redhat.com, linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com Subject: Re: [RFC PATCH v2 4/5] mm: add do_set_pte_range() Message-ID: References: <20230201081737.2330141-1-fengwei.yin@intel.com> <20230201081737.2330141-5-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8067B1A0024 X-Stat-Signature: cnrbhqszzf53athikfez8px4ksazxd6p X-HE-Tag: 1675288762-688457 X-HE-Meta: U2FsdGVkX1/7T47yPvLiwJ1rmswwmPt+2VJHpI3ilWfn2DaneNOtjdnL8+yZEHMrnp7rB8/RYthHxLqZIlUGffGOOtJi0N0hLzBjhrnXbUZP6efKRhq97GqGr6tM/icskieSHoqLrKA8u9OXo7HxAsvOZnn8k9f/lmcZWQwU9i/W9EU+yYpBs+Ackdmw7e5pXsI7hRAFmCXrrTF6lkeYPtZj2zvKmFTnBpnDGQrIErpGA7FbX73GbPldROHQhAgmV27mwo+wVsVrtqMN3uCD0yMEbLYuEs3iz5LnW+q8udzu5iLZjbqO5tGO12ZrhHkUVcJHLP9NOckqTRP+iQ3H2+lH8bO1gcLwmxXr7vU5XI4h0WZxP+nT5WmjZ6BiYwYKZ/sjDVLaR3VXX0crLLRDK9rMYpcTTR99hUCbqqAI+X9UaNO1gfhPYqCpoX5D/5BMlb/V0Aq5ha7Gsyvv4FHp4AXXfYIKjsUTgeW8lQ6oz/gP4EXAgPk1h79odnWwz1FTMDql2rfGpvPxkkDdEltOS530ZuikZ2D6c/UplKjTjbwwGJaYHYtrpMQUQw+4ObjGFmSlU9h9tBhbraxVv0ZOP04DamrxLZ4FNktcGQPbkea4d3T5LFAkYJWNoQwfmTtf8lAkr6AxUiD7Pu52qtYPJrQdWxBWPIKyRoZyTDkbprqIfSB6BSlbsB0QW7Q8JqrSHSxSv5c6VjnNeu/jT/fFV4pEF+MeIAfBcSbHB97rezVEl+sL4i3wM+iEGfhJxemc/304a5S3ypNxXgOf3BFGtBdVNNymbJHaFLEOVwlcKt6Pr/OzGHcTph94KcOHqvchBzvpCHS8cNdi9d99J27pi9oUCpQloju97NwxMcpLEW2oBkiIF4LvvF0EIHpV9x+pJUn2AsRWZguwXNhe14pfrBJSxdIBBlpTIfpRxnVG7Nkrsakcoq4OdToVIBKT9b3pv1rFw0y8x4N1ke6OTPs qp2gS5Nz /Gd1VBR1LUUdGULauNBLQh0N2k4Irk3GllHKVcwDbB8tovl77BaMeWx4vgJTnpD8gksY/33sMeAnXPzQ4zgtlxHGDlWApD7JvX/99q01E6WNBAaynMBKR3HqXxODchz0XTdtN8O+5SS3NTpwhwUIB6n1kibUgMCM93iGK59tDJfjJIYB3rj+O7VJAmFcixTJZ4L5+85SRIVogoPs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 01, 2023 at 05:38:39PM +0000, Matthew Wilcox wrote: > On Wed, Feb 01, 2023 at 04:17:36PM +0800, Yin Fengwei wrote: > > do_set_pte_range() allows to setup page table entries for a > > specific range. It calls page_add_file_rmap_range() to take > > advantage of batched rmap update for large folio. > > How about something more like this? Yes, we need to define > flush_icache_pages() and PTE_STRIDE. Never mind about PTE_STRIDE. I forgot that pte_t isn't an integer type. Instead, we'll want each architecture to define /* This should be right for x86 */ static inline pte_next(pte_t pte) { return __pte(pte_val(pte) + PAGE_SIZE); } > + for (i = 0; i < nr; i++) { > + set_pte_at(vma->vm_mm, addr, vmf->pte + i, entry); > + /* no need to invalidate: a not-present page won't be cached */ > + update_mmu_cache(vma, addr, vmf->pte + i); > + addr += PAGE_SIZE; > + entry += PTE_STRIDE; entry = pte_next(entry);