From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E268C636D4 for ; Wed, 1 Feb 2023 20:17:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39A3A6B0075; Wed, 1 Feb 2023 15:17:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34AD96B007B; Wed, 1 Feb 2023 15:17:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 212D16B007D; Wed, 1 Feb 2023 15:17:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0F0D36B0075 for ; Wed, 1 Feb 2023 15:17:49 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CFCBF120376 for ; Wed, 1 Feb 2023 20:17:48 +0000 (UTC) X-FDA: 80419833816.24.7AA7C54 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf19.hostedemail.com (Postfix) with ESMTP id BF00D1A002A for ; Wed, 1 Feb 2023 20:17:46 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Q16VYuko; spf=pass (imf19.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675282666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sggLwzyUTSjgBIuaJEzP79mf/yrQdo3fwuaMhlgMyAg=; b=03p35s9G996kn5+fOPDQJfs+65piIbJxJ7+Z/05KI1ShcVm3Yyrm00AaIJcIlSSjgQaUFc PLPdIBkW7l/fQsOsPKN1WNlM5w27IYhHCjWjRZkUZL7PvBXEPaf3/Q6rfF5hFOpd1Cj74T 7l+CC3zLzTzVeWGjvLMiJ5REmiXU3XU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Q16VYuko; spf=pass (imf19.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675282666; a=rsa-sha256; cv=none; b=lH9u14IhkVzFP723SFHduW5cg+fG2NqExmWPc7o+DiLBwqCl5X/k15r7DvBXs78oTCtN22 DfpP9Ymsh/RdP5czJqrV9iesavwv4meC2wGPhmnvLwcdOqkd9ZSqRxwiVXJH0XZjB7ILDU ZPQjKDxTH8FAtQjidHq16sQXDPqXekw= Received: by mail-wr1-f48.google.com with SMTP id q10so18443578wrm.4 for ; Wed, 01 Feb 2023 12:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sggLwzyUTSjgBIuaJEzP79mf/yrQdo3fwuaMhlgMyAg=; b=Q16VYukoMyBcpYogXwJj7qSzf23Nca0ykWYVVqORa8MWA3cOs7YYNyBEOzmDcgy9V0 qdcJLZWzIsihJwCHfsdpGEnpyaIoC1ZOu1CECV+FNoBTaKGxKPejBpftRQ/R9EZN3l85 RBwf6QpFww2dpjrferxAKMyz7gNYR9lKkuVEGKol+k54AwvRl1F8EZPF0RV1p7MeDePO zTqE0AbCUDvAvi9jorKLdgtJJfNC0m9ZoWPgfNPLB5z6f+WeW7ChCRQCxOkCUQ/SBmyg YvxiZ/gGh3EXJzcrPt4WFa8SMG5WgjJhfUCMAHiDkte8zoD2A5dlFotemvSbVVWqfx0C LrnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sggLwzyUTSjgBIuaJEzP79mf/yrQdo3fwuaMhlgMyAg=; b=brPGPraGDzHVHaKYejXrRMvn0BemkfuQpK31eR22obJ/7YZGx/Xh7+tr2Cp7awtJV/ K5eruwWKQ6zbOe/DKD3jZcX5ZiQFYL2MjIhUBP7UsezwYI62SXhELV6haau1g+JP4ggi 4CoeI/2HBorR22FQIRuMJQUvdg2f8I4SaPdzyDWhdMfUobZxB+G5oGj2UkTX9c5F5Sez xbWM3Ztv/D8A/8NzCH7SFh3+vRwwOrxpFzU9L4/CFn9alGeNwpYGfAufIyivp6keeR01 XskuBywcvQWF+nYjIrnN/Ckusb3fCZWhBTrKJued7mIX8/XOuk4Dl/LuOOK8be7di+5l riEg== X-Gm-Message-State: AO0yUKVSxrpLScCDJ2iiWpgr+u1UoE2f+sEKwz9pKGbIpyDErLVubpKa 5B75Vd5Gl7nD0HFmWh0GrsA= X-Google-Smtp-Source: AK7set+fr6vKb2OMIQX9zZSglbuOws0xM17kZgxoQZ42JzYd5vN+1jVA0zh0yCDQt/vDmbY5kH9ZWg== X-Received: by 2002:a05:6000:a07:b0:2bf:95c0:6b30 with SMTP id co7-20020a0560000a0700b002bf95c06b30mr88786wrb.31.1675282665475; Wed, 01 Feb 2023 12:17:45 -0800 (PST) Received: from localhost (host86-164-169-89.range86-164.btcentralplus.com. [86.164.169.89]) by smtp.gmail.com with ESMTPSA id r7-20020a5d52c7000000b002bdf5832843sm18021271wrv.66.2023.02.01.12.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 12:17:44 -0800 (PST) Date: Wed, 1 Feb 2023 20:17:43 +0000 From: Lorenzo Stoakes To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, stephen.s.brennan@oracle.com, urezki@gmail.com, willy@infradead.org, hch@infradead.org, error27@gmail.com Subject: Re: [PATCH v4 4/7] mm/vmalloc: explicitly identify vm_map_ram area when shown in /proc/vmcoreinfo Message-ID: References: <20230201091339.61761-1-bhe@redhat.com> <20230201091339.61761-5-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201091339.61761-5-bhe@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: xsumtdc98qoezn176q1sr5a696fdr64y X-Rspamd-Queue-Id: BF00D1A002A X-HE-Tag: 1675282666-124367 X-HE-Meta: U2FsdGVkX1/zQjKN4ZuK3uDNoctkqXCTI0Uq/zf6ZiNDU5/P0bZz8adA1V0ARkVDfscuAGWXOHOelS2vxfSGuKqHIZoXaHoI/zqOSf+LnMvSfv9oPP4VB1doHE2DOpys3z+2qBQK5GdWOL4ON12eXtVN3x2IYQlCtFoq9tE33r7QwigdoWYu+F5//GqdNmkXi/u+3G9/JiD57F9brGL9ccRyhwdyHL7fwpMyWaOw6ouLze2NkBHUQZExaO9gyX1VTR7QICBfMutkNuooM0e0FISyJFPZFD6mL8PxctsecB2EXBwwCoS/rXHUlDvhi12xuHKtONdRpG/EivLS2Jmq57Hm+q0rGLfgI2qc15l+mvrilyD4odkA35VmH4f7MODPOEwTYDpMhVm3oBgpRVfzL3t3IenvV9oJ0N98OX3L41sI0zFbSvYNyc85Dsxh2yz/1VvfFALtu7cWugnHDE879XBWMYixliYCmbneHbI+nmKNiKwVZs7NH6O1nLf9E94wpoXgx5dIERgdEEwF77nbNn0xwxke3VCkkeZMUn/oViJ6XLQUh7xrM/ep8KIQ5omShQqjaAtQMNc/RhiluIXOdxa7mjZBLNzVVxUX4f17fJekS+vSlNTrCK9bQ6WFTcyp9yKYV4qB1BN52YLzSd5+c1m0fDp4y0rrvTlGjU7eYL+6q6Ai7rYOu1E/Qc1di+QZW2yC6h5MdMDxvykRFteneObD+Y3TBj91Ut5LOaSt5D6FoyLSEi5keHOIGQxNb9tGhogUqkK2s3SbT0vSb5IEgSc8ggp5uLdQzstdyVc0IhrEzq5wZkjFSU7WPotezJwlWPIXQ4WiWg9VTJmyOaOuUlcQVUKjQZE3PmxwTWMt5VE8S3CHrIwoWtAFD1mNStwGMayUoUUOuwSbcs3uWU7hoRP2ROL38nkfts7dPGZxYhbZw1sZDrB0qYAvhAbaOVpXaHyLk2vy00eWAbrcZYy jyHGJxJv LICfBgneL2qiDdjft8CC8QXzJR6Nlu7HvZY4QOcRTkolleSHCjtKPYCiUiDJhsdva/XRC6rTjTSeBcCwn2z1XFg2bWsQ/QboNrgkDqApZ+t8lXGVg66ApyNis7PYg5N3J8VHKoX1R2XK3mMJKX0vbeaaahW7nx+Gy39BsgMdTIAv9mV3JiyHUhZNIsRZUuXAMbu1j1mpYnHAP5QU85PXzssQmjmoTAY6+4BEm72QTDcYA7DXF7APL+ge9KKNZrUr1qJrb0oAMLk+Qrks8EXJB1rq5IeVYt32eMwrkVTVWx+77ylUCS4zNLYVS916onljuPmgcIX27IDLQMbeNqvOl/+meXWzqcU+1MGjGNPrDesqOfe0ICu/IUHG8cITciH37rcimJrTgM9NUso4yt7CEuYmTW2PkZIh7cgM9+7rTHrAjM7wg49qPOWDdSMFwgS7Ki2yc+Jx//Ouw2cjrkUxQl1ZDu2/crrjCJbz+tcar9TFxa8Qe8N8kzf7/ghkoN+BK7mIl7y3pTggWylsmFmINNSF7QGt+uwuGFDXz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 01, 2023 at 05:13:36PM +0800, Baoquan He wrote: > Now, by marking VMAP_RAM in vmap_area->flags for vm_map_ram area, we can > clearly differentiate it with other vmalloc areas. So identify > vm_map_area area by checking VMAP_RAM of vmap_area->flags when shown > in /proc/vmcoreinfo. > > Meanwhile, the code comment above vm_map_ram area checking in s_show() > is not needed any more, remove it here. > > Signed-off-by: Baoquan He > --- > mm/vmalloc.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 5a3ea6cb7ec2..e515dbacb0cb 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4232,14 +4232,11 @@ static int s_show(struct seq_file *m, void *p) > > va = list_entry(p, struct vmap_area, list); > > - /* > - * s_show can encounter race with remove_vm_area, !vm on behalf > - * of vmap area is being tear down or vm_map_ram allocation. > - */ > if (!va->vm) { > - seq_printf(m, "0x%pK-0x%pK %7ld vm_map_ram\n", > - (void *)va->va_start, (void *)va->va_end, > - va->va_end - va->va_start); > + if (va->flags & VMAP_RAM) > + seq_printf(m, "0x%pK-0x%pK %7ld vm_map_ram\n", > + (void *)va->va_start, (void *)va->va_end, > + va->va_end - va->va_start); > > goto final; > } > -- > 2.34.1 > Reviewed-by: Lorenzo Stoakes