From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A772C38142 for ; Wed, 1 Feb 2023 18:22:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C53A6B0072; Wed, 1 Feb 2023 13:22:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 775676B0073; Wed, 1 Feb 2023 13:22:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63D976B0074; Wed, 1 Feb 2023 13:22:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 52FBD6B0072 for ; Wed, 1 Feb 2023 13:22:40 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1303E160263 for ; Wed, 1 Feb 2023 18:22:40 +0000 (UTC) X-FDA: 80419543680.13.FD599E9 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf20.hostedemail.com (Postfix) with ESMTP id B56B81C0021 for ; Wed, 1 Feb 2023 18:22:33 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=OFXvmyKP; spf=pass (imf20.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675275758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LK1P/CMLNeISz/c0nlGst2RWi/0NZ0o/BpvrK0rFx2Q=; b=ybS6VP77/LvX3tScK+e3ux8++ycGnWRfOr8S6NwioWIceUQqYoDf/RzEroJa4vez2Xt2Ln ryPjFzFlw3Nc/hF9APHH+LGcz34zEi4Ml2IgEIda5p5cGFKdhIsFhaMzklSWTfWfestw7K 0VXuyFkfBiEPd/QFz55cRbBgxgaxm+g= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=OFXvmyKP; spf=pass (imf20.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675275758; a=rsa-sha256; cv=none; b=aGukkl6QjM3ic/pdRPzNg7DvgfG2wcbCJV9hOi+R7cEluR8KtzzFLUAmhscDMK5jcMA4+l XYr0pld52dP8d5SUTdF/LYtkX+/tGfVokXSNVhTb2GEgX0U/6W/uH6DQF6xQZraG2MPwUz 0jY3McHiEM1YQKKsK30b5fZrJGbzfOg= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C97791EC0426; Wed, 1 Feb 2023 19:22:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1675275751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=LK1P/CMLNeISz/c0nlGst2RWi/0NZ0o/BpvrK0rFx2Q=; b=OFXvmyKPcyconiHwMNrgQAUNOb0dhANdfQjhsK1+Kr8nj9iA+ITBUH/1kjILD7uoP/A/d9 G3Jihf+k44XEUC+K34HG/rOGRbCMHMbFe0JMSFsqVnG2UGxr1YUgSM2sL+g+LqvF1lO6NK poXHV6aglKBiEyXYXfKUQsOYwEpKe+s= Date: Wed, 1 Feb 2023 19:22:31 +0100 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com, Nikunj A Dadhania Subject: Re: [PATCH RFC v7 11/64] KVM: SEV: Support private pages in LAUNCH_UPDATE_DATA Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-12-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221214194056.161492-12-michael.roth@amd.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: psbu99x368aebqtobbtbf8ozi8rg3mor X-Rspamd-Queue-Id: B56B81C0021 X-HE-Tag: 1675275753-349349 X-HE-Meta: U2FsdGVkX19Nl4IIe3pXCSeD9MURxRALc4FtrmLzV0Zrg7tynrl9N+Z50EvliYWDwZmyPtZDO35vDhta/011LhF561ot8AX6+3cIxGm2cYdAekakpye4GSSA05wklSJfDNWVlC0nukmzpbJ8FjJhf5ggA2SI5gdgGz3RrI1ImE4UthxPrxRlgqBZ3li2Pe94HidrlhRBGLBWuQsAj3s9j9n/hQwPfx3DQs6F5fOtoiDSug/5U5gBKAnbks81ktD8lugR50nuAWy8QF4oO2CeGMX8Set1XAvw2c+jTnJqzb8tHqW/cnxFmAv85iWUGDDn23bUoXcraJy7EwLfS5mmDU0BSkUfeQAF2fuqClMXiO/ZQeuNRG68I1uKvqqKjwrxwl4/mbulzDgXDCUKBLaerlB/HG/EV/wuj+Ph3eb9EM+HHfN2bcvHxTixasEJmpfYwJ7q+RQ8Wwze6JvLPWBp8aiHUgHvrzPYpxs2mX+VspbpXsINoYu6GSu4T2rlp8gJY3GYm+6+SHRfjvZSR7sCPVqYzTP4IFQ4NDu7ona34Z46eNdA/vDl/UKQ5eg/Qga27FNi1AeAV/UuN4O6t4IjH3NhZLAdcyU1n8VTYzXIfZG61ED9WeqdWGWq4hPWKUmOSnUPi1aX9QDjDQ29zCFWj+NBK9SxqVXBztInhQdhJhIp3JGFbrZUNbnrhuGSCysKUjmzFAJGQfOLajubiHPpYjjKrN3LFVXQvhDlLByWov7MMb6ddyRYeP5iS8SfFygAG2+DMsaRZ0Ks6Elykpl/O7BsHuNkSsMLvAgAdTbby5gnQFFZiq+ImDLZHQNLL7errFn3AwQCcf4FLQ5CIRs56z/tBsonyYveGgrSCiX9aDHRuJIF1/RAL+pd/rxo7SECqW481rZX09jVxX29y6r04ad2c+sP0prAP/zX8w+R31swhCeuCNk7E5hGlMO9LgMkNtakXTlu0B5kh4IrlHv vejd5lzI 5WuKE0HAad0vAjImwCVKErS5dL0N2KihdCWwMkdmE4vaWxL/miv5H7G8DsxtDLRCrXbqCrG6ZD+8eKzcFKPra/QLNfa7H2Jix6XuFoh6KBljds8CP82K3u9abOmZvUzDjmQytAzstmXHzimEIlqGZIK4zaNRZHNDCMBVFNDnkV6PAQ4PbJLxXIiDHC2s0wJDOcg1JsEQwA3DsKk+NFDJxeDK7BGZXy2qI0UmytaAeHl44n2XjzPgIMxeiAYTn0LjexLD5kbUSZ6uSj6A4uLt/H06nZVn/w9yL1/WT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 01:40:03PM -0600, Michael Roth wrote: > From: Nikunj A Dadhania > > Pre-boot guest payload needs to be encrypted and VMM has copied it "has to have copied it over" I presume? > over to the private-fd. Add support to get the pfn from the memfile fd > for encrypting the payload in-place. Why is that a good thing? I guess with UPM you're supposed to get the PFN of that encrypted guest payload from that memslot. IOW, such commit messages are too laconic for my taste and you could try to explain more why this is happening instead of me having to "reverse-deduce" what you're doing from the code... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette