From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4134EC38142 for ; Wed, 1 Feb 2023 17:38:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D38E26B007B; Wed, 1 Feb 2023 12:38:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE7EE6B007D; Wed, 1 Feb 2023 12:38:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAFD16B007E; Wed, 1 Feb 2023 12:38:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ACE476B007B for ; Wed, 1 Feb 2023 12:38:46 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5EE63160865 for ; Wed, 1 Feb 2023 17:38:46 +0000 (UTC) X-FDA: 80419433052.08.6C91748 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 90D86180021 for ; Wed, 1 Feb 2023 17:38:44 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mWtAG3Ov; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675273124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j50WPlf1oOeMOPN2v7tDZdN2xLD2hes8q87D9jXlTFo=; b=VIPH+wbbpU5w8pE8fyN5wAQPUchvYVfLP+eXROWatSdQTQCILUmdhAvtMmzkXOfKg5qJsB Gc7M5nQCUfUws035V3Twn16gvszVhSQ1wdgm09JUFjgG6/ry1llDlgPquEIUxC4Rtpujy7 m9LkNIFJ7PBXB6Jo5kY26MV1lwrtHSE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mWtAG3Ov; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675273124; a=rsa-sha256; cv=none; b=BOEQUtUjLoSp3vidw9p+3e1rE8m0fADDANKGqmX45hkYep8scp8dpAV3dxwY0WLczCOmYY uvVFGEN4nXtu7leVwHrYvs7I1DEXoiFmyyULTKgz0ZzxQnkHoqwiSxCNrbL1vnPhCVUcoY qh3T1XOqkel8hVECU128M9jLMthz6Zw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j50WPlf1oOeMOPN2v7tDZdN2xLD2hes8q87D9jXlTFo=; b=mWtAG3OvhEUBZqQy3Jt5mexO9g d8sd2RARnhLokWPz4CxsI+wb8r6qVXzdyVVEWzAoJm00VBLeuVV//qo+fbFwlQScl50a7GklsXh51 iMqnmuQbyOnrCodmTmWHdkI2R4gsXt2ApaDF23zPW4MQkxeTnH+eHGlQnyVticKnVG9fJBinU0d2r c7kTmQ3V8mkgNPupD4ooqGWoGrL7Z3qSmMeRjHZVzCk3twCAtMqfBgD8JjoQl/9/pRkDqMrC9v0rm kCWAuY57kHj2hzbz2EOny7w8OHxO5bpHP8LAFlKCm4Y7ABApa0Hb9a+equRMf2k7mdJeFOpUpXMMW BhGktSPg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNH4C-00CXCv-18; Wed, 01 Feb 2023 17:38:40 +0000 Date: Wed, 1 Feb 2023 17:38:39 +0000 From: Matthew Wilcox To: Yin Fengwei Cc: david@redhat.com, linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com Subject: Re: [RFC PATCH v2 4/5] mm: add do_set_pte_range() Message-ID: References: <20230201081737.2330141-1-fengwei.yin@intel.com> <20230201081737.2330141-5-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201081737.2330141-5-fengwei.yin@intel.com> X-Rspamd-Queue-Id: 90D86180021 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ye19nxiknaapyt1bmqajgfzr6e8sado3 X-HE-Tag: 1675273124-236273 X-HE-Meta: U2FsdGVkX1/qPR+Gl+BwBlUtS2sH6kHcPTuUVnB54QkhRTUjPdBsmV7yAFi3EP5ANRFCbt/zqT13L7IWOar8r9KYKT5/CNGO6Amll0scSE7NRlBgz+8uHGqsnXlJqQqFotrfTCGh3P4vCLZ9z4C0uOwQE/QKBEE2BGN4EeUakyWNVvefjsZzU5SX1qX1iUQvqjkQ56q8GpVZHLnRRzMc3XcZNlcUdiU+j0xk8Mi1wXDpAcFgg3Q6SBY+b/TNeb/SwimN/T5eWpOk7e/hJYmM9xXt3NjCAzHxPWFnau1bKWqtuGiVVX12sPG+UU0dSvsg4Ny7QFofuMov4rTNYfgAqX93OEo7geAwkn20JJN5yrZhytYA5qEE+5Yy1fN7K7UO9SuWeqerO/22pFrS0WIQsAdVRYt96sXZh22cfr5vsTTtvn7M3dIKOu8L6SkbhMm7xlFc4+8F1GgjLvPkoOoTmW3J0fteqzFlwAR1vSjLaVNnsfVSKvRU11ih19asUdKIHSWdWkKvsO43dyVcpU+xESz65lShx9Y7b6zOQSHVw1CdaJUvGCKrqBB7DPRTPpCLjEg5n6jbrLRRzSVH9Q4OiaBlcyOKIXQBnywWjYppwv8XoPppuzptkSrvcnP+ZYVIS6WUyS7nLlb+UmOntSVO00+jWaRVvLNfuotuEb1V0tk4x3P1rPIlsrDDTXRyiZM5PRaYbj/+8NN+IVPV+21kSithcGoXN4818ytDVb2XNupK8FmtN2ZM2kABtpxaXgpAWeREFkuE6euHkbWKCTeihLfZvG5aThM6HZ+/jdpcFKtSxCPBzDD1ZIedBRhXX60GjIcUegaxIjl6JtaMj+0XkIZoRarcvcP+Lh6A7lvhZWQgAqVQSyLMoMqOEFWpaDZjf0y4fYJy2mLTrZDjoiBwo+tNAXe4ioS77V+85heXGjvZz77iWO67+RBADB8eJQbY9jYhAj9lzBSvdjKf5Qy tAAUW+7Q uXURti1+++DwfTLvrMiA4eKKEefGkXXy9Olf7iI0+sfbIXcn1UrfPfnZn/Obe1s/dMym51eMI+C3YT1BOEPVyb2D5xejASy9dHFj8GPhK98d4+B2nu4p1KBD3MQAAj61mjyAlcxN5YHnjnS6D7NL2LSVDB0R3vnyzuloSQv0EDRbXGdhCaa/BsJ0RohEra9GP4LW6IwYVI2AI6c0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 01, 2023 at 04:17:36PM +0800, Yin Fengwei wrote: > do_set_pte_range() allows to setup page table entries for a > specific range. It calls page_add_file_rmap_range() to take > advantage of batched rmap update for large folio. How about something more like this? Yes, we need to define flush_icache_pages() and PTE_STRIDE. (we could also do for (i = 0; i < nr; i++) flush_icache_page(...) but given that some architectures already implement flush_icache_range(), I think they may appreciate being given one large range to flush) +++ b/mm/memory.c @@ -4277,15 +4277,19 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) } #endif -void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr) +void do_set_pte_range(struct vm_fault *vmf, struct folio *folio, + unsigned int start, unsigned int nr, + unsigned long addr) { + struct page *page = folio_page(page, start); struct vm_area_struct *vma = vmf->vma; bool uffd_wp = pte_marker_uffd_wp(vmf->orig_pte); bool write = vmf->flags & FAULT_FLAG_WRITE; bool prefault = vmf->address != addr; pte_t entry; + unsigned int i; - flush_icache_page(vma, page); + flush_icache_pages(vma, page, nr); entry = mk_pte(page, vma->vm_page_prot); if (prefault && arch_wants_old_prefaulted_pte()) @@ -4299,14 +4303,23 @@ void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr) entry = pte_mkuffd_wp(pte_wrprotect(entry)); /* copy-on-write page */ if (write && !(vma->vm_flags & VM_SHARED)) { - inc_mm_counter(vma->vm_mm, MM_ANONPAGES); - page_add_new_anon_rmap(page, vma, addr); - lru_cache_add_inactive_or_unevictable(page, vma); + add_mm_counter(vma->vm_mm, MM_ANONPAGES, nr); + for (i = 0; i < nr; i++) { + page_add_new_anon_rmap(page + i, vma, addr); + lru_cache_add_inactive_or_unevictable(page + i, vma); + } } else { - inc_mm_counter(vma->vm_mm, mm_counter_file(page)); - page_add_file_rmap(page, vma, false); + add_mm_counter(vma->vm_mm, mm_counter_file(page), nr); + folio_add_file_rmap(folio, start, n, vma); + } + + for (i = 0; i < nr; i++) { + set_pte_at(vma->vm_mm, addr, vmf->pte + i, entry); + /* no need to invalidate: a not-present page won't be cached */ + update_mmu_cache(vma, addr, vmf->pte + i); + addr += PAGE_SIZE; + entry += PTE_STRIDE; } - set_pte_at(vma->vm_mm, addr, vmf->pte, entry); } static bool vmf_pte_changed(struct vm_fault *vmf)