From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB431C38142 for ; Wed, 1 Feb 2023 17:33:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 573F46B007B; Wed, 1 Feb 2023 12:33:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 523BB6B007D; Wed, 1 Feb 2023 12:33:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4130D6B007E; Wed, 1 Feb 2023 12:33:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 333506B007B for ; Wed, 1 Feb 2023 12:33:13 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EBFC080EA6 for ; Wed, 1 Feb 2023 17:33:12 +0000 (UTC) X-FDA: 80419419024.29.FDA2CA8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id DEF4640018 for ; Wed, 1 Feb 2023 17:33:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fvQ7ODJL; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675272790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TMvBCMIHV++qeulCYUAHjbXXTloYzXKVDmsICQeySm4=; b=b4WgVAqV+EzoZCWOHGl8gCpWk4ZJlxYUqZ4CLdwcGibLKEtMijwglIfOOx9jkRPUGyCHlE 7nfKTfmOVR018tTIZEmFDl5k2yF8m33GNQ0zzlf8puXiAnZfmDgWMCVsffLZfYxGWJ0Lil k5lIMWDKiOCSTzY+YV83cdx2vWZUJDk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fvQ7ODJL; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675272790; a=rsa-sha256; cv=none; b=ElBmSzP0oWhFXbQgqe4wcVQTU3zWYeX8O+sELWE3OmeT/TUuT6oOFWB9/azectdQa4ibSN ObsVuZo4SCOU2fm21AMtYkJoIqsMEF/rm3uEA/BLVUL7Mj2eGTdncxnO9jQX1pPsUsfhAf BB2edqnf1m544yyD89xwAj11ajhuIWw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TMvBCMIHV++qeulCYUAHjbXXTloYzXKVDmsICQeySm4=; b=fvQ7ODJLuCtPjvbshnkqdz9n3h j9VrCmyY2/+qHm0OXCZkr8upnd1J4Bd22YeHPEIwbBpXcJ4/j0ThrMpUOp8rIjpYubJG+r81PEG7o yS+XP5eVpv2c1eufuaK/boKd8e9i1dOOYfn+kaByBxwuVM0Styv0MTwxE5F3Q/rht8UrkGU/zwnBV +HUDsriyi5u3SgbAhlsOIFjUjp75DEBaqfKyHKlCGC1vDlJsv8056Yq/VTSgstmj0OmLXjLT7kIUa iho9HrfcEDBb78lfGJjM9yQzZKr43sKbRUBsD2cwr0+CCe0pFu+0ZCgpCg80wv0T6xWhqAinIfA5V vLUIdbUQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNGyh-00CX2p-Ld; Wed, 01 Feb 2023 17:32:59 +0000 Date: Wed, 1 Feb 2023 17:32:59 +0000 From: Matthew Wilcox To: Yin Fengwei Cc: david@redhat.com, linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com Subject: Re: [RFC PATCH v2 3/5] rmap: add page_add_file_rmap_range() Message-ID: References: <20230201081737.2330141-1-fengwei.yin@intel.com> <20230201081737.2330141-4-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201081737.2330141-4-fengwei.yin@intel.com> X-Rspamd-Queue-Id: DEF4640018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 8xw941xqixyhwn7sdjwpnsn56kd57uc4 X-HE-Tag: 1675272789-393858 X-HE-Meta: U2FsdGVkX1/qSQdooZj/B/HENM31z45jKDazeLxiwELi5yFZp3JjLfx2xiBreu+CrpYlNdoQm4Vf7ldUIXS/IfHWKhuwX/68tZFX3U/CByC8yc6NZkdNUt+zKe71/Zb7bI6T7Wc3v2E275gxWnfp4ZIDtjZhovficzsbQIhWu8Jhea2KM+4JX6oHTTfwJtkqz49AC++JyzZFpASNexXG5jXn9tFj/CEMzgOSa4E9k+hhuVfSEwX8t0cwtRlRi//TWYkLhyRkCLDMKeO/OCjFLcbSmqio0GjuQVLSTHf2LXf/sZKCmucKoEIGEeJpJUvucpfqMavbfH1f/tnrdp7Cd7r9LHczCpZqSy/4NK0Zlcy0nOxQYBHTZ6ypypyoqsSO3EOR5KjjUG+r95lMT2hXCFn/DiiO1s9GsMnFmJ9GoHOD+msZhAoKV6cDe9fPOoeqQS6OI5qIwt/vdhQ2gLFwPCaiqwqF8t9gPri6SWzRdYZZN8R3QMOVzBNHnTrm506nWMUgp25kQgczPkt8PmlA4kq701zk8Y1r4Wkjr8q9fkbh8g53zdgmqTJYgAluj06FrLwnDlpbwaSFDc1ROEM92ywUaS13gjFl+FgdXO66hLktVdFcYs7xEXFhLMRmIo49C7MgmAYHDdY4g21MlE4lKzX+RVEuHof6LMhk/4M3C1m6Q5HVsgjSc+tpfqiC6TKE177gZf8ZbABMRrWPzhpiuNMiA+t68C2IqpKRlUyGmF+53UuGjasT6WuxtHFeYlZw5uFYq0udNyUKP5eX2FJZyEbdtj2viKso98zv32b55Ack7JtjYxXB5/VLC5AUssZzqcIxvqwPtyAzbzJ45BNO99UyghLtcz7hx1YIttMaM9IpuFocyhC/qE4fr1LNYPL82lIZAPIKNOhqVuzpFIr2tGwGGz+lQ/b4VJ49US4OJiWjC4aKWydJ6MZ0hKKXq7Y/wtqRIMkZK+eMcc0oVgu 2EWDvPlQ tmdG9ptyOQikyuHE1P030Ctd6KVYJgfmHkMrsrAqfkk+MsVFXVAkR7/FTO+l6oh0bau4Ppb0s8+6yw1SQY5F7LV/bZYOQ8dEkh76W38oqjI3HU12uud1eyqykTdBJXQXPhESZhe456szgn8+q9np/BbcZbvQIXPnNAushkqRNlvoAlUjhsJXCp7d/8WoLJjfwozHHuhzweY2KPAA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 01, 2023 at 04:17:35PM +0800, Yin Fengwei wrote: > /** > - * page_add_file_rmap - add pte mapping to a file page > - * @page: the page to add the mapping to > + * page_add_file_rmap_range - add pte mapping to a sub page range of a folio > + * @folio: The filio to add the mapping to > + * @start: The first sub page index in folio > + * @nr_pages: The number of sub pages from the first page > * @vma: the vm area in which the mapping is added > * @compound: charge the page as compound or small page > * > + * The sub page range of folio is defined by > + * [first_sub_page, first_sub_page + nr_pages) Lose the "sub" from all of this. That's legacy thinking; pages are pages and folios are folios. "subpages" was from when we were trying to use the word "page" for both "the allocation" and "the PAGE_SIZE range of bytes". > + * > * The caller needs to hold the pte lock. > */ > -void page_add_file_rmap(struct page *page, struct vm_area_struct *vma, > - bool compound) > +void page_add_file_rmap_range(struct folio *folio, unsigned long start, > + unsigned int nr_pages, struct vm_area_struct *vma, > + bool compound) I think this function needs to be called folio_add_file_rmap() I'd like to lose the 'compound' parameter, and base it on nr_pages == folio_nr_pages(), but that may be a step far just now.