From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C55EC05027 for ; Wed, 1 Feb 2023 12:19:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1DAF6B0071; Wed, 1 Feb 2023 07:19:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCCC46B0072; Wed, 1 Feb 2023 07:19:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBBA96B0074; Wed, 1 Feb 2023 07:19:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ADB276B0071 for ; Wed, 1 Feb 2023 07:19:21 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 870F51C65F0 for ; Wed, 1 Feb 2023 12:19:21 +0000 (UTC) X-FDA: 80418628122.26.3964869 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id E4B4114001C for ; Wed, 1 Feb 2023 12:19:18 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mSTttzla; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675253959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vkRA3RgldZwQy1Rt5+FnSQTm+xTUvtojb2cbqAI5fmw=; b=qm2ivqEWxfLXiVGjYqaQFkA49jm0myRfvishAugBjs8dgqI74NBkDs8EXT4kVn5E0sHqaq CZQBhkmqlmr9u7ZEraifKZJODRZeKM5hG1gjdVGcG+R0uh1b/8cBk7t262qu+6cVPeHQrW 5BcqF8VaAbAvAMYye2HzOGlg/Qlli+Q= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mSTttzla; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675253959; a=rsa-sha256; cv=none; b=w8d8ZmWI+2//E3BHtjOba+lEqIjl/fJnzNt2KpRAsN9mOdfIQqM+3PM7SMg5erFIy+GjN8 oa9Tz3nuFEUEDv7hidukGGRQqceL38wMuKyuV2YdjQJTsxQBlSu/dl9bMFLgWLWdKQ1eUK 49Jxohl/ZtZJEZUXVSsvKVGIrvntLyw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F055960C3E; Wed, 1 Feb 2023 12:19:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15D82C433EF; Wed, 1 Feb 2023 12:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675253957; bh=772MiW9mQPh+KTvZmr96PFBr8QTl3kP4byXYDSUvGbk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mSTttzlaBqtcD72tYR1zi5yN8MbEl8GbslcBUchxh370gLPfnhDY4QsVUUTw0rWWH Ceq2pyy5tjuQpFJO5SFSqCc75321382k9G+SWiUjF2VHfMRlkg2wqYxh2F7TT7mOUC tN7TAkjuoFyoUsgW1hsLiEO1EomUe5tL4VuByvMris9QfBXm8ZHgBjc+Q99MIXx3LB ckaJ8O/xBJZ76Wfi/XlUGbqpDeMeP4X70v/UVXrEOfWSlCBpN/BFnITZx8G3akX1av YFUgzaPgARNlbCNLTRu25otXHaKWUVPzuRHo8sHX2SM9kZVrV59D5wCo9EjgMjlFIb pA6V3qvEAd90g== Date: Wed, 1 Feb 2023 14:19:03 +0200 From: Mike Rapoport To: Hyunmin Lee Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gwan-gyeong Mun , Jeungwoo Yoo , Sangyun Kim , Christophe Leroy Subject: Re: [PATCH v4] mm/vmalloc: replace BUG_ON to a simple if statement Message-ID: References: <20230201115142.GA7772@min-iamroot> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201115142.GA7772@min-iamroot> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 87kr7q39gdtr4b7fm659jaqa3rjig6rq X-Rspamd-Queue-Id: E4B4114001C X-HE-Tag: 1675253958-56089 X-HE-Meta: U2FsdGVkX1/WK9Q6nbxdTL8t2aG/9f/PALNiKXTJ47qij9EvhxgZARWuT4+TpzWx5kl3ZhgRRE9OpXWh5LmB5AnvfOlsv7RJJv7du3VW/25fu3ZyAm5yueNcpAFOj5M+xsqFb06UeUwWP6lFuJ3on5LIJj24SupIxtrO86mkrm3fH0OWvso4cfFWInIs5XtriMB6l/B+ib4UYSBkHCEBbWU8L4EkSfD/WAXoyBGq7sIFfrg8cn08xt6siL/nRpq2AmMVqpMLgZ0LPXxz5IN4nHvchbRRB7Dq/PMHqNDSfUaoyhcs7vj0L/7s/tCoMdjKjMpNt8tTTYlvbP7IgRWjsX/5W9OQN4m6W/0t08JGVCsrb330S18zx7UkQSYdBzCRskEwfBWRVUhHcvQTci908jRvvpegsoE29Xavy6JWToWhbaaluPH2IJBXL6IhUIQhKJmZCwcHZom4ONFlMmlC4LV84mMuXwbeQLcwifUC/WL26TJHwf/RpaJka6fTFisHjE6j0+72/4UzY3yAzHUc9sh77JJnykQbSu0FQ93v8kHbQIg5Qhd3fRDI+MtX6YJpvxd1H04zGX88b7kuxDcbniimAz/F/sf3Wr7w3MIelkbE21/+KkBMHiYPcF9xkcW3HudGJE0BQqEJjjsoNjuREpk8cjOHPzMpLYjdlui3FCsxOqk5rKXb/m/RRydMDsajJ+tPSbkjGe3kf3HTdBWc080tRXiEdxOVygl8oIRxZjfIRA6TRJRu2LLWF5KiZDEdJCJqWajQYuynQNEe7jWRdAZd9TLVCyRJG/YfP+n75cTMBLwcPzXs+ITVHvXoySdMBeAxchjQtXkxly0f0QZiqcYa4rV3gJFeVgLuuXxSBI9vo5Yo3WTIKmK7I6hjY/sBUFZGtylK1SKbObU83hcLgIireOfitZNL9eXr+uLjDdw7FOsWWZJAxbNJ4IYvkzyqpTaIBy0VuWGcVphYWle wqe/tO6l Hp39Gh1wFwsjBqGqLcDZ6AYSDn6pM4WZKyFl35yIXPDLyWtDvnWhzaD9nz5tuY/DJeCkkXKCoRzIPYevtCrNqxN2CJq6o+WLIrGh9T8HYuo+9ftFX0hglWyfwavZt10Noe6otWqVbgWDJjDd6DzHfdwI6BEVzz4aacTLEEFFdTa8VIx1x0Dz/FP9rmXaOTh4aARmhVbwTS+i/bf4Tjh5ltN/gcYIXvSM3QWSi3kSWLlJ+//1OvHkR6aOyK7j9X7TfWwjJ1Z/F8irQAVV3fs4R66kJyo7h7wCaNgeS9U/7FJ8fcaiNHUDxhT5m39yQpP18ABgWuT8V65mqGQXt6dNh9aC8F0nsfsl/4wR7EX/sSM2KemjVN3s/dvPiDrJ9bojiqa+boN7UsgPwKTRIKT8tq+uqCRxJ42KkMzZGuPU2zmlfnd18UForatyl2hMxKiVIF0THs1Zk1kkcYyYmy4OKTXtctPRzp8VWyqhGMnOtS/lWJO8abvpfYUqdJF6M6jHQvLOZiOKFCEm0rJ4ZKR6T7OAyiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 01, 2023 at 08:51:42PM +0900, Hyunmin Lee wrote: > As per the coding standards, in the event of an abnormal condition that > should not occur under normal circumstances, the kernel should attempt > recovery and proceed with execution, rather than halting the machine. > > Specifically, in the alloc_vmap_area() function, use a simple if() > instead of using BUG_ON() halting the machine. > > Co-Developed-by: Gwan-gyeong Mun > Co-Developed-by: Jeungwoo Yoo > Co-Developed-by: Sangyun Kim > Signed-off-by: Hyunmin Lee > Signed-off-by: Gwan-gyeong Mun > Signed-off-by: Jeungwoo Yoo > Signed-off-by: Sangyun Kim > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Mike Rapoport (IBM) > --- > v1->v2 : Add commit description > v2->v3 : Change WARN_ON() to if() > v3->v4 : Use only one if() for three conditions > --- > mm/vmalloc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 74afa2208558..3b7e8856be35 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1587,9 +1587,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > int purged = 0; > int ret; > > - BUG_ON(!size); > - BUG_ON(offset_in_page(size)); > - BUG_ON(!is_power_of_2(align)); > + if (unlikely(!size || offset_in_page(size) || !is_power_of_2(align))) > + return ERR_PTR(-EINVAL); > > if (unlikely(!vmap_initialized)) > return ERR_PTR(-EBUSY); > -- > 2.25.1 > -- Sincerely yours, Mike.