From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C198C636D3 for ; Wed, 1 Feb 2023 12:13:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5E796B0071; Wed, 1 Feb 2023 07:13:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0EA96B0072; Wed, 1 Feb 2023 07:13:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAEE96B0074; Wed, 1 Feb 2023 07:13:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 99A176B0071 for ; Wed, 1 Feb 2023 07:13:36 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6C45BA03F1 for ; Wed, 1 Feb 2023 12:13:36 +0000 (UTC) X-FDA: 80418613632.02.6C997E8 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf06.hostedemail.com (Postfix) with ESMTP id A1E1218001A for ; Wed, 1 Feb 2023 12:13:33 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jRNEy6L9; spf=pass (imf06.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675253613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fZKtpTgkqaYU4jEZ3IrkFfLCfdP2+CMiYu/MZz8jd5Q=; b=V/qTYIYoHBzPcuYlU8yI4wvRpnc56Uggtxr2v+8z/3o2ypFI0JHuSfqo4Qm1hhf1SvNZuG v3/XAv12Jwl0PWO6LxF7PipHiRfAZK0pVfuJ1+GwMlTh5madIp1EW7/wCspVyDb3er4KEL xuTcLQYs3bSZh3trIMkEipNqnKKNE7U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jRNEy6L9; spf=pass (imf06.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675253613; a=rsa-sha256; cv=none; b=JjzHeup16CsDI00IHw1Iv5WrLTdvp/n+ZZHgogNR1YFsQRBXqQWnJlZ+u13xb8yQrcMsC/ iWS6AGhZT/2nV2DRe5sRhUWaiGzcGuqxucwx4LJAiGZ4O+oAPnqAuNyjhSwo1mVGnK40qZ 3DBGwkwRUGFvH1nNiDFjzPYMhW/Dqb8= Received: by mail-pj1-f43.google.com with SMTP id c10-20020a17090a1d0a00b0022e63a94799so1973840pjd.2 for ; Wed, 01 Feb 2023 04:13:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fZKtpTgkqaYU4jEZ3IrkFfLCfdP2+CMiYu/MZz8jd5Q=; b=jRNEy6L9ISEqRKtajxe7+ZTCDp0rQAwUvPfegZ0GutynyhtLd1nHin6cQMibCoCzqP jLvR7lVsJSLpxM2phE3Cv7qVNjKggmtrCBPI3e2oNpzPPOkuoqJuf/EycKq86614i4iN 1nChwfHb72oH4OLlKqrybeYPXFrpJ5WVcRdeZO+UppIx9ytqn1bKdyYwzsRfOfXqXvV8 iSx1xiUxnEj/dp9VSGEctcvxA7B5u8PKRMgF9eQa7u8UnWeeXlCj39yOO4DdOHllktT6 LPjs0M3f6wGq+96fbNLlWeMgBRWjz+rBAed0EQJ/RlZ36LyjnwR+IKxeV5vlXzwhVHYO t5yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fZKtpTgkqaYU4jEZ3IrkFfLCfdP2+CMiYu/MZz8jd5Q=; b=GGw/nwNv/ISio3eHSeW5GvWUl3NGMHo0XeQn767d6J4g9CP5cNqOzb5du+Ger+cYpC dHFWcLaJHU0+4/+PMsWiEJoEzNpBjIYzspfihgDxZjipu6kMFaFTQfrLDOEsqwANd23F h7Pv5HDG8xWZRlLo7fo1dFIFNHIOzM9vS5t3O0GiP7tex5lW886NfzAh0ifvYQejj97X caHwymrMSW0V0bth7gjDVy491Su69sVWZU58ej0i0uxy2HPlMXnwZ/YE0cUivIhlgjtf HHyV/PheFkw3QWFEeHw5OGYudhkLTk7eLdYhe0TUtnHb4y6FmAKbTJnC+Kbp9QaDlpU3 8M0Q== X-Gm-Message-State: AO0yUKXrPxLBBs/Ay9ZOOvpmWuGqFNRqZO5R7UFnCwDH3ClCic/Z0WAm cUf8i2xp385KVTmqsKjpu+o= X-Google-Smtp-Source: AK7set/YWfFU4RInB3p0bI1nUQDVXzDUFc21yvyI0IF5VsiSAQSlmEd5DnS+4URi7lMxfkRjnK2eUQ== X-Received: by 2002:a05:6a20:2d0f:b0:bf:58d1:ce9d with SMTP id g15-20020a056a202d0f00b000bf58d1ce9dmr373675pzl.28.1675253612416; Wed, 01 Feb 2023 04:13:32 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id o18-20020a639212000000b0047850cecbdesm10178996pgd.69.2023.02.01.04.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 04:13:31 -0800 (PST) Date: Wed, 1 Feb 2023 21:13:26 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Hyunmin Lee Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gwan-gyeong Mun , Jeungwoo Yoo , Sangyun Kim , Mike Rapoport , Christophe Leroy Subject: Re: [PATCH v4] mm/vmalloc: replace BUG_ON to a simple if statement Message-ID: References: <20230201115142.GA7772@min-iamroot> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201115142.GA7772@min-iamroot> X-Stat-Signature: k64da3nkscd35ndg3sa954uhbj4qcsyy X-Rspam-User: X-Rspamd-Queue-Id: A1E1218001A X-Rspamd-Server: rspam06 X-HE-Tag: 1675253613-331345 X-HE-Meta: U2FsdGVkX18hXus8KXuER0lrZMDmChHuFjAQW4yXnW33JBuKX9zY3L35OpB8WdOtk+9BDwvKLW+Ae+67F5DB7C+0QcYdhGA62qCAcgeOkSoZSEdzdqBdAQhHOKQiSprnm00LwVnpZA42fqyKUhMeMVa4nUBVCwNkHXQhkP6Qe/t92hxfZ65gkk/iY7DG/o0ZeXxibD+WhPUdq08PgVO7dX3mbu8Sm7SOCWyDS/FwEIG9fSyq6JetnqWk4bI6ghJzirQl8Im69CaEiiy9HDfbt+xT5CWjNsTUghDPyYKPcXC2v8uG+ut7sRGkBvg1Kn2yZcatP9ahy2I5x1odYxjJtVS8u+owpF7N/AJWA6/GfDUpGt9EV7Hafd/+QDV3RAEZ/Tm5UFNv5kibhatX1QyWDPzQZDcOyD4CVVm35n9ohbyG/lUU5KMm27CLsRGaqJ/8XQ0BKbG/fV6GEbTaI1NBQIO1rOff1yZDT0K3T01u3qwTzQYzpc2XBuSJqaX0QktuoXg9wNWqwnGJLlzI2pzjQ+z+1U6EYmerompekGwzO2pKRkwGBMDTj4kCZwFMxmgYBFwMbM4pjA559kMo0o/b/viq9co7MgSESQ32cc5HClALi2ZGbVvfbkPCCZOq6Z9XOTj9gmFsv2lm2ow/NeU3Hg+MNjphjP1LhV0Iv8lqd5o1w2djHj3VWmBxXB+7q6LU5+a1kSlvFqWgUpYJs+rA/hji927l2mYMTrnU7mCvs/Z3XOEo3fPUPcarH7+16v1Bt4NOmJOeENulejHOMUrvvSBEMz6O70/Fzz4hMB/4G3YFY4DLA4eROSAEFDnqfYsPHlwQ25R2iJzLxtnT7+/NygkR5E2l+xBSDNYyiDxcyHUCy/4TJkjc0TIK8Lc2yTpxmLQf5/FPCSC5hMd4jYq5Oze+GqMzBwQhFbiqvnaltc4w56EdeW0AJQ3r29PC0DouvGIDIfICrx6E9ylCuYq bXULah93 pSW8JiYXD4OqxCNaGRXq2tNcVkL8nNJikuDTAlvwalJXrNp1C28aFrOTsLY1Qcap0d4GzMHgO6nkYozpa4Rzs8jkH+zdBt6wQhTIRxSwFI9m4KTbQ/VUxWDnYH6kUF+uAXFTIA+24nT1qZeGEAp78SrHnEpZjLWw02X75MDy/CVW26HDTz1D84SYOw9B9RmdHNvFbffAUFhxrzYogDUcJFpZxkxumhyYOluCobS7b8Gyrz4YEa7l6JekAymdrJNVjA7AbPngt4I9mFok+KuTaAJcOx8BpS728f0AZxPNQYr7fHGKKD4QMRDLjUqMwi8KIi+PVyeYLAZ9X4W3gvUNYi+T5Z/2gx770lKQqEHEypRPanSrrSyOiQ7+pLUw+d7quLKrfE++sKrAQTm3m79KQAHFB54qI01gB0q+NOKyehs0vU81mfF86w2+RY8xsUV2IQI60b7yJPccGCeqZT/CbGWUWU5t7PA8ArThqGIRDfpIXfTxAugFp/ktG+fNwQ16xZ0GuPu8TNTy1Kz3TTN39D/k+gvKBAPzC80Lnu7brE/w3kIewAlNBPC25EUFaXQTnaPMHoSKNJj4jQ5T7rtlB/bxqMdcQ3HbCqVzi8LYPasMe34AGbi7kM/bJGXIy4vaeqDHEdPcAmw9PyMI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 01, 2023 at 08:51:42PM +0900, Hyunmin Lee wrote: > As per the coding standards, in the event of an abnormal condition that > should not occur under normal circumstances, the kernel should attempt > recovery and proceed with execution, rather than halting the machine. > > Specifically, in the alloc_vmap_area() function, use a simple if() > instead of using BUG_ON() halting the machine. > > Co-Developed-by: Gwan-gyeong Mun > Co-Developed-by: Jeungwoo Yoo > Co-Developed-by: Sangyun Kim > Signed-off-by: Hyunmin Lee > Signed-off-by: Gwan-gyeong Mun > Signed-off-by: Jeungwoo Yoo > Signed-off-by: Sangyun Kim > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > --- > v1->v2 : Add commit description > v2->v3 : Change WARN_ON() to if() > v3->v4 : Use only one if() for three conditions > --- > mm/vmalloc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 74afa2208558..3b7e8856be35 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1587,9 +1587,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > int purged = 0; > int ret; > > - BUG_ON(!size); > - BUG_ON(offset_in_page(size)); > - BUG_ON(!is_power_of_2(align)); > + if (unlikely(!size || offset_in_page(size) || !is_power_of_2(align))) > + return ERR_PTR(-EINVAL); > > if (unlikely(!vmap_initialized)) > return ERR_PTR(-EBUSY); Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! > -- > 2.25.1 Regards, Hyeonggon