From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7397C636CD for ; Wed, 1 Feb 2023 14:22:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DA116B0073; Wed, 1 Feb 2023 09:22:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 062FC6B0075; Wed, 1 Feb 2023 09:22:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E45E36B0078; Wed, 1 Feb 2023 09:22:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D2B4E6B0073 for ; Wed, 1 Feb 2023 09:22:31 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B0E9780DF3 for ; Wed, 1 Feb 2023 14:22:31 +0000 (UTC) X-FDA: 80418938502.10.2119727 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf17.hostedemail.com (Postfix) with ESMTP id CACA840009 for ; Wed, 1 Feb 2023 14:22:29 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=O5Nz0DKN; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675261349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j4lxdpaowO7ASMedJlKtZbh/kx5LEejmBeEu0y9isbk=; b=cuvy20R0zuEoCAeeo7Juwom/hZCa+BrBRSH7eR8TtskOXk+qHRNEW2YjWsFX+BYuJ6GmUO DQhA9bdSVqsSxuw+Cpvec0ZZL0hGbcKtqwo+M3glUMLQgKKPUqTvq6iNG0W/JIV2IQds8W HMGLDvPTwIXyL6/WKysswGabZ4tJfKU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=O5Nz0DKN; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675261349; a=rsa-sha256; cv=none; b=VplNBp08Ba8F6GZF9wjaYXdR8jxNCDUSnQW6236BHiNZcN87xvMtP9sLd9Xl6Przfibtra r92JRkKZTOwUM4fY0biY75p+BwV/FgDckmUTDm0p6rLmAOQL1CkCUKD8eLGAI7CKriP/2p 2MPM5IApinKczX6sCn4xhbloq93TGgY= Received: by mail-ed1-f50.google.com with SMTP id k4so7086693edo.12 for ; Wed, 01 Feb 2023 06:22:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=j4lxdpaowO7ASMedJlKtZbh/kx5LEejmBeEu0y9isbk=; b=O5Nz0DKN/Uj80cHbuB1ldIMLdlH++UAgNcK0kkjJNulyHrdXo6+pAeLpUR70PJBEN7 hjQQ5bx8cwCNqt4Su0lM+MtXWVlbxuAIpbhrNcGd2X0RV92WmX6UB0VFu07ddIi56ALV UISL4MAlRpsaPfV7JKoJyXDTXIVFt2nzZ6Hp+mtw2jCTRGnQu+q/hT2IAzE2p0GXu9bK HiiDKEKZv4Me9qJMmYDf1AM4lTJTWwfuCFR9olO46ATK8cla6cCFjkVrGYacaQZcuTUM Eo1XixW6OoH1T2fWHnjd2zPaRt9XBo5qN6pd84utv1nrXT7VnXeSnq5x/wB3oEQnCC1o CCXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j4lxdpaowO7ASMedJlKtZbh/kx5LEejmBeEu0y9isbk=; b=2u0/gmRmcMD4+CtVCDEC0Pmu2MqMPgsWXFDObzcPOK8El9KU4ZYrgb/tu81BF0mRAw BiLbA8gom3MqiM0PbYg6qKJ3s9hVpnEWaxq3NIN20dt4R8U8ovz3rPg4VNoHUjXnwEOr jWHJBNA5nWvDIECvN46dIKKlhUGHJG3KK4T204k94znalGeiq8GHMrpW+JDvhvv0Z/Cp H2ZSBnExRAB7O+u3ZVq8xPrcPk8vpx41N7JSpNeUajUUUEGifezIMke06V/N1LuV3mZL EQ1ur0n2OlHBULy8uRrS1Kh4idPz1LM0YU4Ehn6n8xvy7XDWIQV1gyN/lQPNQChE5BU8 US8Q== X-Gm-Message-State: AO0yUKWCVqcsPQ+32ajv8i3V3Mj4Zw69fll3tuRe2lw+kX9F4Bg+vHaY Vv/ofYCCUsfLWqeQCF5EL1o= X-Google-Smtp-Source: AK7set9HN5zAS4AQ4vvW+T4vXIBsk4axiLq2OXWR0+5+f2AU/tukwLwJojApbNl75d5of+aKaxxx3A== X-Received: by 2002:aa7:c403:0:b0:46c:8544:42be with SMTP id j3-20020aa7c403000000b0046c854442bemr2190649edq.5.1675261348292; Wed, 01 Feb 2023 06:22:28 -0800 (PST) Received: from pc636 (host-78-79-169-126.mobileonline.telia.com. [78.79.169.126]) by smtp.gmail.com with ESMTPSA id dn10-20020a05640222ea00b00482b3d0e1absm9829665edb.87.2023.02.01.06.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 06:22:27 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 1 Feb 2023 15:22:25 +0100 To: Hyunmin Lee Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gwan-gyeong Mun , Jeungwoo Yoo , Sangyun Kim , Mike Rapoport , Christophe Leroy Subject: Re: [PATCH v4] mm/vmalloc: replace BUG_ON to a simple if statement Message-ID: References: <20230201115142.GA7772@min-iamroot> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201115142.GA7772@min-iamroot> X-Rspamd-Queue-Id: CACA840009 X-Stat-Signature: ditp5j6x8sj66bsachfrktcz6mzamji1 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675261349-595536 X-HE-Meta: U2FsdGVkX1+DB5sJA/4vlZ8YO1ZilSeWO223Wz+FwNJYsEBpT0WdhauKDzqbpIOmAnUqoDN0zaIIQq3EYYp1zGLsZcegdODfLieZg3KKxYeGRc4kracsiS3pwXRGK6wRFVxHTvhoIZWUUw21LJzIVUcPcZVBLZcYcW4CjzJVo8UuX2HQxTibiVvU8j+z2M26dI2ULjS93nu6tCn+8glOfwvPA/y5Yz3+tyTdKU2187eVITExfr9PMV3nD0Go9wrVScZ6IuagER6Ou+dPLAyAlqXcqBkkd6qpZngnZbCFi/sT2yMbS03kL93fTeOqsed00MNnXHvWiycbo+pp4RZ+mPOBn2F+yAVtvAen+vgYv9YtOi23kkdt5DqyxFUMto/iy/xlf6/rvqG/LMlWttRppslIUtTvWlaLufqNMUPMe7UisSwQCXWx1I2h/k6MuVqO6c7UedeF9uUrMq/ic/2TR+SjfQtNdBC0XETQtj+AAbm9bVRXVFcxH41D27XLeZLxKjknFGceWXyPYhm3TtsEKa4Qgm9d/8rsVobobH1blY9wQtjM6P0FcvmaGMlrRZ2Jo3wsTbEoJ07hwl81GGangdOwFwSXvxbjCUL0vP6n3WUUkfmvBHeVykERZoZSFQ7DK/nMayW1ki+6M1xVP3yxnV3WxsXOtjcax3pxE57O/pe2obqcU2Sy3pImt13TLGFzUN5+pEAqw0wnqUY9PmknAsHWnI7ka8RZU5A4RZ4lQo6OyqUT9rLvp4qo9nAclAXYOt8g8RaGtTM/stGsQVP0QqzXktapQDc/Wt2xkIVBH8/Qu1sz8LuHyRcRU7bb5uUJbBcVbNTJAOB+lzFGejmv+TxXoGrnUDNDVP0nZnu3cDySviaFF2HCGA2l6gsw6KpmZkySvu0aTj5Mv2H11zU1iL1tjB0xTLi3KTm5WfIOzr5ixUbdIRkV3sTaPXkwYVL74DY9ORcr1KYha56PLxh g8sHZCN0 onzL4EuOJHQ7bR+SfpwipvdGbERHKg13bqB80VpHYHLnfi3OjwlKLBpGRFy6zHn7ucPiJl2qLOZuYBFXbdc2N//EDiSsQdRB2ZygyNOW+cd5rY/SAM1zR8PV0l4yw8lduPy9KiCeZ7sR34fm2Kx7oQCWK5LkD+8I2uMGrMkW2sBfW7USGP6XsSKeedL/9oczOWUB4eGG0O93bmgiGxyesFSzRTTh3S6+6rJk9bVlCWVMk8HUHGnPl9PZnNoDAW7nbRGIBXAOTTo4xOblAZ9c1hXmTrU4woHngQlpXEtDkc5j82xcJav/gNewJL9Ih+g73MsuDDdwp2WdBaN7SDXAqpVTvq5mi3eFRWVZ6a2AIVaDieW8wsdlFBPTxSXY0L1ysNHcU3PSAidqd2U0KO33650OLeDOSBSi9ED6qAHUYoSfWRFsi8DZYKOKRcJLaFlxF63WHIFDMDjS9Af2JijSSADwu/lqesK+WtYxWDZND13BYvQCbGcUrcZMDZrzBIIC95ZP19/vxzdIJLbKe8KNYVkMO6g57muGiMrGDxmSrHQC8qXqufyGiJvTUcWRX99y35RPydEtGG8N/6LYs+Exg5mNLKkI62nN2MwsSmcJrzQ9vW4I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 01, 2023 at 08:51:42PM +0900, Hyunmin Lee wrote: > As per the coding standards, in the event of an abnormal condition that > should not occur under normal circumstances, the kernel should attempt > recovery and proceed with execution, rather than halting the machine. > > Specifically, in the alloc_vmap_area() function, use a simple if() > instead of using BUG_ON() halting the machine. > > Co-Developed-by: Gwan-gyeong Mun > Co-Developed-by: Jeungwoo Yoo > Co-Developed-by: Sangyun Kim > Signed-off-by: Hyunmin Lee > Signed-off-by: Gwan-gyeong Mun > Signed-off-by: Jeungwoo Yoo > Signed-off-by: Sangyun Kim > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > --- > v1->v2 : Add commit description > v2->v3 : Change WARN_ON() to if() > v3->v4 : Use only one if() for three conditions > --- > mm/vmalloc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 74afa2208558..3b7e8856be35 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1587,9 +1587,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > int purged = 0; > int ret; > > - BUG_ON(!size); > - BUG_ON(offset_in_page(size)); > - BUG_ON(!is_power_of_2(align)); > + if (unlikely(!size || offset_in_page(size) || !is_power_of_2(align))) > + return ERR_PTR(-EINVAL); > > if (unlikely(!vmap_initialized)) > return ERR_PTR(-EBUSY); > -- > 2.25.1 > Makes sense to me. Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki