From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B7CBC636CC for ; Tue, 31 Jan 2023 08:38:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CDD56B0074; Tue, 31 Jan 2023 03:38:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17D816B0075; Tue, 31 Jan 2023 03:38:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0462E6B0078; Tue, 31 Jan 2023 03:38:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E63376B0074 for ; Tue, 31 Jan 2023 03:38:10 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C288A1C3654 for ; Tue, 31 Jan 2023 08:38:10 +0000 (UTC) X-FDA: 80414441940.30.F57A4F6 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf20.hostedemail.com (Postfix) with ESMTP id F32BF1C0008 for ; Tue, 31 Jan 2023 08:38:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ISQTBSXK; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675154289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z0YOgb1qqY+eYSMvEeNHP+Hqfb8/SIN7dXd5+Q8wSDw=; b=nWkZO6If2+XLBc1wL5jdJHqdPoIUGiPZQFKD4fVFcTOOT3lBzlH2V7pbGO91udwyKF+m1O ntaKb3QK6Fc7HkUI9Bxcur/cghVRk0/loO0IjV/z314hQj6O4srSqshjAo8EJi4b/jQ2tX MDoFxLR0+6CTYcFxfxEbluu9DmwJU0g= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ISQTBSXK; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675154289; a=rsa-sha256; cv=none; b=ACRtKLsfZIAJYfYP/ZrLP+f0sZPmP6+x3pFhzONfLYr0m9+akw7br9gNCc0/oher6e1z/s P5LMnN6c7kq44YejVpiXPXeWIPcOdVHKNgdN0zZHz5DOpEBhnFl0wfudVZ4OGkglHvipDv HjYBqmC8kubzKgjlqH6H2FjPAG6Seac= Received: by mail-pg1-f176.google.com with SMTP id 7so9535007pga.1 for ; Tue, 31 Jan 2023 00:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z0YOgb1qqY+eYSMvEeNHP+Hqfb8/SIN7dXd5+Q8wSDw=; b=ISQTBSXKp5vZheNDNbgJgxc8QhRpCjt4p/8zTq2lmx/K/QORLle9hCl0aRHYNmE7bA DAIbYEOe+wqRfihl5meXLKnT2L1jCw/qdo+UDM0JpmbttQdugF6PoRuPWMHTwR0+6iL3 +4qgQxUfNJnZx9exU/Ov6WHNn3Z24QFcPDGk30U8fvL8+buiDP8YMrw+vfBP4uSvUPjd 7NZVEJZUr0nc1qsQNpcpw7Q7O49tf1lLq9Sc+uPD2bQmZB1ZzVzAl1mdH7YSCil2WP5u +zkoZx0eflRnKw4IuL7RKYSrJ8Hb8G3OykIwmA75G7aBoc4rAMFMw4/gnvDuy5FMZgQV jvog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z0YOgb1qqY+eYSMvEeNHP+Hqfb8/SIN7dXd5+Q8wSDw=; b=SUPDO6LRRJHp2EVu/JeZms39iCIkDr85LFMCfWd/Fh5uDnp3M7LkwOthyFJFtrN642 vH9aCCr+T4HDxy9hM9u0gvaRY6Y7bCOQqZCiD7KqLLpzggfRssw2+Yuhcc2fFJd1+cni bi9cC999Xd3/hzYhP2uHbxlvAQTKZDAnFkra55d3P91HLnTrPc5+Rj97P6rlu4YDKe0M 05/Rot7Nst6NOQkNyIDYU0hJcnJt+bYbhEomuO2RCKdlkmjblpORonusbKHP3p7V1m9Y uTeE5LfrRZ+tyFb6eHSSaY1L2EHiwsJJL6tf2jEPJrlwdNf9etWRnAhMPdXQRIFJIjVZ GH2A== X-Gm-Message-State: AO0yUKU1x2xUCe+XOLnJ9OyjpoXrJi14JH51ruQqbDiaMei+kao2UW8g ZOWFhR5PfuAUWdTcvuC4bvw= X-Google-Smtp-Source: AK7set9V4v10dCKnXellHnRjZZLAYKhT7gKtrOZH79TXD4DPm7ZFZxn/mEmSjdBWDr+GYGEfwIHscQ== X-Received: by 2002:a62:cf43:0:b0:593:a3f1:7c04 with SMTP id b64-20020a62cf43000000b00593a3f17c04mr8372501pfg.8.1675154287816; Tue, 31 Jan 2023 00:38:07 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id t63-20020a628142000000b00585cb0efebbsm9089629pfd.175.2023.01.31.00.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 00:38:07 -0800 (PST) Date: Tue, 31 Jan 2023 17:38:02 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Andy Shevchenko Cc: Andrew Morton , Joe Perches , Petr Mladek , Steven Rostedt , Vlastimil Babka , Matthew WilCox , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable v4 1/3] mmflags.h: use less error prone method to define pageflag_names Message-ID: References: <20230130042514.2418-1-42.hyeyoo@gmail.com> <20230130042514.2418-2-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: k799fyz9igg3dkp3n99a3kkstosxjgum X-Rspam-User: X-Rspamd-Queue-Id: F32BF1C0008 X-Rspamd-Server: rspam06 X-HE-Tag: 1675154288-471839 X-HE-Meta: U2FsdGVkX1+vzJqJ5QY/6qCylN/suxCk4Rf6TnFZm23+WjIKnHPhHtfJjhzAdC4BmuDZUwABXwlZ/ebbD0mD88uWO1xJpbMeBKwFMcse5/yVQtx75C7SzaIwW39HeeDgLTPq+rqB0lYxwmbEfirfEI06LV+qfjdlq7dEoy00g1vlZ2wS02pZX9yAHB4bD8btA1KWDsG/+GZdv8JRveUi74aUILyKExuS9zc5mIH64JHv6Oc47hyw/rkUqeDKPJIOjvrLuo5yb7CDXqMUQxe+bHx00kwXEtAbYZFLDCi9st7z7tCvVoG/+fTPllyLG2cVPJycUkH/R3fcA8SHQE3SZOr/wClqhEL5F60Ngfa+Ej1W2GIwKFutopUU2Pv2xJR4unCJnTlTVc47k918oNty6fZy0RodFsbvVzgDYLtjJd/D1s5OEOOgvbJ3nW/WhVDNCTRDHHKb9glyut5vOKzkbVkv/blkJLkAB4Zwbicjg1id0H2VQbmLRxQhaJPtWMyTduSWhFvMeZNBnthResQrdX4NlZGDkuT+ehPi7Ft/zcJpPnzq+Ed7E/CFYo+/oaPBTrUuWkAAEG+79Tu4g9/XpsF/HqXUUd9wSxGt/lKy/TniVuja25D4lO5CPJI/sOffUaZA2z05YtYgQDx7MbWoPM4y4ahvatV3Y2FgBj03xFPg6gMfv257+FfckUXdYk0V8a1ZeHvQkb+85/i89LmviXYWp39y9YHq0o+ZCbHamyP6RmY3murjH/uwbnDWtwdB99nTvp5c4a/33fwfmk1TPQe4rxPj/cvw/wpm/hBz1MArhC/IcPyJzijANUcJXs4fr4wHzHyzgKoutq0ClsT8zCtWzFX92S+jLYWR0FTQcdR49TJOuXPwlgIWprwxaAkqzzADZvWwMbE0P8YsFkbhLvSnzXlsSu1I3g2SejYHVKMzxBxUexWzkeqVBtBSrX+bI3Kh7WTUSDQsPus7Wue sirfQyjF KdmCMeAqAdIj1SKGZhhoZWqztGPAXUwQiSaG5cd9Tmcs1ZvLsUxFrTyt8W9opXLlrwVfeCnpJTf7h2tvilSECCMGLkH+vOLp1y1GZLtWOiMwpV3pdD4CTCGp4FnrZbdFU6RdQNkjXftec9ndY5w/B8Pd/Vf9/XYAf4zlo5fVnogfVM3BXzEbM7EgiC3i0Q50SJqcbnxoPpyBdwnXdxb+ZUqLCF/WNcsKcBKekccXrUEWmRjPS/YFfjuR+WS5dHX4+r5r4S7Wen3WWZB1iewjKBCXdDmi6LBT188Glsmbt08oA11cT6ZdZl788qdCvggJo2IQ69i7YAJCygHiKwal7m3B6X6Cl0ZsIgD4E/79jeweeGsao2RTxuy9TfKy/WMtNBTpzznfeiU6zsldif5JzISqm8lkItf3wBjtHQBmmRtNvkbkGjMsdMJRTn8zhwjUQuUkFlRY9dpCHFjS8ZwlowOqSZLlvB9XAc2ksyS5o6DL3lXGeMIKctYgc4q5TTYp+fjafDOtOuW3DbOn2kGB2vfWny1EIOC4flYlXfLHC5aEKBm2cSA8Hxgr4VAYjwQGdaRI8S+CmbdwiRLfFPlWy8Kt3a6e1LnU71h9qukrx0A3HFuskux96GUVZtNXeq78Ii6DU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 02:35:52PM +0200, Andy Shevchenko wrote: > On Mon, Jan 30, 2023 at 01:25:12PM +0900, Hyeonggon Yoo wrote: > > As suggested by Andy Shevchenko, use helper macro to decrease chances > > of typo when defining pageflag_names. > > Suggested-by: ? :-) oh, yeah I only wrote in changelog forgot to add the tag. I think Andrew will kindly add that when picking this series up? > > Link: https://lore.kernel.org/lkml/Y6AycLbpjVzXM5I9@smile.fi.intel.com > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > LGTM, thank you! > Reviewed-by: Andy Shevchenko Thank you a lot! > -- > With Best Regards, > Andy Shevchenko Best Regards, Hyeonggon