From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C26C38142 for ; Tue, 31 Jan 2023 08:32:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 889026B0075; Tue, 31 Jan 2023 03:32:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83A276B0078; Tue, 31 Jan 2023 03:32:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 700CA6B007B; Tue, 31 Jan 2023 03:32:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6255C6B0075 for ; Tue, 31 Jan 2023 03:32:42 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3402014084E for ; Tue, 31 Jan 2023 08:32:42 +0000 (UTC) X-FDA: 80414428164.18.8D23989 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf29.hostedemail.com (Postfix) with ESMTP id 6166A120015 for ; Tue, 31 Jan 2023 08:32:39 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gDvhUFvT; spf=pass (imf29.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675153959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eY6WhpauLgjdc2GeVm59ZJcPRy3bOJRPWYy2o9UJOTs=; b=rzesIe2hnKIc2GUBbFRCTAi8lCWvfgP6tcjkKQof6CbrtZ53E7/el1zzaFSuaS11fqfQj8 Ry8yDDJW2OE6hXny6oa5hjxXwkM/cwoxL07C6fGgwxPgHQYoVn/dMxhYqjONQ9DbHY5WE3 f+REj2W0ZfQUlTNynd0e378MUbQhUn4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gDvhUFvT; spf=pass (imf29.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675153959; a=rsa-sha256; cv=none; b=XcviYkwK8eUFtI38GE8ayYNuhOsUCNufojwfwJ6lW6pTFjgQNkTMCrLiOFEI2QgiEq0cxe lt/fwnbTug1aF9cGS/nESF9Pnexol8JUwpVHUuRDrOrVzZ38BT897PnuMDmdlfCjLWWyOI QRWNKnGFW5l6Pc6YwhLu/zBx8oJPKxY= Received: by mail-pj1-f41.google.com with SMTP id l4-20020a17090a850400b0023013402671so1586950pjn.5 for ; Tue, 31 Jan 2023 00:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eY6WhpauLgjdc2GeVm59ZJcPRy3bOJRPWYy2o9UJOTs=; b=gDvhUFvTLFqud44CwwqInyihTUiI65hFA8JOcKHcLn9UVqtcsQv19U+MBWki2RO8Nt R30z1HOkLFcxYsOMFQbXwd2hBjB2KuglBwPPycXfU/f92RNvUcFSUvLneYWpJhgVlptd 9njIBtJQXP2icVAY3wmYUOkQ9wz87mvD6pLmxrieRF/AI0OYoEKEs1O1QDURTHPnhyq8 lsKAxU9oHb1JDqhd40zwBUJUv32A8vGZT0y+Kphrx9F/z5gIROXjFQvJXm04C18g6T2n NBcRV1o/3AH+VpRCuHPjgf1QVhy75RLJqTbWXYiQ6JtG8jNvCfOaU7SrLZhzsMyn9ZYy 9jbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eY6WhpauLgjdc2GeVm59ZJcPRy3bOJRPWYy2o9UJOTs=; b=vj4ZlIxODmN+uPDIOANK7so0iYOyHzPLdeaYvprCKWPQKERLyPtuDB5xMm1g5qAzax 3BAOLronOq7ZMKy1qt4m53FmItgWu9SuhPnS15UbcC0jhTOS97vFgdxB3+9+NfJjAPaM DCox9RC3FxLjSxKusbjd8kM4WtQrkQii9EdhaDjKfudtgWChGaKYQ5pE4bFzyqxudu9Y DyIAzwkoa72q/ybPnM2/0twHuw8jAaMpdjcZ9hkEB5ixqPiW1zuaTaq/oN4IOOxaLzBB RLyKcBSjB2u0oxzyYehroHxBCGOP5ne6Wvp8JWcYUacceO0TrRwqYMBbnThX2r/SPn2B vacw== X-Gm-Message-State: AFqh2kqKxIYJRr4a8UxgavGSbxSF757IuoExlHEqsLythzI6PQdi1Q5F RQi4tGFBwu+RpRkkuGa/nQI= X-Google-Smtp-Source: AMrXdXta+Z0I0LRtkA5JAdf/Ab5Zq2D11VCaAAiVvOoRHiaRxBEEPXz5DuLtncQGQLEyCHpSuMVj9g== X-Received: by 2002:a17:90a:1a5c:b0:22b:b76b:5043 with SMTP id 28-20020a17090a1a5c00b0022bb76b5043mr40692416pjl.9.1675153958109; Tue, 31 Jan 2023 00:32:38 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id mv12-20020a17090b198c00b0021952b5e9bcsm10482650pjb.53.2023.01.31.00.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 00:32:37 -0800 (PST) Date: Tue, 31 Jan 2023 17:32:20 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Sebastian Reichel Subject: Re: [PATCH v4 4/7] mm: replace vma->vm_flags direct modifications with modifier calls Message-ID: References: <20230126193752.297968-1-surenb@google.com> <20230126193752.297968-5-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126193752.297968-5-surenb@google.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6166A120015 X-Rspam-User: X-Stat-Signature: xmkrp61k7pr5c8f7438w6t77jzfqepoq X-HE-Tag: 1675153959-412042 X-HE-Meta: U2FsdGVkX18cDMd5qmjK+AbfCW95SlqpiK0xrDZHc2DQm9EqKg7U/vNBrOV+WVxdcMmiZQlz6NsVcSCEYlYtcnSrfBPY6k7Zw6kNBTnoT+aA9oW9+OCmReCC9rUIoqX+0EsTStV9wIqzExerYRBj+SciOkBSlspDPckbXRv4N5o1MGWzihVSU/FEN5rIm/lJGXtVnfrFWywQnMWF5aHxZalQ6EN+4UMx/IT5hyJLPWD1FgjTcPkOrKZjvzICgFvijKNYYEBryFqxP9jQ0T3onI5dGFXBf3r7OQsVupvwGBZ2ipewpeAW68iRUeQVfdrEaqUW0eZcUPgFaj0HUgVBoWnTyKeJc6sP7igqGImwLBUec8BnNfiTyEzmDzupk74jXelLBQgEkScARV6+mjY9MV8KL8JM8VPjnCmlWykwpje7iwZR1hHMAnWUMdriJRt8NPFiWvj0iwoovwFfeOan3BTFZlgvkBi7HusEt4JuU4yqGOoOUoEKv+u0oI2cuMNMrjFuORii6gU5UGbyV0VmrWr8GeN/Dg2fnHMc50AtjZekj18ES5PczVxmWIiDo0V5DyCjlb0bpi8ckm0RtpAU7n5JodDFDvLUOzn/h2ZQri1uUNyrXhcrdfZW1uFyviBy7U+5EzSlc25hnc1kGVS3OZ7OZ1S0z1JpY6VVjBGNTiJIBAfFRbD/I/i6CvXcyPXsiueuA86lSz1GgcjYZYS1PEe94MV/jas7/wF3NWa9ehMOvOOSr+fMNnDNeM43YgkG9KjgfXzgF7pCM9TPUT9xNWNcE5CXpQ0n2dvbeMM8wwE0LqDJ/SqtQWhGUFZyUgbhhbDinnXjxD3R2NulJM3VzTBxcoUIHKDX5GNE+j1QQlnEsS+9WR0zKhyyE9ytz0/i0/4e6c6KXTo52sgD6jsMyEmdYH2f07014zrC/N7HZxExRlekUByhQmnFNBqbfoSGNiGZgnN7Vo8oIsBDHiU //+PxP0X DEYwPLqDBnFZrzh9wNcMTiXK0LgEmNH7n+ZrLtpcWUsj2InIukBY6gB8APwSPFGxnRMcidwjcTm3c38jF6KQyzO8iS4lKIpIq4S0J2F6n5nYf/5+0EirgZBgQrOaLQaHTVuVp9sAW8wx1IXlNq79OL0Ma+fatervZs6AM+u2ei1HAaK8dK7ldoiXfsjTZkHl9OjgRhLfkJ5KVshRNVgLMaNeO2wG8vORHJa9vwubSpPvZxxHWpXnMacg5iKu725y6OrOLHLvZY5/c1VCqKxRExaBLzHIxDebpAC/pVD4XE2OConzdNtQth1eTdarkF0T/OSs5nCpEWziqV8mFKH3Vd+AwxwOpySGDp0/fBe4a/fnlI4Oj/YBWR0FCzj/Xnns8SH+CEeoAzfrfsBCSf3oxspfNgc2cZA6Du3ftHTYtfL/razICh8tc0qUc9ARF9bjCsIx9Glf7q2cy0Y1IN8ud6Ftsz0dTi4wQSEdEwMg39Sz0UXlE64qAATeyEsGFAl43m/Ev8L0RXoVsR/berLu2DptRi+jIh1pLIN9abhYxO3JtI+2csxeyBZaghoi1F+kcwnuqXt6kZWSBdNmCX5dWiYaaRiW7wC3KVPAmpJP/RfwGNJAC6Qm4pzD1h3GHn+KCb5WzZAlg41+AoY8NrAk/abfl0hrQdDdbvWUboqVJdL1ZAx0eAgx3wcbuK6Lkx8N0tTY9Ty4YQE7jq3D68ZPUUy0MASwEdBR4nxGYUpLLkSOnXcT+a9JhH2rHzzvQNpQtAZXxpuYxg2lGURb6qTAW39bvOPZeoKUQjiwu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 26, 2023 at 11:37:49AM -0800, Suren Baghdasaryan wrote: > Replace direct modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. > > Signed-off-by: Suren Baghdasaryan > Acked-by: Michal Hocko > Acked-by: Mel Gorman > Acked-by: Mike Rapoport (IBM) > Acked-by: Sebastian Reichel > --- > arch/arm/kernel/process.c | 2 +- > arch/ia64/mm/init.c | 8 ++++---- > arch/loongarch/include/asm/tlb.h | 2 +- > arch/powerpc/kvm/book3s_xive_native.c | 2 +- > arch/powerpc/mm/book3s64/subpage_prot.c | 2 +- > arch/powerpc/platforms/book3s/vas-api.c | 2 +- > arch/powerpc/platforms/cell/spufs/file.c | 14 +++++++------- > arch/s390/mm/gmap.c | 3 +-- > arch/x86/entry/vsyscall/vsyscall_64.c | 2 +- > arch/x86/kernel/cpu/sgx/driver.c | 2 +- > arch/x86/kernel/cpu/sgx/virt.c | 2 +- > arch/x86/mm/pat/memtype.c | 6 +++--- > arch/x86/um/mem_32.c | 2 +- > drivers/acpi/pfr_telemetry.c | 2 +- > drivers/android/binder.c | 3 +-- > drivers/char/mspec.c | 2 +- > drivers/crypto/hisilicon/qm.c | 2 +- > drivers/dax/device.c | 2 +- > drivers/dma/idxd/cdev.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 4 ++-- > drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 4 ++-- > drivers/gpu/drm/amd/amdkfd/kfd_events.c | 4 ++-- > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 ++-- > drivers/gpu/drm/drm_gem.c | 2 +- > drivers/gpu/drm/drm_gem_dma_helper.c | 3 +-- > drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- > drivers/gpu/drm/drm_vm.c | 8 ++++---- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++-- > drivers/gpu/drm/gma500/framebuffer.c | 2 +- > drivers/gpu/drm/i810/i810_dma.c | 2 +- > drivers/gpu/drm/i915/gem/i915_gem_mman.c | 4 ++-- > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- > drivers/gpu/drm/msm/msm_gem.c | 2 +- > drivers/gpu/drm/omapdrm/omap_gem.c | 3 +-- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 3 +-- > drivers/gpu/drm/tegra/gem.c | 5 ++--- > drivers/gpu/drm/ttm/ttm_bo_vm.c | 3 +-- > drivers/gpu/drm/virtio/virtgpu_vram.c | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c | 2 +- > drivers/gpu/drm/xen/xen_drm_front_gem.c | 3 +-- > drivers/hsi/clients/cmt_speech.c | 2 +- > drivers/hwtracing/intel_th/msu.c | 2 +- > drivers/hwtracing/stm/core.c | 2 +- > drivers/infiniband/hw/hfi1/file_ops.c | 4 ++-- > drivers/infiniband/hw/mlx5/main.c | 4 ++-- > drivers/infiniband/hw/qib/qib_file_ops.c | 13 ++++++------- > drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c | 2 +- > .../media/common/videobuf2/videobuf2-dma-contig.c | 2 +- > drivers/media/common/videobuf2/videobuf2-vmalloc.c | 2 +- > drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +- > drivers/media/v4l2-core/videobuf-dma-sg.c | 4 ++-- > drivers/media/v4l2-core/videobuf-vmalloc.c | 2 +- > drivers/misc/cxl/context.c | 2 +- > drivers/misc/habanalabs/common/memory.c | 2 +- > drivers/misc/habanalabs/gaudi/gaudi.c | 4 ++-- > drivers/misc/habanalabs/gaudi2/gaudi2.c | 8 ++++---- > drivers/misc/habanalabs/goya/goya.c | 4 ++-- > drivers/misc/ocxl/context.c | 4 ++-- > drivers/misc/ocxl/sysfs.c | 2 +- > drivers/misc/open-dice.c | 4 ++-- > drivers/misc/sgi-gru/grufile.c | 4 ++-- > drivers/misc/uacce/uacce.c | 2 +- > drivers/sbus/char/oradax.c | 2 +- > drivers/scsi/cxlflash/ocxl_hw.c | 2 +- > drivers/scsi/sg.c | 2 +- > drivers/staging/media/atomisp/pci/hmm/hmm_bo.c | 2 +- > drivers/staging/media/deprecated/meye/meye.c | 4 ++-- > .../media/deprecated/stkwebcam/stk-webcam.c | 2 +- > drivers/target/target_core_user.c | 2 +- > drivers/uio/uio.c | 2 +- > drivers/usb/core/devio.c | 3 +-- > drivers/usb/mon/mon_bin.c | 3 +-- > drivers/vdpa/vdpa_user/iova_domain.c | 2 +- > drivers/vfio/pci/vfio_pci_core.c | 2 +- > drivers/vhost/vdpa.c | 2 +- > drivers/video/fbdev/68328fb.c | 2 +- > drivers/video/fbdev/core/fb_defio.c | 4 ++-- > drivers/xen/gntalloc.c | 2 +- > drivers/xen/gntdev.c | 4 ++-- > drivers/xen/privcmd-buf.c | 2 +- > drivers/xen/privcmd.c | 4 ++-- > fs/aio.c | 2 +- > fs/cramfs/inode.c | 2 +- > fs/erofs/data.c | 2 +- > fs/exec.c | 4 ++-- > fs/ext4/file.c | 2 +- > fs/fuse/dax.c | 2 +- > fs/hugetlbfs/inode.c | 4 ++-- > fs/orangefs/file.c | 3 +-- > fs/proc/task_mmu.c | 2 +- > fs/proc/vmcore.c | 3 +-- > fs/userfaultfd.c | 2 +- > fs/xfs/xfs_file.c | 2 +- > include/linux/mm.h | 2 +- > kernel/bpf/ringbuf.c | 4 ++-- > kernel/bpf/syscall.c | 4 ++-- > kernel/events/core.c | 2 +- > kernel/kcov.c | 2 +- > kernel/relay.c | 2 +- > mm/madvise.c | 2 +- > mm/memory.c | 6 +++--- > mm/mlock.c | 6 +++--- > mm/mmap.c | 10 +++++----- > mm/mprotect.c | 2 +- > mm/mremap.c | 6 +++--- > mm/nommu.c | 11 ++++++----- > mm/secretmem.c | 2 +- > mm/shmem.c | 2 +- > mm/vmalloc.c | 2 +- > net/ipv4/tcp.c | 4 ++-- > security/selinux/selinuxfs.c | 6 +++--- > sound/core/oss/pcm_oss.c | 2 +- > sound/core/pcm_native.c | 9 +++++---- > sound/soc/pxa/mmp-sspa.c | 2 +- > sound/usb/usx2y/us122l.c | 4 ++-- > sound/usb/usx2y/usX2Yhwdep.c | 2 +- > sound/usb/usx2y/usx2yhwdeppcm.c | 2 +- > 120 files changed, 188 insertions(+), 199 deletions(-) > Hello Suren, [...] Whoa, it's so long. Mostly looks fine but two things I'm not sure about: > diff --git a/drivers/misc/open-dice.c b/drivers/misc/open-dice.c > index 9dda47b3fd70..7be4e6c9f120 100644 > --- a/drivers/misc/open-dice.c > +++ b/drivers/misc/open-dice.c > @@ -95,12 +95,12 @@ static int open_dice_mmap(struct file *filp, struct vm_area_struct *vma) > if (vma->vm_flags & VM_WRITE) > return -EPERM; > /* Ensure userspace cannot acquire VM_WRITE later. */ > - vma->vm_flags &= ~VM_MAYWRITE; > + vm_flags_clear(vma, VM_MAYSHARE); > } I think it should be: s/VM_MAYSHARE/VM_MAYWRITE/ > diff --git a/mm/mlock.c b/mm/mlock.c > index 5c4fff93cd6b..ed49459e343e 100644 > --- a/mm/mlock.c > +++ b/mm/mlock.c > @@ -380,7 +380,7 @@ static void mlock_vma_pages_range(struct vm_area_struct *vma, > */ > if (newflags & VM_LOCKED) > newflags |= VM_IO; > - WRITE_ONCE(vma->vm_flags, newflags); > + vm_flags_reset(vma, newflags); > > lru_add_drain(); > walk_page_range(vma->vm_mm, start, end, &mlock_walk_ops, NULL); > @@ -388,7 +388,7 @@ static void mlock_vma_pages_range(struct vm_area_struct *vma, > > if (newflags & VM_IO) { > newflags &= ~VM_IO; > - WRITE_ONCE(vma->vm_flags, newflags); > + vm_flags_reset(vma, newflags); > } > } wondering the if the comment above is still true? /* * There is a slight chance that concurrent page migration, * or page reclaim finding a page of this now-VM_LOCKED vma, * will call mlock_vma_folio() and raise page's mlock_count: * double counting, leaving the page unevictable indefinitely. * Communicate this danger to mlock_vma_folio() with VM_IO, * which is a VM_SPECIAL flag not allowed on VM_LOCKED vmas. * mmap_lock is held in write mode here, so this weird * combination should not be visible to other mmap_lock users; * but WRITE_ONCE so rmap walkers must see VM_IO if VM_LOCKED. */ does ACCESS_PRIVATE() still guarentee that compiler cannot mysteriously optimize writes like WRITE_ONCE()?