From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A9A1C636CD for ; Tue, 31 Jan 2023 05:29:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA3BC6B0072; Tue, 31 Jan 2023 00:29:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D54106B0073; Tue, 31 Jan 2023 00:29:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1B1F6B0074; Tue, 31 Jan 2023 00:29:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B43916B0072 for ; Tue, 31 Jan 2023 00:29:39 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 78F061C61E5 for ; Tue, 31 Jan 2023 05:29:39 +0000 (UTC) X-FDA: 80413966878.05.99D648D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 65618C0010 for ; Tue, 31 Jan 2023 05:29:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JvR8Ququ; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675142977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CQYz9YB3giOSRpIimXEFMxgqmfkfwruFek5pOzrb5IQ=; b=eEciuVmh7wouVGBVY+j8Qayfq84ud/Vy8zHyUFAzXf36srqf4v1u4fl+WKwsm1HkiTwmU8 i6ZDuILgmIkyHFrXrhH7RYfimzelREB2mqMG0+tkaKLDD7nJ6y3fY07tA0F8VsJgjhS7Ns 5eZa9LfGkSXj9cossDTdg9UtTWZ0EKg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JvR8Ququ; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675142977; a=rsa-sha256; cv=none; b=FgWrsDxipsItGOdAioeud2C0J/rw3rVL71wiWtlUWmYM4x7hVUXZzxranEk/MAWhj+WeET W67WCleiZ44XK38hpjyu3Xl0IDe/yOTXeD0a5Ah0kCzcAcVt94l6GRRFpUX1pqhh5K41fT 2d6xptwggb9FVWOfSUuhaScpfwGy4lQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CQYz9YB3giOSRpIimXEFMxgqmfkfwruFek5pOzrb5IQ=; b=JvR8QuquuMwb2FdJFO6IqAmkUN tBrsFCSIXyqkvHRM7fZ5u2Yg3NPMsUB4PxUX/qu0v0Y/y56IW2JyHo3ZH+sQn74OeI+wQgRHwm469 ekItn7tysg17ZoXo4wlDrE+odoN2wcg/QN0iGuhxZacjagKnw/aMq2JYFfGPuFT057WF6LsNJV+MO pG5SmCKtbNcmU931OJT8zqoMhqX/QZsBHuLW2VtKp9GTurrJUSgXCqAjzkF+H+0oZnKPQSIf5WWDS sHj5zkmFAK0ZxjLLSQoGz0ejpEslLySYtQeDdfyez4NU/l444zvg47QBe/HZXhOo5g6wjc5+Ht4Gj 7x1ystVw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMjBr-00B2qK-A1; Tue, 31 Jan 2023 05:28:19 +0000 Date: Tue, 31 Jan 2023 05:28:19 +0000 From: Matthew Wilcox To: Jakub Kicinski Cc: Christoph Hellwig , Jens Axboe , Ilya Dryomov , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper Message-ID: References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-2-hch@lst.de> <20230130204758.38f4c6b9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 65618C0010 X-Stat-Signature: hih6h4x6e19rdju85xpsid3wd1pr8trx X-Rspam-User: X-HE-Tag: 1675142977-94636 X-HE-Meta: U2FsdGVkX18WBeJ3TIQG74dLQqYwZ545vsePDE3IkOykXPkFQvpN2ZDPg6nZ3XueMJJNQlE/ZGLro46rIaVcLDR1kw6QPQ12VYzSbjrxf6lxf2NcSpS0NXcTo6EPdyCZb2ghFimyS8S+Vjd9o35bTQL9wKYC4pUu6f4XzOURHpWwtKkcBYgBpqRESrhPY5zK7/Sxe79RHkJ5qbLZKy5PvTU2FLzi3czK2+J3uJht6o67ojNVc7yEk5zUdn9LL2diYygEYvvjQGNfnzc/3dXBClHa5Ap2P4ZWqm0Us6qCoozH+QWrZn7XONZDyBiMUyhytaUuA2NDvqDVb77Z9IuQKsW6o/Kq5phRaQl5fDOKmL/8byEqh9itdIjQfiEsZGHvBNASrxCOrxieX/Z6FPvMRwnXWtHs637a71G9JnBqRfbhryQ+Ai5LzicianpVlHcrwLs7c132IokxUQutm1LEmdt6hgfUiFl/WT1zrQybc2vhD2YhqkfCtKI2qsn1gs+suMC44UGYbQH1MpDgkZDqFTDOMT54LBkt9Ngokx2vh/4rOWAWjabAO7Kp7HBrcuM7YUPQLI20obxGHSTaCWa6iyK7tTrV20EKRi3zUew6WKmPp5iQyNK3CXXDzUhumMIo+DkSj5kDcO7etagAp/LWyP3AVkB2yTigyP1sLQn3IRJ7jTANY7pfAu1jqXUylnQ1m5UmAgKY2B7ZyspJlTSsrLCsSQUDtQtDlZyvko2ILGmac9VOo3WjZrZ/v1sm9UE+dgMJUcw4o/AtBO4U2TRp4d/5Rwt0Nutb7dd8yBrmwenpmQOjzKp+nsbrofw+HXBV1aX75Yj8DH6e/wjPcDQ98h/BpppQ9ArwdIJUE5ywplSwfZS4J7zA33QrRAB9wrfN9VYw5ZxFoxi37VG4+zRgQS6yzWiMdpKfvVqCX99gu1M6aMo27qm1bh85x4cBDhwBFYe+si6VQ64dTLMt6FP DpmpGgfG Fy+14eM+ytWEdEeamooNesmDYT3xAYHpW2r4p7smEYOqdEjk1LScm2k3hQJtAR7Vp6MtGT3F1NnrNovRJlL05PL/mZ5Om7pS2f0yNdRvO3hHkMs+0XcBZomtZA/Cjns1tZRmiraGJr9x8Ow8/UIp7GdJjCs6WVdlWQSZAMfCwBwEcJbeRICj1iu5XrPTAtGyDO+cdu7zcimrG0BI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 05:00:32AM +0000, Matthew Wilcox wrote: > On Mon, Jan 30, 2023 at 08:47:58PM -0800, Jakub Kicinski wrote: > > kinda random thought but since we're touching this area - could we > > perhaps move the definition of struct bio_vec and trivial helpers > > like this into a new header? bvec.h pulls in mm.h which is a right > > behemoth :S > > I bet we can drop mm.h now. It was originally added for nth_page() > in 3d75ca0adef4 but those were all removed by b8753433fc61. > > A quick smoke test on my default testing config doesn't find any > problems. Let me send a patch and see if the build bots complain. Disappointingly, it doesn't really change anything. 1134 files depend on mm.h both before and after [1]. Looks like it's due to arch/x86/include/asm/cacheflush.h pulling in linux/mm.h, judging by the contents of .build_test_kernel-x86_64/net/ipv6/.inet6_hashtables.o.cmd. But *lots* of header files pull in mm.h, including scatterlist.h, vt_kern.h, net.h, nfs_fs.h, sunrpc/svc.h and security.h. I suppose it may cut down on include loops to drop it here, so I'm still in favour of the patch I posted, but this illustrates how deeply entangled our headers still are. [1] find .build_test_kernel-x86_64/ -name '.*.cmd' |xargs grep 'include/linux/mm.h' |wc -l