From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC40C636D3 for ; Tue, 31 Jan 2023 05:02:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D6656B0074; Tue, 31 Jan 2023 00:02:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 886AC6B0075; Tue, 31 Jan 2023 00:02:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74DEE6B0078; Tue, 31 Jan 2023 00:02:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6650A6B0074 for ; Tue, 31 Jan 2023 00:02:03 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 36A48140414 for ; Tue, 31 Jan 2023 05:02:03 +0000 (UTC) X-FDA: 80413897326.02.B1C6D9B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 13164C0011 for ; Tue, 31 Jan 2023 05:02:00 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Q5zfNh/E"; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675141321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HeiethKseVGJ70/5PjRlX5YDB3+nnc26Ua2pXcSZvpo=; b=BGW8bvqdV5R9VHWvz8Tp8XVmFPFx6/kX45XbCVdjDYhAf0MPvlnSpuXbLdmnRZFANw8Zi5 P3vp79Glm8EHAv5W/oBJGH0Hqnq+feB+K2w4fYHtkaU/0UjZqvcWnh1G2jzDFDnTdguvk1 tNJoHMxoJRHcNWKsomBLlvtWVzqD2lg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Q5zfNh/E"; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675141321; a=rsa-sha256; cv=none; b=qEcE+E6bhBQrFpY+B8MrNfsKD2I7de6GgWOkuXUz0mlN413sLm2HowSEVFAd+NZHAI3utH 9+lSWsprxs8VkRcA2WURzINlPANkpcMC8ZLOHeyrUG3RIxqlHx0JPNXnKY64RQv926CdjV gXrmwEBLQ+Yf8hx8S4TJD5rqDIrr0Xs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HeiethKseVGJ70/5PjRlX5YDB3+nnc26Ua2pXcSZvpo=; b=Q5zfNh/EB2Bmq7oWjxZpT6+msk Wru/DAC5G3Ah5BIaBZRlzZAeO/DNnzrkJTotw+xknA145DoaVDP0PapXQz9haLCp6JFInHd1m/Gq0 Ugh3dsiSMTuuFZDfTCVfD5u3uqBFHZNFvaNOEf6GBWhQrOrUuRM/LfCeHe1ih3TKWB/32GnPqOt0M +KS/+gertHCfno38+Xr4AT42h2GV1/Lh8Psc34Ane6VpgoKN86DPzQO3EbFQEM4/mJ4G+4ucfZfY3 NPYL3uNiTdgqjKCEqIT2kmWqSZZmNNoBtb5mihNp+8SSg7Q7Ae2AfDTQFg5YePXBH3WHd0Kojkyq6 mP4yNoNg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMiky-00B1Pp-3D; Tue, 31 Jan 2023 05:00:32 +0000 Date: Tue, 31 Jan 2023 05:00:32 +0000 From: Matthew Wilcox To: Jakub Kicinski Cc: Christoph Hellwig , Jens Axboe , Ilya Dryomov , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper Message-ID: References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-2-hch@lst.de> <20230130204758.38f4c6b9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230130204758.38f4c6b9@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: bnhhmz4sxe1eihw3xd8z33ntaq4akw9m X-Rspamd-Queue-Id: 13164C0011 X-HE-Tag: 1675141320-46510 X-HE-Meta: U2FsdGVkX19OLYvkvmJxFoyhgEODiuxuuly0OwSrLrmg/9eMqoenxwxtCwEE3QETO76oC8ekH/qlIT0VcSWOLKOHirYqvWhMrbrjIuLjWTp3Ci9VQhlX8CWlCJMuH1VoVc6Uphi+AI0asZurWGX7w+wXevV7QB9lIMeezhMg6Qp2vaXvllTFcjBlbsL+dHdx+9JYtme1DtMjsvQryqL9qNZbPl83t72rmOwJJbC/LpeWip1EsdZJC27OuF8lZ94antHXFD4zNCrzcyOan+oXakUXePu4WJua4PiZe/3H5k0YT/Udfrkqz5oZ3lMbXlj16WjBgKBQQyPMxios+pX7Vfj63/Cmo1dRXwrTxCddYy768pCrVr54ZjR5jvPRkAzCuGvckfGUUJcGCbkwo3fI3jCzqAfRTw55LHAjAzlxPzAU2KNtZk/f5gJcH609M7XlWnUNdB5zlo+PuPrhG4XDL9XojvF7qwCIUWL1sU5gJGZXQBfi9bHMgHefxOyY1fJxw4eaISpOTT80ZhQfK1+CNyKNHmHkINBL5XChZVjn5iYtAUKv2UWKoTOhflKBPCOVKU2yPD0NslsEyMMYw8W8Bo7g/hBW5XT6cHqugzxxNIu6s3MTc+sKN7TDhiSXlwCoOvWniIItHoNPzSWSwb0QxYDVEk2KvjF+ubz5eOLKxJvSnH4U4eStZ1m280kzEfddhjsNa/4gyH+OGtQ6FSMaGjUbVEhcwAcucF51rhh/00GC7SbfOhQ2Ly/kaNobpuAsbtCERBXfJKYbQoWu9BcyVJGd1ZAvByvDGw24IBL9yplZWxGfEbzlzTURcQvicUl9/9QCHFWX/FhrOqLDuweZkDPcV8/WmDLTP+LWfIVskKZ7tIdQkvdowwZOGkITrnHseG9HCUMpxGsrh0n86Irt3Qrdk9u+YhMTKqIkWUMqeFCsmmnm85mVHdiGGQIoO+O1zBekX8d4HK9vPs/ouR6 ZJhDPU6M 5bBMSjx7x/TQWrqkkG1/E1rGkVos0u6aVnw8gP6HHP4dqPSeXIioV08LWoMpm6WnEdYfK4P1ZbK/Fnz8wqpCD0Kz3hFnZSdYPBcLVQXDOX9FpnkQNz9xHW/V1EZxh6geFvIGjjlFXXNdQrEJ1T5WBucF7TYCEsf81ops4DrOcAClTNYCXZzjMZmupL0bkNM+ZHV3VoRHCT4reLLY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 08:47:58PM -0800, Jakub Kicinski wrote: > kinda random thought but since we're touching this area - could we > perhaps move the definition of struct bio_vec and trivial helpers > like this into a new header? bvec.h pulls in mm.h which is a right > behemoth :S I bet we can drop mm.h now. It was originally added for nth_page() in 3d75ca0adef4 but those were all removed by b8753433fc61. A quick smoke test on my default testing config doesn't find any problems. Let me send a patch and see if the build bots complain.