From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED5DBC54EED for ; Mon, 30 Jan 2023 14:14:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30EFA6B0072; Mon, 30 Jan 2023 09:14:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 298B66B0073; Mon, 30 Jan 2023 09:14:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 139606B0074; Mon, 30 Jan 2023 09:14:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0532E6B0072 for ; Mon, 30 Jan 2023 09:14:39 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E27C1C3D92 for ; Mon, 30 Jan 2023 14:14:38 +0000 (UTC) X-FDA: 80411661036.03.FCDA18B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 942B640019 for ; Mon, 30 Jan 2023 14:14:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="E9/jA4GQ"; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675088077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RnLDgyEZD/ocVf8P49nEv/yNWY1h9uTcFgWOo5yH67o=; b=a5ZvUx05D8tX6Pc09Y4W34I0ZrI5Pzoqp5DfF0EmeMiVC1YTA3er30/dd6LXFPlYFSnuI7 Tnlt/M+gSc7qmSu2GPXlL4Jp6S+MRYw4C0xxgUBl6pCRyNZ8Inmh/qZ8TZyJ/gAKum2KUX E8n/wIgeSz+YPHnoymsgxY1FBY31tcA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="E9/jA4GQ"; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675088077; a=rsa-sha256; cv=none; b=MQkthsWykRIiJ8aLhJzvOxUhie4crwQaaGnP+oYpxVSKp2V+kbtuoafzKNmVfhOAykIMXh vSLhrhIkfG5IWXnvjoKYAfFQvQnWs9YBTXmR2N32n2Y/E2HpGdZDg4eAtjR8N/FccntGMM PCmLAX6h2rYEGI1g+opYlhR7Q30YrFc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RnLDgyEZD/ocVf8P49nEv/yNWY1h9uTcFgWOo5yH67o=; b=E9/jA4GQSLs2UT5kFP4ghPywsR QLV7ArRHQ845oADMPOPQqkhm3cM+jBWcXbnDNaX2AukIwqVth/Z0CPvFZJYRWzEvNLy3yVMU/C3Ww d2AGaStvMLm/0s1GTq4rEzaxDp9V1Pa9k8BbWMq4i+WTs5kcKnRNkwInj9aX94jNiyIfROwgSEqsg XgfEtc8k4mnDChS+VNKv8KXGYeyLwF2ZRxbidQ/Zd+wE1jo/2Qr6Er3SBl6cBJtpd7bHvfUaPoWJi 3yNqchpBOC3X001i0rkFc5UN9roA0yJK/6BEQN0EuytQ+rOsM0m6CdGfBX7j4V3arlvb9uIbSkXr/ 7WVV5CMw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMUvW-00APf9-Db; Mon, 30 Jan 2023 14:14:30 +0000 Date: Mon, 30 Jan 2023 14:14:30 +0000 From: Matthew Wilcox To: Yin Fengwei Cc: david@redhat.com, linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com Subject: Re: [RFC PATCH 5/5] filemap: batched update mm counter,rmap when map file folio Message-ID: References: <20230130125504.2509710-1-fengwei.yin@intel.com> <20230130125504.2509710-6-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230130125504.2509710-6-fengwei.yin@intel.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 942B640019 X-Stat-Signature: d3uh35wbhipro1qtxjddrc1qo8xeyo43 X-Rspam-User: X-HE-Tag: 1675088076-250261 X-HE-Meta: U2FsdGVkX1/ZPHSN0hGUgq/0eDJ/6EWWybu2Zh/dwersS0MIwe8OhbwY/dwyHAGiJ8VekRNgDj5HYsIci9QVPKMMpvuaPADnrlKEFVeQUCOLT5BtzDQ3tpOpKI6YQOKY+nU3H2Ij7FRKuEEhAS1/P19fJP8VJESOlT2pJO3hXOmsfq17sTDQEtJszo+P0N2OewOVIdt9o70jp1VChduBy4FPuJhDrj9meX21lam5fnPj4g6XgucSRMQSkw98+OQlW2WxRxenA+9BTRHQVaIPqguBTPisv+rWF4pDKaPOq8pVMX9Qr6Jic06ZoJ8iLPO9lDofegig1ZjLSyBr7FxWdt9roWC0eljlyec9X3wFmmbHpcTbTyqh+wGTqLHzkDsqlUW+DWoDfbEKEKuZTc/hrCq2GjsluiDCrvU6J4NaH5e6c8dw8PkPwlZHdaE8Z627LRefNummX/Ob4DqIC8RRCm+TD1ir+Al4EePs94FzBccMOLGaRotsZKHQAXeohUmr+u47d4GnXiIDKArXeW4evbIaot9SwAYsEdNF/r9SjZT3RROGrIFTDZp5Yo1YNyGdJRTEi0cwJdZVq9h7LDXuOabt4xKhWDvylghaIUmitiXyPCwcleo49ByV5ZFlS4sStSFOmfOB7/XAtlj22KfXuqR/xSiwkxAYaX+KOqKPg/Em3RrQLYWnk3dj/ofNPMs45aGCGuefEP0zRzvA5h3/kSeIiXUTGlsaGZ20OJMsmUKQa63IjzhsvYpKe/iabXGU1jVKJijGm+nDnumHgO0Gz1mWyZfETsG8QIV7mieJj9Jiprr43xp5iiVqNyms7NHWVR77flVv1leQtEo/8Knjh9S/uR4jWfLPeoEktRMFQZvHRQFGfXrrrGzeaTvJI8IztE/Mq8UujslIMHyCRixAGxdI2W3UDodDQRm3BvaX79P5R7G9frMWznf0XLVclEIFXc82a0iVSm+7zqpuSU/ upH3bopO WARj5X4i1/Ex/zOy7X9z/QEOVZjdJ1P3+dMdtEfqsnGnJBWMwdON04J6Wed9UZQv3wAQ8w6sO7ZJVXQiF0uGdSqDgM5sAZtFcHuqLiML9K2hChhTaP4rTaeCrMEP44ZaTY5lKiu2W+3RMuUFpJveCrPRJ9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 08:55:04PM +0800, Yin Fengwei wrote: > +++ b/mm/filemap.c > @@ -3360,28 +3360,52 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, > struct vm_area_struct *vma = vmf->vma; > struct file *file = vma->vm_file; > unsigned int mmap_miss = READ_ONCE(file->f_ra.mmap_miss); > - int ref_count = 0, count = 0; > + int ref_count = 0, count = 0, maplen = 0; > + struct page *pg = page; OK, having read it through, I think you're making your life a lot harder by keeping page pointers at all. I'd pass xas.xa_index - folio->index from filemap_map_pages() as a parameter called something like 'first'. > do { > - if (PageHWPoison(page)) > + if (PageHWPoison(page)) { > + if (maplen) { > + page_add_file_rmap_range(folio, pg, maplen, > + vma, false); > + add_mm_counter(vma->vm_mm, > + mm_counter_file(pg), maplen); Again you've made your life harder ;-) Try something like this: void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr) { do_set_pte_range(vmf, page, addr, 1); } ... and then here, you can do: if (maplen) do_set_pte_range(vmf, page - maplen - 1, base_addr, maplen); base_addr += (maplen + 1) * PAGE_SIZE maplen = 0; continue;