From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32265C54EED for ; Mon, 30 Jan 2023 10:14:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 599CC6B0072; Mon, 30 Jan 2023 05:14:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 54A566B0073; Mon, 30 Jan 2023 05:14:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 410E56B0074; Mon, 30 Jan 2023 05:14:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 315B66B0072 for ; Mon, 30 Jan 2023 05:14:22 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EEC6FA8D54 for ; Mon, 30 Jan 2023 10:14:21 +0000 (UTC) X-FDA: 80411055522.12.328F36E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 457A880004 for ; Mon, 30 Jan 2023 10:14:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nwijJTkj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675073659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZtzrawYp98whol7Y7ReGneKoHZh3tEbrhAuVPEKuMhM=; b=Oa3taErqJzeJHZcJWgW5B+oEnwtoSBquNY/X7BMlDGzn2jMAR2nJ6fQJXOvHr6/H8mai/D Kd9LOXRPi0CqkRuX4LgQdNRGQTrhicy4sxvJK2f8aqH/21ofJ0Kd/eJHQoWRkxX2jRZQr7 Z01y8aYSaUIUjk+Xb0QDKQSEp4E7PgY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nwijJTkj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675073659; a=rsa-sha256; cv=none; b=FqjeZ0bn/PmKUw7UWdybVaMqE3YFwf++KA6tmK4SFNYqqpJua+DG+GUs7oakhOF91eZgtV wJwM8KI2rr6Yj8IELgiePErAxMlG8KGgz9Xb1G4JmuHlSAztuJEWndhkpP6wjQe9pFjYHL 5lEXxCI6MzdgBClTlLDe1zVODMY84eQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F56460F15; Mon, 30 Jan 2023 10:14:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F129C433D2; Mon, 30 Jan 2023 10:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675073657; bh=YQdo56Bx7FrNbXodWDmZnWDioobuuYl+se8HK0H8qZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nwijJTkjSQj6rM+FN0ySHsRFb1lQuJ81ZKCJP8sVGc3BjUlroVq8/CvB5QwxoLvOf FX6fEHQdSMdRJoUcKH76xcbOms2W1BUdghnfE5BYPk6RiEJRcXK0rJLH4D37DqefRj MgHXX7/gNaDAEHugGGCm2IUfA1nwYgHT/8O+t5liR9EglQwjw5TrrHSmuxhuQo8eCU awAF+xqxFb1HkAO1GxBDEtr1fhN4K3AyY92EPVmobuNHUV/xAHncwInakZ3ohtPOzB grWeUdtJGmf4z2OTndK7fz0/jaruhDOFFid2JKikd/nLbqKCMDsBiqwhkOpVIwaDJ8 5Gv1cAWGLDWmw== Date: Mon, 30 Jan 2023 12:14:04 +0200 From: Mike Rapoport To: Hyunmin Lee Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] replace BUG_ON to WARN_ON Message-ID: References: <20230127115844.GA1124261@min-iamroot> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230127115844.GA1124261@min-iamroot> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 457A880004 X-Stat-Signature: zwpjkmejpjfz36b5pw1nezixfqe3rqfu X-HE-Tag: 1675073659-291750 X-HE-Meta: U2FsdGVkX193RVbybx+U+uCDNmQkVWWGRuOA3QDVzZCyasOXchrzw3TMrSJ0c9o5OQfZ0GxXlbDEo6NMv8n+GLfO40F076Xskj97uSsM76EiPM6jPduCzlJp3hptPPQeVbQNNxz/xvY0/AmJTGQxXj7arX01huRAG91Kbab7VOO/D3+RP/oxGtrKIivTXcWqC7sZbQZhQIDJ2msrSLIFCXYgA2U8ksQznKE6209nS54/uHXBBSW9IvkSXvxa0bhoqwxIDGiZ78b16GDotaWDqCS2YwJH/n01xhhSyg/Nf2suwe+tp3Q/bhWZkOJlu7nNYlh2YAyLcaYOJ/R536xSK1Zkx82cjAVabrEpfcq/LlGdfi0lP6xLW7HTtwCTgEcaxmoAuT3oIA3ibuRg8j++Q3QkfVGtoqgqOlGiaZlgbLX9rwhmpPbB1NfX0+OevfWCg6ubKAbF3UnIwomec9ffrneE+e9ARimvtbTaWIqHOpeR914z4P/4w/JiaOIHFWQ0belIptpNLFZQKCTUJD9faq/k9NPGj8Xzb4TEPnPfOyGoDfqMVrnAoj6cnFqOzqCbWDT3dtBNAiL/FBbyMVSIaL/WQ92N0VBj0ZHvBmT3+vyp0UHM2fyzVPWNA5PgKCsFPUocWo7XevyLva2tEVY2kR7ARUZoTTH/wrySc3QVvzkd8EI8Da+E8yi+7IwBvEHynpE5lqQJg9gLc/jXV+PF9kqWtmg1yo9Xm+rg2FzJIEjWgZfw+LVEzXTA/gSvfn62zXQ4EPEvNTzstgYylbhChaPyb0kFHFgfAj4rFSlG7JN/aOLK1PVDlp0Jpo9rLXexJEoI80bdbB8B5Oy/pL/LKnZFcZVESuuP5esA7m3ZgV/LpkAEXtOdKX3ucflMEMj2QQ+3WkEVfXj8ZFxsFIMbwslNSDFvcBWfXNEhK45/cbJpRvhZg47uAGV0tiwoMewTs3mxkNzhJhroTCzioSX XiKMEwzw mfYCbX7RVrgilkgZlHKOSNY8H/LcHY7rlGAKnOucWhsVRceT4Kgh2dZc9MQ0mb0t+9FYLvNuQG3bAPngpKO2GwjDHfIxpKSFKcGfa8NZR5fNZ9dwIOUh4Il19pUO2nUz0Sdlzyrh147u8tbQmLnrPbxvTTm3TPw5BMv77P+rxRuFhsa6bdpJxGy6IWmEFj+ugzxTlkBewHg7uQArWikzAaR7XxJUXuBLgaJJFOg9cAR6CGn5GutJFKVycqo+eAlw6UDChKqdDdSTtH89ddokZuVH2MWg7uANRjqJbOtLcEb5dXlAuBUw67ttxWjvotXwcNjzbo9Owdx4DSYjCmmj5owTXUp8faNqnuzJKZhrRmLJ9axTJ/LUMOUoTqf0NCdae0vMWrgp0yri7a5gFay+L7floh6ldLFkWj7s3x2fWPLy3OawmFr8Q28+G8M6VBZgFVSN16bm/A2h7yLerAYrVjb6cbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Fri, Jan 27, 2023 at 08:58:44PM +0900, Hyunmin Lee wrote: > Replace unnacessary BUG_ON to WARN_ON. These BUG_ONs verify aruguments of a function. Thus, the WARN_ONs return an EINVAL error when their condition is true. Some users enable panic_on_warn, so for them WARN_ON will still crash a machine. I think a simple if() will be sufficient. > Co-Developed-by: Gwan-gyeong Mun > Co-Developed-by: Jeungwoo Yoo > Co-Developed-by: Sangyun Kim > Signed-off-by: Hyunmin Lee > Signed-off-by: Gwan-gyeong Mun > Signed-off-by: Jeungwoo Yoo > Signed-off-by: Sangyun Kim > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > --- > mm/vmalloc.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 74afa2208558..9f9dba3132c5 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1587,9 +1587,14 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > int purged = 0; > int ret; > > - BUG_ON(!size); > - BUG_ON(offset_in_page(size)); > - BUG_ON(!is_power_of_2(align)); > + if (WARN_ON(!size)) > + return ERR_PTR(-EINVAL); > + > + if (WARN_ON(offset_in_page(size))) > + return ERR_PTR(-EINVAL); > + > + if (WARN_ON(!is_power_of_2(align))) > + return ERR_PTR(-EINVAL); > > if (unlikely(!vmap_initialized)) > return ERR_PTR(-EBUSY); > -- > 2.25.1 > > -- Sincerely yours, Mike.