From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05FBDC54EED for ; Mon, 30 Jan 2023 12:36:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68BE16B0072; Mon, 30 Jan 2023 07:36:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63BD46B0073; Mon, 30 Jan 2023 07:36:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5037B6B0074; Mon, 30 Jan 2023 07:36:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4088B6B0072 for ; Mon, 30 Jan 2023 07:36:03 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E73AB4045C for ; Mon, 30 Jan 2023 12:36:02 +0000 (UTC) X-FDA: 80411412564.11.BAFD8AA Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf02.hostedemail.com (Postfix) with ESMTP id 2B92F8001B for ; Mon, 30 Jan 2023 12:35:59 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nuT9hV1r; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf02.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675082161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TjJqgNdoU6ts0xJSopg7rMS5HNtqd4s8IF1fdr63Ejk=; b=dJd3xhzkfWmL77R46K5yNiWquLnorBgzIHjR/sfKYs2Fi1LfSfdd0n+1TnA805/5zFRgSf w5wnvRr2tghcWgoxmLWBZqgTTBl+V2QKmGF5hdhe2S6DVrOIbqxqKsy4BPYyKuZupiswia SfE0uCzEv559l/iHiv1Sy7W4KWenB7c= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nuT9hV1r; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf02.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675082161; a=rsa-sha256; cv=none; b=5t+UzfnfN9YHTkUbw4YWkR5CQkRWH72gS1fSL2kmwlrSO4zNWIVOuHhL/o1jhYp6kTBVmP CBcD+9AO/y06A1wreFBFMtYVOVcW5agpLhlAzKiXv9y2yFP/T2UfItS28wHhJvZ32yKRdx wiBKs/ouD2YEgLj457WgUR1IC7BmmaI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675082160; x=1706618160; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=R8m8Daj8DLw7fbozGOxSYGqaZ1lMYeutU3qJd2Iks1Q=; b=nuT9hV1rC41/uf7ti3oqA0VBuKBpN5TAXNW34+kSa8XxJALcS9wdAWg0 1U9SPoKW1mEGmroqBMhT1Obk2lQCmtGDad5nAfpyg0WCl+blMyfPdPI5f 01P3Dn6rDK6kD8FQzAzPCQeMf8KxxJdzzLN0tYfnYbFbqQHZHEBtl9hBi d5AsVPKbsvjnWZ4GGLuVTTeHpzAzgebgr+WfkS9DkFGfxbGfBwGssrhlK m/s97Kv6FUMA8sfdhf6gii7pBWCGA8lJhVGqpwWJ/1qbwjUwZqK+npR9W EWqTYdbcXPjnBswOuebqvRSVM6TfCgzpTI1C22dq0q6UVxXPJPwnUOBan g==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="392093329" X-IronPort-AV: E=Sophos;i="5.97,258,1669104000"; d="scan'208";a="392093329" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 04:35:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="732684302" X-IronPort-AV: E=Sophos;i="5.97,258,1669104000"; d="scan'208";a="732684302" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 30 Jan 2023 04:35:55 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pMTO4-00HLbR-30; Mon, 30 Jan 2023 14:35:52 +0200 Date: Mon, 30 Jan 2023 14:35:52 +0200 From: Andy Shevchenko To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Andrew Morton , Joe Perches , Petr Mladek , Steven Rostedt , Vlastimil Babka , Matthew WilCox , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable v4 1/3] mmflags.h: use less error prone method to define pageflag_names Message-ID: References: <20230130042514.2418-1-42.hyeyoo@gmail.com> <20230130042514.2418-2-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230130042514.2418-2-42.hyeyoo@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2B92F8001B X-Stat-Signature: 9hunwebfkxsdoxi6iisu3ukkxsqa61dj X-HE-Tag: 1675082159-267554 X-HE-Meta: U2FsdGVkX1+34P1EFl1gnKRylJyY8wBRLdVvKG4UHXNPdE6Ep7qIhXNzGn2cLa47LwRLtugULE5uCS/P+HposIxGS8XwBNvpYecpnpzYuMORjyXwX2cZ0/993udKSvylxmJ3beeL+KHjptD+6o2HMwiAkwrM6s6L2midr8QXlZZFpws8XzMBoaZJnh9b9f8NLoU9ALz27UZX8YXUZujTggbNtOQT5sYXJ7P9YI59pXxGkx8DfMm7LmL5XJPf7mGyi90hAuWIqz5JY3BYGT2eJBRQ/numcjZFjoxVXnK4ySu5YAbusFWrN5zxhCWD5ukbM2BCe5Dw4mwm5oB1ziqMdkyCmSWgHGmwUE5tPPT6uCCZC7D0ZSkwzaWxn+Rrz0KdpokS5Tfz2gRpvHV2oUwzbpUz326Po3K1PwTwGXECvsu3L7tWwMCJYKWiUtpCl3tfHbBrStC5PGqk19/vkMa/FhDK/vK/GIEJDR4pDZRWUR+uYt8JHYaYRNqnGp6JzzYM1hB5bTHAzk+cksVGDprB38nOrfejc/kB0EuADda8jlWC14flhcu17sCNeiF1rVLXAJRKhcTrfpumTzdrQ0gZg5Ylrg6PdFxfgYRN+BOZh1efCGFvqRiw/30seA5WhltO/3v+z3BjDX5qJ1Jc+KdWonBUVqKtsBDwVKhHefDjj4VC6/tGlCB3Y+DlB0U6MurdFEIDnvIyEtC7zd2ebJ49rzlIOCDdXr3CYtmeX6A62L0CDLmnUJQj/qZuXkVXie1eYFQpl3/+Vw8yzCIrD7tzyhunj6j5H3eDvtyiNYZIChVxnVDCP+2zcuONYyZP6zwkwzTKtaLppNQvwIwyzzbkuLBd8psc3ja+4ELcJpl0r+f6HXr1hD/qGmLYNXfhn1BFFGIk56fltd9hAw8lwS3zBe4a76Dna2Zp69fk9yW5LAM3kRlTuX9xF8tiq/7pEefXWrzqOVbLksPsCstfWcs k09yeUxI 9vpXNVEXJfhZAoOxuB6Bnsm32mGRdSWJkK++geC0OvLeqXZD3IExyx5oO07V8W9ZLGCmj8zdgx4sz4PAgmHaiBvlpXOcGzwbT4Qi5pzcJ9OZusFVpjRKgtb6Kvy86AKD+9gcEPEuxd+eXZapv5nPFKkAp2HG2jcl7/x7EH/4WqcPIVXrjOtPnXdXrwIyL/UBgqOMj8TsNdzFqgI6L4e2fYgWNCyXBsxdLbMYFsdS0UhtyVUWHgqToO8r0l93NmKoSHDIkfqvHodNXiDeqCnI1vkkDM6aOlOKVnyLSTSOw8xt2NxfcL4q0NRUJmY74+Y3DaYj/og7Su+g9/ovdola5AECABlQtfU1gb+XqmR+8kFCvhx6JpCy/+wofkLgYA4cUEr9et7ZILrBu2V5PScRRY3QPhOp+quRrWjo4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 01:25:12PM +0900, Hyeonggon Yoo wrote: > As suggested by Andy Shevchenko, use helper macro to decrease chances > of typo when defining pageflag_names. Suggested-by: ? :-) > Link: https://lore.kernel.org/lkml/Y6AycLbpjVzXM5I9@smile.fi.intel.com > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> LGTM, thank you! Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko