From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 347DCC38142 for ; Fri, 27 Jan 2023 15:03:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 690B66B0072; Fri, 27 Jan 2023 10:03:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6406F6B0073; Fri, 27 Jan 2023 10:03:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5077F6B0074; Fri, 27 Jan 2023 10:03:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 418046B0072 for ; Fri, 27 Jan 2023 10:03:33 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B4BA340F4A for ; Fri, 27 Jan 2023 15:03:32 +0000 (UTC) X-FDA: 80400897864.25.1AA28E4 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf25.hostedemail.com (Postfix) with ESMTP id 99762A0026 for ; Fri, 27 Jan 2023 15:03:29 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=M6SSWaRK; spf=pass (imf25.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674831809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n31FklM0OYREnHA1tP1e3LSdaHgDa9JeETQaAtpDNx0=; b=4eXek1T36HutHUFH9S+p28bjOjn1tNJ3z1TEPUhMxfw9BSPhhsI+XUwVOOMiLKV9GJbxwg i4bjWGiHF11WHzQrODuwGtQIq5SXCycGks1WMWZPNsxRMXD6sP9EnBLGo7WIK8frU+U1M1 jWmm+U8YkyJYhz0zZcNOgIQ2ioyP2tM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=M6SSWaRK; spf=pass (imf25.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674831809; a=rsa-sha256; cv=none; b=c4aab91uzeoC6vP11I+jZKW+H/wf/EzTQVPlCGUBkI/9/a/HsyIQEu8SubxJHE5WYOWC1N 85XYVdKlOdvg5c2bq3Njfl0zTToHohubG1lWXNIwKB1YdxWJAt1fU+FmpDdFEvnsaA5XW+ oydL9Z/EJm2o/avNmOBPaVCdVMYd5BY= Received: by mail-pj1-f43.google.com with SMTP id w6-20020a17090ac98600b0022c58cc7a18so600854pjt.1 for ; Fri, 27 Jan 2023 07:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n31FklM0OYREnHA1tP1e3LSdaHgDa9JeETQaAtpDNx0=; b=M6SSWaRKvHYyXnHeqRhKyDiua1oMz8Hd3PukoMuD6rBmopInZtl50XdRMj6ER5UXOv RLP15t2X51gbC98s/9gPou7TistUJOmaDVU6OqMgrl2l7qxgftafZmdGPY9Yz34GIPxP YK2CuOV46j3Vrbn9ayuLfteOAltptj+Xdk15vmSkmo902j9QETHVjAAF3k2EhL9N42kl qpUh3S4rTSAVhq3SbRFcf8jdAy9W+Cv9c8cITddHJQ9guoLJFU+82ncQiOYpnznCreHg 4mfZmNYqI0wROQWoQy7otgEd9hr8NXVVRPBGip6GQMsadaSA5DfZrXOPILlXqAmCbiuV coPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n31FklM0OYREnHA1tP1e3LSdaHgDa9JeETQaAtpDNx0=; b=TsAIxMaVq1msHtKQnloTv0C3gEFwqNWc/qOCv1guqhIKBWNC48uTkn+vxsQwMgZdeM navZMrPfTdz1cJ5MnKWPj9OLK8GD0Rq+jRKpyDRutz9/WXwTz8HQLi9ED4co0FM0w6vA mwzrOM3lC1eWXf7bUW0jthFSWGO/BKnFrMaQNBm5J4gLqj0q+FaPeKAAU0EJYIF3gHlS 56YqKkJ1945tLqdHDRW5KgbvvTpIgMJ55djd6U+5+Xn8TkjlWs/iYCyFN2lbHuOzz5gD WikwVxC12vZ2l+9Tbphhyjh7YRZzzCYnsJBESx4lDeO5kXl6d5wipWNN87FhZqpj94yE g2nQ== X-Gm-Message-State: AFqh2kqtY55DRRaanYBynd4JhFkPUWrrRD+D54rbNSA3ySFygBnc8Lfm AphPminU/pGLZ6rKlIksVYs= X-Google-Smtp-Source: AMrXdXu8fOFjL0+xdFqgqCe+WGF6zeplIVby1Vxp1yf0RzVYaCVenBITz8K3fDdfqv0cIcld35fvHw== X-Received: by 2002:a17:903:124c:b0:194:d664:be3a with SMTP id u12-20020a170903124c00b00194d664be3amr36226903plh.16.1674831808380; Fri, 27 Jan 2023 07:03:28 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id t18-20020a1709028c9200b0017a032d7ae4sm2983879plo.104.2023.01.27.07.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 07:03:27 -0800 (PST) Date: Sat, 28 Jan 2023 00:03:19 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Hyunmin Lee Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] replace BUG_ON to WARN_ON Message-ID: References: <20230127115844.GA1124261@min-iamroot> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230127115844.GA1124261@min-iamroot> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 9c1ztm7zti5hjd6edo7uhuh6s4n9uwog X-Rspamd-Queue-Id: 99762A0026 X-HE-Tag: 1674831809-77511 X-HE-Meta: U2FsdGVkX1+Wj1tvDh8jY08fuPshyzxhGTEoA50NSJQBettdzGPsyg/DT0syrzWzOcxQMWCCQlRTRrePI9FEh+69x7AqqbNlPGiuv+1sYboak9e/URdCadIngqW4saRy+m4OeJthnzadvtAACg4QpOK3sIY3XmHxxDu15p1BliOAhYnB1tM/HMcGE4ZRVEe2l7Alpwj2XzERA8Och5cUmpHDLOhnnpp7Yz/rY29Dv90xFW3PVHcI2/ztARtzPB5n53JQvwYdLGmxKp2V4tt8e9nFn8FUv6qhOpe4nZGVZaCpuLbnkpMiOh1qMp7oUmDICDycvybrwdPwcgI7DWdbyvCSp32dy5RGAF83rpg5qvcB0ZjK5n/51+rImmeytp6KU+AyBrfvJ4YIc39UVaP+ekAz04F1hAnFi8yA2KFDPurAv9YyljZSRYgH//yXHSJohlXtvIEnjzt6Gx7obei4BE1rwLH+GkTfkl2GWRW+pk8Qy8VVmR3IEoIck9k4A0SS3+AvJhmMmnoBDVKWAg2EC2Twru9mUFjYphntO/oQ0z1ctY3wlNK7haKSBH2sWApNrL4kiHZJid0C8/Kg9ipOVH3RNDdMkzflioU0TFXXFrvKFXplHvLFpJx/RBllG1DWi8SlMZjDGP0p3ZedJPgyocH8uxedJxPMRPho4N9viL7pSYjLCkp7qpOFXFIxOXnuzztUIJ5sYJbyZTog84UXj1/Q0N4tPy+jVmL7Xvw5FprlT+4KJEmIa5omQfy9njZAqJpUvpWdRnsbH7Ru9WFzyk+mJbK/niBWvE1ih9F3aAtbu1YYP4uRSqwn+kIxj+JiDkhR3v1kgH0D4hYXje+t6dluClr4rROktGcGqM5ug9m4RdyN4cV4dzMgflQPB80IU5CVmIxvoDT05smMUuxgfpapBzrMrWJuM/OkfYaJ4mscYO0XrrJj65stex+Kc8vC3f88gWo6oKCom8jbS0z JcVrSJVk ffgmMuk7DUVi9Va2OKmzKUQxlDKp2tfRCRIbRs0IBarXg8eLO7zfc2ZPGw5VbFp3VMKQDCqPQdNkbcu2aKAtyLbuQ54k7dLc2X/SIgjL1UecOFtV6rXseOcK609bLhFRoUqyzGyHwvJrKbCk8H3IlGsU5FmZ3xjMorZC/Ltcmv9/5Yz1WxsvplxTc3CrSA+iHNdER438rBbRua5kDxV3M4PMsASeuX70Nv2AwuKwiuzpt+JIJwY+ypAKVSJDkUrqyYfdS3zDSz0HVJYSMrngTad9ryuMI40+3EsvE0fH+SVAjDs8fVx4YgXF5bnpQquuzKVE4UnBdJCvdhanp1gc1C8UXQU+liMaHSaffrZbVvcjBtjtUnlLcjpvOEBO78aw9M2Br2bYmH9oRvhWVvLhSmxjoEUkKdH352QQhDKe7wVb2ikDrOmOlZA97TQgbujGyOEbd/hwjdWC6MkCcoDRuo4nfejGAr6AAR9edSZRS076htvIKHEufNaqX6vhQB7HgMiH8cekwqPtEHOXZ5ddKbDdqJxbjRJlIuAOw/RZbJqgRVOd3QfFqUx19DkuEgt7uM2mfHS8+qpghFeNxxratTC6J4l0oxY4F+NHb2J/n0/bQw/2oBU8aDbmssD0L/pwPa9EA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Hyunmin. the subject line could be "mm/vmalloc: replace BUG_ON() with WARN_ON()". On Fri, Jan 27, 2023 at 08:58:44PM +0900, Hyunmin Lee wrote: > Replace unnacessary BUG_ON to WARN_ON. These BUG_ONs verify aruguments of a function. Thus, the WARN_ONs return an EINVAL error when their condition is true. > > Co-Developed-by: Gwan-gyeong Mun > Co-Developed-by: Jeungwoo Yoo > Co-Developed-by: Sangyun Kim > Signed-off-by: Hyunmin Lee > Signed-off-by: Gwan-gyeong Mun > Signed-off-by: Jeungwoo Yoo > Signed-off-by: Sangyun Kim > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> could be rephrased a little, like: "As per the coding standards, in the event of an abnormal condition that should not occur under normal circumstances, the kernel should attempt recovery and proceed with execution, rather than halting the machine. Specifically, in the alloc_vmap_area() function, use WARN_ON() and fail the request instead of using BUG_ON() to halt the machine." > --- > mm/vmalloc.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 74afa2208558..9f9dba3132c5 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1587,9 +1587,14 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > int purged = 0; > int ret; > > - BUG_ON(!size); > - BUG_ON(offset_in_page(size)); > - BUG_ON(!is_power_of_2(align)); > + if (WARN_ON(!size)) > + return ERR_PTR(-EINVAL); > + > + if (WARN_ON(offset_in_page(size))) > + return ERR_PTR(-EINVAL); > + > + if (WARN_ON(!is_power_of_2(align))) > + return ERR_PTR(-EINVAL); > > if (unlikely(!vmap_initialized)) > return ERR_PTR(-EBUSY); > -- > 2.25.1 The code change itself looks fine to me. Even if BUG*() -> WARN*() conversion may not be a high priority task, I see no reason to reject such changes. -- Thanks, Hyeonggon