From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1124EC54EAA for ; Fri, 27 Jan 2023 00:27:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 884BE6B0072; Thu, 26 Jan 2023 19:27:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 834126B0074; Thu, 26 Jan 2023 19:27:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7238F8E0002; Thu, 26 Jan 2023 19:27:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5EAE56B0072 for ; Thu, 26 Jan 2023 19:27:32 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2B3E7AB4B2 for ; Fri, 27 Jan 2023 00:27:32 +0000 (UTC) X-FDA: 80398690344.14.8CF468E Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf20.hostedemail.com (Postfix) with ESMTP id 168F71C0006 for ; Fri, 27 Jan 2023 00:27:29 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aiT96oz8; spf=pass (imf20.hostedemail.com: domain of kbusch@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674779250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qo1Q6LRLRX7ReyVkvd0V4nYf00SklD8QK3UK5i33dLE=; b=oheZgKG/YQgcsBZBacFWCNhxRfPBwzNrK3gAJ8fKDwfqYqYkz7YDlPzmKQbfI/zlITzqj7 pZFy+OMpAL+6bgOxXq7qBCR3LgIg3vjTRg8+Zw5es4o4HWtdV6kOt+7OaZkaDvdSIp1FWY igoOlfwRN5fxmouiR7DRzqGuSOaxqOA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aiT96oz8; spf=pass (imf20.hostedemail.com: domain of kbusch@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674779250; a=rsa-sha256; cv=none; b=PMh/2AIizGmOqpz9QV3YPf4qfRrywmUGWTXjIMCXz8HC6LCinK33+13UUjAQOuZwCOFtcS oV8iSraxhNBv/LZFLrfUMEqya4WvA6ljCVLPE7FEtxJzI5P0gaBgtItz6GaVJPwWBMeNBm wzMEalbHZzZDxwgkfWQqx4H5DdhphPA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id BE3F5CE25A0; Fri, 27 Jan 2023 00:27:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D93DC433EF; Fri, 27 Jan 2023 00:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674779244; bh=deQh6cAWkh3EgE6cMrbUrdOHHjl5t+yVbCHQD1OOjMs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aiT96oz8szS8HSpsPnEMTHJ1HnqZCQtp7YSbSfVnk+YTV8pMB/QHj79nWfmC8L/9C F2QdXYF8SPRXsKw2YO6vYTGExxgx+YhahGp18QQuuRV7iHi6Z6hjK8HmCkC1Dp4L0G yYqKICWKAatTTJ6XogEWo1w6CFlXVsNAhC232bv/prRo39K2gROixcIdp0UIR5XyG6 MOKedvha0AnWS/8XiXaFPR0mx/NkT4GISnwxiIkkffpgznE59uSFqTV6E9mK4Y0siA 37w42JM1pXkDaoh2uWPlj24x7rmROu2A1MRSSyvh4webeOQM5iHBadEvEjf0GJZQrI THunnr92fUpcg== Date: Thu, 26 Jan 2023 17:27:21 -0700 From: Keith Busch To: Andrew Morton Cc: Keith Busch , linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, hch@lst.de, tonyb@cybernetics.com, kernel-team@meta.com Subject: Re: [PATCHv4 00/12] dmapool enhancements Message-ID: References: <20230126215125.4069751-1-kbusch@meta.com> <20230126142209.b3546fc52f3f13ddcda67bac@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126142209.b3546fc52f3f13ddcda67bac@linux-foundation.org> X-Stat-Signature: yur5xrbeayue4ngt8bnhc64zxsw4pmx4 X-Rspam-User: X-Rspamd-Queue-Id: 168F71C0006 X-Rspamd-Server: rspam06 X-HE-Tag: 1674779249-722406 X-HE-Meta: U2FsdGVkX1+yTlt/5xLm49nxtZe2oxhIxi1WODpluO7g89XxduRna/9gSo8D+50rYOE+NTSdFTEKKBuOsK65ThWK5g8iBW1Me1caaZpHfm2eS3ylBXo7pypMJJWIvMVuomjXiCbY1y3I66ige7pwduyRdQdrkw3pkoIDgifA7p1q3Et74zitOD/5M3NrTvQg1mlXy0nfL1fhQrs9E4sMSG6ZVaDOINzry/A0GSCCLblrkqnYwALH5Jbxy07ZaEe/giU6QwHaoNLeWKLaQS9x2Jcgj77FBKD3twqqCLnOd3b5UpzS9gFjDZ8yxfcvjzNnZ41sNrh0F9lAaezVl+BSlXX27K8BbNlCG0o3De3s3aGuh1rkGDryZTZ62p8PZtcxeylu2it8CNP8I/h6YZRB+EHF6Zco6ysL2s0YOMRvko7rAofmZE+W8MY7LZNZS0t/4c7gs4FojbQCdY3BnebCNJdxyO88Qpjn4RWFIdFlC2w+iEEVEkJnDgmnPDn5raygi1DilP2zZdtNHf0JBLpswRAKjcp8u1k3/qFPJ6F97iKFOJ3HDTtpO7ngW1okKiVIFerjp2p7hST2zdIlIjwxplLSBK+gXGoeJ76Z9uZiOPoyK7OZLcQUa879LevSDCaXHT2fZot1mSFfSxabJ5D8QEJ58zFE1XG/Jo/FKYIa9El86Sa2ZuzsOiSlXADN4amEZ0W6mkKR9mGrQcaDXdl49/ISvZyd5MV0Vmz+gLdiLVePpZ9wnI3ohItkNrTca0+Y5CaSZUKuNvD5kG/iUlWH4hmlFAkpHGHfSD86k5ERqkCBXmRFcm5CIO/hI/hDUGmInPwR0RQFOcT+/oJRrUjWmtaP0SXi+MPW7luFbFaHBpL1GyKBieiOcoM6jbrusrbSEpPfUfiEOOkIAkNzrnA9AhmnmVHEAvAGEnjinPmRY+QOXNDPMNwE/qBjPqSeVDaJfCbDjzU2oMAsSx4ae2W CZu1Fj3I GY9q4qiXyBeBODxnI0ogCqihaS64P1dzzkIC20k6GGTuVTtxoADpFf3FWjbVcA1F+IAXOaR04EA/VktKX1Vq+iPNbisRUk5Wyw5ty2U4PnOeNi8R8+3JlL10pzdsZRDSMi2PdNdQ8IGFLHiSbE2CE/105RFGqJduAsRvHwQXSCad48NE2u0z/ndTDfsjh4WcNKgvkbMUCvv0YF6Yq23j/Jrgw0hpg9b7+7woMnvdyJmJL6TkavsrkniQvrmSMHKvR3sdmNnUPSOQVp5EeS0mzoPKWnk0bOQuQ+/tHbXTABeGMm2VmAebLY0SGozBXPjMgOMVF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 26, 2023 at 02:22:09PM -0800, Andrew Morton wrote: > On Thu, 26 Jan 2023 13:51:13 -0800 Keith Busch wrote: > > > Time spent in dma_pool alloc/free increases linearly with the number of > > pages backing the pool. We can reduce this to constant time with minor > > changes to how free pages are tracked. > > Do we have any performance testing results for realistic workloads? Yes, I mentioned this a little in patch 11, profiling with nvme with high-depth dmapool allocating workloads. Results really depend on your environment, so YMMV, but I was able to observe time spent in dma_pool_{alloc,free}() reduced by half.