From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E160C05027 for ; Thu, 26 Jan 2023 20:08:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B42886B0073; Thu, 26 Jan 2023 15:08:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF2BF6B0074; Thu, 26 Jan 2023 15:08:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BB308E0001; Thu, 26 Jan 2023 15:08:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8DB2D6B0073 for ; Thu, 26 Jan 2023 15:08:03 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5E8DD160D85 for ; Thu, 26 Jan 2023 20:08:03 +0000 (UTC) X-FDA: 80398036446.22.EAB2A52 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 963A01C000F for ; Thu, 26 Jan 2023 20:08:01 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wO8H0zWv; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674763681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yLIeRegKr0X7vGwXYffh/Se/fwvXPCTq8z1VBVpsZ3M=; b=emNoW57UWMHGy5wimcn5xs8q0ysQUFvhNoO5yzuex7Y4fZDZa1yPyYqA4EaWXGJIStzsGi 816LLX7EkNF33WL7K4Zjtc+S1hWHZdNyE5mPhxRZaoUw2QAR+B3hBuuiu2tneFO+0NH5qF WfimJo4gTPKz04uBG0Dr2mtX6dBEIPQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wO8H0zWv; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674763681; a=rsa-sha256; cv=none; b=y7JqfuRV5rtAMfhPnbzSeEE7mGz01Gp2WFHSZ+NnqQcPNCoE3cqSdlL9pV1BTMIKEG+klF pqrkpd6w+m5HNL4xt++ghRXvpyaDFyekw2B9+ZLFMMQkPrmGsRiR17fJd0PdqLnL7550B8 nHNwQOL+2Q3br9JXLhRagoYmj/0Dpg8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yLIeRegKr0X7vGwXYffh/Se/fwvXPCTq8z1VBVpsZ3M=; b=wO8H0zWv4XC0Lj0qhFP+52HnYB 8DXzNRfWpx1zYL08jWrsf70m8NGRhRdK6jLsdd4Czh3tApW8svxijyo+oVVVUqNPO5lKItdzEGhz4 Dxw3mPAUIC5QykqHl6IyToLpYf9VM699EY4ORgT32Hc/FlA7waQEbdyJJ+okQsWcugiGlavaUspmd 1slmPM0Oex0M5RKlT64rC67QJtNVn92C0oAYuaGfnnFvFtDuOohVMhomWy0KSJ5JTEEHANxy2ncHC Dp1pBMkh2VBcaWpJBwMpD0U2RSrgX98v670VRWk6P/MnRS/QwzlVrKB9uehpbm7tu3Yd5xYcs3+tO 2XjrcLkg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL8XJ-0073AH-5o; Thu, 26 Jan 2023 20:07:53 +0000 Date: Thu, 26 Jan 2023 20:07:53 +0000 From: Matthew Wilcox To: "Fabio M. De Francesco" Cc: Andrew Morton , Ira Weiny , Sebastian Andrzej Siewior , Alexander Potapenko , Andrey Konovalov , Tony Luck , Bagas Sanjaya , David Sterba , Kees Cook , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Thomas Gleixner , Al Viro , Helge Deller Subject: Re: [PATCH] mm/highmem: Align-down to page the address for kunmap_flush_on_unmap() Message-ID: References: <20230126143346.12086-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126143346.12086-1-fmdefrancesco@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 963A01C000F X-Stat-Signature: 8ehxbfz1ruumra8xszab5epdndb4ttnw X-Rspam-User: X-HE-Tag: 1674763681-921876 X-HE-Meta: U2FsdGVkX19jfxpN/dHaMADYuGRlL1Jc3Fbb8atbJkmUgSfEv56xOEHmDD5oueI5RYH61cFvH6AdtQh+Ftm0ITDRPkRlvd98ksvP5on0ipR5nVTGhamd1nTr1NyfVO8aszmWFbHuKEm95cV8XQbu8XgTwwaIzMqhG50Ef2NQ8l+aMyqoVO9hfcDsQ/kfJzmABUlXV/Bg2TNMVKefCWpJRH6pvC6YJg7scs0UN6jkpudFRVi1tzb1gZthqAY4OKpDroPmPJdQ5Bylcx2+2Wa8Qba4u4i9NI4lYyfLrFXMWFtC6s2ztBzm5LzajxZqj+kN3qjkzDtCq3g9BLJax3OgHnxd6nuVr7bxjVkEX2AoxyUwESi5cF1dnsEK1VkCwEWprxBGYAxIUV5LrdNhUX1UshL/uSKoF/4CMGHIdRwq9ZSOyJJewUWxM2rfJLHyXYfjsBeFtY1hh2OELVc1He1F6dn1HbdWqjkYFerR8GYidWxVPCyymRwEk/PQNkPNHOUydDGH403FokBqiJRViAv3/sy/+BVYPFtnMwlH0LPrZVUiR1L/H6d3ikXfVFyKEo/lnZbJs5mX+yBjK30WICOgIoT6O5PnouqaTkeLRzw4xrnP0EmK5rzjxObKQTqGt8koBzospuMZJD/UwIt45if9+Rw6Jj5zxVlaVQSZOQXymqcni9hb2ko7W+8yMoHyJkib+VgMX077F6p5UFN9LzIKx7SsmSvorSeNSLseaw2LBrsH29d4V0QjpFa4mNzufCFfba/tP0tEUcptWVBZQZaDJ7xnBQcgA4dpbKLL0UI7GIg0uGua50V38JnSxbZvzn9zzYcqXEumge/usTgObtHI/xw7dBcvYGrs7q0xRf9KjsSoAGRpauh5vNjGa9aN1JvnvcBBWfCi3KeQzvcpz99YLyOfempQ2qf4CJ2+n0ANtQxE2NqpeJC79YAZhBNHKzPdB3I3DFcQ9RDmhnCeK4j GUfn2FHJ Xf1Dl79EdIQnVpYMAnnMl1OEOsNPTEiU9o2rAX7zFFMtyYRLPyLWwBsNrW7CWGaXiGCbb5bqTyf+fHX152FvZk3E3C22Nd+VsLH8kqMhjDMEf3abmEryBRZ4vC9UOZssfasOSkJ8h3tCM0i4cOkcI/bHwh+ALQhvDLbQxqqhILTKhG0qybXKu1JsI1z97KeBA4QlNAf28wR5Qg/g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 26, 2023 at 03:33:46PM +0100, Fabio M. De Francesco wrote: > If ARCH_HAS_FLUSH_ON_KUNMAP is defined (PA-RISC case), __kunmap_local() > calls kunmap_flush_on_unmap(). The latter currently flushes the wrong > address (as confirmed by Matthew Wilcox and Helge Deller). Al Viro > proposed to call kunmap_flush_on_unmap() on an aligned-down to page > address in order to fix this issue. Consensus has been reached on this > solution. > > Therefore, if ARCH_HAS_FLUSH_ON_KUNMAP is defined, call > kunmap_flush_on_unmap() on an aligned-down to page address computed with > the PTR_ALIGN_DOWN() macro. You missed a spot. Sent the version I've had in my tree for a few days.