From: Mike Rapoport <rppt@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Bagas Sanjaya <bagasdotme@gmail.com>,
David Hildenbrand <david@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Lorenzo Stoakes <lstoakes@gmail.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v5 1/1] docs/mm: Physical Memory: add structure, introduction and nodes description
Date: Thu, 26 Jan 2023 21:36:01 +0200 [thread overview]
Message-ID: <Y9LWIQtPQ5yLIwu9@kernel.org> (raw)
In-Reply-To: <87r0vh9n17.fsf@meer.lwn.net>
On Thu, Jan 26, 2023 at 11:19:16AM -0700, Jonathan Corbet wrote:
> Mike Rapoport <rppt@kernel.org> writes:
>
> > From: "Mike Rapoport (IBM)" <rppt@kernel.org>
> >
> > Add structure, introduction and Nodes section to Physical Memory
> > chapter.
> >
> > As the new documentation references core-api/dma-api and mm/page_reclaim,
> > add page labels to those documents.
> >
> > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
> > Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
> > Acked-by: Michal Hocko <mhocko@suse.com>
> > Acked-by: Vlastimil Babka <vbabka@suse.cz>
> > Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
>
> I've gone ahead and applied this, but I do have one little gripe...
>
> Something like:
>
> > +Reclaim control
> > +~~~~~~~~~~~~~~~
> > +
> > +See also :ref:`Page Reclaim <page_reclaim>`.
>
> Can also just be "See also Documentation/mm/page_reclaim.rst". The
> right things will happen in the HTML output, readers of the plain-text
> will know immediately where to go, and we don't have to add the label
> clutter.
>
> </gripe> :)
Do you want v6? ;-)
> Thanks,
>
> jon
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2023-01-26 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 19:28 [PATCH v5 0/1] docs/mm: start filling out new structure Mike Rapoport
2023-01-25 19:28 ` [PATCH v5 1/1] docs/mm: Physical Memory: add structure, introduction and nodes description Mike Rapoport
2023-01-26 18:19 ` Jonathan Corbet
2023-01-26 19:36 ` Mike Rapoport [this message]
2023-01-26 19:47 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9LWIQtPQ5yLIwu9@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox