From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3772CC54EAA for ; Thu, 26 Jan 2023 21:54:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB4F2900004; Thu, 26 Jan 2023 16:54:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D163E900002; Thu, 26 Jan 2023 16:54:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACB7E900006; Thu, 26 Jan 2023 16:54:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 90E24900004 for ; Thu, 26 Jan 2023 16:54:36 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 59F63120D25 for ; Thu, 26 Jan 2023 21:54:36 +0000 (UTC) X-FDA: 80398304952.14.738DD1E Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf14.hostedemail.com (Postfix) with ESMTP id 61AD0100014 for ; Thu, 26 Jan 2023 21:54:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=ktqSuYI3; spf=none (imf14.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674770074; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JJwCfXL4BYUpCEb2XPDFHx9R/zNmK1q+22jJU+x9B7c=; b=pvyibQANN/zEopDuJ5oC66fj8dtUVbNXV3K8WPb+o4nKBUn+hlKUSBzoMNV1WrM3MVyyD8 QoV3NaHmQvMQJnB4KxssNVJEzQmtNvacAEXH+udCLnMR5gIIh5niGMmMeNVpKyuu/bjUiP R49/sThQAwOFnHIrLAKFJdkRIfzsVsM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=ktqSuYI3; spf=none (imf14.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674770074; a=rsa-sha256; cv=none; b=flivi5oPGsn/1ra3Fep3i5i5Ptx4TtVpDwN34ZfC2WeyDjfWwvFJRYVYEvEr2A+nw/ybc9 VI3uvQKTD3ouf7suD/OzVi61Nyytd9B5nCFrl1vzK46ZFKp7mBoJV5pZpQ3LqJ2a0jmurg uEPoPjFH6ldDNNg8uiC1ISLvVMP/xDM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JJwCfXL4BYUpCEb2XPDFHx9R/zNmK1q+22jJU+x9B7c=; b=ktqSuYI3IdQfkyDAWZIMLp5SLn eOY0i9SJtPz38FegUd7y7e9/3KGwB+S6nF5cNWJlqKc6FOzTCHBMqczRirZC5wwSc9UF8JytYWfJO tSSScv4TV3KgvVYaybT2eIv6p/Vk+yqT4YGi3ZobBApeDhQCaHIDjIvaDeevF5PNxlupjfcN1dQ1l 75GPZdXUaA/aw0NkPLXu/N/xsvjixuWSde/ZEOMlRa3yZmhABUvM0N0eIpXghdfXNeJ+3uSxOVyeN F4z2/2t325lgo84QNfxo1vs/g8vTSr3ojEOENqvWpFuXEg0Ore49vRihkyNMm3SULCvp41EDv9j84 bOW4Mr7g==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pLACG-004K1b-2x; Thu, 26 Jan 2023 21:54:17 +0000 Date: Thu, 26 Jan 2023 21:54:16 +0000 From: Al Viro To: David Howells Cc: Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v11 1/8] iov_iter: Define flags to qualify page extraction. Message-ID: References: <20230126141626.2809643-1-dhowells@redhat.com> <20230126141626.2809643-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126141626.2809643-2-dhowells@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: raxxky7dnqhaumnkehh85757sdxbbt4h X-Rspamd-Queue-Id: 61AD0100014 X-HE-Tag: 1674770074-982810 X-HE-Meta: U2FsdGVkX1/PXpZSl6QEr0uH3lTGtPTDpS+5DAog5dmmxG0IdyUZyRkc8K/bO1apob7Owp/WqlKIm+G4KrmwJvg2KnV+b384Ltw8MB+CGXLRaJtq5kRewDQCrdrRmorrQ/B1J/b+svdBPZn06CQeIVj3nlKextDkupx+xtfu7RNZTFZa+NEIqBGaiwJkfxF8qiLTcuv8GTbL/LzyEGTvfHz6IFTFQNIx5urbokjQ7jd6F1sFRNvPNeE14DrdSB0Jqzarzop3bbA5X5WDSZZcP2WoAQ9AiQOfhU4/k30DuA9fAIu3443DorEqR/ncoZdFtrkB1iMcPdBlY969YKUHtTRnQ9bhc2o7fpQfZp0kyxLx7C8MPIhOOJADGMtUU8U9cx7/aR3mWjcCSFp+AdY0Ti+eHeOxMGapzZ/lFUSjlIUjMVT9L5HhWzkP4S6sVR/O+x7ZXSsF6rmb0O2IngwE7MnBvhhztjkJ3l4yKp9cbMFJ/3Se8uRxTT36e7ug4GlQFSohT8Pt6juGsZ6D94bIe34rT1Qp6DE6qn7yY+YT0sQ5L4PxKwKmEm/un2TE8644Asa3v7+Z2dwqKvA65IkjqBbCI5i1ArLzrhgu2ukkPpJZ1caA93q60UiNTgtV10Dem2A7/g/1LBAak8UD8AANiHPVLuQmK2Y+GnZbVYNWvI1F13SjXD4l6NJ1xqJLSPJ1r5bn3ORwoEUhMjfBoRNIOqUzFyHVDavUY+/edCmEEHvvOB+OE++5tbIiFDuYuxbBSIy2bQn/LnkHUGnLRyCUK1fjFzR183nGQxZO7HN+3fNWbgU8zdMEi/kY0xl2fV7e3i+ZwkWgnsbis4zJvJV3zNffLILJkeGrDNWkb+s/3sgkrp/UizRbxxF7B9V8wFYTddQD08wry4or4wfpe4p/fyXhULY5oEtk1kwLXyYN6HB09/Bfikp5E7hPuecxRDuRyNgo9Ui2Ewyx3VmQLQG HBSYMlEX x4QzXNV479aCKifQiblH7bpbyhRfgFKSLbk8STcYmoZjQ9w2DpedPZY32p3K6QbsopcuXAsRBt3G1gh1I9VPXf9cV/cmKp65mmPK4cGIifNJ6Pfm2sb5NVe+2FXE2zqHJwrNiosBmy1L2EkLU/VfWoNjdfFiNrLmTxKqgPy6TrgPyEpAubWkZKCGJtGA0me2r6IbkIhdSDu0GkMD9gfJUT0oOrMu38yVNOwGDp2KfirN32t4Zxs91Qc9rWoZ8cPEkrpfjuPZhY2t+Lvaz+0JGAhxLcYuLtKTbi4+Id0q0MNBoUMGYb7tOuK5Y7SE+29YI70MEqg6OB9r6oFIw39gP8jaRCZXuSdsTIl5KAb1XR051zALN/eahO281rM2l/rpY+zds+WJaK885xf8EhYKSPcpZRgy1lMMOBP6a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 26, 2023 at 02:16:19PM +0000, David Howells wrote: > +typedef unsigned int iov_iter_extraction_t; > +/* Flags for iov_iter_get/extract_pages*() */ > +/* Allow P2PDMA on the extracted pages */ > +#define ITER_ALLOW_P2PDMA ((__force iov_iter_extraction_t)0x01) That __force makes sense only if you make it a bitwise type - otherwise it's meaningless. IOW, either turn the typedef into typedef unsigned int __bitwise iov_iter_extraction_t; or lose __force in the cast...