From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5316C61DA2 for ; Thu, 26 Jan 2023 15:14:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F053B6B0072; Thu, 26 Jan 2023 10:14:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB4E88E0002; Thu, 26 Jan 2023 10:14:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA3868E0001; Thu, 26 Jan 2023 10:14:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CB9F16B0072 for ; Thu, 26 Jan 2023 10:14:32 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 86D3D12026E for ; Thu, 26 Jan 2023 15:14:32 +0000 (UTC) X-FDA: 80397296784.26.11A7356 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id D0A9040002 for ; Thu, 26 Jan 2023 15:14:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QgrN4+6H; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV+4e80b6db3bbf9ecf339b+7095+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4e80b6db3bbf9ecf339b+7095+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674746069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jf0GYlkID4WfHzv9bLTw/+0umA4SZs7LmCsUqDXilJ4=; b=Zolk/gWZ4Tm/BpaGQheb4NbKxJJCDulagHOcByH/sQL5qsKSGDSvsSBMriB8xGk7HMBqVK Pr3pSyo7hl3L1Z6JQz4HT7hvBjW6J3EbX0vBrzNdlogm3ir7KThmctqkqJejZf6cVBUXx+ A++Vn6P72VHQBYsth7PMKvfnPIpIdg8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QgrN4+6H; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV+4e80b6db3bbf9ecf339b+7095+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4e80b6db3bbf9ecf339b+7095+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674746069; a=rsa-sha256; cv=none; b=X/IXBZTZWEYKyvwJX727w3yxYFyUHm6EPWyHVafxFXzNghJ6A5V+68ucKWNvNDiKEMpPSH pyhr74OlT937v9xt83E0hwBoSDCS1KnDX/Ef7q/OUY9NDFNzSNunzFf0ARNVSzbebWg2RY RtMxk3zfBi7yajYQhti+SV8on5khUO0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jf0GYlkID4WfHzv9bLTw/+0umA4SZs7LmCsUqDXilJ4=; b=QgrN4+6HqfZ8xoumbUmAGVXdqP V3/DBO2YX15rUYgjoN9DvriVOWX8B2PmIyJfWF0wqWOACDGuzhIaiCdG7smMtUVOpqxuTlGzfSF9j bQjRvgwp6NB4YTYWEoVD6RIvW5t3SrmaNTZlJqmMNEpVJeTTklB9uABrJ2uZ8FOZReb8VYR2/ruEH YMvzWw8+ERFV6N3HrgVHiItcJsgstfLipVb+fKQGgVgRsYQe4sWg0cBx1/bHcfh9z9UduSSaGHlOx lMPtv2QaRcACKRFrqseKdsE1JTvaVCz74i84qn533KpeJ9hthmSpCZX7Uh1tV8V+NYeE9apl2BoBi 2QcL+v/Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL3xA-00BRFc-Mn; Thu, 26 Jan 2023 15:14:16 +0000 Date: Thu, 26 Jan 2023 07:14:16 -0800 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Al Viro , David Hildenbrand , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic Message-ID: References: <20230125210657.2335748-1-dhowells@redhat.com> <20230125210657.2335748-6-dhowells@redhat.com> <2642148.1674732850@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2642148.1674732850@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D0A9040002 X-Stat-Signature: e7w17hexrqurzpr9mxyg4urof8yxm6hb X-HE-Tag: 1674746069-37691 X-HE-Meta: U2FsdGVkX190ct/u+PQgoa50tD/GgTRivliMtOxJPyg//t0UfS6Dh8qvBFjGyDgBjpF1dyx/xqOSxEbxLbaOXXLsheBqQochsO4iKDNERM7HHkmsiYfboVUuZ7+aLJzsVvjdxFy0FyYFSxjSb9P/PbrGyjR5HNw3V/2HWmQR7DZ9OPVYVOGx0I38eZLMQbf9ScbVUSUDfFalx1+1zfSXDkWeDq0ZiBED7ASQMipYivUYOUYzBGC7X0bzzjztOr1fww+TIyGItVwoEAmx8vwrzpEa+URkuTxpJVIFbeCRVX5vZcdQZUBKC6KxErdcs4I0TzDxwIZ1qY4KqCbe1ImjLnx2Cn17E8oZBIM+pnhC5S0Z3ONVMuf0nRNHNBuLZCvtpLIu7payt4jxWkud46TKZKReRdGnzUmxye3PN6s8S3zEYm9EvMjD6XpHOKA2sLrS6b1+emXM7QH0+LEFhzyWJiRjSizt7gTCcLPWLyztbYtkI23tVTdcsB4Nu8/zh12jU1DC41M9iS3pW6u3wsrIDKAdH1ocuEih3ZLKstp0wKPZWG5+OL9fPL0ls9fnF5x3hZkoH7fonHGOA3962wJfnrS4rZnk6+4ph6DmfVis7nvFctWoN0b7AtjxkuEFBIhdntEvEUZ8d62FetLUur3oADvXRpDg3vsktrJ7WJ1NpcOli3r1CjkRgCVhPJ85lbbBu4gG3/GqxjbF3FxLRU/IRATuUelxQsuYW9LG1eeeRCxfUCSWInfHZqI4Ww6Y/UKYHRBsxkDKHMm+teFIJIELzCz/4G4fhjyvfKsZrk5sF7XZ+f2yGznb31f8Ul1eO93ZXE5yAZJ28aAjmA1c0aQuJ41uYGy8bXo9EKYqw5Ezwlvpr9ZQWyyvisOiwUuWEMU1IyfoSZbBlXibjEAS8kBNFfkx91MelrUj1nnyHG82O+VXJZOswdMfLEtAxVJnjUbZsnwDIVQKqPu3KBMgFZf f7fihxP9 bX8Y7haEcN3I+4BK4OAl71B6mkzdaHK5ExpsEH8kG222eJdt34N7TMNWctrzB+0W+NGyyIjjrVwTR4XWgOSLZKdJu71b5AFGLbI1m+i2WCVtS1+mLgPZsVRIW7b27dVck/wt6oUgYPkHcIKfniTBIfiH3OVTUZeQzaNcs6kXpzDYZaxGPzPhP4bHdQ61zK/kjPqNvc67+XJV55dB0t80xwc5TssQPiGUEb1dT9nSS/IRj9DZ+aH+MHSGn+bUxXGZeJjM0k1hKMjYICHMtNWAaFrTSe/qDXYD1KxK4xVs54xppg0/uUR5P40gKHrjPo3XZ+PfQOZafuDSVBsVuhUiNtcCSBlbhZEgT1NtdrgUJmcuo4gGDVr8j54azFJb+fjIvzyfXux883EMPSbia+QbNKKIkS8D1Li2cD35ioyHESs3J8UF46ocvzzJUNAsG1Zlp3Lb5ITdLRbi4EDcmoSyu+siS3GvlCw1r+o6VG3Yw3aZx2xeH/YHjYmffVk37GIDTK8Qlibpk2+Nuzo9yRDmBJSpJL3PkuR07tkLfbGGkYFvg7RkBjyDN+cMDjO0hFanCUqtzNGyD2FZKl4yJ2za3lOi5s+gv0Jva9g/gN/mGYxCjqzlIfepVKt0fTZGmBmBsPbveP1CLsAsPU87/M7bqQsfmtcYV/ZeiNWTv8j9d3F65fv5on1EOGO7fCD6W/gF7fM8iwQFLtI+b5x/RW4ryHv76R7SiV6w63Kx45cCSO5FPVIU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 26, 2023 at 11:34:10AM +0000, David Howells wrote: > David Hildenbrand wrote: > > > > Signed-off-by: David Howells > > > Reviewed-by: Christoph Hellwig > > > Reviewed-by: John Hubbard > > > cc: Al Viro > > > cc: Jens Axboe > > > cc: Jan Kara > > > cc: Matthew Wilcox > > > cc: Logan Gunthorpe > > > cc: linux-block@vger.kernel.org > > > --- > > > > Oh, and I agree with a previous comment that this patch should also hold a > > Signed-off-by from Christoph above your Signed-off-by, if he is mentioned as > > the author via "From:". > > I think that was actually in reference to patch 3, but yes - and possibly a > Co-developed-by tag. Christoph? As I said feel free to add a co-developed by if you want. But more importantly restore my signoff from here: http://git.infradead.org/users/hch/misc.git/commitdiff/37ea178d5d95166196112905aa75d85cb0416d49