From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72E6C54E94 for ; Thu, 26 Jan 2023 15:11:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78D8B6B0072; Thu, 26 Jan 2023 10:11:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73CFF8E0003; Thu, 26 Jan 2023 10:11:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DE3A8E0002; Thu, 26 Jan 2023 10:11:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 508836B0072 for ; Thu, 26 Jan 2023 10:11:21 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2713BAAF75 for ; Thu, 26 Jan 2023 15:11:21 +0000 (UTC) X-FDA: 80397288762.18.A02188F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id AF731180014; Thu, 26 Jan 2023 15:11:17 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iqmwaHjx; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674745878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EH9adbDOpWNaGYEHl4xrAV40gwHDwqK76tq84Z0eyXc=; b=CVEN6Ut19T6MhqP9XrCC9A7t1RY0Kd4xNcX45ZhkzTrSZ/4OFcgCN0cjQRrL00azdvoMbn /j349vPufM5uxt79eflZxiXx4cPgi53U9XznpVoRgDGbl2tiTAuXZhZ/DMDQmT3ISJxszo rWVlfz2Uqq8ZWEcg5i+JOy9oQ7N22VA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iqmwaHjx; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674745878; a=rsa-sha256; cv=none; b=PvxFQZ5iJxrWPEngOw05ZUhV9Ese0RAHlD06KLMaL+ygunHUsbEUSU8qZgZAFK5ShPBOrw o+jhQNTZQTAk4cwoDYdwRnf3GuuEyFfytkQRQTdPbEneyS7hTregMUFPBfJS3kfqTZOyuh y/VSyHkAjinIr++enEVZqsK21ba34Ok= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EH9adbDOpWNaGYEHl4xrAV40gwHDwqK76tq84Z0eyXc=; b=iqmwaHjxa8hZXZrYCzuWMxG2Kd gUi1Y8eYsd0omFHjfmpVdNaehwIHED+H1VzLiTscJu/MXykaHjjIUo4/UeePSQ/3qO2Scxl5KBcbs rwafzWiMp0gW54lDXpQNTGojrzBrhUSE24qBNrz9Eu8wZKUKM+VJeNVRGRDui4Mjh6zNrJRA9uXJe 2WKv1rttzI5041i+Ny9WQoRsYwvuy+Pu29+WLEfQrszB7lQZjKA+bZ/4URx7/yXNldScNG2l8YeYl moQR7vt2oRKUKukioTBGNdLmNI+GiODuZUH9eGz4sLFdnhDHr8CijQAXVN9xNJqlnGwrCU0R4Kh9h Kpe2WfSQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL3s4-006q4a-Hd; Thu, 26 Jan 2023 15:09:00 +0000 Date: Thu, 26 Jan 2023 15:09:00 +0000 From: Matthew Wilcox To: Mike Rapoport Cc: Suren Baghdasaryan , akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, will@kernel.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, chenhuacai@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, qianweili@huawei.com, wangzhou1@hisilicon.com, herbert@gondor.apana.org.au, davem@davemloft.net, vkoul@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, l.stach@pengutronix.de, krzysztof.kozlowski@linaro.org, patrik.r.jakobsson@gmail.com, matthias.bgg@gmail.com, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, tomba@kernel.org, hjc@rock-chips.com, heiko@sntech.de, ray.huang@amd.com, kraxel@redhat.com, sre@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, dimitri.sivanich@hpe.com, zhangfei.gao@linaro.org, jejb@linux.ibm.com, martin.petersen@oracle.com, dgilbert@interlog.com, hdegoede@redhat.com, mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, deller@gmx.de, jayalk@intworks.biz, viro@zeniv.linux.org.uk, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, bhe@redhat.com, andrii@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, perex@perex.cz, tiwai@suse.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org, loongarch@lists.linux.dev, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-stm32@st-md-mailman.stormreply.com, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, kexec@lists.infradead.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, kasan-dev@googlegroups.com, selinux@vger.kernel.org, alsa-devel@alsa-project.org, kernel-team@android.com Subject: Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions Message-ID: References: <20230125083851.27759-1-surenb@google.com> <20230125083851.27759-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AF731180014 X-Stat-Signature: wqee3t9qgmdoewesw7aogxo6pea6hzxg X-Rspam-User: X-HE-Tag: 1674745877-707754 X-HE-Meta: U2FsdGVkX19HtRDijkd552iNuA6MZaEUbbIDDaB746wB4FIzFmHahKNTHhg6do4asb/C2oVTc6AexiGOMFPOlw9Lbc9l20kCuGDwdWcf1djx13v+b+PSPosLbguWgvY4MXZz/gag3kgIj3Wndc9EuvNqG9+K86EeWu/Df2uoIVzIYThnZFPqDZ0Ua3VzvET3WCFGWS2tS+KXxOyhIl2Z8CB6SpSw77koMF0UCQqEJahZeS9C3bCqoWO7mE4b2M1449G2oChh2d4gjrdQfzmA9CEXwm6qXryn8MNQB9X00Vbwqd8gdispiP1NdcCfs9C6RAVGu0vrPdPNr5zfC55W2Pu1U7/mkekPaF416g3U0uelj/l8H/cmlEZzexh7Xj8DEC5aMpHG31ZZRhigGY3cY7+PPzo5SNfzBA1yQ4dwlihOuK0PBCNg+kDnwBP7JzI8nt272YLDk+EAZtOwZN0jKvTDne98RychyCwciMgIymcSCpMsK9zdREnAetPBuXq+XqClCKo3DGbLPX1mmom88zBAoI/JEQlJJMEgfg3HOCqV3ApnZoJPaT1vVJss1ZU4Ea2/HYiW7jAUaqZrfzLufX+CsyoNCqEHlLUnDwr/H0dgFWGeTCznV8hIgsqo8z5EVJFdkt+oNS3LXgPjQlOIeF6H5GHcuU9Dnq/KG5HWcuNN0+bZCNPWlZalY/GA6C0xAX7Rsv6XhUWy/Ic8V/NOJV5+NE2qdEU5VpoGIJu3UWj390M3PPZZ/BSfOTd5tdGoBUQZLuQuLSLENrPN1pdEa4j/FYPmtv6HJxzO+sOQitVMmypXqyEkj/lGZX2JqtQ6Fr6fjUf6A78jCljsrgs/no1+Eijm32VphjoYnVWhZDVsDa2wvKsJd1cfznCgSjntm+0o+Y+21oyxsTtPMkR8wM2ZoirA5uRKgnr0jS6dc5vLpwTkkZoo3XY/k0hyUWs9MyjU9ZuPAELiQBFIlww lIclRL44 BKeCqZ7twON0WQmikoTXtzPP4WduGCGtZIh3CPeCoqVGj+usmCTdsvWgdi7zp2wInxDQLa6vPg9rPUzRLiew9BmgpTOgePIRBtOpTjkQWA55VBAL+fahHVmRuV6YvX7imcRVQn6s1dUtJubgoBehyUf9hgoxDUNsveeAnjX2AkAQCI3ryviywYkpBNe6HMF6Z+VpeiDs/ZyaVdNvAbjVL42LQZiNTGMOIThmfnMd/Z4lE+26dlxPPgATFktuwSXkHRjoH8GVYkQVwLS4zBqSeDakO2ALFB7BZ6PqKBpMaOaJvf6HB5f86mBqeSwE+4To0TCT987qWpS4SVgLUIzW6V86SS7YdFN1pRlhFUshvDNH7vO2wsszI0lsQQAXUehLU7Gj1p3YQrqYO2SB6GMmZFplwYe+dEguO9bYW1XkYDoHs8BsUKdoL14yNlMI/42WmV9eksQVGjUGXDBnSdLqt68ebkzwdfyN/bog7NK5iyzOY63dZ+0ra7XB5NgN/0Jm6eoUI6mRDrfmvmgJCnJsGWVytN+hcwq2GwaYCzrcLSlxM1y0TiO5lKEppws9T0iv5WHw8IJDG8PNt8yLbb/WpqzidaA+9JIt33sKaWq6osI6VR154OdZRzNaXLhksfurApHVHMDQ4tziyTHL02OntIX+SHA3Cw0hvYRMuKQsN55krezIO1pxw5o5ZqquhCJStoE80zJNDbM2ZGn5bH79YlWrH04+sOj6J6cf29PLca7ho9Q4ZzBxJfwei/zgLzfwa/jZm5MZeD928je98nzTTCvFoylRBFLrmryjlwrr353t8w63Mg0u4H0bywpaddFdYnrgjrx+t9ojFwzeTDalRQqppcwtA68FzVwQGzATKkVKVlkDhvbiWQ1kuLtYE/R+91RuXhKFZQG9432J7lMLSEHDjjfIR1D/xGync0ndMCkCm5pTdNdsFcho9nNqbZizS1MgZITGZjupCEBVHQmpneHRLwl2M ygtS+Fzz NTk0e2X4J8+V3IyeyGrEiERIeucfWv6lAJVeiDfHfx2/w47fbszoyoVmgtJkI8VxczY9uRPsQNDTDo9uYXMqmQ3rsUy1Pd1fUsciXI2eYWrqSOXLfAuyHM2kZRyl7K9r4etQcmO2ZhzK78mtEBRvrNDwVobEHNJsHSJjCD/vPn5q1EaBuBgDSWVfI6bVcS2fGDM7kZZWlKSBoBuTRpEMMSZSUBmNluE7BAiTdYYterobky6QAsEfYI1BhR93v9lWIchr4QL+/1si0JRlEib/8JPZSO8wC0xhXnDuUwM6im3FNXFT3G8hRWrcDHXOSXIA5C5ka0rDvHyQwKqCprpDUItymZ0dDObgUzg6t7R5HE7s+lGvuAobZzuSrM5kpt6iKawQfQg5A22DcxYcpPN8uC14UX5zpCujNZUKLqWuCwWgeKdAnEziuOjbLHbO5UsDXpcVVIoyo0WLWFGreLLkMbypkzvASL1WUxtnBiMjz9teKHi6vxQ88FjJIF21k65CVfF7CR7+vy7yRP1Xcck73oFrSVkpLedfEsME3LKeOYrJpQxZWD0tVPdQgBWSsq/4ZyPmKfHJh/vxOGf4vSisErsEUe9SJI8mB639IMl5VoaHchux17MIA1LiB3Ra1gNHaOzkew6JkYhNlLN/9ZBeEaXZdDWGytc4MQ6tEmYCQM4eDxAEZXhmYNGvaQwYyLKu77vx/eUD7ntyb5D/dyaWsNs7v2dk4rendxhvkk3S9+pT5UBK6E5mtCDczUtEwegnfYAilLb5TZKg3QDT0bEn9RxfS7XDubgMTKcIbo536A/1j/nlEf85aXkyfToShGxZU9Tr5wk/WLY5uEEQkc/nei1pnFqSqIUm1Z4AL46oVoCVxUmQJ8tzSao+obvo6MiiRIvx4C2Qpplk+0kIjhJ9SKm+86qISt5JpKXATqvDTe3NNrHwTJrKVDoaTHC0t4I9r0RU9zRlMndSy0zEIXy7ISVZt9fx6 MA67NeXo UZ3zlzYevx5w4NKw45mo0x5Gs/2uD9XMZq/39AepON+Yit25Rr5pdMFSqbQLDDSMQ1B3Nk5OCwCzoOjtlzZLtez6c6dAST3rZZi7I8KoXFy1abvAdDCYqumGgoI94A7W/Nr13AWtvBHEgPh6A6Li2xEQoQQ8o+nIpW77r026cT01I3BFKYIUk40Jmv2kUvZsKFRMQZseLjixpy52zYfVHhqG5JQ1JEsgafNQP2PggFjqta4fMiy88LMH3R/5RaU6pTASLihUnw0NtWoo0/F9KKC2yh+//tJLcOe9rifsX4yFIuL7uvJCau8ljOnu+tkzfxpSrD9MsxW68Z66m8RJW3zykf4d4VKOTYQfuKNGjEDUY0CHilo+Yg+30d1vwroK/kzsZcxLHtvN4n0OnY5txk4HK++ezUZHp1cJEFu5kLFR6Whtov8wTzgv3QcWBgOC5q9Yhz0H3F1RBl4+G3eyTkaWSuTK49xnMVhMNg/WEc+0+f6q087xzvOLvF0XEa6boIyYbO1lUUW0+g1EvkoywsKoZRS/xzVCjRE+3GGnnMNNPUUkDOeZQZmO1wFKH9H5O7SHKy5RycptyY88p+MUfZvN0rhD3H7Exw0wLog0SZOgK7GDjRia4m7Pn49Jiwzf5WUJIZ1qO1E+zz6N8K2RsXW8GpkE0tNZXgFakqRIB9z6c3nXYMdJLGNuSBw9Z0ssphgKErsc48gV/o7HuvwYk08Q/Pg+t/hdf6PgkbwbC2DTHehXKP7vtS2p9r5CRhXzYNfnidy4QCD4d/6e8Wu+oJPVpP7WOG4F0WS/oj5D9jmx975ZkF60jZoT2homV9mwLe4BkndJ+iukgf/EsdOTUFN46wxy+2prfkfFhkiOa5l31EKzmNOfE502qdp24FE9ivWqiGx88mtQmMzCeDCNi83k8QFz+X1q9Og8WCvnezR7MlTqoD49o8to373KeMKR6i9bBW9rWBFqPXGQfiWk6QDqZ/slW FaUcPSv2 c4DV1xYs6dLP4Dm2XDkCv6LCTdJJs2vkCKJwkkV8KSKSVbuvn3IwoitSLIe/37wKojg+/gU7YC/T7sidSQyCJ+fCHXvMas7iATNxmDrbVC/LkGX4QyFEHl055qJkYpTP4ul2SX+UJcLOEheDWPx43OBcXrqcx3kfGym4fdtIpV4IPGQIKVFFOzto0gufnRQ1zH2WyxPENMtQysBvKc4bgzDI7YkkZ4WuW5q6oKGTFKUKQhgN6XoFemOUuaKDbETtLWqF0xs0tw3FDzPS/5s27HxCQzWDA1Me4yLSa7hje5V9SSVQksIlGXs1PfMgDS/q6QDt5OUbS6aYgo7GmYHXHkVIRM38TmxmS4dFC0sslX7UjoSxJpynib X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote: > On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote: > > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > > > +/* Use when VMA is not part of the VMA tree and needs no locking */ > > > +static inline void init_vm_flags(struct vm_area_struct *vma, > > > + unsigned long flags) > > > > I'd suggest to make it vm_flags_init() etc. > > Thinking more about it, it will be even clearer to name these vma_flags_xyz() Perhaps vma_VERB_flags()? vma_init_flags() vma_reset_flags() vma_set_flags() vma_clear_flags() vma_mod_flags()