From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C596C54E94 for ; Thu, 26 Jan 2023 14:51:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C57778E0001; Thu, 26 Jan 2023 09:51:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE6158E0003; Thu, 26 Jan 2023 09:51:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BCB58E0001; Thu, 26 Jan 2023 09:51:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 79A2B8E0003 for ; Thu, 26 Jan 2023 09:51:50 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3689AC0AB8 for ; Thu, 26 Jan 2023 14:51:50 +0000 (UTC) X-FDA: 80397239580.19.E104BAC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 4BC81C0011; Thu, 26 Jan 2023 14:51:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=r54XDevq; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674744708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HrtUUguTsc3q4s7c4LcTF1DMLDGgIvDEx3lNG8Wbexc=; b=jbi5cZ1Ek6W7uZc88mLlpQcvCXakZSziCaiGGoW22MxvuNctwoOejmPs8YZEC7lWGkELxV 5nLbLRY6EkxAsndksJvHapjDsG5lJtapQq6sEkqw9rfzGjv2qVCtkK4eInFxiyAxiVdYBz 5n6zxqGkW/oLezMDpkMXcD6RgrrHtKM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=r54XDevq; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674744708; a=rsa-sha256; cv=none; b=yKreGE6G7w/V2DTu5pXXdmaZbWMRuk9dTyHa350dh0cCjW7Mm+unyAzYsL2Ct2FjmI6uqq v5O0d8Pa3F8f4O9Ym9iuQjRGjsssyRUIStiqbj8SiDMwjwfcLe9PkZZlOqkKUsvgbucyOR Iowqe0s4WAL7VYMIGKHnSVf8BRvpD8Q= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EA0C61756; Thu, 26 Jan 2023 14:51:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3695EC433EF; Thu, 26 Jan 2023 14:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674744706; bh=vTtNm5B4uxkFGkyUcD6bt7bUv740cC5zoLQ3n4iCXig=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r54XDevqCxaIthjhpV90e/3PReNDit6CxkjYziBMldcr+DpwGPcGH7s0yFhPlYu8B NohDoJ7KVIUCX5Zs7V0ydKB7t9XQRchAYOCR8XLnEbVPCZ8e7MIHv0UEcp73VODAq8 aFhcsGcrVCc28IZRly/gODnl3cguu4R9trJCc4u2GtQ9ygUwR4IFSGftEKj188geBR 3987kGANtDLWA/GzBI6W69E/F450ClXU14kAngo3y+A1wCivQR2InkOef4HeCwIwVj QYEspA95Wv7WS3mfCUr9QMGnsDd2HsZvTUBOWl52ZSZiQBqHvpwy1Yy3PsmXixNWVQ B28KDvwGClVRQ== Date: Thu, 26 Jan 2023 16:50:59 +0200 From: Mike Rapoport To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, will@kernel.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, chenhuacai@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, qianweili@huawei.com, wangzhou1@hisilicon.com, herbert@gondor.apana.org.au, davem@davemloft.net, vkoul@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, l.stach@pengutronix.de, krzysztof.kozlowski@linaro.org, patrik.r.jakobsson@gmail.com, matthias.bgg@gmail.com, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, tomba@kernel.org, hjc@rock-chips.com, heiko@sntech.de, ray.huang@amd.com, kraxel@redhat.com, sre@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, dimitri.sivanich@hpe.com, zhangfei.gao@linaro.org, jejb@linux.ibm.com, martin.petersen@oracle.com, dgilbert@interlog.com, hdegoede@redhat.com, mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, deller@gmx.de, jayalk@intworks.biz, viro@zeniv.linux.org.uk, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, bhe@redhat.com, andrii@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, perex@perex.cz, tiwai@suse.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org, loongarch@lists.linux.dev, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-stm32@st-md-mailman.stormreply.com, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, kexec@lists.infradead.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, kasan-dev@googlegroups.com, selinux@vger.kernel.org, alsa-devel@alsa-project.org, kernel-team@android.com Subject: Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions Message-ID: References: <20230125083851.27759-1-surenb@google.com> <20230125083851.27759-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4BC81C0011 X-Rspam-User: X-Stat-Signature: g141qimdwc19x5syfuwc447q3frqwu3k X-HE-Tag: 1674744708-902593 X-HE-Meta: U2FsdGVkX1+tHmd3dJlQDvBKfAEr+6mXaSOdWWW1m3d0wwjeatUXaeQwOLgOlQ/LMXeyHh+gz9lOFoB1wcFmKoRsvSl4lCzsFxArYUQCUZXkChZUypTUehYIginX0MG7sU0Z2uER7Vj74x5xXtCgvhlMwEiCCNN4Z/wljHG+uxNhm5BiNzkzu7Zn+JRqTq1JMZFnqtUqPL1KNZxS5yJd/rDv8OhwwigVGPzM4AEgLVKX6gogFi+QMw0GjAhX+8AJCyseen4AVK2CvL6WG6Hfs0VFZZFccoXvWINIhRjFYLVgYtC5yAKkfmKlqObfSy6rvwdADTauTYG31f02EKHJUV/huP+0tY1qQxpxgc8eaTmE/l8tL7bO99PLaRFBsmXzLE1Vr9wlCSwgak93HcsbQA8vql13XoBANoOFbjViXQ3wbx7WH9jAuKpJv9PsWMu2oqb8X89d54dsZSDiHNqsTZC5Ewo+URNIgeQmr+F1/eYRBnDT+pUdqJfm77tkUk4OU32YOReflwmiShvkUXYGmhUr4/LxajHDVC59Q88cjLmPX9yg80SxY4EEbPBnKFmsGeX10HWz4QEebrTTrLHbexI/n7TKoGcae8ISYOoYc2mRADUyQlzt10I5jLprgj0L2lFwUAOcLngJNYKHuswosYVjzeirW4vebAoXvsr4mbuEqFtpALujreyOdF6xuCjb+MxTCFqys9lSRqM6s2yOUr3LYl1j+/G9tT/ViRPMVeyqQl20FHtl5PqgcjSDxijZE8LlMeMH3SXGqhtApqtJbpYK3F6YRd7e8rY0cRNO0EwMEVu7vL2ZHHsFVCmO0cg3kpmyddaKVgpA3BN7txeljRv1IyR/DK4hi9apOeMkjuPbdSiYHYFVyHxTbpuv42A4FhyIASKPjND7REpqaNstczXIp8g1oVhYg58lmFnVHSdrp8ZJYrhknQv8AW7vsyZuFz4CYrCpktqDxmhhzVw mAldYlVV /FXTUHnEt8DK+9z6Ts8lQgPqWt/nC64tIwA8e7R6lsmCQHpjgYiMwKXgbn1VYrKic32m0qTsk2Vq5UiJmgIfOHfiGIT/ONvovlX9hUu9Mo09hcIYowMZIWW5r/4yArIhIFSVBuZ0wkJ2FYyvsWWr49XzQ0E5InYEJrD530sAcIb/aK9B7nFt49jRL/HToImK97gmtM/M0//giBO6juZz7UhdBvOulHzGnUebRZ8xpvcwu12u3EDqNcLpQtcZKr6xjGXp9nEG18cp3ahrBlLw37hcSdDEopWD9RgUX7yvyqlR+VU8HFPPu9zmjRFXk+W8/I6pYhpe4UePwCJ6Zv/Hu9iMiov7IipmT3qFpoSvWsD33i4Okyf9PVfoo4ZTOIVHMcYdaocPtkIe71FIJwGA1Vp+6ujjr6FVaeunvPUZrzOzWn6ROsEeawfxFA4eVpsnOHiQzA2f6tv0Uvy+A4icudf/vAl2Ucy1vXgoUcDiTRJcxaaQ6V8raIVoJvr/thyBJNJkFlG4EULAtVhfzY8K5EPAV6ZBy1Ya/gOraVX9jFvQ5FqfH7tDfBZemcpxK6IHOeeRidn0/Bjq8Bd2WLzewKpGrTwBDMt/cWgoj0YhAjm+yJuMEUu604wXWftDSPp2Kz4gbSmvci6fTVSeTHuVOC/NNEBCcGIF87ZgEuMW2EqvvukFr3oIFJP4SRTnoameVJvmATEYnBGVOkKED84rO1EKUl/IVrlnTxdddrCPLdDexdFz0bVg9druePoepQtCoWxKh/xTrT7zecIE3kJxchjfY0v5VmGG1N/JB4xl6fT+sCLxAd9OqwxIVl6cHWoNomc+5CqcG+n9Ubj4cJu85ZplX38I39xCEAtW5NC5ZgGDFTHE/keNr/LmmYEhVnsdnkcLr/DyOXhgiK1k2sGDoR63K6NjBSzI4fjFyo7p7pe+3m+Y7vzqyexL4vTpIHfUkGJFTzNqYfmmFyjoC6iCdHKSV+/qp Mev5PiS0 8GUvMaCYLILGTt0Mywg2HMmUqqRJbFfsqH5qv4yZxtHlAsxClyBZr5K9gJxrc7rxwov6wHx1vuEOFaUSQis/t10Waaha/O58V8jPrC0fBxX7hXDi/REsVc0UWNJNjYtJVN/kboAuey8D+Qz3Ov9l3qRVdNzF8bX9IVkUOjvvl1SWmMwhYElleeUZwKMCrqH4oH1aWvnzlI86ce3k4vX/XAx2Mtk7Kc8oy8xP0o1b4Ys3glk2BIdA49RSI+FV22y7hQRBwrqafhyqCAR6el3KUPKxdVkHQikPIZr8+8zeIukP4rjB0Wb56jp9S82HmtzIKfAEkg7u4nVRGNNFO/yOKUpq2o3QUDbYDkCXeTqlo7gJYgM442MsUt0vNSd8x0GHL23CIrvCLu+1vRmk3TjQRUL4EPTw0Lxm+LmyZsU5l53yBUeYFknQzPDv4x3hBWjMyDIpePquhaYKMi1KJ3UzyW9+Ew8xeehwNOFnKy2ph6NbMoux1fe1i743J/Fv1LP1IYSFkLFdqp5b2n9iyZLOITAA/9Tc1G/uKu2VZ9SFju4afEgvsdTbC5NCzaNjd7sGpNQ/H7u5NAV+qBnW2FZBIZmYa0g77Xr18Wc3T3a9of1bLiP1cJeq2fmUQP6GbKiqJb/1LXEQ/Zga4/CDJVE5JHdLEjFLcwqTxVd1tbuVhgBZJQZtZDr8xi0M7WPl1ksdTfE0dFtQroABY1v3wYqOKopoSDI7ZigO4fX2zi8eHAbfa+IvhO70CArN7MOhbgduLSbm5LWUuysi5tVu2xGvKqKhVVYqZ/Hi3BnOBihJxNsyzLRiMaPETPG12/EAk+KxaFCpMTLwmiz0Wzq2emW6sX6O87UbUpd3bCJMDEVNyHNHAz7SDkt13QmjDCc46Qa/2mj2yp+wu9vQCCwg25WNcaxh4sOUTMZcKD6Yp/Xw3loMU/2xc/urBTchPBpvkHK1Q2T4lcycCUsgVZ71imm2f/mDJakVl 0UHSnKwW MqTviq0X8JoIo0j1NVH8bzXzf+V6jA7FSNYjY8pdoKr5P/K0OJgLoCxvSXomdjS7rpeWB4+1WV2oidQCg3HMRNjcGP4w/mNxw9SDjCWEV7jMpejO1EtnC2fmWBgS0o8YC0QEmexVq4a/mfCIrpcStXo3riSQpovVOYEFQlFr4gYNTHj8wk0KVfU/D6RA60hah4UvPh1PjGI2yTVQItwPpV5Z2deZ24ckYOQQHWyhJ3zdeuFjicXy6hm5M12Zxm84N33VyVLcnhiL8CFM0o4FOMOOa+7gh9iK05QEadB9+rtcSrESt1a6wrCSDMe3XZbldJjRGceMqdTNyQR4/T5AiC67722AXZ8+OqcZ7S969JF3GBIY1Gjd2OLh/6hGtpzxEzxnLW7v92LdM9VIk8UWEdUteXRmm8H1IrTKd5PZB7vJuE5he1Zia7hG5EdHWXWlOq3BQgCEF7I15ZMu0gjPHArME5z/npj6583FlCyZJJk7TPN6+oZANy4EwFsqHuPe7a5gGroJklenKVm3y1TLO3Mli05f1OPchnLGkeCNfYJMQVC9NWFDOyyhp7fWQ5AxpOIyOTLloGRkR9+7o+Vl8ahHV8lH7DvNGD4cpfqYapcBUOyKzg9YncwDAUQJV8+WCJndUAvOazxl85qhLji4+2yHrPpZyp6xvs/8Xd9XZONiwlQT65898nYOGsRgH986uOuBKAIdWIiU8og1gVX3j5CgAI8NaPbWoVcJhrOW9ueAk7T1ndpZeJlMs4ohl3WpeQV0+Eepf4lSdvMhbp3W3L2AAEWF0N8UbxhZqk/5j/M2wcjW/NapftiEgZC+V0XRU5ueAPxdoDrzWfxcioq7BLChVFySSl9z54tS835ATGSiy1VSRfUCvcqezJ4TWc/vuxq6fnJK0HaLAaZFD6QGJ75TOmndCwE3IH4A+TyAhDyfkacwlEY5OGCCKz3QzLrX7HdxHUJgcMhf3GKBFGneSI0G/jmQv JZt0foDn vsfm6+SVLvI5HfwpJadZWjRgBIltnDwQoIydxIirIFZBvOYFmcYjp97qyXxsYiDz7RSzgPBtoi76AeaGcn67uYQTOUzR5LtP7THOtGdE6kG5a2geGvGKWRJhpXdTC7/MJ5S6Bczeqh+SmcH1fA3TEI50nFXSNP2PbUFnJjmNgZs9RIT0oo6rbHvGxcr95PR+2FvxFTVURDSCzVq4uJPtnHTrjTQhwuPOZTLIt/llol7iNPGVEZh0JHL314WfkrJiy1BSYoOf7HofVuM6TARJGFyleSGYRwcSdtlBvwALovOC1C7dIuWAgpGfR0a/R+VF7p3bbVKZpTLeLKGxtid0sx4FC4WAlhcgzojpBzKRQ7FFJkt86yzOt/p/ZRCGAboXeJ5zpLJ3igspzKE/ek3rTiU2kpwqCQE+uhvEHhnc0+SywKmGPD7W1gxBkmqtdHZ0MUEarTmI84jPly/+cxEWmTwOrfElJWbqaHWR6eZccOtYlzBnTPZjYKnbRxlnjiLVYoOzp8zomFEFfDsq4/DyPN/Dee+o8cQgYPMjcfq4F+s2IwGLCdsl7WZW5xrgojivRw5vC1FbRij10LbzeUKIlAyt0sfRKCmlE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote: > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > > vm_flags are among VMA attributes which affect decisions like VMA merging > > and splitting. Therefore all vm_flags modifications are performed after > > taking exclusive mmap_lock to prevent vm_flags updates racing with such > > operations. Introduce modifier functions for vm_flags to be used whenever > > flags are updated. This way we can better check and control correct > > locking behavior during these updates. > > > > Signed-off-by: Suren Baghdasaryan > > --- > > include/linux/mm.h | 37 +++++++++++++++++++++++++++++++++++++ > > include/linux/mm_types.h | 8 +++++++- > > 2 files changed, 44 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index c2f62bdce134..b71f2809caac 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -627,6 +627,43 @@ static inline void vma_init(struct vm_area_struct *vma, struct mm_struct *mm) > > INIT_LIST_HEAD(&vma->anon_vma_chain); > > } > > > > +/* Use when VMA is not part of the VMA tree and needs no locking */ > > +static inline void init_vm_flags(struct vm_area_struct *vma, > > + unsigned long flags) > > I'd suggest to make it vm_flags_init() etc. Thinking more about it, it will be even clearer to name these vma_flags_xyz() > Except that > > Acked-by: Mike Rapoport (IBM) > -- Sincerely yours, Mike.