linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Linux-MM <linux-mm@kvack.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	device-tree <devicetree-discuss@lists.ozlabs.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Jessica Clarke <jrtc27@jrtc27.com>,
	Geert Uytterhoeven <geert.uytterhoeven@gmail.com>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Chris Paterson <Chris.Paterson2@renesas.com>
Subject: Re: [QUERY]: Block region to mmap
Date: Thu, 26 Jan 2023 14:37:51 +0000	[thread overview]
Message-ID: <Y9KQPxzHBuZGIN4U@casper.infradead.org> (raw)
In-Reply-To: <CA+V-a8tR1KiLSs=Psa=w7kf0zT=yU5_Ekr6-3V1MR==Wtzmksg@mail.gmail.com>

On Wed, Jan 25, 2023 at 12:30:13PM +0000, Lad, Prabhakar wrote:
> Renesas RZ/Five RISC-V SoC has Instruction local memory and Data local
> memory (ILM & DLM) mapped between region 0x30000 - 0x4FFFF. When a
> virtual address falls within this range, the MMU doesn't trigger a
> page fault; it assumes the virtual address is a physical address which
> can cause undesired behaviours.

Wow.  I've never come across such broken behaviour before.

> To avoid this the ILM/DLM memory regions are now added to the root
> domain region of the PMPU with permissions set to 0x0 for S/U modes so
> that any access to these regions gets blocked and for M-mode we grant
> full access (R/W/X). This prevents any users from accessing these
> regions by triggering an unhandled signal 11 in S/U modes.

I have no idea what any of this means.

> This works as expected but for applications say for example when doing
> mmap to this region would still succeed and later down the path when
> doing a read/write to this location would cause unhandled signal 11.
> To handle this case gracefully we might want mmap() itself to fail if
> the addr/offset falls in this local memory region.

No, that's not what you want.  You want mmap to avoid allocating address
space in that virtual address range.  I don't know if we have a good
way to do that at the moment; like I said I've never seen such broken
hardware before.

I'd say the right way to solve this is to add a new special kind of VMA
to the address space that covers this range.  We'd want to make sure
it doesn't appear in /proc/*/maps and also that it can't be overridden
with MAP_FIXED.


  reply	other threads:[~2023-01-26 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 12:30 Lad, Prabhakar
2023-01-26 14:37 ` Matthew Wilcox [this message]
2023-01-30 10:53   ` Lad, Prabhakar
2023-01-30 15:24     ` Matthew Wilcox
2023-02-01  6:31       ` Christoph Hellwig
2023-02-01  7:05         ` Jessica Clarke
2023-02-01  8:05           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9KQPxzHBuZGIN4U@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=Chris.Paterson2@renesas.com \
    --cc=arnd@arndb.de \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert.uytterhoeven@gmail.com \
    --cc=jrtc27@jrtc27.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox