From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25703C54E94 for ; Wed, 25 Jan 2023 16:28:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 437F16B0071; Wed, 25 Jan 2023 11:28:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E80B6B0072; Wed, 25 Jan 2023 11:28:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AF756B0073; Wed, 25 Jan 2023 11:28:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 18A576B0071 for ; Wed, 25 Jan 2023 11:28:41 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E024F80A51 for ; Wed, 25 Jan 2023 16:28:40 +0000 (UTC) X-FDA: 80393854800.13.D7A9F63 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 2186040021 for ; Wed, 25 Jan 2023 16:28:38 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H66lRNm1; spf=pass (imf07.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674664119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qzcI2cOiMLC6iyLbAYLrVK0a8w/r7U/Rv8ya40xtvwo=; b=zBS0SDlNZShCDqMSTT4fByc/pE8XAT338/AiQDb9TfDsCqIwxmVAngKEOSQcE/suUZYH5r /6At69KCAfPHYZo2CJMM8M3vCGBzdtUJsJ9UgG/Uxa2sWqbpqtXcTs5Hl29319ebseSvom 4VxNFi4O2dHFdYT30FKPo2COuo5y0gA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H66lRNm1; spf=pass (imf07.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674664119; a=rsa-sha256; cv=none; b=5747v4uqoIJhVrzZKhqggGUnWn6ZzNH8rRnhEHztGQSbHxeDYQkew5a3mAtgdna2xjiagc 1/ToZQGvc+e6YK1JffSFTE/M372EbrqCbB5BWbAXjGEDerH5c4vswiyMxqyEPn9p+p/IIR T84cioBLGBVP/uAVwmgZBhwOoqj/pjM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC166611BC; Wed, 25 Jan 2023 16:28:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E0CBC433D2; Wed, 25 Jan 2023 16:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674664117; bh=EFtrI+qkMXtuqv2/AauSnQYLbjXALjHF58RitU958dY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H66lRNm1bH8ABZeGBLaQk11C4esX8FmvjWLeRmGDWDbm2Mg3g3NuDCyyaTpayLpwC 4sBV7g/avgr7fLS5n+EjEM+SjaS0g0pmJArbUpnbEdmDHtJHsC+tjmvcz4bjAVRq4+ 4a5JyRYcGcyao7yE9sc2wYYkpapmvdsB/FlaoCRTDeIxsc6Srlkqa/1X1BPzpGP/p5 iCX6c+D/PHkT9D4K10VHOEhDhQwW93Idm/oNezpjLANXPDWaC9lHCIqtYifhENXuQe RLw1KyXCdcnCUZMS93kV2vX48UzFSeewNTORHXQLaDnVLdz6FDsLwB2D8Pgh/zESjh 9G6SmhI66fG8A== Date: Wed, 25 Jan 2023 09:28:33 -0700 From: Keith Busch To: Christoph Hellwig Cc: Jens Axboe , Minchan Kim , Sergey Senozhatsky , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , linux-block@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 7/7] block: remove ->rw_page Message-ID: References: <20230125133436.447864-1-hch@lst.de> <20230125133436.447864-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125133436.447864-8-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: nke5cuimtq71uioa8x4ie6n5ezjudoch X-Rspamd-Queue-Id: 2186040021 X-HE-Tag: 1674664118-480037 X-HE-Meta: U2FsdGVkX1+mMFJ7ujGh16ntDSbE8k8MwTRUHV8V2bfKdnKbdDnw3SJlFL8bvqYyOO0Uafr1YYhyJJ6PJQ5ZtcKy7DuObDWo2iKcnmZ6h890gQDcLA9o0qHHkI7D+SOmPeoQgmwbl8tj0ie+beMV261ntd6bxVWPANIJ0JvjeR6uHnX4TsBh3EKrskXTKMzZvRPxAlkZMJ3SbIqJunM8oDFMXzzh6NF5cvj4+8VicrxdwO1erEJJHteOb/rFTZ11PmpZ/941vsg3ccy157EDktFgz66NLvWWeiELdtjB2SwROIel85lMgDkvlsLVi4LfUSJXVA+AriRTWJZTDqz0oZcT4RoBWQ5vY4HFhvFg8ik3pmWbAMSFH1bCUqFrNww9t4wzsZ4T64Qxdv1emXmCp8eYqFpk5mfNhJ6v7lBcRnz7IeL9123X/pZO4If5GwRjkL5QEzT10P71kfVsxl1tFSyHqh+OOvKBXcxBtePPs34o0JW5IjJI4RUN3/jk2Nve3bsyYTNulayZcwiTaboQ9mCE9gxohb7o71niotD+H9aQn/ZN4HwEEKJ1S8+K0acSAPFKyyTiJ0MlnI4mlFSLvJ7qwsfCzZoQoEZRAPqgXHY6xxQAgdW6IH4I7xqFdAD8/3jCyncH4dMHQMcgE0DZe36AVKb7/eczmVQmtTkJ72hHV+4OSxttAh59wW30B60L3UGLlxwVOM5qqSOKPLZCfOS5qOe6Yzk/ov2vhlMpIZah+EW3K2LX1K9Lbz1MEXu2A3yNSTmLFDYxp34OEvRNfrbsg/dbNI8pIWt+G5IKYFJiq8rQgJGfNICIGAQZvz3PmOD1KQCnOXEYmzuV1mnwcERsOQgDoQeKxqAaDEpg6XqsjNmOmomvgR2HfTXsm6fA1lWgNLtXdUvW43C2yq1WyaMhr24RAoHqDq35ISr0sLHlQc95KlRNZRP2Q07A2xyLoZZow7zI02Lp7/Dq6HH L4hwlF3v M9V7TL1tiPaa/4Q0Mgh1Auv/TAatrZuFT8HtEKVoku/jCStfVJdE418oEqv/2wEfaqWjweSMtbTdbwkL6qaT9w7isjpeMMQGoe5DlQ+Ip+9JR+1zWgC1E4wpkcs2riaF2wXCKQtaW9ZmaF+uASOIzTCS5lu7xrPcXRvgc40pU+DGuVnlF137BuSBGbwlXgZQa9SCReUB4ysRYBVHoQStrJ86Igr2SxnbanUoSzQkKABRcEn7b1MqxbrNIVGihtx4sIsfvl+SegK+EA4380+J2GofkzQgSleqbWPIJcmGIgFm0ORngiHpvvKZC9Zi8xNv3pkeO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 25, 2023 at 02:34:36PM +0100, Christoph Hellwig wrote: > @@ -363,8 +384,10 @@ void __swap_writepage(struct page *page, struct writeback_control *wbc) > */ > if (data_race(sis->flags & SWP_FS_OPS)) > swap_writepage_fs(page, wbc); > + else if (sis->flags & SWP_SYNCHRONOUS_IO) > + swap_writepage_bdev_sync(page, wbc, sis); For an additional cleanup, it looks okay to remove the SWP_SYNCHRONOUS_IO flag entirely and just check bdev_synchronous(sis->bdev)) directly instead.