From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 336FFC27C76 for ; Wed, 25 Jan 2023 15:58:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB7596B0071; Wed, 25 Jan 2023 10:58:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A67D66B0072; Wed, 25 Jan 2023 10:58:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92F7F6B0073; Wed, 25 Jan 2023 10:58:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 85E206B0071 for ; Wed, 25 Jan 2023 10:58:39 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5882E40C7C for ; Wed, 25 Jan 2023 15:58:39 +0000 (UTC) X-FDA: 80393779158.20.C65EF38 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf16.hostedemail.com (Postfix) with ESMTP id 8F86F18001B for ; Wed, 25 Jan 2023 15:58:37 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Bd/qPBy7"; spf=pass (imf16.hostedemail.com: domain of kbusch@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674662317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pvwSpL3Jgkw++m5hL3VRkgtpo9F9JCuKaPcSpmZdMC8=; b=UGVDfhVBokv8tCP0gw/ftm7GaOfr7/C5isi0n8as+SonjaGwBxQ2oCie/aFkWbXJnvQ2ah h2/CMGJtJaAI2TRuvoJqiyzo7/8h0VBX+gLsiXeH7AnEqbLzwjz8Tg/pBTNlmRH6++tWqq QJTUlah54RixBqSevshptdJ8nzdda3w= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Bd/qPBy7"; spf=pass (imf16.hostedemail.com: domain of kbusch@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674662317; a=rsa-sha256; cv=none; b=ZOoSeEQ7w4yRau53snL6kn0rfcYZp6SqPV2GeN0oPizvvlRNSqUw1ThWoY386d2X1cy/sh BqBBEeWZGYD4w66U1CuOY4+EWSLgDQNaFN6VyjaOh8FSyqM+L953g1PsByUSZnrFv5U0/X pNafq8zHh+92g722ZK3ChW9IqEX6jtQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E174DB819B4; Wed, 25 Jan 2023 15:58:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92CBDC433D2; Wed, 25 Jan 2023 15:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674662314; bh=aUkUHwB0Xq0oSmDtb8Ps0uypEki5oRPSjQ+9ZXsbQpQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bd/qPBy7SrLfQAuZ9JSfkCuSJNpOuQb2TjGJ+gIWalTOgOFE3uYUzPD/8iFs+30ue tXsOJueXU6KgxSRsN29umipxzyFhudNla3UMJeYGzwHbsozsSONQsM8bjN84uHny8r IhS3nSt8ST8dR56KmBhyUM8/BdcZxA1Pi08NEfOeOdom3hGZqkmM7Fo9FYdWQT3I0O kNXVa6/2CvVk12LePVQIjq1DKkwtGkP68WuJzfo9SCGvyzld6nDLZPL8keFOfYWFEe kIulbruoWh1IKa5NicW8ACkm6qixyuSeNpW7RBxkrRzyJx0euXhw98VtLUN/AH48/2 l5wig70p4uoMQ== Date: Wed, 25 Jan 2023 08:58:31 -0700 From: Keith Busch To: Christoph Hellwig Cc: Jens Axboe , Minchan Kim , Sergey Senozhatsky , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , linux-block@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/7] mm: remove the swap_readpage return value Message-ID: References: <20230125133436.447864-1-hch@lst.de> <20230125133436.447864-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125133436.447864-3-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: a3cufix5tfoao3ti6q4fzpz9ibhythgr X-Rspamd-Queue-Id: 8F86F18001B X-HE-Tag: 1674662317-891443 X-HE-Meta: U2FsdGVkX1+85g+Lr4WurlvuRtcsj+alA4r0sUZfUMwhqf612EErZegHAR0d1lGGac2LACNrjfqfoMg8pFqBvyoOIWGtpXxtxy+pkQVejYLB8Fkqb5mqkx9aVx5S5AAO45w9XUcj74AmLd3Uki7sP/YOJd777F3kiIWoyISKms7j1asoYy0MZ2rJ3EFI4773Pi27trYOMWxZS1T9/PkwEasg6T/3Chj7BzqeDU5XZLA0mkSA4DAn9pZP0RNBHtHI1YtWUyKBjYRCKgaoV5LYoDaAUFxaHc7KN7H6nz4PaFQR7S1wU0vj09BQHmzN714wJsQ8t8qIb/2qT/dFfP8SCeUwmAy0igKJfdxJgNu2lnRdbYDpajLuihXAPcbkELpuXYVJ1GI3V0azAzL9/QHP+cxalPk3e/k0+7d8WPlU6p85MDJDLRvOpZr2w5yVHgW78HQKOZA77iGYgHGUAdFiR99gUy29fhDJOEe+ChN0BEXIvq94NtTSu6PcdtwZVgjGuxSFzu75EEv/bx83M8UoADqFCPzZAqsCyAa35ijaaM37U7LFY8guMFmvfY0zPQ4HoItGtZh3Mz0MZQk0JP2D7W8l7DUneycpF2BJNC6KcYzKoe88CgyiRkt9Zw4ITaALLN1Tmk7GYeBvC5jvIL4ozpi/Dd9mnWYXC/cmC/kj/656ymoXM0WtILEXyqab6XDFCx5d//eVKWyMC8Co3rfbjZ03NVsZdhFJfjP9NH8nSRP4TvZRmKAmKghqni7Hn+rJRbWqhgg1tH0xJrmO0ciJlcqPG7Ma1wl7OXwI1blb4TKBmuFX9w1PN2XP4z6YNipX1eseLBIuoKlOQhuqTz0mpy0+BC4YffoB4gY23C6Lj0dP3S+Cg+rTicyIUIutPuMTUFaHj/48yeDEGg1I/il1lC1sIQ94O6J5HzqI3DWwjPKeunkmOLWVO1kSrEs4sDpr0WmbHKdPHSo8SXYXcBL 3p7yC5+M kLPXg2Org6rBo1tv6/EgZMBVORL8RlerUX1c3PrnXumnHZl8Kha4bw24jq/O0vohT0GzGTXvLiwq3q9DUgTXb2YAO5EmdSqNWsgPuuI115C1MpLXnxQ4qpnODf9Qk38jxNQN2P0dsuhwC6+LKQ2c9yKZ5jcCPbmkPm5UWRMsT11/RboMr5zBGizeSMtpOv5W6gU+6ZXpfFFyWP9TzGtDIBW9e82aATtT/4LfRJLTwF+IKEoriCoCYZOkMIbSnnMPqbYZATxy2NL6Oq62+thRTVZg++DFjq/wATuvHIWT88QFNoi6aic9Ua9DoiPVvvwhs9L4x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 25, 2023 at 02:34:31PM +0100, Christoph Hellwig wrote: > -static inline int swap_readpage(struct page *page, bool do_poll, > - struct swap_iocb **plug) > +static inline void swap_readpage(struct page *page, bool do_poll, > + struct swap_iocb **plug) > { > return 0; > } Need to remove the 'return 0'.