From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3594BC54E94 for ; Wed, 25 Jan 2023 18:57:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 990796B0071; Wed, 25 Jan 2023 13:57:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 941266B0073; Wed, 25 Jan 2023 13:57:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 809056B0074; Wed, 25 Jan 2023 13:57:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6E7456B0071 for ; Wed, 25 Jan 2023 13:57:12 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 08772807CF for ; Wed, 25 Jan 2023 18:57:11 +0000 (UTC) X-FDA: 80394229104.23.A9F92C0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf16.hostedemail.com (Postfix) with ESMTP id 1A28D180011 for ; Wed, 25 Jan 2023 18:57:09 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s9iUhDWO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674673030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IbviU9oCJhym37cGWuZ0Ah1Vo3uXkXDnDEpXSyT9wSw=; b=vAFJ6PBSQJTDYtm/5AJION1uwG4DYKaktnQp4HW8G4HaMcq2pQJR5/I3I3MjfLmlo8frrd pmq9G7Q+pNZOruPuXeae+NDJLfBpqx0J1JVXuWx0poZMryS0yPe2rPT4W6rPsFsfU/e3PZ saA5BccxqsiZut2op7zsnLpwbkgpkGU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s9iUhDWO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674673030; a=rsa-sha256; cv=none; b=UX0JpQV7HVW91cDN94jqa4NEcjl4GHZNC1RK1qzA0Dfd033X/UKGHT1RgrrM7O4IBtpAin Pfr4jk/9lB7EQn482sRpUKuIZmNkX3sNsSnltT6dsXRwfyDLfAeCbJr4WS48czEG7LO+8/ 0GQ7U/OYUjLFQX6tEj9dGCidzDvg93Q= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4C8A1B81B41; Wed, 25 Jan 2023 18:57:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E73DC433D2; Wed, 25 Jan 2023 18:57:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674673027; bh=st13cJxsleWr9ZGQyG0CvLVid1afNTC/Q/aI29/yE6E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s9iUhDWO1LkoWKK/9tMkgE1+y4bqcZmtnTF2kwqoyHRRJB02vVuEGGoxSCC4+ZKqY Yb/BjsMfTj/u41pueMR4JiSu0tKNTwSP8UwjGeXXoQSTZ/UE9sx4p0/WjxWWAA0+8j IXCQ3AqaYAPdJh6uPgMB/k2C/h4POGHNbHiMCmlBLt2KDPUtnl8DUhqNiBb2vpG9TM AHFv1tUQ6XKPugM4oU/NLD97zuBEF5i9Vx4LvPI1m2Ee4ugxf1Em7sdU24srXkx07V 9d+UVqvfGamHn6Q0RUj3e+tEBfJiNWBlwdTVm3T9d7/bitY6eNKfON/UykP2SDNqC3 pEXnw9IMTctnA== Date: Wed, 25 Jan 2023 20:56:52 +0200 From: Mike Rapoport To: Vlastimil Babka Cc: Jonathan Corbet , Andrew Morton , Bagas Sanjaya , David Hildenbrand , Johannes Weiner , Lorenzo Stoakes , "Matthew Wilcox (Oracle)" , Mel Gorman , Michal Hocko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko Subject: Re: [PATCH v4 1/1] docs/mm: Physical Memory: add structure, introduction and nodes description Message-ID: References: <20230115184212.996298-1-rppt@kernel.org> <20230115184212.996298-2-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1A28D180011 X-Stat-Signature: c6d3afmt6y3k6a1yqxbegjham4g7a5f6 X-HE-Tag: 1674673029-938736 X-HE-Meta: U2FsdGVkX18ky3LEhDHSouQobYGgFiyd/b6zhhwjxafu8i3ej+0niAv7sngm88aBDw/zQZUtOJoQWhCQeIR4Shf3MNbciikELupglxczBifK7+610SYEgGE/Qmr+g4E8aFYO+p/0UInUyHxwLUYL9Y56+sPnLRZ/usbkFhzwdb33jK1M6Ld/jwXqwP0AF9LxeaMUTdSuvqk0QU9Pb40HZNpW2Xu2UW7hQGOulLSLXFdGbjYsKwCTcHyCTSccAaDfW5TNvlkiBLRvjTbgDaCDVQl8l3v620q/VoVWaHMF9xf4FYwzF8MNVmPhFo6DuaAH+jPP8Rt1FqLAhoNAEGV9XvSjhVrTfbkQYgXH/RdhQqi0kl5mzd/fUrAKgzKpCbEkakS0NEr2qAvhvj0GVXQKV1NJRfFakL6L9eJn8baKOsD2ycq107eOxOO8CrA0cRRi4Fqm59xOLgYAbrbjpDaqSFlMicL8aICe4vVEECYNNSP3DEYxnnysqJBWpbhz2L5KKpJ+CkUdDP579RJszZOSbke2wtn6QYOJfsVUdMzXJwBn8sIr+UvQZmD9Y7/f/Ay2PiLL1vu3dXptj9FiQCyzCcGKBbWcDJE511vjQiwcCg7a9kYzygHLoT29yVZgxQoBLmSq6QajXgQkHx0Ogg/5f8maMPoEsXSLd+abbxl5ko9CEvk97cDAAN1QT6VmDWtc8J77COKUS8Dc9DS3QEq6dEm98L5LDjJO0nDti/jWtIb1kDFhZUlc22NGpiBuWCDk1wnRRI0DVIV2npOqGPmMqlc9Cryvp4CYJmp7xU17tsOpjPwN+TR7q/iVPOpI0HMOeqRNPKGLdglQNWSxK/sZJfzRlyS4b/FZ8RuQ3D8n9Ck9DMFUrNKN0UBvNOuOtCUkjfotRm8O15MnaIos9OfOrrUjbr62QetLm2/3afSkgvlYRnuadpzuijFmxs30CU6SwpMPq0F7EhXYcyQAmNm wfDxXq2F NushacI63XSTj6ZPebhYBSd+DJ8mId94pgdYHRO8otZMdq8atWUIBmODL7VQoaxm2VLdZDt8SPEaexscWV5RVFsyFEkKg5kY8CxavkZqzdu5ggSbfcCSokFbVopWJl8LNKIu56alhFn6/GySeWXem0KMb0dEmy696MbPixqPTpMraYA7tPOFxgaFz8qErCQ1MnjNtjqR1YurjUr4up6OibaBj0uXKvX1UdPb0PjoViLogfa7C46BjCPi9o2PtmPz/LMftLcGhSOW0wsxLBpyUj36MpSOUtHCoTJ0IdtYyYhQuHiiE5luchq0Y3iheFrfSr9MsdWZ89yOG9D3dNKbQxLoLJUIvMZhPySKXrPw/hfhwofAv60bhpW1lb77OXEfQ/9aPF6qbSVnHYK7i+4GfI+kNZGxVuGmw5yvkTfTCzej9GKVBSD0624DuqxME85vPiv0c X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 02:40:54PM +0100, Vlastimil Babka wrote: > > > On January 24, 2023 12:16:20 PM GMT+01:00, Mike Rapoport wrote: > >On Tue, Jan 24, 2023 at 12:00:07PM +0100, Vlastimil Babka wrote: > >> On 1/15/23 19:42, Mike Rapoport wrote: > >> > From: "Mike Rapoport (IBM)" > >> > > >> > Add structure, introduction and Nodes section to Physical Memory > >> > chapter. > >> > > >> > As the new documentation references core-api/dma-api and mm/page_reclaim, > >> > add page labels to those documents. > >> > > >> > Reviewed-by: Bagas Sanjaya > >> > Reviewed-by: Lorenzo Stoakes > >> > Acked-by: Michal Hocko > >> > Signed-off-by: Mike Rapoport (IBM) > >> > >> Acked-by: Vlastimil Babka > >> > >> A small bug to fix below? > >> > >> > >> > >> > + > >> > +Along with the node structures, kernel maintains an array of ``nodemask_t`` > >> > +bitmasks called ``node_states``. Each bitmask in this array represents a set of > >> > +nodes with particular properties as defined by ``enum node_states``: > >> > + > >> > +``N_POSSIBLE`` > >> > + The node could become online at some point. > >> > +``N_ONLINE`` > >> > + The node is online. > >> > +``N_NORMAL_MEMORY`` > >> > + The node has regular memory. > >> > +``N_HIGH_MEMORY`` > >> > + The node has regular or high memory. When ``CONFIG_HIGHMEM`` is disabled > >> > + aliased to ``N_NORMAL_MEMORY``. > >> > >> Noted. > >> > >> > +``N_MEMORY`` > >> > + The node has memory(regular, high, movable) > >> > +``N_CPU`` > >> > + The node has one or more CPUs > >> > + > >> > +For each node that has a property described above, the bit corresponding to the > >> > +node ID in the ``node_states[]`` bitmask is set. > >> > + > >> > +For example, for node 2 with normal memory and CPUs, bit 2 will be set in :: > >> > + > >> > + node_states[N_POSSIBLE] > >> > + node_states[N_ONLINE] > >> > + node_states[N_NORMAL_MEMORY] > >> > + node_states[N_MEMORY] > >> > + node_states[N_CPU] > >> > >> Should it be set also in node_states[N_HIGH_MEMORY]? > > > >You mean because of the aliasing of N_NORMAL_MEMORY and N_HIGH_MEMORY? > > No I meant due to "The node has regular or high memory." Or do I misunderstand? I checked the code, node_states[N_HIGH_MEMORY] will be set indeed. Will send v5 soon.