From: Mike Rapoport <rppt@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Bagas Sanjaya <bagasdotme@gmail.com>,
David Hildenbrand <david@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Lorenzo Stoakes <lstoakes@gmail.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v4 1/1] docs/mm: Physical Memory: add structure, introduction and nodes description
Date: Wed, 25 Jan 2023 20:56:52 +0200 [thread overview]
Message-ID: <Y9F7dOuvX3rBfcvr@kernel.org> (raw)
In-Reply-To: <AC10188D-6728-478F-A95D-1A460958533A@suse.cz>
On Tue, Jan 24, 2023 at 02:40:54PM +0100, Vlastimil Babka wrote:
>
>
> On January 24, 2023 12:16:20 PM GMT+01:00, Mike Rapoport <rppt@kernel.org> wrote:
> >On Tue, Jan 24, 2023 at 12:00:07PM +0100, Vlastimil Babka wrote:
> >> On 1/15/23 19:42, Mike Rapoport wrote:
> >> > From: "Mike Rapoport (IBM)" <rppt@kernel.org>
> >> >
> >> > Add structure, introduction and Nodes section to Physical Memory
> >> > chapter.
> >> >
> >> > As the new documentation references core-api/dma-api and mm/page_reclaim,
> >> > add page labels to those documents.
> >> >
> >> > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
> >> > Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
> >> > Acked-by: Michal Hocko <mhocko@suse.com>
> >> > Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
> >>
> >> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> >>
> >> A small bug to fix below?
> >>
> >> <snip>
> >>
> >> > +
> >> > +Along with the node structures, kernel maintains an array of ``nodemask_t``
> >> > +bitmasks called ``node_states``. Each bitmask in this array represents a set of
> >> > +nodes with particular properties as defined by ``enum node_states``:
> >> > +
> >> > +``N_POSSIBLE``
> >> > + The node could become online at some point.
> >> > +``N_ONLINE``
> >> > + The node is online.
> >> > +``N_NORMAL_MEMORY``
> >> > + The node has regular memory.
> >> > +``N_HIGH_MEMORY``
> >> > + The node has regular or high memory. When ``CONFIG_HIGHMEM`` is disabled
> >> > + aliased to ``N_NORMAL_MEMORY``.
> >>
> >> Noted.
> >>
> >> > +``N_MEMORY``
> >> > + The node has memory(regular, high, movable)
> >> > +``N_CPU``
> >> > + The node has one or more CPUs
> >> > +
> >> > +For each node that has a property described above, the bit corresponding to the
> >> > +node ID in the ``node_states[<property>]`` bitmask is set.
> >> > +
> >> > +For example, for node 2 with normal memory and CPUs, bit 2 will be set in ::
> >> > +
> >> > + node_states[N_POSSIBLE]
> >> > + node_states[N_ONLINE]
> >> > + node_states[N_NORMAL_MEMORY]
> >> > + node_states[N_MEMORY]
> >> > + node_states[N_CPU]
> >>
> >> Should it be set also in node_states[N_HIGH_MEMORY]?
> >
> >You mean because of the aliasing of N_NORMAL_MEMORY and N_HIGH_MEMORY?
>
> No I meant due to "The node has regular or high memory." Or do I misunderstand?
I checked the code, node_states[N_HIGH_MEMORY] will be set indeed.
Will send v5 soon.
next prev parent reply other threads:[~2023-01-25 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 18:42 [PATCH v4 0/1] docs/mm: start filling out new structure Mike Rapoport
2023-01-15 18:42 ` [PATCH v4 1/1] docs/mm: Physical Memory: add structure, introduction and nodes description Mike Rapoport
2023-01-24 11:00 ` Vlastimil Babka
2023-01-24 11:16 ` Mike Rapoport
2023-01-24 13:40 ` Vlastimil Babka
2023-01-25 18:56 ` Mike Rapoport [this message]
2023-01-22 5:30 ` [PATCH v4 0/1] docs/mm: start filling out new structure Mike Rapoport
2023-01-22 17:43 ` Jonathan Corbet
2023-01-22 18:41 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9F7dOuvX3rBfcvr@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox