From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 828CFC54E94 for ; Wed, 25 Jan 2023 18:38:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E17876B0071; Wed, 25 Jan 2023 13:38:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7B2C6B0075; Wed, 25 Jan 2023 13:38:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC0396B0074; Wed, 25 Jan 2023 13:38:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AA4FE6B0071 for ; Wed, 25 Jan 2023 13:38:40 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 84F42C0B7A for ; Wed, 25 Jan 2023 18:38:40 +0000 (UTC) X-FDA: 80394182400.22.EBA4CEC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 02518180016; Wed, 25 Jan 2023 18:38:35 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mx74wVm8; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674671918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WhE3p5nMlMDjaV/irGLArTSJUCL3MW0izpTScdbc1OU=; b=SssgC66kTB2u/X9Y1nE2dUztHrG+f69ZCR5DHHP5S8NV7Em+73dYBC9LGRubM0RmoZCfCa 6UwFeDIN2FqEGVDIi9It0QtZ+8yua8MvvdbXKEIyb1iWvLYFpULDC9nupgchr4A+qrz65M XMFOSaWDwGXvmAd31dRw/5escG0JF50= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mx74wVm8; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674671918; a=rsa-sha256; cv=none; b=taoRELcHba5E2UM8E8hx6Z4TtABrJrvveM17SdgCKx2p53kKIoAjRoaMa3RZku7e4ckbdC RUUJcMBkuvmyDmfdZJNQpgQWbb8wQSc3biJJEor3EFX1gh9IF6oLGNGBBKA8EqRezFcv9C /VQSmLn90D4uqkD7PFvS5WYGb5PMpEc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WhE3p5nMlMDjaV/irGLArTSJUCL3MW0izpTScdbc1OU=; b=mx74wVm8uyXRMzRkznkmPv14f3 DM5mkZY0d2Y454KV/p1DBO6bVWUBYmLnjNwq5de4oOCp4K1tzlZ+pYhblaAnUsgNim9Cg22n4lXC7 YVziRodKlXV3h1dcA4wCil3iZ6I2W+LteukgjO5nFw9bnJFOnLJvx0ni4Ju6wCzLw38ztU2xqwXDF Hz7a4pCnrIPatIpdvDFmrtxTdMVr7eH9j59LSpJj79ys6zGb7fhMV69syzXZoxm/q67WE7IxkNx+x YR6wIJfVUlSwCzFkthS2vqR79CZmfDxbuiYrAaQdlm8CD16FJpwzTtCFj0zPf7AtdmoIV8Mlhhb7E KwDK04uQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKkaL-0066XZ-MG; Wed, 25 Jan 2023 18:33:25 +0000 Date: Wed, 25 Jan 2023 18:33:25 +0000 From: Matthew Wilcox To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, will@kernel.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, chenhuacai@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, qianweili@huawei.com, wangzhou1@hisilicon.com, herbert@gondor.apana.org.au, davem@davemloft.net, vkoul@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, l.stach@pengutronix.de, krzysztof.kozlowski@linaro.org, patrik.r.jakobsson@gmail.com, matthias.bgg@gmail.com, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, tomba@kernel.org, hjc@rock-chips.com, heiko@sntech.de, ray.huang@amd.com, kraxel@redhat.com, sre@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, dimitri.sivanich@hpe.com, zhangfei.gao@linaro.org, jejb@linux.ibm.com, martin.petersen@oracle.com, dgilbert@interlog.com, hdegoede@redhat.com, mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, deller@gmx.de, jayalk@intworks.biz, viro@zeniv.linux.org.uk, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, bhe@redhat.com, andrii@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, perex@perex.cz, tiwai@suse.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org, loongarch@lists.linux.dev, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-stm32@st-md-mailman.stormreply.com, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, kexec@lists.infradead.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, kasan-dev@googlegroups.com, selinux@vger.kernel.org, alsa-devel@alsa-project.org, kernel-team@android.com Subject: Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions Message-ID: References: <20230125083851.27759-1-surenb@google.com> <20230125083851.27759-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125083851.27759-2-surenb@google.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 02518180016 X-Stat-Signature: so3yufgdut6m78qpwjikrge67tzz6j8b X-HE-Tag: 1674671915-895086 X-HE-Meta: U2FsdGVkX18MGB5TeX+wy2tFiIYzcQHzU+fqDoEVZcpAtviQvMEJ87aw5X01BaszxEjEaSHJFsHMIoIGNiMjrq7YOsTRVUYqqTxq/wo7BSheLfkmdFdXo6bpcMnDdU+Glej4od3sEJTCmelxZiqtEfyHJx3zo8VzJIPpbc4DqbTTJkHxT32JbFLXXEJ+iAo6leRhuVPGZjcfloW8cU1+w5/vVCPe/4YSJca4x4l+KkvNY+hhdOVdIK6nmmxyfcwZbooNHsaswbn5WtECiSt7lQzMr5Fb6A0avpMBbhFuSG1qcgRlkfk5EP6GZPn/qtucTvoSs1RElTJMFijqefSnPBMVv//9xDCmr7dZnGFw/K1fgwBohnEW6qNg6LbTyeWJr9OR4xCrZElSHBUZtfpGCd/zlkiIu5TwPNdoruYr0qc+FshoeAz/XN/LFNaU6ArtkwM3cT1GrAJKfblb8HFF64imeTnIUXwDdI1+PbkUSLV07Ge0pmCXv+tHS9DB9a6oNdVth/T8Hyo4lFgftfZq9sfKSN+eEzt7bKpTKrLKULOd9EJqAmn1w14ciYAtegVLe9lE7epgCgISwi1UCShE9USzM1K8sTYRZQG+IfIq0qTosS/cSvJPnZ5CsYyU+w2070SOxM2zbfY+1J7f37/T60/01ThHV9jMsyFulavxIyWzpioM3iruOrNd+qmhbPDLb2e61e33AXCLHgFOdXH5as9MbyVt3gD0ejjR9NY7ziUj2J5k8BT3Fk5hE1lHwV6PpQuRmFkIF6UT2bkWBrTnloCU+Y8ZSPUdFRIogmUG+idXnoNBNbCKzMFAXmDRNk6Pr0/90a9rMDTy75lxtvpOcsTTnGz1x1erRhGsjVjKgFZzav7hi0rSifb6z3GOxPDewTn7yOsurVMFXAn9GSoN008qoHQvRa03m4ad0XKkswVgZSGzYd2k4PSHNSoASVZlDIQWWq4wFpnTIrG0oX4 WO6u44fe opPyjXlSYaN+hohjU/q5zKvJVLpJ5Abriwphot3oiU09++Oi8ooI5bB3OKvxM/Vzv0lO9xbAymOC9B2udjHA9++NN8h26WdcXvp9F0SxemRBzLa8y1tDPsSEtT7m2+96dGpil+ZpvSaHe3HAs5oECpJDfH9qsDrNgox8z1ljGAEJyVSUZpctHbSzLpU52vTSl+kNygGHOlJp7eqfbtEH5txJ2X9S4SGwwiQiuSP/5cqn9aEDwWOG4ovZYziczRq4Hvk3eRED/kkbc7dUMdWGOR6VQMeQKN1iRJNia59nD8n0XhR0wT1GTfXKGpjh18UACW3ohitSRf4TTd6zAv3l5u3r9oOXISTfp6JZ/gqZ9K7t5ciYH/P1bZ4SYKZ+03TftN6vHbOdkjsOodB5wqPAEA2MbDKOWOzN3yq9oG4ZH8BCScrWO6gj47Ds+fasBCDp54fvG6btCcapXG7Qv0Ers1h/Ostg2DR5IVi0ViY5vLf+kXHP7tGgIsN/fylTwbRs4dtoMGHwR6Z+1/IqXm25azXsjY5iaRcXRrSXiYkUlK9GtecyPr6ge82ZvzhAZ7SgFAWqoNSdIjUKDrwhEk91SxM+9/a8xtxXft3izX+V3146Ej3f0YqEuRFC9I6VtDq0Cw+mcohYa9LOT0Zfgf6Yc2sb+u2auCkccpO+AP62LGpSnUsDHUoj98Khh+XkZSLrkpXRvwnDL7C9u24Mst/UwjVNFB+IkS9fwx3AB0LHQESEZnIVfuPxzk8kDR8IjevaL8j8NIm1MXKVfqUYNhyRXH+9ZhyRY2D95hJYtKFunWu82BydbJc9YhGWvb52qGgeNwHbGGG0P33dn5SWM5DoxLF7+i1vfJqSSAA1sXYp47jPF9K/dbPc5oIkupGfm8e0E+oMFeG1hTxmey+5jaoonJq54cVCQW6XxkqBeDqcONJBSVSS5cDSXcPJhaLpjmV6P2go9KULo+7t4ItpZvBPziJux6DiO TZrOljzY mGcHMd+xwnbTXhGgXcOms/hFk8//zsdI6VveSZDCo3/brE9rD0ieySr3rBzrgnIbaXH8w74HK0Bak0kgEDWhEXEAjxupMlZmuUCMvs2Gsuzbw3cxJ2QRS66bA0pJw8uFZbUWGVihCZhPWQbvkO/xdZLqetLRF6lkbDVZGG4S0QSx2fN2/bK1WJ1RbOdAakts9Q4mt6Rcw36y2DwdDvcS97y4p8fAmf9SK8Pvcb3Ut5LQmZyqynKM7klFp3Yc7W/sjw0sSsdeI3K3/fl/L321XScA5RHPyH5dujmiD5E0CWbIc+vyjbkkU9zWWG40MaT5W0WO9xY+vwX856uQw8x6SDbVXVTTl1eTVcutsMia6/pqBFsmDfDCt0wxJ5AvTTwnW5qeQCcxZuBuKhOvsuDYrXafzEeSk7vUR823tSB1eDqSPZvDLBe4cKZXvSb/XHWvH6BityPF92TihsyOUx//wfbgVo20kv4t+J1jDE3ssfUHOfoEmtcET6vQWr+ZCXA/t9UQ1hsc3/wZ1HUoN7IdJDJzZ7rlOIPpMR67g6X/Aj4+WFBANxGFDBVVoJdcKxGDVGlJha3HU2aq8tegm3BBCQeTkrZa6TX5Co5u5DrHw80cgtFORXJKsgvpkLRBOCJATGNLL98q5i9qBUy4A6p4zaMt6Daq5omeOHJp/SI7z6GbAmZW520FdJ9SMTBdoqnzESzrTnyDK9BmzMj5FL8AWMG6rQVoaP2jlrNBY3fV0r3PnGURhZsQoJ9mWj2p/GmIbwrW/siAhkEfsGnlFP6RY8wv4wgn6WkOnw/EcF3F2lFVKfkWAfsmWPLpKuw2koVWosRdZZolrasqf//Q8XbpkqhzO5COlNxYZh4p3IDmGwlBSAMegHzJL6jrMuqpt9hf3Lqjocz5jW4EbkvXOVHZZ37cSthRV7VVaTZfa/z5kTWU4V3tD05WyoYMcMl6arYD3WG3nDCPN2QMOeEzmAU9drLs50PYz 6s8lG/hv Xv7De/SItrPQyDVu1Fd/XQsdqu8s4yCakilnhOv+FsBOz9rXlMLvaAstPNaa01ki0p3HUw0gN9z2WgfISfNlCoaV+wWhqPunI2qlH811qWOUpd3DwSJDMhZCQoMHZwCUteCnjpmS+/PN4TSaIefHyYKfZBQL+fGKva/VtWIKMnQ7cq/y6YIjNIbWzqnBokDuiP7YHNtzHA4WTWZtLabTjUaqdcg0GWHtf1OK5pvIlUTK7O4A2A0M27z+UWWX4hv50iBOEZYA//+GuNLsZZ43E+fklGgK0zVeSohI2b+0NbJBWy+ajSTtfZQDeY5E1krZy9Yuuz6m7qpgPwOFrEeI8Y0fVeJo3s7C4vYTu/OgWNCqsQTKq4hCkwf9//42YonH6S5T0Z+VhGOiXsoA+hTOsFsNSiYzXt+WHCbK/KcBcc/x8v8X2WpnpePghAQTG87ALGIpTW0tb2pTAA7/fIXNVudEbLoftlSfIV/IPtwS7XxlTNO5xxQFMZEsg/eXEbxiD2TeBA0lBFvlD3EEC8Y6Ovn3P5RTn42VWdAFv/Iuu6Gt9UY+gsKzyXuUvB9K98G8WFCaJgAHd7aBbI31rIk3cvWtOxxOjMw4kZfTDPVYOUy6c3iUMhLkLhgcS+aSRW4xuOrTyL5Huejqbp7bvLLCOzISUoyiMdO+MzeR6KnO1CwrN8X9sJqnA/fvq9doKofnl9lJ0Kx9UkIly82+pOw9eglnIUKummQjvUcoemfAZrBgqqb+0aFM2AZIm5dbu0JOR9ZE+gBwduAiP0z+m6jAeZ7+1RffxrTTSM96z0zb6iEvCnNECTAh0w+x1oJ7PZrAcaWmxMdvScZ2zNf6WveNpZqUEdaKtDoOxPCe/LyxB9GRVlWxe11i5m6O4rdU6KVoE79g68HDFYWfARVGWcMEV48lv0QHHVP/Cmp+yOBiTXhVmbj0vqFu0QaMVoiqCB9k9Uv7vu404j3ajRHa5onFm3EhhUgsI 7YYXScRq wAzBWtAxLxjuE+WUbAEiqtTsKoiFSLDi50lSJZC7zxGxxBJdd8/jJvyRZ1/TetB56B3TcaVGhaXomGq7S1v1b/2J0V6Yaml3fEq4BbvqNhd0GMfJ6pf7qKstJuHRSYuLZWP8XzP11L6K+XfOOXrxoq3UIPXzNBcCMkroUne6CZZM0tKz2tx/dAfmsru7oyYntK60WnAvTHv4moBcelI06oi7PACUmmGsc860cUqLy9XK4FxI1js3q4Z18DKsiOTa0htJJooqbplV5+4CvKxlnsW/Q0tbuzC62iqKmrbKbRD4Lhxy1IZORjIDoLHP2xMf77FdLZcG8BuFgUEJ6OHvabJNxo+Ags8M40rWNRiH+lFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > +/* Use when VMA is not part of the VMA tree and needs no locking */ > +static inline void init_vm_flags(struct vm_area_struct *vma, > + unsigned long flags) > +{ > + vma->vm_flags = flags; vm_flags are supposed to have type vm_flags_t. That's not been fully realised yet, but perhaps we could avoid making it worse? > pgprot_t vm_page_prot; > - unsigned long vm_flags; /* Flags, see mm.h. */ > + > + /* > + * Flags, see mm.h. > + * WARNING! Do not modify directly. > + * Use {init|reset|set|clear|mod}_vm_flags() functions instead. > + */ > + unsigned long vm_flags; Including changing this line to vm_flags_t