From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA12C54E94 for ; Wed, 25 Jan 2023 13:29:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3868F6B0073; Wed, 25 Jan 2023 08:29:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 336286B0075; Wed, 25 Jan 2023 08:29:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2256E6B0078; Wed, 25 Jan 2023 08:29:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 126136B0073 for ; Wed, 25 Jan 2023 08:29:42 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DDAB0160620 for ; Wed, 25 Jan 2023 13:29:41 +0000 (UTC) X-FDA: 80393403762.25.D2CD7BA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 50E9580021 for ; Wed, 25 Jan 2023 13:29:39 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf02.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674653379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ULNu1+f0KzAuvrd7lxwOr04rECs/4/7ek0pHIIOlg4Y=; b=2NaR1yaK/Fy/brNsoN4CFQJ0UodY2i4YOQn6Tv6fu9sXovrIpoRVg7DM/8aLc5qqlYaxV2 NqyI3Zk3//2BHOjaJ6B0ZKSEKv5Rpr+e3hkeHScMxSbcC6O0Lz7xpTsa2XqLVk1kqRrYLI +Se8MNV5md/BHS+GTUeeKEVGiETP7tM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf02.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674653379; a=rsa-sha256; cv=none; b=GpTagOUX4Up3oQYRn217vf/4EJEK7B8Gcxu5ckaQL+k7DVg9+owO1ebgFAYpOMJnzigOow gsUrhM1DKSpRyinGqIPahvo6XIC+y0yMu+uUTFruotn0DiCIqk9PBa6G/89ey4IaNtQ3l7 jqBG+sADBU4StVGUOPR5S6R1T4bZZ1w= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 218BB614A4; Wed, 25 Jan 2023 13:29:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A322C433EF; Wed, 25 Jan 2023 13:29:35 +0000 (UTC) Date: Wed, 25 Jan 2023 13:29:32 +0000 From: Catalin Marinas To: "Isaac J. Manjarres" Cc: Andrew Morton , Rob Herring , Frank Rowand , linux-mm@kvack.org, Saravana Kannan , stable@vger.kernel.org, Calvin Zhang , kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] Revert "mm: kmemleak: alloc gray object for reserved region with direct map" Message-ID: References: <20230124230254.295589-1-isaacmanjarres@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230124230254.295589-1-isaacmanjarres@google.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 50E9580021 X-Rspam-User: X-Stat-Signature: hbmaeaeupm1xo5okf1ktj971ugtaeprr X-HE-Tag: 1674653379-531572 X-HE-Meta: U2FsdGVkX19Q9F8eo/IvY4KqBkd9/7EwPghiF/q+1PX4i8KFWQr287NUXDjBU+13swZtYGKxKv8uD55XSwzJZqkQYgdJLZwb7vZvY/bM8M9PjQBx7IB9Kdg1GFVoJPQKiIl55AALwk+gr0iOrd8pTVEZ27mLKjwVCrxkka5llUXxq3l/Csoqh7IOH7MJruujuFGg2d/lDajp4+FyGJ33ROhNxNuO+BbKiHpObSckIr6QdiHIf1tyeW/NfsyUOhyKshKJeMoKpQnqak7tooY7O2b+9hRdoynH7AXXvO0q6aVCV24uqV+iF0ZsxQDHCih8rV1qTLpoXhnBrjvNWEF4ipGBbrLzjXC0td5WW4kKYLaCEjaknE6GVqSf4oGByjxHIM3+ZeBBu007MUWSvkRwUrwLxcUnVgtFsLG8OGXc1frsFsZKT8xV/QYDfGIwoAMDVJ1qdr2dJUE+xrexqJ2vfFr7IGRMSKfzeXrhCQw5RIAm8Up7TfFDxLVCbMEcWJeWfpG3NPX+qKVYsL3C5cmtbW5abYtxqLDJcqF+/H90dBO3Jhw7901yBeTLHJqy0JI0VHtGIKBKdGVQYofrAx06frZn9wj1zKGEgpAFAHgCo6zEw8fR5wJJXqnzcphK55FoqfbqR7kCAkSPcHgTaQslGzGvaIBecTYQQW5pzordJulWXORbK1AJ2jKnM6ERCV8BBhy1QIOl4vatb4rt45PzpaYaLmoXg8WA/eY3ZJw5ql7bS9JF/Ojj91HVmqm2BKk3FNF85Ga11+VmTu5P4dmoQzTFKqQ3B169Ke3L3LWQGAB54kOQLyhEAf2kCiIPEl24lUjOF7S35EMROB9JN00gNF4S9dmvwnTM+7iK+qZHGaZkH1zZX5BViTEDFsFfTAGFXJgeZ+yObRHvhkpdhRl7p7aGs3eHOXpld1+iocSG4fcTVSlNzs/R4Rq+i4NtaO3nQdD/lQfOLd0G/hP0juy lyz/r9FJ 858SM4etluyBYxgIiA06MVKkvdvFgeUHoqkiHczucOPAYL58W9X0E3NdpjS3JqgK5zjg0FFHWvRAYeYtp2aI9pkB7WWz0ZG7jGuF41KBewvYxCZfMc8fpKG45D7L5IrAnRgQUU5/YbApFtmDEXsUNzaEZkyPHdyhbnZ2su2XbL0zKMY8juJjANIx41OnJt93R9mLpvxBDA2Z5g8jBdlke7LMcPUeY6Q3z6tZjXBIgcMHSxQ915kwngefk2S3yfn/MrOUEDhPv2Jme6xOlp7WJHnNeTmY11Lfvg3qsPT9bd7RndITEiorzp/8DvKoBfV7VSjGbeVhVoF7xIbFi125hZPMXNcW5Q8gVUu/NItUjeQsecxubVpblru7rh4YUDBgzgWz4QO6+7joB9P0EMlszv/qaZO9MvHzf/1PH1D/PZEwCJQl+AEte4kIEgFt7iK9GO45LOGyedj74zLCvWbn9N/RqYjc1xnbflenGdgiOtCAMfqqr0biWdVm5wt2gVSZVl01BICAZZR5d4iXsEAxmh882oe8ghGvvo6CReX8KtDpb4gzOabx0LvRZPLbsQzI2QLeDndH2rKGikaowoGhGbC4ht1SB6n/E+UOsXtOOUj7w9VAiuk6mx0RpnBp+QZX/rUHN169sKEz3foVOWEbAXPItGA/7US3hSTvk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 03:02:54PM -0800, Isaac J. Manjarres wrote: > This reverts commit 972fa3a7c17c9d60212e32ecc0205dc585b1e769. > > Kmemleak operates by periodically scanning memory regions for pointers > to allocated memory blocks to determine if they are leaked or not. > However, reserved memory regions can be used for DMA transactions > between a device and a CPU, and thus, wouldn't contain pointers to > allocated memory blocks, making them inappropriate for kmemleak to > scan. Thus, revert this commit. > > Cc: stable@vger.kernel.org # 5.17+ > Cc: Calvin Zhang > Signed-off-by: Isaac J. Manjarres Acked-by: Catalin Marinas