From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50799C54E94 for ; Wed, 25 Jan 2023 09:10:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B20F96B0073; Wed, 25 Jan 2023 04:10:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A37AC6B0075; Wed, 25 Jan 2023 04:10:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83B816B0073; Wed, 25 Jan 2023 04:10:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5B1F36B0073 for ; Wed, 25 Jan 2023 04:10:02 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2C5061C646A for ; Wed, 25 Jan 2023 09:10:02 +0000 (UTC) X-FDA: 80392749444.05.AA709F4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id ECE601C001A; Wed, 25 Jan 2023 09:09:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=L8qSvLf3; spf=none (imf18.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674637799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hk+0OseVD3OO+ksIzhtEU5LrZV8KXEqXC3zpbOGn/ls=; b=UujnXYccg1Q8CddbDgrFFLxA5WYWatjZrBGzdioLFoij9pJhElbEyQtCO1iN7bsLmEGql0 W5b8y3ZTvWzQUGf4XMS/IZBxVh/6djiv3Vj9BKBM6bPwFbeQ3QxKaioV3ETO1QwHB9tiSz J1O8/iz0U1QJUMli1niJ07qEzGTNyN4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=L8qSvLf3; spf=none (imf18.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674637799; a=rsa-sha256; cv=none; b=FE2HEIXvmradxHg6irbq+n0b0tQ2E0VYZ1Io9N1V+H8+otTy0giX/Z+KckRvV3Lhm4I6mC lWcUlet83azfPQm8LWr7YkBrONSMDxSgW9oZI2nldiCYOYXRb3PMaewUAS96P+ga03Fs94 x/P/AvT/uHHEOksFz065KB27pKBCDHk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hk+0OseVD3OO+ksIzhtEU5LrZV8KXEqXC3zpbOGn/ls=; b=L8qSvLf3dSoKSiW2HygcIYLOca 21DCM8/DXgLnxfiohHpsT3lhw9RWtU9FTk5Q6obziletdupyk3K9yzioMkIYd3jrdHr1S7LLdHH60 lZs07uhtEIXDyuP/MuCEsO9tg/Dya8cSzK7mCmRjV2qBie+7+Y5IGxB0daAwFzjqMhaFzpySf6YXo 2vEVk+F84A4V2/U10C6G40hQA6YENiuXDX3aMgZ9vALWKqZFZvyNzBmwUbYJ2TrPobnkNV5WcsTzh MlPPu5bEJs9JKwDVT1dVMYwpGrr2HHxIHWMyvY2cQrGsAsrDt+nZKoGt/dS9qSUmXOpPkxoiUPomG V0Od16xg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKbmm-005neJ-75; Wed, 25 Jan 2023 09:09:40 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D33DC30073F; Wed, 25 Jan 2023 10:09:37 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 673382C247607; Wed, 25 Jan 2023 10:09:37 +0100 (CET) Date: Wed, 25 Jan 2023 10:09:37 +0100 From: Peter Zijlstra To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, ldufour@linux.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, will@kernel.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, chenhuacai@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, qianweili@huawei.com, wangzhou1@hisilicon.com, herbert@gondor.apana.org.au, davem@davemloft.net, vkoul@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, l.stach@pengutronix.de, krzysztof.kozlowski@linaro.org, patrik.r.jakobsson@gmail.com, matthias.bgg@gmail.com, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, tomba@kernel.org, hjc@rock-chips.com, heiko@sntech.de, ray.huang@amd.com, kraxel@redhat.com, sre@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, dimitri.sivanich@hpe.com, zhangfei.gao@linaro.org, jejb@linux.ibm.com, martin.petersen@oracle.com, dgilbert@interlog.com, hdegoede@redhat.com, mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, deller@gmx.de, jayalk@intworks.biz, viro@zeniv.linux.org.uk, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, bhe@redhat.com, andrii@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, perex@perex.cz, tiwai@suse.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org, loongarch@lists.linux.dev, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-stm32@st-md-mailman.stormreply.com, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, kexec@lists.infradead.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, kasan-dev@googlegroups.com, selinux@vger.kernel.org, alsa-devel@alsa-project.org, kernel-team@android.com Subject: Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions Message-ID: References: <20230125083851.27759-1-surenb@google.com> <20230125083851.27759-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125083851.27759-2-surenb@google.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: ECE601C001A X-Stat-Signature: digjegd68ao18ej3a5ycbtj1nxwhcief X-Rspam-User: X-HE-Tag: 1674637797-152751 X-HE-Meta: U2FsdGVkX1+wLdJzHbOsqxNw+QDeXNcV3j66GzaqzWCOohY63hHk12rh4zoYz9uDr0OPNHFWfQRNOe38UpY5dmxayNdF1lOjfPRShoPyVoAcuRotAJHRkkp2xlt63HCLyWsjsHmM1y6w30kf80hslGhPis+iSNXAnCtvlGtdPVLNiZBdbmhAvWFV/4ZMCh2OW4hFNV8StcoZdN1HdqZ5pfM3fgm9yW10gIFdWMP/eRRu3xi4boBfZgc8+tEIMBp1SldDjgbzI7QL2/ALPzbzpyD0dlxIHvVJyn4XXZtPHvJpcKIUKpUST95swA3Y+i9Zcfk9h9FRAauRXGCzgKviHL2BVonh6jl7NB2MDvYzmmammZjLa25vvKYYYPnjiJ045mitsOgGYnIkWCow6NdwYw3Ca9KJmkrl1ruQUM1+QAPSaw8H63xNwvF78fHG0Tu9UFqZl7+DEevsHw3rsI0UL7AVv45tvyG6lMoQg3w0hohu7Ug8/Kf6jyj1uvqCkbtzLTI9gtdjc2vD0evPMX/Z2+fbg/hn69RcUSQyWWr4f3W9Ot4pjVHuU0FcBhpzGBVOx3KmWAxHA7jOAL5PvRo9gQA8Kk+BgwpSpzWn33BC9gQonxByJnWAeKTqrwzrfjyPz9qSZww+anUF1EQsMdbLlsTCkcHsddhg//df5AVtZjiWEpiWcVhW3nDUZLlCg/+fxBtWoHvOkafdbtyH2vdgdT2ltf0BI4lYNyBYAVJhihQmcj6Lhe8WSZqoAOAgrr4W8iN1bU/1KbN4GyaqJW2pUNgwoVZxdPgLXn8DcHwBE0rBHcrvHyIYKnSkIMb91FfNNsCJEXs0W5KnPJXdNVJDENJz8AVZF18ZzQZLrB+QQc8gMDiy+uk0ovMkDwP7tB5r93mKmLEO/BtckmezvTxroTgw76KAZzBash2Jdm+6lyeO4NMYoeGSG4CNjq/OgihZdFrfC195gAqdVqh+huw 4BicRapT uK6rn0agcprMbrCLomANMscRJYiF290T9w9XY3US/1SszTJESNjyvIWNYMYKnZYU87yVcOdlJVcyE7exH12O6vo6kURB/r3wrdrSP2wVEoWtg6eXNU2f3thchJHRBtEMkW3YISO7MaCQs1QwisAEpVXtn2Y4ZmYF+p9ov2k5kt9D9sI9XlAJrXgTGbocaLmMvpWHCUDFR3dVc1e7+gw2MTqOzM9V5BSsPAm977HcGNAN4yjzfpw+NJWg7CrYUOcvEcBys2smPxfb5yh9XvYpbdNL7O0E68k1GB5C8rvXGzH65aqkEMEIJG08SHBgEP3zb3IN/chh5XE85E5PttWpnAIna3A8HnADmEVXdNP/kCN2s8D6uPkVPE74J+kBjYldZBWLcUonXmunqrQ6TsFM1uJjXeasHtVDYR9im18/tcqwY2TeVq8uVZzdlcAh2PJMnKVLMXgq6SlXCPoGR+JEbTJ70uqzHGqb5HiQRpCnvtat5WS/JvYZrnJjwhdmAH7r8RVx59TSYICambyCoBMBTltzvDuwgVTKUXZ6RiR8Dgdh7K1y6fptl9gJL1sAzhOlw4eaQZeLTnaFADZtThi4ROBwUqXbUCtU5l+wa7MFJpdklu4Njm6vD8z0wEcT0VYEURNgaq1IX/bm4Y7AgDvw7UAHi5bbp67rcgmRhxk0seqGZIXfRz7XXaSgo5vtt8pxPHRhNlKaODL/+KEv38zgzWAX34rTRwT5D/4rgCt+D8D7TUQRaRDXet95XopoTlwzWVsmbh58CHoRirEIUN6hDo/5HdbpiwPASkNebW3HwUCmCgtoKxetkqw/wES5g1jPpDikwAkmjSuwyO322VnSVd8QrCFsOrod8LdgDKazpH3izNXGoRR/CLJObgLJiE2LNL1xGmI0HQ9UWcO6rAOMONQy3jkq+2JbFS+5PGUlDFhqEF/yDrTvvScWieZ+ur4nHTCUda7lSd7610A30RPU1FwfJOYAi Co9Us3yh 7kUfrQP3sWT1hA1U0I106LWqeGBThu6B690dcjsH4NHpwCyByb9kDovB7fX68OuUEUTp3cXZRBCSMMu6ciCxXRMxD50tHvYkxJU43iHdbiSIffXocYXzIaCR1aLYZjzPKozDrtkjoLRpdcpx7m5DBVfAKHlUxXSmVlxMv/RaNO7ZejfId1RxI5yOOV9eJ9bW8uuq3e32HhqxSggykPUqFdkX9elUEhg08EkxglTBLbug4nQQtQ0lSV9rnZ8pfy8dQobyeoRt1mkuoHK7TV/0YVjdXV/y05BNroZKrn6XDSzv24WoUK+Mmxe+sJsk9f5lhP5re/L2BpKD5QkQ57PDWKJxuMA7FzrbPxaIND1dp1Rzj3cfQBB3+bR7pnqQQjo5fBkXgnAJJYAQfR7ERFq/2wg+Ls3FXIjyAUu2hJRar+8ZPb+TqwERNKQEbwOGgyknHQOZHOazsAhd0W3eC6gH8gCCZ7k6SZTIprzTegF3gLK79r8h9TAgb7NP2INNaMRmN6Y7/pvbFo/y7S7wx/4zn5tBfgOZ1RhNqNqCd8wt9A+1Vkg0rgJpSAlNOF3PLqPtxGw7ungvuBW9cMAmHnIWCy8/3kNPMNMUvRj5bMHBoFhUzUFpGw6DDMUII+kxIvLRBvjK3pfjKySZq1+YoEzuRM/6wlFGqCTN7eJHuAPXQOx3X34ApdgPQiFzgtYm2LtMhtvnNcAvriCl99tkZTo+I+980PulHSduWawNe/kmhe+YKhHcO60Jz66PsT6d6EG5ftOPoitZZMzAeWX+UaGWYGuixyg+hRwmXDLERMSCWzSFVm2KgnRGuYhV1vSld/dm7Y2jPe7I6IHwnPJ4Wq/tzxhC9adCz5WhpXj6wDMVK9I0/8zElezRBo++PCqb0hZb/UR9wI9Yz3IjYaUR7AXe/aEuyj6Xp44N5/henLfBGqDfrrX0WIj0uWnuAkwny2RkViOe84rkqdNy091OXYLMN26redObU Pp+8eSZ4 VqRIZA1kMUwudPLiiem0k1bcbPJu6vpNkDYzIP050wrrzlmQi1RHPwVrUsZwN6HRzTVSNcv7q4sCdpvdUffrq7s/HAaEY/OeOSuPZuFGJ+2XfFqx5Xq4fSYXTL6M6Z/RHmKOonXsQAkPJ1Tc6jjNZhwcxBiUj/tlgCVJjpXxEgnvCVg8lWqDUO/YGDDIK7Zai7qSbHbApCBKe0dpO3h9pZfpCrIcGwWbcmWgTimX4emDWlU5uWvkkxmzZu34+a+ic3K/a6FtuDABnUysrhRBYNFfpWGhEtNF/XED3K3V1rjr+lYONvhvK2laOwA63eTAG7pLUPNax2mgSFu5GAOSC4EFzVyAtVxcBScruiQrblrTxH2oE2iZv/I8wQ8vDxUBkQVIk0e6jjrV181Vw6TxN6+tnu+z1nqzmXlrT8WP8vpmJbd64KkbpvpdWeDzhlMtHZawi9Pwch23Bt0yFtJVIxu1z/ZkXrOvgHksSJ/28iQ5cSGPAL9ClF1rMC966HSXgh38Rt+6S97o8tXlXhpZGr5TDEoiKNZDigkmfQvzfAOlC3hoCmDUjJkpql95DHHMv31KpzUQs00HE9ebKRp6GH42YqMTpJ7+OSEdZ0uDxhQmH3aS4YvZIpIkPUFdZIaAhWCfB5jsUS9M7t8ri1fyt9VJqaQ7sXYuXMjt2FYvwlrOdsq935QIGEwfUV4up/GkZxwh8X8UDc7Iy93kr3KSR5Ax1cYv5M3fzdzVXydwYpmUmLtQrvdVkI6XVLrVvx84Jqj1gKzcEszeHA8MjB0M7QCiP6vnyUqdDwhgObt+KIsO5Q3ghi9o9Ei2aTT5P7QZocT3T/xTJTsqQw4LoeSJIp3EzkOZ+6TWGt6EgOn/Btjmhxn3l7sERpSWr4ff98MKEY96tSiVImVQ1sSRurfqbf14Z3k7FBIXzRzcN9VsZk9zRTw8R/GlcYUg1S3P+hVMFh5Iy/cRTKwww1ea+KbjfYFZg9+BP I2RbvCRS Nb/zmYWXpQ6a3QoVpdUdlLgPSIuQuOulCD41tXqTmDQgKW+bXI/R5BthxDuJ1fIxvCqOoSONqMN48EVzadD0zAngFgS/H9bwzKkbkBq53AN3h06vdHgwpdvV0d8y9BiNhyj7hm5b41MZRoCW2Oi/3dNdVHZuMah7XfyZfLgxRmBrpA4kCQXBrEw56IcMzj96rBP3NE3IVVOPbwBFP6j5KNS30EzFX0KuoHN0JAw3B5uXK+hcBZqAGwYxQU0CGbd28IW6W2qhqWtx21VLf5jt6md8QbFFt8Jn7XKrnJkEyg0rO/SWHidVw/mDMuZVTXJnDcZQxkHlL4rpx4S59nQBiMveJJKjoVp9OnCNWcx8hwcQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 2d6d790d9bed..6c7c70bf50dd 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -491,7 +491,13 @@ struct vm_area_struct { > * See vmf_insert_mixed_prot() for discussion. > */ > pgprot_t vm_page_prot; > - unsigned long vm_flags; /* Flags, see mm.h. */ > + > + /* > + * Flags, see mm.h. > + * WARNING! Do not modify directly. > + * Use {init|reset|set|clear|mod}_vm_flags() functions instead. > + */ > + unsigned long vm_flags; We have __private and ACCESS_PRIVATE() to help with enforcing this.