From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52012C61D9D for ; Wed, 25 Jan 2023 09:38:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B22A6B0073; Wed, 25 Jan 2023 04:38:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 937486B0078; Wed, 25 Jan 2023 04:38:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 714A56B0073; Wed, 25 Jan 2023 04:38:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5D16F6B0071 for ; Wed, 25 Jan 2023 04:38:58 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 295FF160CD9 for ; Wed, 25 Jan 2023 09:38:58 +0000 (UTC) X-FDA: 80392822356.15.AD472E9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf28.hostedemail.com (Postfix) with ESMTP id E0938C000F; Wed, 25 Jan 2023 09:38:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=r0FIat4k; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674639536; a=rsa-sha256; cv=none; b=7eGTvzwmoSjmVHYoExJtif5GWYeicZMWTcEUg8mQghfpUBC8XXHKOyuTxtU5prBuj8K/Qu jAfmfVemtoiISzs5XcabKm0yM/JdSfizbKUeBBbzqWMV01ErjxhLW0T3FN/WH4Jqmk4vj0 FaKgoyU7yuDvtXaL+Ze/h1cQlf+PfPk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=r0FIat4k; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674639536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rlC3v8G7Qltb7/sMWGykfElAbj3RZvreU88MtZ+OLHM=; b=JtR+t+cPxT4U4XwYvxuA0NtfV8qO7ocoeENJ1kEOl773JMQyMgXQR7iahjYzFyyp5N2SfH Ei1UVWA2+cJpF5zfSeDG/vP8vLvptrUbk43OW+sDgfnWJ4WCMV0UNDnwe8lICh1IMbrE4H MDyBpEuWDl4K/lqE1V+8nQwt+498hHg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8985B1F8CC; Wed, 25 Jan 2023 09:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1674639534; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rlC3v8G7Qltb7/sMWGykfElAbj3RZvreU88MtZ+OLHM=; b=r0FIat4kOE8WovOTP3LWhacl5M3EjQXhF3aBT5cBj3FuQ5I+yJMTY0cq7QTmO7SFPDQv6O tRrm4BhOZHjZFNfq3BxFKWYU7SqtAc8zTE0tqhcCiP6BOgQ+ipP6+yjGZBzFWwz4Mee2C0 GFF6IKS/BdrV8Bwlj7T9ur543veHKvk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 446411358F; Wed, 25 Jan 2023 09:38:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jLUjEK740GMsIAAAMHmgww (envelope-from ); Wed, 25 Jan 2023 09:38:54 +0000 Date: Wed, 25 Jan 2023 10:38:53 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, will@kernel.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, chenhuacai@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, qianweili@huawei.com, wangzhou1@hisilicon.com, herbert@gondor.apana.org.au, davem@davemloft.net, vkoul@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, l.stach@pengutronix.de, krzysztof.kozlowski@linaro.org, patrik.r.jakobsson@gmail.com, matthias.bgg@gmail.com, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, tomba@kernel.org, hjc@rock-chips.com, heiko@sntech.de, ray.huang@amd.com, kraxel@redhat.com, sre@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, dimitri.sivanich@hpe.com, zhangfei.gao@linaro.org, jejb@linux.ibm.com, martin.petersen@oracle.com, dgilbert@interlog.com, hdegoede@redhat.com, mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, deller@gmx.de, jayalk@intworks.biz, viro@zeniv.linux.org.uk, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, bhe@redhat.com, andrii@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, perex@perex.cz, tiwai@suse.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org, loongarch@lists.linux.dev, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-stm32@st-md-mailman.stormreply.com, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, kexec@lists.infradead.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, kasan-dev@googlegroups.com, selinux@vger.kernel.org, alsa-devel@alsa-project.org, kernel-team@android.com Subject: Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise Message-ID: References: <20230125083851.27759-1-surenb@google.com> <20230125083851.27759-5-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125083851.27759-5-surenb@google.com> X-Rspam-User: X-Rspamd-Queue-Id: E0938C000F X-Rspamd-Server: rspam01 X-Stat-Signature: bhkwogzkfgr56ehs7cyhy65gftsmyhgp X-HE-Tag: 1674639535-420475 X-HE-Meta: U2FsdGVkX1/VHFBfI66xztL4ZyACOlheO+5mrF8m9dLM9ad0X9EUuOryYkre78pyY7aMG4sfFZFgQpTdnPKbuKGpuK0iyxFiMxNtG7VObQyyZC+MddsfWoamoOwkvcC2Is+kpwDjKjziBw5qBDH463+JvMM7jAufM1E5nTGDBszIX8lEqgxAnXVHoZAx0XzANDStZHnAF4f5Vg5K4g7CWI2h7ZDod9U7FoELcE2D7qUPTVjCz3BdGVpGzfyTqOAo3BucsESPnHCkEBqT9T/wSp1qftpblu/y6uTOqpv0I7SXXFRzR4bWwgMqhwuoKbrY3WujN9k9h0/0xtCk2YOF6C8WY6uHDsci+XDZ1LCmC75B6xQkTjyCSk9qbF8enyHrnc6TXD/NqTVAf3cXELbNd3A7PlPkwp36TeknDn4QFCUClZAcj38qaq02vLe6Nx9oMxd8I761JdYl/KXr2Oi5Ju1jkOcCaECoTRp1+n4fWHyad+rQY8CAvPfB3PmZqzI9bliQ89wE/tt6lCubc2R8bc1gPb6pdN1k2kYwIM9mxEJtWoPyjfF6CQrHJB9pFP9ORFJp+3O7Mq47SnyItXuBUpicryWHpEzgNoXS33/HS6Fnbpp1I9hCARgTh7zbPiu8pg7i7JMMmCCnIHUFNYXAVfeoW8siDDGBJO1BOjI8qPIOgcx0sfl1OZoOy58neM9Scigys/N0PtM2jVHqw36+JG8T+YsNihi3OGNJGfPyVBsQfGcov17M6QmDwkuM7I8RGg2NpjRsK1EMOEjYLiuSBO7JgDcxCsOV0AwajBMwQJLvDPD+vvDhVJZT+VYwnVF3Ch98XwmmBJZ/mxRPc9idxJ1vAVRlKprr+VhzQA+y6Xe05maDp+4bX00+OPeiEoTrYdAVhhf737fS/ekdgG+oYi09LUHHnBfH2iTSbrJ5wEi5c5MkDGv44W12fsKmVTzJ8ySHhtS3rFnjDkadRLP BAjqAvYJ uVidKt7PKOKv5nlvDJjx51Okx9Y+/sRCiF95LO7fCXW8UWgXvQfX3VFGK7PG/cMrKWBLn4rYKA4KbJqbdfx+zGcgECYVnJraR0IaS9Fbd/NdZaeeAf1TaF2h4VjnlMwtybTZ+5Xti3rJzwvRZBZ1Gfe8XbD18aFuxusfc1Xg58OxS4pz2PReW8w8DRjI3x3YdY+xRYYNo5UZB3G1NrU8/Y7hC49oC2buKgGN72259YpMvcv2Ogv596XMZ78zyHsTsfU3RXmYVb0qPuyeMk9M8aUf2txzBPfSdZtjjVN+MDIGgNEwHWT9vhEzDLD5SQbyrmBvoWXbE588g/c4f1VwhO7GF3zHmK3fbiMxoGyP9JLHEC1U6VQA32o0CezwBwkwloijELEOHuFB54lfZz0v0s1MAB/pnTVczhzl7i/pdwllWCllF9HPK8gXTWhVR+0p6s6DA6Kbria7xHHVKgN1e3EL46iWSXaRngEls/1eA5IMM7S8yNPQhE9PiAr/z+8zXvGT+mEy9qDBKhdbo2wNPJ+cY7qdmEYTV9vz85vFL3aMNS29Qa3ONoiU++rXRCUWBJlqLjfwAXN+rBNhL5wB9uA1A4DO6l0AEqyG3dTYR2ivsMjDjXuwkOwuYZwxluU9H0hNdzbGFf3sFq8AWYdFjVfY0qTAx8k/dYYiQAL5uj9Lq6lsMcY+oti+etpZsvas6CA9ACk8X1U1LJ3JCPPM8CDzwjIHXQACgu5trY5Q3/Y90sRrZAx57TGSYhGypUFoC7T8naLsBoDWMoqnrtm9pdDqiUl3yuRMJ5kElWPBhZVZACIee5pPhtTNdKG5GrVA8F0R95B7oI3nQBUpR9LUBj8Q/EcTY3CFkel+uXXHKi/XEvdP4KCHlsEhzaZKpuDszP4uYIztrY9/hYmZ/yAAWhR/FawwqBXmd2QZvTAW/63rm8yJhMgJeIJoK/P6qhQd3adUDYKMCTCUOT0LEp7vM8ljGS3jL 9oxj3Cjq sulBXNoF/Xd9SQzOeeLiKli4bjkIQrL781DgSCKx1h7na6tESaDtv68jkpwuJxmea9HPAabGNL7bCZPfs6JCC88cgqU2aNjqa3n+4/vMGPOqhc6gcviyl2e26/nXoCcL+Fqm7U8TevyxYeQBYfYXC9L57qbP6Se8HNYWYnFb9o/NXzc/wKVMbYugTR8I7DJwnuRbKHgEnsRgxvf/I+CYIDc+SGweju1x1h2ks41rslWWyGpvl0wuSqH9NMXZXezoWzbua7zCsBGeVM6wEOKzaL+8YqLxaitZYkL3Q7W6sAE8oO7x+r9ftjdYrof6Ho0Jr1FVAD51rPu7zdZCEt6VHnvZf8ppQzHXTsHl6dZKQEsHEjazfb6rM8IipQIKCysZ7+SkVjBFml7vg92J9ukIo0uU0ELZUYGGAyCZoisemU6UAlwH1BvN+xNH23EdpuA0RNwDXADiIfopJaypoNlAJcjq1v2yLuL/RL67KJD8FzDx9ZTy3BOQdP4bTkUwflQesqc0mwDEZIsxBoTdxIn9QPmi6xmJKnkGylsaiMVzuOIehr9EOu8yk488hH+W/2OiYdNcb9izubyS+Jx2A4yzNj6CunqJrLIeUL93aTi6qn0H9rvVuElSTXvMNlno/4qCTEccEyU19bYiDk6AgNcUBTH7iqhPOrWACxTxyDs4422xFTU9tusbK7mYLwNkNWVPzPflw7Te0n7demxheSrh6Bbbmsd9rjOOFX5ZiJ6N4XsPOcQg59yjst1d4miDNqq8yuNb2OOCvm4aK4W4QS6QwZUE9meawK/gF4zrh4QRkVTEQ4FO2yd7EVSzQ54m7wcIOR3UiSDxtQO28a/FOSNu2eEEElogaOe0AqJiLCwYS0T2ufsemJ98eHvw92JiDF/p8H3Eqj9nrH9FUqtR9pLBqrVW5K2RVtaL9uK8tZ1Z51H7iR4zqjyR5gHp+n8O9dLWPU5OKqr32fCB4X9DTNH8S+6biiU4P 1Ov8Kpu/ wNv6XUxuFdpLvI1RGrNowfD0UtVN6rysreFa1GWC4WG58xYZ060nbSS7JJ9nyKxH5sL2zxYerU1lUYeYMDgMtTXskH+acQZUhOhLKrzMxJVPXbk9hhSfFUDOYYSwNknDFZgpuZp6GWvycTPLhlU6x8hrNN5loVcTuYbBE84vB/zs36PmLNamOGVpBFxLgmBA4XYoFtxVYW5w9u8ZZDCzZmQZNnArt4h/J7dguKbdPo6HaA2FrEJOEQuKHn5h3ifrQnOcEIl2wE4xi9r1kOo4qC5SMf6qzD/fmmq6i+HuszgiO/hoi4ly/1wr271E6eRxrb1Gu9bePeGhxE+z+LxkSP6rOq3JPos89Cit9QPrNsqDmG8wtUnE7M/QyX+fPGp75cDhAnsnDKNNyR4YbnYOzK+3d/o0LgCxlBt5N/+rOpycxoK0Ca6nkx4sceHNsEaic3w9qk7qWHd9qUvKiLscjqbQzqVH9e/5BUyFdfsvoTXZMsZzAMsHul3aiaguzFepHalqMF867/Qi/PKCT2dksv6Qvsar8KSjuCse3aSipFqAx/SQYnQ67HA2F3qIV9F4MJqd7dtjTHQ24ofOkbLBmpqMFgcQ5kCDJgcLjr8VVv5gXdKIMAIi4RC/15pMXKMENsqqWbpMNV49XkDEksKQO4nhlrLQ/MABlnyFVmJiyEeyiyQjI60sSNAXFB1hJ1DaYXygE5iixx0zHDy6L422/8gDzmsIkHAtUPdPa3hyxzly3y253x0pcJFwmK7qmSSZ5Kz7o+5kL//F6VIv1jSOdHtmsGf5SuvJkhNfXZY0hziGEyHckODDU2MdzclEKthegq/Z8QKVytCLS2/iWTb5MLSJYBX9XB+BiPSYgUN3NgRoe3j13uwfK1cWwx2z1z4XW5CrCOsYu/ZdXyxsQRYwWTHsRiW+zM5P/eLunmhw6jOMqxRd3VWaT6tr9tVLlXUSh23uuKoQC1D5HQXlrGEQHAOpgKzQn npt3x4mc toAFEW4P1xKxM3F2GxpUxO7uMIsJkhHgU7Wrnot3mzMci6J/S7jImc1Sq0F2/GJSZXnJbfiOiUy5U2rHBW6eJYBo27DT9zQCB/Hy77yYS4h5rfobl4Am/ak3pg7h1XVdFLCTHY7AERCL9Y1y8BsGbiCrH0SOeYCY4pTXD/AO8bxtmKlz7gX9j6FsmxbbA35iQRIy+mkLajZcmoMB29xpkdYSzO5ehyX+osNlq3QQE9yRC/0nM8dmoM5sKhr9QK5y/2UGI7zMyNasNZZIbY5U/ontMCU5snnZGxV978T0RoNfV4+xO8qKjjKve0zgDluTHw5ikSa8TEBd6onyxptKglHY9FtOEnVy2R0RVfCNipQkPlGo59CCQbxCyflRsD8Q4INm42frg3hRSx0Br5v2sjp8Xh4daFTplZkLz92rutpc3WzD/cV5qJuKy+I+VIyW0lRvhLlAxtHXwjxmtTzWU3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 25-01-23 00:38:49, Suren Baghdasaryan wrote: > Replace indirect modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. Add a BUG_ON check in ksm_madvise() to catch indirect > vm_flags modification attempts. Those BUG_ONs scream to much IMHO. KSM is an MM internal code so I gueess we should be willing to trust it. > Signed-off-by: Suren Baghdasaryan Acked-by: Michal Hocko -- Michal Hocko SUSE Labs