From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8473C27C76 for ; Wed, 25 Jan 2023 09:30:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87B806B0071; Wed, 25 Jan 2023 04:30:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8057A6B0072; Wed, 25 Jan 2023 04:30:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67ED16B0073; Wed, 25 Jan 2023 04:30:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 584506B0071 for ; Wed, 25 Jan 2023 04:30:59 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2B1FAC0B95 for ; Wed, 25 Jan 2023 09:30:59 +0000 (UTC) X-FDA: 80392802238.24.4C0BA05 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf23.hostedemail.com (Postfix) with ESMTP id C9D3B140008; Wed, 25 Jan 2023 09:30:56 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Pij8ssoJ; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674639057; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jognpwZWDP/caNk47/2I5pB+VrjaxgWmcyaDbH1onsg=; b=d9Gk4X/ZbI88p4fEYEa/p4YZ+9ZjO6Qlwiq6GebkagOYz7Jb0p+7VzHjQT3ew97S33xHp2 gkQKG6IMU/RigMeZCBKVTkQgFg+AS0VDEpfzwHdGBQYb6+8YE+0+uSpMMIMvzgztmFVKcZ Tj0AzOytfhoTqrFj324wdSg20n0NXs4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Pij8ssoJ; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674639057; a=rsa-sha256; cv=none; b=2xI/jlnCImRz/oWow6W8DtMfQAG9AdZ8N8LGVDLGj7bBqFqydAOMqF48l0AptivIDyU6bg 90kdTmf/dpMSgZ6Gh2ZfAWTa64qNwWklh550q8A1SVjbB1DwW7s0CNwjXOMRwdxsKUnWBt raVD74iDO0Z8lq4u0yYDDFjRTEvf3OU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C57E921C78; Wed, 25 Jan 2023 09:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1674639054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jognpwZWDP/caNk47/2I5pB+VrjaxgWmcyaDbH1onsg=; b=Pij8ssoJlw6k6tQr48jFXJyevDWch308vx0CLomRDmV84uEdMgTC6NhqR8VCkgI74II7DW anm6YuwD0GfDOi17b+9Zs5S20/ilyumOWkOAGicsthADYQDP18s2AfYp6RzP5d5hjTOUwm W4uNWFQcSkUDrOF5p/6xahiK2Zzyzto= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 684E91358F; Wed, 25 Jan 2023 09:30:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yJRSGc720GMeHAAAMHmgww (envelope-from ); Wed, 25 Jan 2023 09:30:54 +0000 Date: Wed, 25 Jan 2023 10:30:53 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, will@kernel.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, chenhuacai@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, qianweili@huawei.com, wangzhou1@hisilicon.com, herbert@gondor.apana.org.au, davem@davemloft.net, vkoul@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, l.stach@pengutronix.de, krzysztof.kozlowski@linaro.org, patrik.r.jakobsson@gmail.com, matthias.bgg@gmail.com, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, tomba@kernel.org, hjc@rock-chips.com, heiko@sntech.de, ray.huang@amd.com, kraxel@redhat.com, sre@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, dimitri.sivanich@hpe.com, zhangfei.gao@linaro.org, jejb@linux.ibm.com, martin.petersen@oracle.com, dgilbert@interlog.com, hdegoede@redhat.com, mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, deller@gmx.de, jayalk@intworks.biz, viro@zeniv.linux.org.uk, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, bhe@redhat.com, andrii@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, perex@perex.cz, tiwai@suse.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org, loongarch@lists.linux.dev, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-stm32@st-md-mailman.stormreply.com, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, kexec@lists.infradead.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, kasan-dev@googlegroups.com, selinux@vger.kernel.org, alsa-devel@alsa-project.org, kernel-team@android.com Subject: Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls Message-ID: References: <20230125083851.27759-1-surenb@google.com> <20230125083851.27759-4-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125083851.27759-4-surenb@google.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: jspsxro1i6epi3rxs98atypnaf3ajqm9 X-Rspamd-Queue-Id: C9D3B140008 X-HE-Tag: 1674639056-737665 X-HE-Meta: U2FsdGVkX18t2NsdA+/DPFpDsp0U90NQdAB5qIn7i8Usx9Sex381jbQ/XFp9d93DP4M6rSKy4N1DBLia30m/D6GhE8SStMQpAg2sHNSIwyTk7GhmM6WP5fsYlVOC+DWFc4M2YjARTSB5vDDw/fZXynNrXcITJe/bChBztrxZ2wxcb44W8vhhyPMFPLliHiZ0Oks9w2zXXocA0tF9o+WlqpmX+16G4nwb9HVAB79iLqsRAWdI2yZXRdvRhRb+gDFB0PleLnslPLv8egH9TQqrzfzPza+dgnVnc9ilu9vRP/PKnh5i8EmiBvBXA7buexQq5gko5wL7YL4VyEYL0kwwm5Y598nS1zafXZbG7luAaM9SYluQL0Bl53h69C5YnD6qCHNyfRERDMZkLXVw3InVU9+gu3uvCoXTbKzvkufiqX8UHajy43QN69W3RSt8s9AyRsro10Pj8h6rBC8Wrx0UpPoFJRS6BaMkUVpQf5mZITcHhUqvtnrw8iQvcLa2jzUsY+Aev7dX9Fsuk49dU6ZCPqkr/D3EGETuwXg89JHEzfb2RYMXOz2SMuZ+BcDDlO9banOkoJh5y3ft7m3UEVQJnhap476x3IJTzxhHoqg7OPjh9K2m9aMkv9Zy0cgeCFwL6Mdy71fI3ogFNpmRG9YCiWxJjC7BXwS6pPQuAw3fjYySVuT//JAkKlhQoCr+DnZUe/HKdmTt7JPBDxgwqdz1VC9GB/glUEUoE2LH8s6qMqmWhSiI4Sp/yMWdKo/fcXTUzuvLbHgyKOF64O4M32BLk+3gVCeUNsliTrIf8LPQooXQaP0NmQI/VaKspk8DjAsVT+bSfvbGg7cgaPTSMmZ2zZSsV5nDtDzl8kUVn3A/ib5C4MhFVDQ7g+iXXQTgEzApk1jRNb0FXPUJayTqv0YkyaZGvWCTYty2tHaqgYTZQHlDTL+Frz1g196IF5mtPmSqyQgyt8XY5UJkmiYjB6h R6RUnFX2 U4Ra+4WhShAUwim23NWwTjDKMHwNt3j3Mwr3WXNhs5tPo9AHz5fp+jXR5DbQ5ACQQ6xet479F/Ug9zV1bb4nngwPBNNRHUrVFTsIXircxbRkt/yYMscJs14VYaHRYQnHeQ4WnAkntm5awBDdiLdvHiVEtywP+MuL2vGI8g2VOXIKbc15vbl35dZbUksNSoFNHyV2lFACzaZgb6t9Kmi469PtC7XniMr25Uu98M4G+fQGShBNELPnmH3qqkgSGY1C9bPjDabISaBQmqfUZ0zn94XqCLHD2PLZveQ1mmxxFJSjNen+dVAa1XhOexz59ncXATo71ZBlI8jztWR7RBTWjbRrf1Lyje7u0mADmQ+HQHqeVG/2w83NEYn4Z59CywqWcRdFwyfb1W/a8+Hf2c4ybjWpTTunoNEBSlUpCyj0xyZSI80ICXcLguawlwhqZSIErTm9mLkL9pvxbr+kWtt1syc8rqTRtzVOnOXlN3uJ8MhztG8HR9RjBIVtfjPPcsv82iU37DXAPokUdfy+TQ/d3QJ56hkKtGVZ8qpiDS3qhDMWKiVyuAGfsVW1ZVqcjOt21pnofSdemiCHuJOI+7j4sW48MJsd1EDrzc2xOXR+lbNZNpA8wS0VGljqBspU17LKjpp5XhzpY1a6WPpTHRwN3wEhH3qTKf92aqAeIEWrk2u0AndD/NHeZzNnY/cX8rYWtAVLI0XZwoPViVt8e0QskdSw9qxrerx1s3bXIn1EbKvCLPvnR44wA/kVygZM4HSapC77/P5ob50i7gSnxDYxwGB9oYvNv6KzSRIjAhOxgLkd+xdwnDz9H5PVAa012874CuISuha6h8vzMpNEs1Fdmr8SqHGKbmPwC27GzX6TfLLZAie2GVAb62QFqaLGfuLhv5CTvs6iDdH0+EE6eechgzu3ZVYa+sxOfIGXtpNL6uOaEjumlOZHhYRVJo8vWkTE7nolFlC4r7GphkADpeDmo8jWDOsQV DK0NKSMc wso6xQHljZv60TsrOZMvPFEhfHTDrCCWQUI57V1pUsS/z1hKiWwd1NN7vk6AKfbI/TmT9vOIDTunSdebqJtdm/s9B+mMaj/y0FW/Tn5p/XAj5MG8ZXxE+1JiK7yMRse7niHBAwkQY6ytqxdbHjhqIQ09QtXii+DrmRaq25gfF5QaQ33ySVhVpgpyhqaneCRK07KdfJlra8KKYEoJfdO0GBFTHXNqrTTuv/gcG2/O2FRMtmRefhKJqYTj4AUweZVut1+4Mm9tFqhfpcn6WTFulrVaxQx6QkBi+9nnItbfhlXp2gC78FyXb3RvGcjP4TQ0mRbDkd96Xm/7rt1RMOr8WJTEJTArk/bWf3i3F+Gkvpqdpfieg2z68HFxDIl1WAHsPP+MFy/hWbGTvW0G+2VIkIX4ZTYDN9hhs3e6yHLE02s63i9RPPxgG3JKVTpPqud3e/DT5FQkR5OZoyeJC2MDZAG4NoLVlL/Cm/Dou4jyzmVUGyihr1Azr38CyAFCxyoRiAOmi8BEksVMapEt06eCoXDBmMBiKYjbFiE2LvqGc2q3ay2hpR2kBAS8TWRpU+yNCL+GiRfCxuijw+iBy8MOedKk55SSqXdCRQQOx+/tHjRzffBah9lnkWPnTweciqDMSV1zlWvCL4jOLgPUsGBWlj57oOSdAO2O5n3dH3orQdH/4Y+JAf0J1IYfJfJ6JSNBGtE9FwlYeGik4FBRqugv9vfYi2judMYA6bizEL33q9NSC0eVIiL0sRCtS4O/lE2jTrF+F/Jm/iSEoSVDUpzu6rxGUSQ1/7MO7L8vEg0Ky4Lff1mCyXtrfMs+bxoUgJ1bwfoKj1Kucglbp4NAkuMASp3+2P7BQUjvKhcz/9pxfnHhQyl6gwv2o8V8w8QmyfOuS7o1duNTgUKVQgHleMmpnlHmALkNGMDY0hIZHzZDhef66jEW/op6RT+OEjIYalUHNd73m2es8kwMzlXTfrzyWcHtNV0qc 4P9ceM7A uPl9JehF59fx4mPUOFSD8DY1bfdiEdmFoQHcFJutnOyrEq42SvJU9kszIdzLvstTWHRGtR4EmQ6zPv9QHQZOkBLDAwjT2EtKHzeGRtS5sGwLMu0i/mn+ZpO9lK80qzZqX6fqibPtpRMwWaUv7CbtEhI8D75ehOYLezn9rI3Wi8zvBgWoG2T1Ril+Hvcsa0/eIqZQJ5QDL4HFiAJ1Vr/jhVXsdmY7IPDjdrEq1wq4YCrf/vU1YJ/1MBz2Z6PwOp8P0xJ/WtciFUKb0o/8qmZ7QOUHo1G/jgEzTEWzLOaFigwUvsBmRQ75mVAdCIaEoZUq3AMywSyoekNxQPBbgSOTEOZa+PunyYshrDKIEB+ZouR9COuJy0JfBtt12VkTB11lxh6WyVn87T8qtI7tiwgswzvkPxFjDEicBsAE45c8ZirH7w63Ecqpz/ViIZHvJ2/nFPuVT1/9EljzQzcBzULhKgSkB/Cxf6pVpZlrd8n6cuUYvSIaxkF0yemblJJZLV2WAIqHLD8b0QtFltMMOATBHHovgDx1Pbkn42fyozpdH3qp/O1SMB70azFZCX92E6Q4Xh/92V07Y9RiZ5OkTINgWVcGHLqT6wshSplNEYuTOZgoaDs4yOHwF2Ttcpj/zqLiXBZC5jzUp4y3WKsE6gf/lAJhknAAuACxdS6fPT/413JC1Rvi4j12NrIEf/uyGGzH60pZmxmK0zqdVb2V6l1G964EFhfAFidZSQqkVj8X4rn7PRygfuPfmHGnJhsF6KRL5W13gBJUns/gXUoKtMsHjHGeMNXhJ1ifg//xYj8gjIdyF1vFtPcjU9c/IxmZR2n8WF+ZV8Lx36BLX5t2+D2d2DSArDIH1ZNDj2nnPkB/m8K/LHJ6mOU+AZZrd3KYPI88iSl7wT0w0xv2rBF9lVwpRK41bw+d86MndGjuqrmJ2ZrM4Y6AQJlkbzTHOGg4VPvFwL5+uUtx74I6tUmG/ZJfBvZPQmTLV BjaqKIYt SNHsq0wH8sZBmawDfJzoW3aJ9vNBLzAOKGwTbiEToMk/s1ZxwEVKDNyGuzlXXJ1+P+brRUhgo2sBKt63NhDrKc3sTDeLAHfx7GnlSa4QisTH9rs/TtWvEHd+P9cHlH1rB2OWotJdZWmEa93M2xneu1WigGPV8t2vSJkCfFNnC6LRu3j7sczVirvV4+b5Q6IaW3suA1fxpRrRdkpLUN7+IVPT1eOkTeQHRIFFw+hkuCs7ABBy3dYC8wi6mz4nQNiYl5Wn9VqS5XQ+qDPT1oZCF5ij3guhMucm48I2u+xz5E+3BJirBA0pKVGRi7CVFrzCkqvdh24Zzm1tKI7YAPJlgN8aGydeObtr3GtnkWMl/I+aIqSKpQTcDRtYDVJC1CStvXYOcPVNSeFGz5Cp8TTZ4O4OEznT6sTL4ophAFvdwQewQaQwzt9uNUzEFFyKajXHQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 25-01-23 00:38:48, Suren Baghdasaryan wrote: > Replace direct modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. Is this a manual (git grep) based work or have you used Coccinele for the patch generation? My potentially incomplete check $ git grep ">[[:space:]]*vm_flags[[:space:]]*[&|^]=" shows that nothing should be left after this. There is still quite a lot of direct checks of the flags (more than 600). Maybe it would be good to make flags accessible only via accessors which would also prevent any future direct setting of those flags in uncontrolled way as well. Anyway Acked-by: Michal Hocko -- Michal Hocko SUSE Labs