From: Michal Hocko <mhocko@suse.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: akpm@linux-foundation.org, michel@lespinasse.org,
jglisse@google.com, vbabka@suse.cz, hannes@cmpxchg.org,
mgorman@techsingularity.net, dave@stgolabs.net,
willy@infradead.org, liam.howlett@oracle.com,
peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org,
luto@kernel.org, songliubraving@fb.com, peterx@redhat.com,
david@redhat.com, dhowells@redhat.com, hughd@google.com,
bigeasy@linutronix.de, kent.overstreet@linux.dev,
punit.agrawal@bytedance.com, lstoakes@gmail.com,
peterjung1337@gmail.com, rientjes@google.com,
axelrasmussen@google.com, joelaf@google.com, minchan@google.com,
jannh@google.com, shakeelb@google.com, tatashin@google.com,
edumazet@google.com, gthelen@google.com, gurua@google.com,
arjunroy@google.com, soheil@google.com, hughlynch@google.com,
leewalsh@google.com, posk@google.com, will@kernel.org,
aneesh.kumar@linux.ibm.com, npiggin@gmail.com,
chenhuacai@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, richard@nod.at,
anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net,
qianweili@huawei.com, wangzhou1@hisilicon.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
vkoul@kernel.org, airlied@gmail.com, daniel@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, l.stach@pengutronix.de,
krzysztof.kozlowski@linaro.org, patrik.r.jakobsson@gmail.com,
matthias.bgg@gmail.com, robdclark@gmail.com,
quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org,
tomba@kernel.org, hjc@rock-chips.com, heiko@sntech.de,
ray.huang@amd.com, kraxel@redhat.com, sre@kernel.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org,
dimitri.sivanich@hpe.com, zhangfei.gao@linaro.org,
jejb@linux.ibm.com, martin.petersen@oracle.com,
dgilbert@interlog.com, hdegoede@redhat.com, mst@redhat.com,
jasowang@redhat.com, alex.williamson@redhat.com, deller@gmx.de,
jayalk@intworks.biz, viro@zeniv.linux.org.uk, nico@fluxnic.net,
xiang@kernel.org, chao@kernel.org, tytso@mit.edu,
adilger.kernel@dilger.ca, miklos@szeredi.hu,
mike.kravetz@oracle.com, muchun.song@linux.dev, bhe@redhat.com,
andrii@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
kuba@kernel.org, pabeni@redhat.com, perex@perex.cz,
tiwai@suse.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr,
linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
linux-graphics-maintainer@vmware.com, linux-ia64@vger.kernel.org,
linux-arch@vger.kernel.org, loongarch@lists.linux.dev,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-sgx@vger.kernel.org, linux-um@lists.infradead.org,
linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org,
nvdimm@lists.linux.dev, dmaengine@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
intel-gfx@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xen-devel@lists.xenproject.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-rdma@vger.kernel.org, linux-media@vger.kernel.org,
linux-accelerators@lists.ozlabs.org, sparclinux@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev,
target-devel@vger.kernel.org, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
devel@lists.orangefs.org, kexec@lists.infradead.org,
linux-xfs@vger.kernel.org, bpf@vger.kernel.org,
linux-perf-users@vger.kernel.org, kasan-dev@googlegroups.com,
selinux@vger.kernel.org, alsa-devel@alsa-project.org,
kernel-team@android.com
Subject: Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls
Date: Wed, 25 Jan 2023 10:30:53 +0100 [thread overview]
Message-ID: <Y9D2zXpy+9iyZNun@dhcp22.suse.cz> (raw)
In-Reply-To: <20230125083851.27759-4-surenb@google.com>
On Wed 25-01-23 00:38:48, Suren Baghdasaryan wrote:
> Replace direct modifications to vma->vm_flags with calls to modifier
> functions to be able to track flag changes and to keep vma locking
> correctness.
Is this a manual (git grep) based work or have you used Coccinele for
the patch generation?
My potentially incomplete check
$ git grep ">[[:space:]]*vm_flags[[:space:]]*[&|^]="
shows that nothing should be left after this. There is still quite a lot
of direct checks of the flags (more than 600). Maybe it would be good to
make flags accessible only via accessors which would also prevent any
future direct setting of those flags in uncontrolled way as well.
Anyway
Acked-by: Michal Hocko <mhocko@suse.com>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-01-25 9:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 8:38 [PATCH v2 0/6] introduce vm_flags modifier functions Suren Baghdasaryan
2023-01-25 8:38 ` [PATCH v2 1/6] mm: introduce vma->vm_flags " Suren Baghdasaryan
2023-01-25 8:56 ` Michal Hocko
2023-01-25 9:09 ` Peter Zijlstra
2023-01-25 16:49 ` Suren Baghdasaryan
2023-01-25 18:37 ` Matthew Wilcox
[not found] ` <CAJuCfpHO7g-5GZep0e7r=dFTBhVHpN3R_pHMGOqetgrKyYzMFQ@mail.gmail.com>
2023-01-25 20:35 ` Matthew Wilcox
2023-01-25 21:04 ` Suren Baghdasaryan
2023-01-25 21:07 ` Suren Baghdasaryan
2023-01-25 21:08 ` Suren Baghdasaryan
2023-01-25 22:02 ` Matthew Wilcox
2023-01-25 22:15 ` Suren Baghdasaryan
2023-01-25 18:33 ` Matthew Wilcox
2023-01-25 19:22 ` Suren Baghdasaryan
2023-01-26 9:17 ` Mike Rapoport
2023-01-26 14:50 ` Mike Rapoport
2023-01-26 15:09 ` Matthew Wilcox
2023-01-26 16:25 ` Suren Baghdasaryan
2023-01-25 8:38 ` [PATCH v2 2/6] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK Suren Baghdasaryan
2023-01-25 9:02 ` Michal Hocko
2023-01-26 9:19 ` Mike Rapoport
2023-01-25 8:38 ` [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls Suren Baghdasaryan
2023-01-25 9:30 ` Michal Hocko [this message]
2023-01-25 16:55 ` Suren Baghdasaryan
2023-01-26 9:21 ` Mike Rapoport
2023-01-26 17:07 ` Sebastian Reichel
2023-01-25 8:38 ` [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise Suren Baghdasaryan
2023-01-25 9:38 ` Michal Hocko
[not found] ` <CAJuCfpGd2eG0RSMte9OVgsRVWPo+Sj7+t8EOo8o_iKzZoh1MXA@mail.gmail.com>
2023-01-25 17:08 ` Michal Hocko
2023-01-26 9:26 ` Mike Rapoport
2023-01-25 8:38 ` [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn Suren Baghdasaryan
2023-01-25 9:42 ` Michal Hocko
2023-01-25 17:00 ` Suren Baghdasaryan
2023-01-26 9:34 ` Mike Rapoport
[not found] ` <20230125083851.27759-7-surenb@google.com>
2023-01-25 9:43 ` [PATCH v2 6/6] mm: export dump_mm() Michal Hocko
2023-01-26 14:48 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9D2zXpy+9iyZNun@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=adilger.kernel@dilger.ca \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrii@kernel.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arjunroy@google.com \
--cc=axelrasmussen@google.com \
--cc=bhe@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=chao@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=devel@lists.orangefs.org \
--cc=dgilbert@interlog.com \
--cc=dhowells@redhat.com \
--cc=dimitri.sivanich@hpe.com \
--cc=dmaengine@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=etnaviv@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gthelen@google.com \
--cc=gurua@google.com \
--cc=hannes@cmpxchg.org \
--cc=haojian.zhuang@gmail.com \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=hjc@rock-chips.com \
--cc=hughd@google.com \
--cc=hughlynch@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jannh@google.com \
--cc=jasowang@redhat.com \
--cc=jayalk@intworks.biz \
--cc=jejb@linux.ibm.com \
--cc=jglisse@google.com \
--cc=joelaf@google.com \
--cc=johannes@sipsolutions.net \
--cc=kasan-dev@googlegroups.com \
--cc=kent.overstreet@linux.dev \
--cc=kernel-team@android.com \
--cc=kexec@lists.infradead.org \
--cc=kraxel@redhat.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=l.stach@pengutronix.de \
--cc=ldufour@linux.ibm.com \
--cc=leewalsh@google.com \
--cc=liam.howlett@oracle.com \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-aio@kvack.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=lstoakes@gmail.com \
--cc=luto@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=michel@lespinasse.org \
--cc=mike.kravetz@oracle.com \
--cc=miklos@szeredi.hu \
--cc=minchan@google.com \
--cc=mingo@redhat.com \
--cc=mripard@kernel.org \
--cc=mst@redhat.com \
--cc=muchun.song@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=npiggin@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=patrik.r.jakobsson@gmail.com \
--cc=paulmck@kernel.org \
--cc=perex@perex.cz \
--cc=peterjung1337@gmail.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=posk@google.com \
--cc=punit.agrawal@bytedance.com \
--cc=qianweili@huawei.com \
--cc=quic_abhinavk@quicinc.com \
--cc=ray.huang@amd.com \
--cc=richard@nod.at \
--cc=rientjes@google.com \
--cc=robdclark@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=selinux@vger.kernel.org \
--cc=shakeelb@google.com \
--cc=soheil@google.com \
--cc=songliubraving@fb.com \
--cc=sparclinux@vger.kernel.org \
--cc=sre@kernel.org \
--cc=surenb@google.com \
--cc=target-devel@vger.kernel.org \
--cc=tatashin@google.com \
--cc=tfiga@chromium.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=tomba@kernel.org \
--cc=tytso@mit.edu \
--cc=tzimmermann@suse.de \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=vkoul@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiang@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox