From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F52C54E94 for ; Tue, 24 Jan 2023 21:23:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC9456B0071; Tue, 24 Jan 2023 16:23:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C79106B0072; Tue, 24 Jan 2023 16:23:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B198E6B0073; Tue, 24 Jan 2023 16:23:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9F0166B0071 for ; Tue, 24 Jan 2023 16:23:51 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5A4E8AB286 for ; Tue, 24 Jan 2023 21:23:51 +0000 (UTC) X-FDA: 80390969862.10.A55873C Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf04.hostedemail.com (Postfix) with ESMTP id 683394001A for ; Tue, 24 Jan 2023 21:23:48 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=O87y40Od; spf=pass (imf04.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674595428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iyVp6L65vrlfh47jIwStCxDGJjlhMDEStL5pdHuuEkw=; b=3uPPhUTrSHEXKrD9gTMu0SjUc9jfYm8Hvs0FG3JCQm76C1ePP5haKoUzgLpdzX3crkDNnT kUU7JgfeWdUciCOrd2isPcfUzblV8svmSdp4xaRRE64tqs2ldWVot5+cPjJHC+1pxyFyXM y0BIDvQ1vDPxpMBUlVTzWJo47L6UmK8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=O87y40Od; spf=pass (imf04.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674595428; a=rsa-sha256; cv=none; b=423JBpp1vkkyu0Qv6gs1rxQrkCzrtglZGLf9+WNJin5e/Ppfr+w7Kj5W1Nvg34GAfxOhyZ fQXaHU+4BmM7235nxbegNxbn0L/3GqezjhY06NqQtjed0j8nqH5EBTA3O8barjWTZ3qUVV apbe41eSqPDZBBTwL0b5yPy/Q83DSjw= Received: by mail-pg1-f174.google.com with SMTP id 36so12146211pgp.10 for ; Tue, 24 Jan 2023 13:23:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iyVp6L65vrlfh47jIwStCxDGJjlhMDEStL5pdHuuEkw=; b=O87y40OdSZpdhNSuht3+q/63BpXj9Qlnk7ebL1XkfT5xvT0WPfa9YAYy9kmSo/+5mI w8Mgrj4XRQFOfpvATXffXIxHXeHINHLnAXWPfaVhSQ5PTEjHpDKYQ7BGIKfldLVNmVAN YmdJFdljWKwbiScMhHK9/26EjLsnmMjUkx1aNi1WetiRFLQ0vTEzJx3wj1/nH/8d4Ki4 3egWn3A2NMoL7hf59gBMui6KAKON/+tKDKy8Na9e23Zjz40+w2257Qg2KArvAs/VNUPs RIlvyEsHDkMJCFVCX3hojdQxCdgoOCowahObb7J2eRP6VcBKxs2vXxe2i5htEYLyOSPS PxTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iyVp6L65vrlfh47jIwStCxDGJjlhMDEStL5pdHuuEkw=; b=TZERHlHokPqiluSz/J0GfL5gENW8QTdJ7/QTJILSgDWDa0pzKupOgjB4SROxTRS9L1 zFknaIAB35VV/EyJHkPuqMnFolAPGmR8Hu9zEdSfKjCtH5r6O/DUtNGK3cRC77OQsr2L cjJRXp7nDF3+MLb0FLc0AStcq0DUaQuZDkuia80SASbEw4NlVsUPN8bPa8lSZso2deOX W+ObmpvEZmWq57GxfNMxURYk86vh3jv7S+M17SV1u1IHEuOrhQ7ZgczpjqSVmj0aoS1n YuZ6OG6l4qwx9IwAfqi3b4iGCYBeoOtmSV0jUzVcI3hsRANndd5/2ppeu6G6rbbYbT2e +oag== X-Gm-Message-State: AO0yUKXAOLeUhng2EQ+yh4Am1nzvER9gqNobB0ySzOZOAjpBUKOx6rTb c429An95yZw/R4a/hHnNQdM7ZQ== X-Google-Smtp-Source: AK7set+Y2p77+zW1MTir8HIs/jfqblThQjd4fpJJF03yf/UENHvTMdI9au6m+MeEP5nbjgsIu5zpDA== X-Received: by 2002:a05:6a00:23cb:b0:581:bfac:7a52 with SMTP id g11-20020a056a0023cb00b00581bfac7a52mr381062pfc.1.1674595427089; Tue, 24 Jan 2023 13:23:47 -0800 (PST) Received: from google.com ([2620:15c:2d:3:b15:b561:51fb:73c3]) by smtp.gmail.com with ESMTPSA id 6-20020a170902c20600b0019101215f63sm2128562pll.93.2023.01.24.13.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 13:23:46 -0800 (PST) Date: Tue, 24 Jan 2023 13:23:42 -0800 From: Isaac Manjarres To: Andrew Morton Cc: Catalin Marinas , Saravana Kannan , Suren Baghdasaryan , kernel-team@android.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/2] Fixes for kmemleak tracking with CMA regions Message-ID: References: <20230109221624.592315-1-isaacmanjarres@google.com> <20230124122015.9f4e93e197153183085afbff@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230124122015.9f4e93e197153183085afbff@linux-foundation.org> X-Stat-Signature: d38xoyntybdqcasskb716tpm9n16isj5 X-Rspam-User: X-Rspamd-Queue-Id: 683394001A X-Rspamd-Server: rspam06 X-HE-Tag: 1674595428-840861 X-HE-Meta: U2FsdGVkX18ZYKk8IkxfEFbrqbal2y9IKAsPTojjTF0tvrjw1OsZIVFk7nWQHAA5EcGUVT9WsX849DFJP13K8mIW2N3sSIOIDsBspJfHpKVB9W6x8lMhbKWGFMrINeS3JYnJraWomLyP+x9XRgUe+g4Vgf93qm32vEa3LH+kzK1SWL6TOks+9UbonVgmsjDPwVwuzYl65OE2EkK88dByO1WpAegkGynob7g8u4rlt+95tyAwaCcpOkkk66R2Qi/G5kVZXeyOp1Kw0hOThWpFb8v4jICMRCe1R15JsUxhhIHeT42uLTclnpjakguz8Xh1yeAsTbY7+KTjJaBtNnqrpNm4BcKmySEuATBqKtdMSo6FAFXeDgVKd8cLIqmcT7E8C9NnOGfPzihbZotZf7dSdnIC3MiySVdyZZgc6UIObfmfi4Q/Zjzpkj2VSyJXEj/uYqPWuP9dVoeP0//M9zyo9bY2HVIGWvBktub9r+1mZrAdU9NigIq8Ho1wIpmWrIMSVi6ZhJbKfOZHmcVMsS5Zsx223VWDYjJJ2LGNvJfmC33pZLeWyS/UV/939BAJNWvclqoANpiEx/tgioYB3etW8r9MOn8ub1MpUUHCaKIllQkFVLCSy4ks+P2BsmkwDPPzRbuOsl8dNANnpqb4V2H0wDBOzQKTh2kckLKeg2eFY2qwD60evSzOqgiJpLA5t1GDsAgpY0JE2jWTYtNFe0Gj8urfHOdbnxaUruKrnPN7FHEPzLBF8W0/kEoF7ZG/Jf9EKKY8HeG9cAep4DmOkZg9UHRqbvqwx79XwOSs4l1ZE+1Q9L8Dvzr5OPFt/2DlXgaeFC/slzrDIC8d7wOFkFuTmDNC+E9Cz2SIvp5I20DiCyUHHFf1zqAsO4QdG2MUb4o+MkO8et2UbEk09S/+B1EfrBgJCU5m+7nb3OBwX0C1tYy0Xcf3S30c0K6S6NA8QgdjHYhOoT72q5VbvO8L8DR jfaI/gTP I/YDTE2//ahqul/AkVU5hR14MZeShVf9L+ezPeif0dVS9HjRA+z5QbJoXmYpOhnRBn+44apROUHYf9uT2WKSqOTFDDQ7I5e/wTEgSa8NsFgUfOrWavNXw06hFfleyzFRVH07hCcvIXWyE8I22GWdKj3ExBPEmUUA7KZReF/cygCgvKOJvR08eS78G4Oh82oFtK2nDNL5YhvMv5EmWfcloGgf8ADGy5vcF0yHUI43Lo3Was8L0VRkS8KSDxw7shpbfdfBdNFkrWpXerBhD6Cv2qVAl9Sj23+JWaoz782jUI/HiEghgGnQxMsB2H8dIiTAUYqSp6xZRUHS+lWnkEOwnzL7E5GGF5pTIB+5xcZbtDE7M9XkCl3cDbsLiFCXPrWDi9vqtBHk7BkWk8G7n+Cn0Qt4HDnbgzxG7FCbj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 12:20:15PM -0800, Andrew Morton wrote: > On Tue, 24 Jan 2023 15:48:57 +0000 Catalin Marinas wrote: > > > Thanks for digging this out. This patch shouldn't have ended up upstream > > (commit 972fa3a7c17c "mm: kmemleak: alloc gray object for reserved > > region with direct map"). I thought both Calvin Zhang and I agreed that > > it's not the correct approach (not even sure there was a real problem to > > fix). > > > > Do you still get the any faults with the above commit reverted? I'd > > prefer this if it works rather than adding unnecessary > > kmemleak_alloc/free callbacks that pretty much cancel each-other. > > > > > I'm not sure if that commit is appropriate, given that reserved regions > > > that still have their direct mappings intact may be used for DMA, which > > > isn't appropriate for kmemleak scanning. > > > > It's not. I think it should be reverted. > > Could someone please send along a patch to revert this, along > with the explanation for doing so? And please consider a cc:stable. Yes, I can send a revert patch later today. My patches that are currently in mm-unstable depend on this patch though, so those would have to be dropped from that branch as well. --Isaac