From: Isaac Manjarres <isaacmanjarres@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Saravana Kannan <saravanak@google.com>,
Suren Baghdasaryan <surenb@google.com>,
kernel-team@android.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] Fixes for kmemleak tracking with CMA regions
Date: Tue, 24 Jan 2023 13:23:42 -0800 [thread overview]
Message-ID: <Y9BMXq36fZ/xppbD@google.com> (raw)
In-Reply-To: <20230124122015.9f4e93e197153183085afbff@linux-foundation.org>
On Tue, Jan 24, 2023 at 12:20:15PM -0800, Andrew Morton wrote:
> On Tue, 24 Jan 2023 15:48:57 +0000 Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> > Thanks for digging this out. This patch shouldn't have ended up upstream
> > (commit 972fa3a7c17c "mm: kmemleak: alloc gray object for reserved
> > region with direct map"). I thought both Calvin Zhang and I agreed that
> > it's not the correct approach (not even sure there was a real problem to
> > fix).
> >
> > Do you still get the any faults with the above commit reverted? I'd
> > prefer this if it works rather than adding unnecessary
> > kmemleak_alloc/free callbacks that pretty much cancel each-other.
> >
> > > I'm not sure if that commit is appropriate, given that reserved regions
> > > that still have their direct mappings intact may be used for DMA, which
> > > isn't appropriate for kmemleak scanning.
> >
> > It's not. I think it should be reverted.
>
> Could someone please send along a patch to revert this, along
> with the explanation for doing so? And please consider a cc:stable.
Yes, I can send a revert patch later today. My patches that are
currently in mm-unstable depend on this patch though, so those would
have to be dropped from that branch as well.
--Isaac
next prev parent reply other threads:[~2023-01-24 21:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 22:16 Isaac J. Manjarres
2023-01-09 22:16 ` [PATCH v1 1/2] mm/cma.c: Make kmemleak aware of all " Isaac J. Manjarres
2023-01-09 22:16 ` [PATCH v1 2/2] mm/cma.c: Delete kmemleak objects when freeing CMA areas to buddy at boot Isaac J. Manjarres
2023-01-18 17:16 ` [PATCH v1 0/2] Fixes for kmemleak tracking with CMA regions Catalin Marinas
2023-01-20 0:20 ` Isaac Manjarres
2023-01-24 15:48 ` Catalin Marinas
2023-01-24 20:20 ` Andrew Morton
2023-01-24 21:23 ` Isaac Manjarres [this message]
2023-01-24 21:19 ` Isaac Manjarres
2023-01-25 12:08 ` Catalin Marinas
2023-01-27 2:39 ` Isaac Manjarres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9BMXq36fZ/xppbD@google.com \
--to=isaacmanjarres@google.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=saravanak@google.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox