From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B689DC25B50 for ; Tue, 24 Jan 2023 19:49:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FD006B0071; Tue, 24 Jan 2023 14:49:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AD3B6B0072; Tue, 24 Jan 2023 14:49:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14D396B0073; Tue, 24 Jan 2023 14:49:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 03A186B0071 for ; Tue, 24 Jan 2023 14:49:26 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D145B1A0C9E for ; Tue, 24 Jan 2023 19:49:25 +0000 (UTC) X-FDA: 80390731890.21.34C0A86 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 77FF5140015 for ; Tue, 24 Jan 2023 19:49:23 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eFk4/9hg"; spf=pass (imf09.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674589763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R85STr6GIhhr+ztwclj6pO6G7kZRrikgcAMPHnfe248=; b=a6H8Ey8vublKhopnoAV6OkzThepW2eHdJD3I28y+BE685TIVhgIV40jRNAXh4n+lwRU9vL lOAn2eAHaYGGVlFHy4k6OiIVBXc5DB0VL1Jelj36ZusRp3KTNKUDypldzoUKSDLwxFkiHN lxniQYd3tRqHz/e8T3x+MpWWW1m9Cq4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eFk4/9hg"; spf=pass (imf09.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674589763; a=rsa-sha256; cv=none; b=idsQLMz4GYyaKk08IE4iFa8dNGp5mrM4I/0oP/bSaK3SgXTf9K0aZvi00pbm+m5Qh9e7Rj Ef9Ib6moLdBPNGYz0KtNpPsgc6t/GJdzkEinWPXP5yJ9DB87Y2OrQSyPymI5x9q9dEQLA+ QXBCp7gYvoNCYBMLU3lv5Era0AQqAW4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674589762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R85STr6GIhhr+ztwclj6pO6G7kZRrikgcAMPHnfe248=; b=eFk4/9hgL7Rawca+FgAOSo6KsKSCLyFdoD1Oho0erKm7DBFBrCjyYb0AowPhD1puH2HD6h fMXNOmjgsRgESJjLzSdbXInofgi2rj+FwLs6+BMJw+A6S3Fvfvwn05h8XALqgOHl/clh20 M4QGMN+4xMvnt0ldxMTsfuwBi7qr4jY= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-216-sKIFhaD-PLGAETr7oOedPA-1; Tue, 24 Jan 2023 14:49:21 -0500 X-MC-Unique: sKIFhaD-PLGAETr7oOedPA-1 Received: by mail-qv1-f69.google.com with SMTP id c10-20020a05621401ea00b004c72d0e92bcso8053370qvu.12 for ; Tue, 24 Jan 2023 11:49:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R85STr6GIhhr+ztwclj6pO6G7kZRrikgcAMPHnfe248=; b=qWPzAwFPUfUG/1HsWzGHO0iKp9EbF9UYkL0Fk+bAH8ubNVW7SaINbDSSpkWnbHhLQC qnai9dA3np+pk08mXDQqs7+5poaIE77DXPi0Gp7nMj2f83W2/ZUcips3PC4Y1s2B7NIN rM4bpnUIgmwF2O+CnHTyind5TJX6lGUNvyTNm/egIWhF7bU1spHLNY2Mi2eObNIcuQZf tx7yzJaJUK+/y7IzBqATM2+yYezlFww6Ufn5rpol5R/m0L8YdjrqZHWoNRQzrPmEWn1B qGeCA1HHLU+IyTS9NDOITAzv0b4oG+/5IrqgCo0oQ84rgnZoxcTIYzQuB9iJeTZUWQAm VSrA== X-Gm-Message-State: AFqh2kqT6AhiRhQukw/gz+jnJyjo18bnZ3Bp3nl8Y1j+AQBwRZhts+25 B6H+gzn0SYSF7DoEXwGrLRehvA5Jh19QGhZYCeWCxfpdqUS80AP0/GUEU9k+pYT8FzX8/AoCwnN AAqPyxLTGlZA= X-Received: by 2002:ac8:4758:0:b0:3b6:36a0:adbe with SMTP id k24-20020ac84758000000b003b636a0adbemr40222095qtp.6.1674589761212; Tue, 24 Jan 2023 11:49:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXu1WuGrk9av6WUp2+OZodLHrIX79DJLQmWseM2cM1QbiDQQOkRVcd+zhy6zkWOiNmjgkRdG5Q== X-Received: by 2002:ac8:4758:0:b0:3b6:36a0:adbe with SMTP id k24-20020ac84758000000b003b636a0adbemr40222080qtp.6.1674589760880; Tue, 24 Jan 2023 11:49:20 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id x12-20020ac87ecc000000b0039cc0fbdb61sm1789700qtj.53.2023.01.24.11.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 11:49:20 -0800 (PST) Date: Tue, 24 Jan 2023 14:49:18 -0500 From: Peter Xu To: Muhammad Usama Anjum Cc: Andrei Vagin , Danylo Mocherniuk , David Hildenbrand , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Paul Gofman , Cyrill Gorcunov , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Mike Rapoport , Nadav Amit , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Subject: Re: [PATCH v7 0/4] Implement IOCTL to get and/or the clear info about PTEs Message-ID: References: <20230109064519.3555250-1-usama.anjum@collabora.com> <0eb79bb3-7384-11c6-a380-c027f09305f2@collabora.com> MIME-Version: 1.0 In-Reply-To: <0eb79bb3-7384-11c6-a380-c027f09305f2@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 77FF5140015 X-Stat-Signature: i1cw61i8nk5r3rkbucr9xyurr561w3n7 X-HE-Tag: 1674589763-391290 X-HE-Meta: U2FsdGVkX19eKZbyy4WBvVW5NjyjcApDzdrApXPpJn2uxGTQjuIs1kuvwC7ecFelyeD0YFwBk2sLBNKHSFaHXPqBEu7eZ8S2ZMSRelH8QydOCdPCN1uJD3lz52RGQAf6U7PUGElX5p3DUC76qeoHVRj1exBO6ZFP9trUkeclaLfppCdVFiI5Q/vR6DTHc6pytvE64lJK348/10qKoGbI6km/J/A69I/Lc7i+HAanTrdjky2XJKFkXI0gBSw5aSeHhKdmvKkoVL2zq8LdzB99TIAm1Ssl4++kB7mHeB37U6OXWYzIB3hrow1g8LV901oYWa+5bzkiIyDeTqiPpN4lZw3LGFr7jHS9CAsLRE1YFzrJxTDXQG+mkPWQT4+YnElofA3az+NLOVJFyks2++btK8rKhnYNH2gniZ4dhBttli0aQf0YHQ0S3Ba9ZRFFqcrfMcAyXMGHQfzi3CspdgmUhibNhWy5qus3Zh4sOTonyTVCYv9HVxVolEzTxeXT92p25gGJFXSq2EnSjm5SgPrqqznsYAW8cn9xbD34vmBKXCrzxsNKMH2G2cAZ84GeE4r8jjV1oN7JQhrvnPTb8jy6oFHVIO/wn2rn6cW5uWOpNiis+vogZA51vgI+goqpbKEgdktDTeL4xeiHYc4meAB4Z5kU+il/5IIAz2OBBXvxqLkfniIyZgQl6qdzpeHJ86qCFVHGWeSSGH90xLxN4dLpr2ORcyATBGny2Cs/1VcUggyuarYzje2iJmTdi01GYrOeY2nPZBwPJKcOQDEE+rUf0gQpXwwH0WtDvrIOLx2UP4g9LOlKIOapYm0Q+MiesqKSDcGlYo7DX8obSfHO9rxC9D1koXUQv8xmQRh5kSnVIYEzehNL0poym+/MGDuMmWm/IcdUgpDzwjKUECN9MGrA185VDUpDu/FYhAM6nMDmIaUklX92cVFJHXpRcSbRJbv7T0Ci3YfNjN1HZzeNXG8 F1r5R7OP hPayoXzUgV/gRmymWequFFzXDeL3wdULBaqNKV/FTEn1+3tvk9B+amjjcgoGUPVLG+MrME8CpyMrzmTSLNg0WvBdKKtVqiA/jwc3L9x7sHyvt2a23UAavsewk8BNACuCpK4511RsnI6YlVddb7itDBA4UCf6trrx1zyWODMihxP6sLqeEFJqqAffb99MWMFYnQb4TpeUUrU17iWtWi0ym51ovkT6SF/WmxfUcMS2nrSWzI5Kl7BED5jvKitsAo9S9kdOm08rr+j4uGbd5vqIkVKGbVO0tTaz35dFsG7fVsh7PbPPv2TkvSMpcMKT38Xp/DEObipr4V7VGlUXUgfvoPMGtmgiq8O7Kas8zKMBfn4D6F/4F+PxlthaqQ9y2cI69ZOiB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 23, 2023 at 06:15:00PM +0500, Muhammad Usama Anjum wrote: > > Firstly, doc update is more than welcomed to explain the new interface > > first (before throwing the code..). That can be done in pagemap.rst on > > pagemap changes, or userfaultfd.rst on userfaultfd. > Okay. I'll add the documentation in next version or after the series has > been accepted. Initially I'd added the documentation. But the code kept on > changing so much that I had to spend considerable time on updating the > documentation. I know it is better to add documentation with the patches. > I'll try to add it. Yes, logically it should be the thing people start looking with. It'll help reviewers to understand how does it work in general if relevant description is not in the cover letter, so it can matter even before the series is merged. > > There're four kinds of masks (required/anyof/excluded/return). Are they > > all needed? Why this is a good interface design? > Then, CRIU developers Andrea [1] and Danylo [2], asked to include all these > different kinds of masks. I'd thought of these masks as fancy filter inside > the kernel. But there wasn't anyone else to review. So I'd included them to > move forward. Please let me know your thoughts after reading emails from [1]. The idea makes sense to me, thanks. I just hope "moving it forward" is not the only reason that you included it. Please also consider to attach relevant links to your next cover letter so new reviewers can be aware of why the interface is proposed like that. IMHO it would be also great if the CRIU people can acknowledge the interface at some point to make sure it satisfies the needs. An POC would be even better on CRIU, but maybe that's asking too much. -- Peter Xu