From: Baoquan He <bhe@redhat.com>
To: Stephen Brennan <stephen.s.brennan@oracle.com>,
akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, urezki@gmail.com, lstoakes@gmail.com,
willy@infradead.org, hch@infradead.org, error27@gmail.com
Subject: Re: [PATCH v4 0/7] mm/vmalloc.c: allow vread() to read out vm_map_ram areas
Date: Sat, 4 Feb 2023 12:12:08 +0800 [thread overview]
Message-ID: <Y93bGLwIROQB3Yfs@MiWiFi-R3L-srv> (raw)
In-Reply-To: <87357o7yeh.fsf@oracle.com>
On 02/02/23 at 09:47am, Stephen Brennan wrote:
......snip...
> > Testing
> > ***
> > Only did the basic testing on kvm guest, and run below commands to
> > access kcore file to do statistics:
> >
> > makedumpfile --mem-usage /proc/kcore
>
> Hi Baoquan,
>
> Sorry I haven't commented with testing info or review on each revision:
> I'm not really familiar with the details necessary for review. However,
> it looks like this is getting close to ready, so I did another test:
That's OK, and your testing is very helpful because I don't know how to
create vm_map_ram() area to test the patches, just did basic testing.
>
> [opc@stepbren-ol8-1 drgn_vmalloc_test]$ sudo insmod drgn_vmalloc_test.ko
> [opc@stepbren-ol8-1 drgn_vmalloc_test]$ sudo dmesg | tail -n 5
> [ 20.763310] missing module BTF, cannot register kfuncs
> [ 20.840200] missing module BTF, cannot register kfuncs
> [ 91.475814] drgn_vmalloc_test: loading out-of-tree module taints kernel.
> [ 91.479913] drgn_vmalloc_test: module verification failed: signature and/or required key missing - tainting kernel
> [ 91.484926] drgn_vmalloc_test: 0xffffa51ac2d00000
> [opc@stepbren-ol8-1 drgn_vmalloc_test]$ sudo drgn
> drgn 0.0.22 (using Python 3.6.8, elfutils 0.186, with libkdumpfile)
> For help, type help(drgn).
> >>> import drgn
> >>> from drgn import NULL, Object, cast, container_of, execscript, offsetof, reinterpret, sizeof
> >>> from drgn.helpers.common import *
> >>> from drgn.helpers.linux import *
> warning: could not get debugging information for:
> drgn_vmalloc_test (could not find module in depmod)
> >>> prog.read(0xffffa51ac2d00000, 64)
> b'\x00\x00\x00\x00\x01\x00\x00\x00\x02\x00\x00\x00\x03\x00\x00\x00\x04\x00\x00\x00\x05\x00\x00\x00\x06\x00\x00\x00\x07\x00\x00\x00\x08\x00\x00\x00\t\x00\x00\x00\n\x00\x00\x00\x0b\x00\x00\x00\x0c\x00\x00\x00\r\x00\x00\x00\x0e\x00\x00\x00\x0f\x00\x00\x00'
> >>>
>
> So this definitely still resolves the originally reported issue. Feel
> free to add, if you want:
>
> Tested-by: Stephen Brennan <stephen.s.brennan@oracle.com>
I noticed Andrew had picked this v4 into his mm tree, maybe Andrew can
help add this Tested-by tag.
next prev parent reply other threads:[~2023-02-04 4:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 9:13 Baoquan He
2023-02-01 9:13 ` [PATCH v4 1/7] mm/vmalloc.c: add used_map into vmap_block to track space of vmap_block Baoquan He
2023-02-01 9:13 ` [PATCH v4 2/7] mm/vmalloc.c: add flags to mark vm_map_ram area Baoquan He
2023-02-01 9:13 ` [PATCH v4 3/7] mm/vmalloc.c: allow vread() to read out vm_map_ram areas Baoquan He
2023-02-01 20:16 ` Lorenzo Stoakes
2023-02-02 3:20 ` Baoquan He
2023-02-02 7:17 ` Lorenzo Stoakes
2023-02-02 13:18 ` Baoquan He
2023-02-01 9:13 ` [PATCH v4 4/7] mm/vmalloc: explicitly identify vm_map_ram area when shown in /proc/vmcoreinfo Baoquan He
2023-02-01 20:17 ` Lorenzo Stoakes
2023-02-01 9:13 ` [PATCH v4 5/7] mm/vmalloc: skip the uninitilized vmalloc areas Baoquan He
2023-02-01 9:13 ` [PATCH v4 6/7] powerpc: mm: add VM_IOREMAP flag to the vmalloc area Baoquan He
2023-02-01 9:13 ` [PATCH v4 7/7] sh: mm: set " Baoquan He
2023-02-02 17:47 ` [PATCH v4 0/7] mm/vmalloc.c: allow vread() to read out vm_map_ram areas Stephen Brennan
2023-02-04 4:12 ` Baoquan He [this message]
2023-02-04 23:13 ` Andrew Morton
2023-02-06 8:43 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y93bGLwIROQB3Yfs@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=stephen.s.brennan@oracle.com \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox