From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08986C61DA4 for ; Fri, 3 Feb 2023 17:47:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A2956B0071; Fri, 3 Feb 2023 12:47:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 679AC6B0074; Fri, 3 Feb 2023 12:47:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5686A6B0078; Fri, 3 Feb 2023 12:47:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 438816B0071 for ; Fri, 3 Feb 2023 12:47:49 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0714A121260 for ; Fri, 3 Feb 2023 17:47:48 +0000 (UTC) X-FDA: 80426713458.23.7914F74 Received: from out-116.mta0.migadu.com (out-116.mta0.migadu.com [91.218.175.116]) by imf01.hostedemail.com (Postfix) with ESMTP id 0384F40008 for ; Fri, 3 Feb 2023 17:47:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=O+uDUWm4; spf=pass (imf01.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.116 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675446467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LmsXysxMfYtegr5dVQ+/SDGY+y8MjYLbIXG3YSolM3M=; b=VFpw/wKFy4sS8TN6srg1O84CBbe1kWNUWzMGINtRM4UpzX+77Mm5eH9+46LhctTyrwpeId NDEYVoORr3FktLrv79HngTvQRdKpPQhp/E/1Pax48rpAB84zwz2XM0FFoRyuqzMqSs7h65 xS0PPttgr19TuWdZMMNsklhsRSOFM1Y= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=O+uDUWm4; spf=pass (imf01.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.116 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675446467; a=rsa-sha256; cv=none; b=kLyZj3YHrBUx0Kmb8rmVIhjW/g2BLGiAoe2t6Ayl8+v+VAZz67I3DxX5mcQbFCxXaHpsIX Z5/K3QQMRfbbqlJlVxgpFNrA2eulVlcleEF/m75asTq+WRtB+TZt3laCffK52d5Q0e6H4X XEozZT2KPwnga9nRb2g4i8dFXooEIcY= Date: Fri, 3 Feb 2023 09:47:34 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1675446465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LmsXysxMfYtegr5dVQ+/SDGY+y8MjYLbIXG3YSolM3M=; b=O+uDUWm4eyxjCb1gbU5IMQ9MgqQPqYGTl1wGbSz3HvtnLCmrFlScdYFAl261orz5VDHMsW 2R3lojbaXHuTFKzwuRIxaKu8FU5Oh4xtX0tdLPnw8OG7DDmnDOX+PccpYgqVZxQ0S2+gGi XkklnbdOgQuWaUEYXAXObCVWLzX5kcc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Greg Kroah-Hartman Cc: linux-mm@kvack.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: fix memory leak with using debugfs_lookup() Message-ID: References: <20230202142022.2300096-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202142022.2300096-1-gregkh@linuxfoundation.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 9gec7hofzzwxf91t8j3rdxemon9cro7i X-Rspamd-Queue-Id: 0384F40008 X-HE-Tag: 1675446466-680637 X-HE-Meta: U2FsdGVkX18SoyMM5VLfwuPNI1NWMFa9/Vo6s7evYnxc970H03FmRwxxfTTfONmT6KcsGf7pEoPUorLcUsCcI2RJXYs6Bz9F5ho/t/Q+RLmNHrUwuVWHsNdlaw2q2aQA89f09XVFosOZlDcC6SSoCJ0CZVtb3phBiw9BUBbEWABAVTp+4Qe5NXYXHkKXcIGOVx4KY3L75aZr9WQYTVB/NHwhOiELG2AxsXT7nkTQZ99YRnGIMymwHPDxc+TKRgqsUX6O+pVyd9SQC1PZNLb1Fz7plSBCxDUjtoRuK8mUuLmydHt9cpQRXprGZ3WTH8sDNVdj+YmD1hy14LsJjn3ojysHmqIYkkI0PwMVFNg19dUZpx963Bpwdq7H63g0D7KcIQ/wnaxX/zndgjEh/dVbgGv9QdIWaS+f6vNiESyMzAnC8y3Qm0DEjqmTBrBbf1VjQ2Z0X44unUAeCCTtiy1mt747r+VSTiOEZmwUhGYVsVQ6U71eeYgjBNv9EmxzhXZy9pviZmOD6FBpeZ2OB+RnB0F4+cZ9TN7GzfR3yxirJY1fZkHRzBDw+POeDXv4x32ZdlJTZ4pyHV40ZqP8+16YysuWvkjD7nRT7K6d8mRR3DgeA9MbXfxhzKOVhYTCPVxrfmfRlRamKJcmLtTzfWNS6AhxbJuAh/Xwz7ucYPFi1cGpjJpXjjMZNFnTuWEj5BWzuXo0gi/lWLF+uO8FVesgJX0YIgLduJsn3d3qXBhqW3OHLpUWJiNBjWJ1y0RJZw9kUVE3PEIGmFcAzf4dtl7nE9vjtiENCqM48B8RXvJCmENDpva0AfsIFvnBqwFxN3clC/ESgFCcwrKE/bF9g3xtG/r7jTzWrnRkiOyg/NxggOH1vKGo3yBHnHKJbxkW932kpOTJ9YGlsaESCjoUlFBDPvNXw00m9Ffh1mgjL/JHwEG+Ht4HVA6IfAcnSZnnHJIQfAtMlGzQcV7xbbcUzpa KwcMvVVC K+zywHVnnWqeLs9NtEnAZ+klGlwROEKyxz2qZebF4L4x7Cw3cvMpSo3CO2Af+Op4tF/3EvJ2TEYVR39GAJa7l0DpqDs9T5ElzTJ2rpnY3ilbn+vZv5np2XITVjjeMOvsaD3qTHe5vcmtvtxko0tD7G886meg4yvPmKiRg8drWU/rPZ7uqTrEdk0wgO3mpa75f5Wd79zo4IxG9v8a+tr1DMQJXpqYX01qGo5vm53c5mgTVv6wv3de8a6ka19do1GulvmjbXV4Y36bb8nfTsGT8zz+0GerztT3U26gtsQQ71icazm5A0GJGkdFlvtn1OWVn4qDAiM+pp1tZtqLU2A+O60bHKHEm2Ff76LW6PartZqutfXIjRSTL85Ga/dJrixCA0n22+DWOdopPfUcXDPRAcuJ9d6C11ZgPrqpkJgjshd1IguJqGIBzKi9TMQy/tlb3lTQau0rgtSEn3BFWWyC6DOUf5WL3/euCnzRyDV9guu/x0jyLREApTMb5HJhdEgf4xcDkzNZhv1LxSZzzgZe0u1ItznVkASnU/zSETx6oq3473rFiOKRsKHJFjARiyAxe/Pk8S/TOsR9SdYjnSzoqjHOgJWtLKZPZfMVDlgfnw8uaAjnxoc0M1uJpKDs5N9Hneld0rXBfkUSMHjeu2V/ZuLBsN/hYT59423uj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 02, 2023 at 03:20:22PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs_lookup() the result must have dput() called on it, > otherwise the memory will leak over time. To make things simpler, just > call debugfs_lookup_and_remove() instead which handles all of the logic > at once. > > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Roman Gushchin > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman Good catch! Acked-by: Roman Gushchin Thanks!