From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A73C636D4 for ; Fri, 3 Feb 2023 14:03:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 416AB6B0072; Fri, 3 Feb 2023 09:03:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C67A6B0073; Fri, 3 Feb 2023 09:03:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B56E6B0074; Fri, 3 Feb 2023 09:03:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1BD146B0072 for ; Fri, 3 Feb 2023 09:03:05 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B54581604E8 for ; Fri, 3 Feb 2023 14:03:04 +0000 (UTC) X-FDA: 80426147088.21.A93A077 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 2A7FAC0015 for ; Fri, 3 Feb 2023 14:03:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=P3lHu3A1; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675432981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K7T7ATKtiY2ShzKuJI3yMGaRIRXtDb57YxkbdOBatIs=; b=HrbT4GC5hKRMdGYS75f8zRvDWH/Y2fRCwB/fNEl6Mc6uamomL4Dn82q/gSRD66H0K2JZsM HpQjTJZJkfbLYDwvSOoZJ8+Vv03qH+pgacDwU/ffRfefK5ggEy/7ny830ZQUrS02OMXd15 cz5rY/LFfevroMHSLjavBDkeD3YWhQU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=P3lHu3A1; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675432981; a=rsa-sha256; cv=none; b=RB5zrfAqdD5EkY3UA7A+DlMJHoeGnsvNQg/40yiIsP9UBhqoHIgHTozWcPS92utU7mZ4xO SN6Gi7PzWWYREiX9Tf4g2s8FCXhmVKT9Oij/10uai17pGeqHn7okNmU+ez1KOtFMiQH6AE uWnpPbFC0LVapc1c1xVPSAP9xhFpTbw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=K7T7ATKtiY2ShzKuJI3yMGaRIRXtDb57YxkbdOBatIs=; b=P3lHu3A1/Zsvf6t7nVfbQ8U92j wV9QOk1AW4KLBC+3pjcpavR2okgsxFfoSe/INRcTvWD59KiH60r2mkNb81KrlI+SXfLfUqSmXGeLi Yzvkn+aKHqZL1SJ6K9pJacPcMvbSvdaDE5OIjC8n67AtEKtsjg6XXr9kaqHSMKN8hMzy9AZkxVHNu Mq4XaVOEJ+/RpyiwAs1KpDZTNz5VyG6rIN8sYsrb4iRTzARCS/vU0PNu0wItLPJI9jPiiyoDFEgnk 2CEQPd4ZYGJbahupnh40mmXjUvvWSkKx6NZS8kh9ulpyybmoUBW5QNKIbZQcqha/iNxirToG9ooQn 5X5UkJFA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNweR-00EMCS-Pq; Fri, 03 Feb 2023 14:02:51 +0000 Date: Fri, 3 Feb 2023 14:02:51 +0000 From: Matthew Wilcox To: Yin Fengwei Cc: david@redhat.com, linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com Subject: Re: [RFC PATCH v3 2/4] rmap: add folio_add_file_rmap_range() Message-ID: References: <20230203131636.1648662-1-fengwei.yin@intel.com> <20230203131636.1648662-3-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230203131636.1648662-3-fengwei.yin@intel.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2A7FAC0015 X-Stat-Signature: ce3q59knyaqmyw8k45sageczgz8n5k7f X-HE-Tag: 1675432980-851834 X-HE-Meta: U2FsdGVkX195GEgHTLt6NOwtYbHKSxBFqGPncJMlsq7T1VxoBqca0CqKEHv0XVoRfrcTCvKDA8EC3m2vcLJqS7w57dQQXXXvedaYhxh7TtNe7SnbjpeyY5S98dL2VZSrl5kUdYBlBzgpgnHDsotdwjhqBw5SBgiqgyHMPogQ4n7hn5Yzqlc3E5elyMVXRypi0q16B2RmqQOJ7NpCIla08pnUT/J5Dd/IJPE1sDAzCW4hFKml7aq30zw+vWAV2lsepJuyiZw3bys5dX1d8Lz8LuEhR1cwTUd5Ylsf+/o6m4YH5PFEY8n5n3DSLNO7fwzLn4Bojt6KsWos8HmaYnU3npaYF3+Fj56E4+GlJuPR3ivFRuPDNDvJ460pcEQHu8mPZlHzNBSWlm4aIMcOIJYd0jbxU19Lja51pHaWZyf1rNpg+75GrqKFmbpDujzmtq1IcnnnBBtDxix0Avx6JFS48qgD2ZZWdW165gHHBli53O0HlC9Cy7q862oX94zj2pZ/YXZOLBWPi5UCgxyDZ1b40GavNOJaX+9mF1YhkXWdJIQ4m7kHZWWBbRi2PtHcyZ2IE/WQb2PL4rX+qCos/350a/6TVQBVuSvE9+4zawM3Z+nwTwku74F7yz1RdIzes7dUyfI/o0scJER7uAqb4ImO/vtqXCQsRm5k8KO+PjgCPAgrYahyMkbGNxUZCYcwShyg1rOHq68CkngQPGVeCVUZdVgopfenpU0X+iDWrzFT6HCLmBuZp5cQzew0kbcBVf1Hx66VkIryahW/waOarS3+EmpP6GukY/U+hD+wSs0v/uMofB/zWD7yXqND6X9oxkEtxnhl3llGt21zTmL7ptE6DZ9uLintj92rmbZxP1a/7MwprCk4LBwRsA1Oucv4kiSaL4yokCVqy8MaQGC+UXx4uwo4uwlLeT9DGVi6TuPy12Wu5T0OKD8APAEvhKsNupTrwCUkiaYxbERe2yZQlKt eEj1RAOc fw6UVoJQB8D6UsdWEJgVZTEFFHixeEOCn1PSn06qd72K3GOvNalgd0TRGFqGjoC3EQC/6YM+ggK1FcaoQ27VeKeZxS1LlfqSmd46pe10soclwBieSIOeOXVv56UOpmBN2hF6DGTHWe5z22pZt8Dhlm12LmyxJeBGDn1E+OZf7zb/A2IKxPru0Fne1SR2nrdI2TGo6XZlAb/7eGIw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 03, 2023 at 09:16:34PM +0800, Yin Fengwei wrote: > +++ b/mm/rmap.c > @@ -1303,31 +1303,44 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, > } > > /** > - * page_add_file_rmap - add pte mapping to a file page > - * @page: the page to add the mapping to > + * flio_add_file_rmap_range - add pte mapping to a sub page range of a folio Typo -- missing 'o'. And there's that word "sub" still ;-) > + * @folio: The filio to add the mapping to s/filio/folio/ > + * @start: The first page index in folio Better to describe it as the 'first page number' -- index is usually used as file index, ie offset within the file, rather than offset within the folio. > + * @nr_pages: The number of pages for pte mapping adding Maybe "The number of pages which will be mapped"?