From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB2FC636D6 for ; Fri, 3 Feb 2023 13:53:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04EE56B0072; Fri, 3 Feb 2023 08:53:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F40F86B0073; Fri, 3 Feb 2023 08:53:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2FC26B0074; Fri, 3 Feb 2023 08:53:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D40C06B0072 for ; Fri, 3 Feb 2023 08:53:31 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9C9221A0318 for ; Fri, 3 Feb 2023 13:53:31 +0000 (UTC) X-FDA: 80426123022.08.7F53151 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 17C2DC0015 for ; Fri, 3 Feb 2023 13:53:27 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EJ6O8xPp; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675432409; a=rsa-sha256; cv=none; b=5ivBJuf+CqE6Nhva3Qpi8dD1EdOc4pzc4uSwYLoksT4z+BWDWhs7joANP6EeOzmQ8SITVt M0VL3cilCPwuM2mld158WFyPAkKWL3NqPN/t/m2cMK/xx6WJWNTHNGLM1j+PRNgOYDpAUV d8RG+gvhHr1jYamNMggWu6e3ECPgsqo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EJ6O8xPp; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675432409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C3w+yP85zQUoYvK2X/P16Sjtpl1YZSa0C4ICVVpuL9s=; b=NQNOK3F/WD+HSxkU8fX6xpYL1uwakaUUDTegRDMvWODwuqlKA3BtY4BIE1yDChqtcoVOn2 kGWX7a30L0UnvxxUdYrsM1c8ITEBLfzk6hwFvbdJeMH0gs2wE98CPlgAGp8bqt6LdGHL9T jVOQFKL2ihdUlnemWbnATUa8SbagBX0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=C3w+yP85zQUoYvK2X/P16Sjtpl1YZSa0C4ICVVpuL9s=; b=EJ6O8xPpBMjj3UvMmEH4tG0MzQ 0LDIGjoYHwXsQcFJteUX9WQ67CKcFj9gFkE0cfbQZIf0qSGidM6nEXPiGGnAHr+nT8oJkDucKydCC dAJehUcQRT/4L1iLMnJH+q7+djDtyE0nVGr8VMIe10lrl1Sc4fW0fp2gV3Gi43NLXal2j8VxF5lPc kuQKixJ70rYjdoZorJtLTPJOwAVP4VrY00sQXU1Ej6hQ+6MP1LmOubsgDGfkOo8bBOht3ZE/zAOOD MhsoCY3LV43po4yTFoOLLlWKvFypOlGN2VGAvoGPwkmo/ypVCsPMmjcDrpZ7qZNHmQn/tv1g1a4si 3dmqRxBQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNwVE-00ELsR-9X; Fri, 03 Feb 2023 13:53:20 +0000 Date: Fri, 3 Feb 2023 13:53:20 +0000 From: Matthew Wilcox To: Yin Fengwei Cc: david@redhat.com, linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com Subject: Re: [RFC PATCH v3 1/4] filemap: add function filemap_map_folio_range() Message-ID: References: <20230203131636.1648662-1-fengwei.yin@intel.com> <20230203131636.1648662-2-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230203131636.1648662-2-fengwei.yin@intel.com> X-Rspam-User: X-Rspamd-Queue-Id: 17C2DC0015 X-Rspamd-Server: rspam01 X-Stat-Signature: w6bwxzh1ze77zaqhxjsjezs3jojf6cf9 X-HE-Tag: 1675432407-830651 X-HE-Meta: U2FsdGVkX1/S6aGQfVhgObvHNAaspDPPHZeXy7d4fusv5ZxL3FhYgSnGJ/lTUccYjgVB/GUxz9JbpzymU4FivLHF9AhlUyofm1uuZ4QOvrlLE6G7LZziCDGuNcha+eimBDfvkw2mZivYfFd3unYzfJICuPrneAjyScddEfyAu+w9CqVegQmlkyrZmgfsRL3hbKPlSohZT0CKewtIjkZ9TDetBYPQfVRhWVHIsGG2uitZoBLbbi8mDNc7q+Mc9WJBKW4kD+oF0ONqInTY8gF8C2WzLtkw2DGtrBUnj7RYf4grJ7UB8pI2I2kg2KFVlKcKu5WObwPqpZz4Za9JQL/5i7I6TxPVKxAAW5B04+KlRAfoi0szMYvgznj2avVEsjJh0o65FYWXM2Qz8EtRAMkG+Y9MobqXkbuRT3cRzdO0zpjCA7wzb0VMmw7obV0UB/bxiBdj4zQv8167Ha0vggn94qGeKK98bGJEJuJWlFFLyMpFu8Vb75RFJ74TSyzEKLKM+XvsKI3x/yY5HzD9IpPaOLYL/uLUVSmzYd5dRFuygBBXYqpv3x4+XA8jvUm51MYzEPWtgWk3kzc4TcQTziBn1OXyE+TAaRHRL8i8/ocSjCxKLi7IF+jB5849vxMZq2E6sVEE8aMN/q+9UlS0b1ykji6sJd0B0fYfi33vDZ/j0QzPe1KQYPtoukuN5MApXVFnGQ5uCZW4UbQN9GRGHzc62d+VBTKOXymbId/cBJODcwKZehlbJXWRUqM5oNAb0hrBO1O0urSs8l6OxTcVstuDGE3X8+VcMhG9N+8L0BSPU07MvUxM+P9fNji/7l7jFGT+Cg85kY4791WVeqAq18V0XHAVF3RjotcQ/hfNpcW/8nUewHgUip7ixY3mYpN4NQIbGfePGYw9jHejzCCuFmSItKuV/7mBRRTVe7tyn8bMQa82kTpdZLk0FiJ9Mb3Uai4/caBzQG7mYrbgO3tdESF DL8m5MVr cI++YEYGjZqr1W0WqYKWVABpZfNdkaVe29fwXYrL+cvW/Iyfjp/yG/mZDM0jyHylYM+y0Qxr99Waf49P2kiY9zDUjPOgBa5NPWG4jqkJtiMXs/PA4w+L2QqvxF0Vowh5gtdqU4r6n9gw+Y2OgBI0b2hLPJahbsPdvZGJcU4v0JbD+ESkyvxQ5hcYf0n9qYjsenJQdiB9LBHSVYX8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 03, 2023 at 09:16:33PM +0800, Yin Fengwei wrote: > filemap_map_folio_range() maps partial/full folio. Comparing to > original filemap_map_pages(), it batched updates refcount and > get minor performance improvement for large folio. > > a self cooked will-it-scale.page_fault3 like app (change file > write fault to read fault) with xfs filesystem got 2% performance > gain. Please delete folio_more_pages() as part of this patch; this was the only caller. > + ret |= filemap_map_folio_range(vmf, folio, > + xas.xa_index - folio->index, addr, nr_pages); Sorry to nitpick, but there's an extra space between |= and filemap_map_folio_range() here.