From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F4C0C05027 for ; Fri, 3 Feb 2023 16:22:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AAF8D6B0074; Fri, 3 Feb 2023 11:22:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5F7E6B0075; Fri, 3 Feb 2023 11:22:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E3F6B0078; Fri, 3 Feb 2023 11:22:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 85A476B0074 for ; Fri, 3 Feb 2023 11:22:38 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 56D9D1202BA for ; Fri, 3 Feb 2023 16:22:38 +0000 (UTC) X-FDA: 80426498796.30.FA9B94C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 708DE1C0011 for ; Fri, 3 Feb 2023 16:22:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bkUZ4atb; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675441356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9tlU3E6gFTikzNFh8ic4A7v0yzAetE1KgNmS/ZDw9/M=; b=2Z8XNbSNcA360kLqFkxrcs2h3iwlHIN+4W7tHkW/BXh1GCg52kkeyJqKZX3/I6DCKizWJ4 AuFdcyuFguK0W2oj7Ne4a5x/SctWLYfDMtr7VDxrwYXia+KgpaLabmN4mHeWOiJlXa5PMN 51m0Y312HyIPFWfo+i8EbjsZWUPU1ZE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bkUZ4atb; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675441356; a=rsa-sha256; cv=none; b=npj/jg5hTWD7MW8EdYWjtbhtW5od5qRQGbDEZjy+kA7gnJN+3ZP0N9516qy4n0xlaJAhS2 1vcS4+CbfYgzCS/hKgREZ7+JYVAY3TQ0iir0xqkZuWTiExG/GIdYiRJdqd2OCXDwA/nOes lrhsfAxSC/nnbErZAUuFr4Iqb0CZcpw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9tlU3E6gFTikzNFh8ic4A7v0yzAetE1KgNmS/ZDw9/M=; b=bkUZ4atbzUjdiHVSCwLnutyONe sNiRV3IwT/n86rZoj+ltc240yW0y9nwR3ypN16UIA+sX0uGDmBdA0N/uTz2xFCH0J2tDT8SOaTavO Jn41mc1+Iiq6JJqSWhCB+wo35TH6ghDlCN9x7lvnZR/mtr7hQMxoA2ZSpBCDgJH4rljX8m/iCzahq jqZN6sBR2AVf6kMeaH0/x7U7j3NDmppsdTvbstdRgdKPOqEP3ZnpbZKRiMo5+UKMFO27/jnboaLUZ lkC87ssYd6q3Q/yapdaJx8fP2S9V60y3jiCPNf8/xSVVEFIk7T0y15tgM4KDeJOGqDuZd16QruQ+g SGTwX4GQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNypK-00ES7K-IY; Fri, 03 Feb 2023 16:22:14 +0000 Date: Fri, 3 Feb 2023 16:22:14 +0000 From: Matthew Wilcox To: Yosry Ahmed Cc: Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v1 1/2] mm: vmscan: refactor updating reclaimed pages in reclaim_state Message-ID: References: <20230202233229.3895713-1-yosryahmed@google.com> <20230202233229.3895713-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202233229.3895713-2-yosryahmed@google.com> X-Rspamd-Queue-Id: 708DE1C0011 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: sm3troerjjzy4bdihaq36934qpddswah X-HE-Tag: 1675441356-264174 X-HE-Meta: U2FsdGVkX19Ol14qf9/MUBE+GX6iencD5LY7/1nEth2Di7AUpgCSHEIJCOeFl7lIIMLaZ+GaEBxWW2CXO+WTsQ5p1TWWZYQomR2PcqaN5fiz7bqBLoTWH7k4NRXDbzDl0emgcG2OPpKiLygHoLKJ/PxSBBiayCo82e6O29PpXBQ1o0zzqEAmyZwyM80ZQfA3590+BT007C/diFE23IzT6OejxQL2/9p8B4s1dXXLoq9WObAIK5amOEpmnD5ZgVJV3Wq6LEIoD8LO3beEeCsNj7N8s4WYwPYFckckHW63vWmC+iuOlLMdHeJD0zzyzGDHXpJ8MzGGlZT56Nsb5fcnVpQ+XV+f39GKHwdhiaJVgaIckZRO2BGD/wbvk1nmb7lLuK9FutuEBFLNZf+2q0jjdtA1l8YYDM6w2/1jDr9QMU/iVWc1xSdZSLjkgCrcJGlwLcU92B9W4SkHfVum+pYRYFWBxESqKA5kbAoZpnjtPnCvoWFgLd+ZUkUySQgXSAeuHsVhFsnJZ9iV6vUNSuQO6razP/REQzc6T3dM2np6PntpuFV7GOC5VZ+XJCRE6Y7YBpBDIZO6Co1mFljPx+QeJak+0AN6xKg9F6vnla2/frvS7Few9YLGZpXL3hyhLkXSO6dfSfc17tNN3nPG8G98XyjOYPF67A3A4d+7OECaIVJBh1/nMhvnAVOokpvifRWLQI/xjS9IJ0USplG83UN+TJOKoRmwQlEb2/nqSnFvIT3C2ClqSGH1TS/aT2VcXW74qo6MgL1FT+ACYFXKpII9I2pfyWPa3dbrgCGNfA7bIslTaqeyJQ0TvbnwtdFhi7jA6Lk17CTUBCCR1Z/ZRCyCDZRGkGOjfK9cYPM2iAuucrBdX8x1OtA8amwn8EVFV9u+FtBd/N0yicUQX902ybFyUNGmiO+PbFS9joGmrHF/B76nQbdrXck0gpYDX3cInpoPXylgSVuJoifGBIN00om nyE8jnbP 77u5hnxWPJgjp1zNUvmdqbb/MvUSgpvuHZBfORWxec01sdDg9lByeMzmfNkCfl+y0w+hNnhTQk98sfx28F62Fk4RvVB+rQTNCmH/Jk/POV4MlzU8JEvoPIFn7j5EqrnVaCogRjzOt15C96X3UTnhIV0LmAwOxSaO1cFgl/XLhaszipCGU2xKKBLJtvGwHcX1u6fyUeYGxhSwAdFbJY/+EFaAPmiY3ZrQgpzioJsVDM/eGfZeZ0LsWc54rXIEw++9qcUrPT67roiDkxZ5Qx/AQaxUkAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 02, 2023 at 11:32:28PM +0000, Yosry Ahmed wrote: > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index 54c774af6e1c..060079f1e966 100644 > --- a/fs/xfs/xfs_buf.c > +++ b/fs/xfs/xfs_buf.c > @@ -286,8 +286,7 @@ xfs_buf_free_pages( > if (bp->b_pages[i]) > __free_page(bp->b_pages[i]); > } > - if (current->reclaim_state) > - current->reclaim_state->reclaimed_slab += bp->b_page_count; > + report_freed_pages(bp->b_page_count); XFS can be built as a module > +++ b/mm/vmscan.c > @@ -204,6 +204,19 @@ static void set_task_reclaim_state(struct task_struct *task, > task->reclaim_state = rs; > } > > +/* > + * reclaim_report_freed_pages: report pages freed outside of LRU-based reclaim > + * @pages: number of pages freed > + * > + * If the current process is undergoing a reclaim operation, > + * increment the number of reclaimed pages by @pages. > + */ > +void report_freed_pages(unsigned long pages) > +{ > + if (current->reclaim_state) > + current->reclaim_state->reclaimed += pages; > +} > + report_free_pages is not EXPORT_SYMBOLed