From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5814C636CC for ; Sun, 5 Feb 2023 11:42:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D3B86B0072; Sun, 5 Feb 2023 06:42:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 184286B0073; Sun, 5 Feb 2023 06:42:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0729D6B0074; Sun, 5 Feb 2023 06:42:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ED5F56B0072 for ; Sun, 5 Feb 2023 06:42:35 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B5F27AA9E4 for ; Sun, 5 Feb 2023 11:42:35 +0000 (UTC) X-FDA: 80433050670.02.C745D05 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 655CD80003 for ; Sun, 5 Feb 2023 11:42:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="uHl/kG33"; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675597354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oaSp1uDrEJSreK2BT15lm8D1/ywHnOELmkze9J1/9gs=; b=7wVAMVg9b5Y7YbeB3bIWWVF3x5cbIXNlQ003SmGAiF2xj/TaV5YTLQL7h07cSHAeSQj2Hj 6BuGwF9GkVAWjuNX2KUxlzo+MMoKv2GcpFW6B/4vrolvjD8m6Ygkb7MKg1kZojHiMJIlWT paKLqMwSTptMcS6R0KFrRyLwnulVTCE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="uHl/kG33"; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675597354; a=rsa-sha256; cv=none; b=rBzSJceuhGLGJubPAgJicbnP07nYW2LYsTHeeeBgFIvsFL+B6owkf88iDDNI+rUy9w9ssP 8dKY5y7PhaUAu/7VH+YTJ4xvpYJCAkl/GfVtzP7hnsOaSSdUGoEBz+31OBN9Ze3qsPs/xs RMRYwSJv8+oqvfy9yroP9Esns8q8vOA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oaSp1uDrEJSreK2BT15lm8D1/ywHnOELmkze9J1/9gs=; b=uHl/kG336RTMsqPHsblbXTQ2Z7 N7KGy95S/8cHu6nmIqYAl1avvNVI8mS1yV0V4Vfhz+9MMF+GgwOa1N5sXrtr5VlqJnnQ8KtIeh6Gl C8dgU4wNjoG1CZkCLpvIakxfqaIKWavXC13nKWJqFeTENtN5r/490eaMim0kN3DCJA9If2qXKkgvd MZidgWXWOn1baMT8+mFy8pU4dqnFvWMX8c06sVQy26YM1P0TWiTyRwDGoidsqjvaIYnfHFoXeXJeS V6lTCQc1N8uhmT3bohmKWqGTo/NbpWaCnNA4ebDIwcZpbYRewkh9Z9RA7Wts1LRbGRZY2KRv/h/QU 0SiYGRrg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOdPa-00Fsbl-0T; Sun, 05 Feb 2023 11:42:22 +0000 Date: Sun, 5 Feb 2023 11:42:21 +0000 From: Matthew Wilcox To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com Subject: Re: [PATCH v9 1/3] xfs: fix the calculation of length and end Message-ID: References: <1675522718-88-1-git-send-email-ruansy.fnst@fujitsu.com> <1675522718-88-2-git-send-email-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1675522718-88-2-git-send-email-ruansy.fnst@fujitsu.com> X-Stat-Signature: 1ngz1timdj1r6mgouzj878yfziqs8c5s X-Rspam-User: X-Rspamd-Queue-Id: 655CD80003 X-Rspamd-Server: rspam06 X-HE-Tag: 1675597353-419471 X-HE-Meta: U2FsdGVkX18Ab7j20Q6TdexSulgV0q7oLUJjQnOBckWLcghUq+OtWrmKH10j7RHAoa6FmEwEDccoRKvqVyZz+/AlOb/siua1GIwdvBTKYmKBvs59dHLSrBD+8t6ExqdDKzpAekvzz60hquXWXFIM9r7+j/DL9hz9SuaDIP5nSe5KIiraXU45ZG1q/icChBeYpPO2BHbvmC5TExWv0nugbm7qE+vD1jyMCCJ1aos3SgqZyw9eRoDC1+smjgfIJlbOGdPJFuge2KaT0M74aV+OyMIb6AKTzPTyrHcLJnCc++RgElIQc8X/U8zaqijGkKgU7BOU0oufp0Vz8vph26Hfj6zkV1xDxVYxo14KPq/xqKaN+uY2dMA91TqS3Ps/xpK3YczdY5K/6ym/7TgeSvKgGVevUjXJT9f+t+mKWHUNuctGpVDw4vdqMC0id2R//WcYw7gAHaos5nW28eJ7TzsxJd+xGypoEcL8YYK5sHL/eoJAXTQG+mbTHcwkkl96j/8sKn9d0xOrWIbPLKP0RicsXTbLquyj3UY78gXQ3iLroSJ4GKe4rVGwppqByKYIlSQ7ZsiNWHhZj8jrgwPBz2AFI2xzu+qvY1jGHd8WmgKyjtGljUb1Ee8KmP5DYACtZgoEwMJdOIZI/US15xyPwhoUBpI6m59958f+CmjxkOzlfFXZjx39kfX2UWSIoiqSLRlZJE7QJZ6Y7IElwXXtFNvtEMxsomVH5IhxcEXLRjXM6zqwzvujaNa0TOYMH88NLrh6w+VtMLYyeuSyys2adUYp2P6cpj2oE3R6gp9stubXo0he8GeXb7e2fWBCUj499tLQhcJ0/mnabQe6cpmJ8oS6ZzLq2JxNBzG1aNhuc2wM+rfzGNkqK5IbITfBz9bLiJlXPQRL8OJD/E6Z+6SOTNtRK3Z5SxRHlPydQchioHJsnJVq//+Ut9XIrmxaTCjvYSWUvaMINP8WUY1i5MeVrOp 8qaQZudU v6WiSYD5jq9T+5S6vXxUSOrWil1sYIeu2PgDrxuvT8zvE8YrFHs7moBzB9N/H0y/xDyfxXUs2WcC0dzKlan/rJ53h6LBuzZZKmoaGGYWL+qNB6mSVz6KssfpXvTQNXt+CWJ6nBYROXpsDcqNynl3JRx4X4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 04, 2023 at 02:58:36PM +0000, Shiyang Ruan wrote: > @@ -222,8 +222,8 @@ xfs_dax_notify_failure( > len -= ddev_start - offset; > offset = 0; > } > - if (offset + len > ddev_end) > - len -= ddev_end - offset; > + if (offset + len - 1 > ddev_end) > + len -= offset + len - 1 - ddev_end; This _looks_ wrong. Are you sure it shouldn't be: len = ddev_end - offset + 1;