From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A528DC27C76 for ; Sat, 21 Jan 2023 13:33:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 265636B0072; Sat, 21 Jan 2023 08:33:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 214EC6B0073; Sat, 21 Jan 2023 08:33:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B6906B0074; Sat, 21 Jan 2023 08:33:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ECFBC6B0072 for ; Sat, 21 Jan 2023 08:33:32 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B7F36120752 for ; Sat, 21 Jan 2023 13:33:32 +0000 (UTC) X-FDA: 80378898264.27.92E3382 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id 53F811A0006 for ; Sat, 21 Jan 2023 13:33:30 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Gss5I1H4; spf=none (imf19.hostedemail.com: domain of BATV+1651c3ebed9361b307e7+7090+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1651c3ebed9361b307e7+7090+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674308011; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pj/DkEfwFIRHofLn9X6ceYNaPqlltRYtSVaPq4r62E4=; b=5ma+JLO1lIAm8QJMeqxbJpftl8AlDfLqHhAyBjfak1Qct0z0HqwqKnMt3kaMPZnXa9HpBc UXw8Pde5Hpj+/lwZVj6NjZyKzKM8o5MP3Fp4M2VfuUgfFoZmtjb/daugzTLVo+Urj/zWg2 NrUc1ahTTKAT3qvFdDDh6fLN2Vl/kUk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Gss5I1H4; spf=none (imf19.hostedemail.com: domain of BATV+1651c3ebed9361b307e7+7090+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1651c3ebed9361b307e7+7090+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674308011; a=rsa-sha256; cv=none; b=5dKveXs1gOzbuxTpLZTBGm9F3aQUX1TQYNu7dTBslq6wvzhwts8jw6GJXch33xbIUb58fY uO+dR0jgb5rodKp2iHk70velpwzCKcGEGGPwPkMZNte45dDvO8q1pagqGEVlvYNQ8ablmr qFD9+R+Uq6MX8fzTgWRaOpH5J/gruVU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pj/DkEfwFIRHofLn9X6ceYNaPqlltRYtSVaPq4r62E4=; b=Gss5I1H4QuD52ATdNFbRLH7ko7 df0aAA4w+7gzuFEHy7vue8kT7qXA40IZYbsQ5nKMG6hMqMqn4ehfu7KLeDJuC5mSDbqaydZ/7y354 tmRtEzVkWibDXrXBH7DgCaInzHLy6C7tqdbD6xhng/4er1qngOmfzSYKWK590TNgk2avxpQ18/lMv 0Ky+pKRypEGf6QBk/Ev0iXsreYF8oFGYB/OxV32g9tQ+AaI45NisgZeVlZxBrPgSagR4ICGhnl5eW /T6GhWe0HOrsHLB7yuEabUaxP7DE23n0oDvaC8F4R8rCOGjWxd+pQS1pCl84hIkEOf41jlYSKNEws eOCqD9NA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJDzi-00DuND-Gf; Sat, 21 Jan 2023 13:33:18 +0000 Date: Sat, 21 Jan 2023 05:33:18 -0800 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Al Viro , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , John Hubbard , linux-mm@kvack.org Subject: Re: [PATCH v7 2/8] iov_iter: Add a function to extract a page list from an iterator Message-ID: References: <20230120175556.3556978-1-dhowells@redhat.com> <20230120175556.3556978-3-dhowells@redhat.com> <3598255.1674307847@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3598255.1674307847@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 53F811A0006 X-Stat-Signature: wu93a8o9qeo4t4kfdxtawhtzc1uuzf55 X-HE-Tag: 1674308010-787702 X-HE-Meta: U2FsdGVkX19pkZhcdGT8yLj95QHR/V/E4OcDIM4kLMM1MM6BnYF8diU2jZZ3Wow+cxlHr5hrGSKp2c43n4w4xGgvU1Ojr8rOC5+3UDqIMK6Ik8c1hMuV2mWsOuw0iyZWANbrtp6Hhjn8CeNieWgdfMohM7pniBLKIQUU7edJlw0n1A4qrq4xu5AZ47V5pXVcau4M3ejY8z030ynpBNVUs6CvhwDO00KG6MJqxRF4JRIjmNhU8GzFklm9YNM9LxES6B9YWxf1DblkrSoxChmgKoZj9Rdx48xcy+lFkyK7CUzh/ktTcDpk0YoHU44kEDeiktFnfY7S8t7mXxrUqq8qB9jUv0dT1DVYzFpXYEXGngkeqY98zjebdSJr2agElQuDEi3e4XgVj+TkOKhSurKPpbfdXf+7I9RXf2hSruqQIMlX0u7aafyT1DVQo44roSqCqCpVLx9SV+03rwn3dDf2vz7YvQLVwacFhJL+A5vDjQ/xr56v8edM78U1oaGRb84N0/hb9XmaBfwtfv+wbWk2TFxahCyn3b2gYq89RDj9v/9R8DETrchcQps1FFLWumxb2ddTkYl2RCLKtvjg2ixopzsg0STPHRTCeJLP3+cQPxy4HVZ1d0E1I4lNJcznc8T1PjeozXVQOCnTbUotZ6FqJMqFTgmU0S8VZrsj64ot19upcaVYdYWL1wVuQSZGqlBQ2BxSN0x92nmxQeaGYckXYVggNMJFmO+XHcX6CmM2pZbJnAGnoW/9FUHpV3K+0CZeSJxVv71/d03GHwIw4TCrax1BxBSU+VV9EbyPDtNmDuOXQcV6tDIV36Q4/zIVH9dZhKRzEqqk+UAac5//hygV3iYVgKmL1H4RuiFHUGyvgWfoQmZ1BzB0AVgY7HqF4bi+7EPW6m1eg0x2wEbIEKCMcHd3hCidgQ2BpAwcldTIj+0InvqJ5WXTIAVNrUqIINP5OxeWaRoylud9UuqHFD9 dEYwGw2i fCBbt9gF+2A1Xp44mp0lZeZctTwEyFaDN4f2GG+Mwut9lFXcJqCYIFkUmYEJe+mI6dDFtoqLGLZE6XJxM72+c/IdKNQ2NsuY7W7CRJYTw58FS5acucTaWYiWqIHNB2QRseiBwvH+fABtyWjPYvX68mcTnzYMQThGVxqEcZOZc9xcBCmxpHtMFfvXeXL3NuSAuzcJaX85SEvXRVBqWrWIj9YpONj16eGEkT2cCtWrs2qu/cPx9bdCAjYEbX74F0DoIsWD7ZBv1y2o1hWRRDv/6Hqglsa6sDHtHG25Us/FlfkEG8sqsAnexx7w5HqvPvLW41BOq/71hPFJZMBBINmIFYoClb8I/OaKHY2jCoZ7IegrJRp6X/QjgFNtvagIwhshDmx3qZCer91U9zBVpMHSwfcEB4tfs92X56fOty9ptJRq/CUzz3qyUBVqDucHEaZtxZJ0WuWjUNm+NZp9/b/TkkI8+ywNgAjrU3/z5edoohAO4PjSqC19o6kUDWM1r3jXbiMgyYRPR92BKmps= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 21, 2023 at 01:30:47PM +0000, David Howells wrote: > So just drop the check? Or do I actually need to do something to the pages to > make it work? If I understand the code correctly, it's not actually operable > right now on any page that doesn't have an appropriately marked PTE. Yes, just drop the check. The flag just signals that the caller can deal with p2p pages. If it gets any or not is a totally different story.