From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90078C05027 for ; Fri, 20 Jan 2023 18:59:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 248ED6B0071; Fri, 20 Jan 2023 13:59:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F8CD6B0073; Fri, 20 Jan 2023 13:59:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C1646B0074; Fri, 20 Jan 2023 13:59:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F11296B0071 for ; Fri, 20 Jan 2023 13:59:45 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B95FA1A074E for ; Fri, 20 Jan 2023 18:59:45 +0000 (UTC) X-FDA: 80376091530.22.8EBDA4E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 1FAB2140011 for ; Fri, 20 Jan 2023 18:59:42 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hYEyUmqN; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674241184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=faS00BN0vzsZ6ntF3Du1tRjH6pklFXGeUXMszEheyEE=; b=SvVv0ukz5lkfklxGLmgme4Qz2QR/6JEfTDx3wsS/HchQyAUqzQkWOYlTiiNKm8/QQc53JA bODQUcwzHZtV8pAqWkY/O19s58lx37gaRQGhqj+QOWEOpV7exAlMpp+0E2uo1E4tZe7ytk YCBXeCMZ4IOqIXlevvV7KEhUL4OpJSk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hYEyUmqN; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674241184; a=rsa-sha256; cv=none; b=swknN3H/SrCmQmbFnC0+Vl8rMQ6XS+D2+9Q/BYRm5LJ5to45fg1mGwkbaA0Fa/Cx6CYRV0 OklRPE/bbH4asibkq/4t/kpf1wpsx1YWN4DKTfoh7NVaohw6DDLXGJxWZyytjwYKbLPAQg 8CtFvJKD7Ocvs9I5nSYj6ugmqAqJGvg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=faS00BN0vzsZ6ntF3Du1tRjH6pklFXGeUXMszEheyEE=; b=hYEyUmqNaKOTuvNMQxJooIHLIV AmQgKPQh2tIfprwXAHw7LP04bGXquP0MIThAlkNGPK4ohKVh4Hg9paQvYMAyhJmwiwolxCuS57qib GwB+AQ9Do+DYxm+Nk4NMIOIyFhC7xV88waK71ekyZC9RGt/LgQrIyIX6RLJ7CnEtTUVjGPiWG8WG6 tWt9jlMjP9gcFfoyUWpgOq3gFDQkllEprXljcu6wOn0HRzLt/k+B+M6qNfCIecDSEvWqCY8GXEKdJ 9DYHQg8NEqZ+1oaHoR8PgwJH+6cXkl4Gpm3tUf4Ylo5NFQlgOvIRmVG3O97LHElLAwvFgQRaF7tO3 uaNVGPiw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIwbl-002Knj-Ds; Fri, 20 Jan 2023 18:59:25 +0000 Date: Fri, 20 Jan 2023 18:59:25 +0000 From: Matthew Wilcox To: David Howells Cc: Al Viro , Christoph Hellwig , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v7 8/8] mm: Renumber FOLL_GET and FOLL_PIN down Message-ID: References: <20230120175556.3556978-1-dhowells@redhat.com> <20230120175556.3556978-9-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230120175556.3556978-9-dhowells@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1FAB2140011 X-Stat-Signature: 6xzaftpqknqd4ybwnw5bxwzmcudb4uho X-HE-Tag: 1674241182-867376 X-HE-Meta: U2FsdGVkX1/XpR2jlQCjKUrZAoDzFJAvX6wZzC1h8fWuQ6mSqQgtr9P2wgU868DHT58yBSyyt0hmmIM2B8IvhhCS8RwvrSwddCScwW2C+LkIF6bfI1kaJ1MUCItKZUR0Dp0vzBgbtXqKbyx/igx15q8a6L8eCSwvxjItAAyE1ue/iMFexDLSwWSV6mIVnAz/vZ6DO/u7uOeCWooLfLF9ccC+kEMrd9+eC2NmzqTmA0MmZ+I4EqrRmnUl6IceThUgRzhcziXxGeD+rcRDF4RtTSrO2kg7oH6ZLi1bL9cKRkU85zjDb/r+bByp8JxoC/YY0V8RMVSi7SbKD40uyFsZ3jEWN+3eFXbMyRa41gbiA3Jicc3HFSswZstEMVaf0gmPJO7DL+12NUQzHRpip2AK39KQCiWdnsUEKxy4tVB6MwlTEmRS3mznVnkrq/CMumZ4khnGVLZ0WJO8mbVtp6xdUVtLJdjfFG41MzuwiHpP1fx5SOIISyD9DI9H+6UilinxwQfmeS6OVmW/phmwV0zrvkzrhRZCgFpegRVJ8tKGm8rVPONNAQKT/6FkFsBAbstRV03P+4lTyOnSKwiM4TnEwN7TMZT7LmMnWgqWHGDV9F/hYWZx9FBL3/EPgougvWPX4+Es2xo5Ts/4P+0eSbkkW4+lmOstFvu8KzkV9wk3cAuypux23FD4AUr+wUZB9NKSmVLkJDEexVaDxK/lFFzPO+mm7lt5ldT9uyIeoKPwalHT23Qqf15z6FFXkS1u1/ALPFtwHumSWlLztuls60qFxE3SZU6gmalOf228dpbCtMHTTH+n+QRrz26d+se/e/SigTDZSkMktMb25U7apcVih4aTrdlTIkMLBNQ8smRZyqBswnELO61HI09btypBrvh4fClYKzTU6X5tiy9imNaJVyxSVmwtNx7NEcRozMy/pX4W/kHfXzNwVOzxdO+KcODNM32S6CrpdPjKTi26sqi 1PeKwaB4 vUmlfsG4/L8SO0MEO8TAJXPIHYQ2nYBtSgeu1EaLdpeOfgKPLIK2s9A3QgcI99vOSk148qM6c7EWaL177YkHDZmmn/LmjGOLZHwuW25BO7A0L36ajimaPmb3Z9bzE9FQy1xg9uL2QWxu2vA0Bvae79ZPpaIPc7PfeyqZWkPNJYOWcQ0Dj2IBYbegiVXtkK6fcdifkt/KGIs0DB+fUpbSmCckHOxC3l/5pQ+CUgUlx6KZo0//Y3v4q+6lgIztHI8PVBUmSCHe0QcT0+7Z0tQ2iA8ymrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 20, 2023 at 05:55:56PM +0000, David Howells wrote: > Renumber FOLL_GET and FOLL_PIN down to bit 0 and 1 respectively so that > they are coincidentally the same as BIO_PAGE_REFFED and BIO_PAGE_PINNED and > also so that they can be stored in the bottom two bits of a page pointer > (something I'm looking at for zerocopy socket fragments). > > Signed-off-by: David Howells Reviewed-by: Matthew Wilcox (Oracle) Although I was hoping you'd renumber some of the others since we currently have gaps at 0x200, 0x400, 0x1000, and 0x4000 as well as the 0x40 you're using here.